68586 2011-09-21 16:34:15 -0700 Add X86 GPRInfo for DFG JIT. 2011-09-21 16:49:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 67460 1 barraclough webkit-unassigned oldest_to_newest 471255 0 barraclough 2011-09-21 16:34:15 -0700 X86 has fewer registers! 471256 1 108252 barraclough 2011-09-21 16:35:09 -0700 Created attachment 108252 Fix 471262 2 108252 ggaren 2011-09-21 16:44:37 -0700 Comment on attachment 108252 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=108252&action=review r=me > Source/JavaScriptCore/dfg/DFGGPRInfo.h:46 > + // These registers match the old JIT. Let's call this "baseline JIT". > Source/JavaScriptCore/dfg/DFGGPRInfo.h:59 > + static const GPRReg argumentGPR0 = X86Registers::ecx; // regT2 > + static const GPRReg argumentGPR1 = X86Registers::edx; // regT1 > + static const GPRReg returnValueGPR = X86Registers::eax; // regT0 > + static const GPRReg returnValueGPR2 = X86Registers::edx; // regT1 This numbering convention is not consistent. Would be good to make it so in a future patch. 471265 3 barraclough 2011-09-21 16:49:30 -0700 fixed in r95684 108252 2011-09-21 16:35:09 -0700 2011-09-21 16:44:37 -0700 Fix 68586.patch text/plain 3319 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU2ODApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDktMjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBYODYgR1BSSW5mbyBmb3IgREZHIEpJVC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NTg2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHR1BSSW5mby5oOgorICAgICAg ICAoSlNDOjpERkc6OkdQUkluZm86OnRvUmVnaXN0ZXIpOgorICAgICAgICAoSlNDOjpERkc6OkdQ UkluZm86OnRvSW5kZXgpOgorICAgICAgICAoSlNDOjpERkc6OkdQUkluZm86OmRlYnVnTmFtZSk6 CisKIDIwMTEtMDktMjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29t PgogCiAgICAgICAgIFNob3VsZCBzdXBwb3J0IHZhbHVlIHByb2ZpbGluZyBvbiBDUFUoWDg2KQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHUFJJbmZvLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHUFJJbmZvLmgJKHJldmlzaW9uIDk1Njc2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHUFJJbmZvLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM2LDYgKzM2LDY2IEBAIG5hbWVzcGFjZSBKU0MgeyBuYW1lc3BhY2UgREZHIHsKIHR5 cGVkZWYgTWFjcm9Bc3NlbWJsZXI6OlJlZ2lzdGVySUQgR1BSUmVnOwogI2RlZmluZSBJbnZhbGlk R1BSUmVnICgoR1BSUmVnKS0xKQogCisjaWYgQ1BVKFg4NikKKworY2xhc3MgR1BSSW5mbyB7Citw dWJsaWM6CisgICAgdHlwZWRlZiBHUFJSZWcgUmVnaXN0ZXJUeXBlOworICAgIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBudW1iZXJPZlJlZ2lzdGVycyA9IDQ7CisKKyAgICAvLyBUaGVzZSByZWdpc3Rl cnMgbWF0Y2ggdGhlIG9sZCBKSVQuCisgICAgc3RhdGljIGNvbnN0IEdQUlJlZyBjYWNoZWRSZXN1 bHRSZWdpc3RlciA9IFg4NlJlZ2lzdGVyczo6ZWF4OworICAgIHN0YXRpYyBjb25zdCBHUFJSZWcg dGltZW91dENoZWNrUmVnaXN0ZXIgPSBYODZSZWdpc3RlcnM6OmVzaTsKKyAgICBzdGF0aWMgY29u c3QgR1BSUmVnIGNhbGxGcmFtZVJlZ2lzdGVyID0gWDg2UmVnaXN0ZXJzOjplZGk7CisgICAgLy8g VGVtcG9yYXJ5IHJlZ2lzdGVycy4KKyAgICBzdGF0aWMgY29uc3QgR1BSUmVnIHJlZ1QwID0gWDg2 UmVnaXN0ZXJzOjplYXg7CisgICAgc3RhdGljIGNvbnN0IEdQUlJlZyByZWdUMSA9IFg4NlJlZ2lz dGVyczo6ZWR4OworICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnVDIgPSBYODZSZWdpc3RlcnM6 OmVjeDsKKyAgICBzdGF0aWMgY29uc3QgR1BSUmVnIHJlZ1QzID0gWDg2UmVnaXN0ZXJzOjplYng7 CisgICAgLy8gVGhlc2UgY29uc3RhbnRzIHByb3ZpZGUgdGhlIG5hbWVzIGZvciB0aGUgZ2VuZXJh bCBwdXJwb3NlIGFyZ3VtZW50ICYgcmV0dXJuIHZhbHVlIHJlZ2lzdGVycy4KKyAgICBzdGF0aWMg Y29uc3QgR1BSUmVnIGFyZ3VtZW50R1BSMCA9IFg4NlJlZ2lzdGVyczo6ZWN4OyAvLyByZWdUMgor ICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgYXJndW1lbnRHUFIxID0gWDg2UmVnaXN0ZXJzOjplZHg7 IC8vIHJlZ1QxCisgICAgc3RhdGljIGNvbnN0IEdQUlJlZyByZXR1cm5WYWx1ZUdQUiA9IFg4NlJl Z2lzdGVyczo6ZWF4OyAvLyByZWdUMAorICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmV0dXJuVmFs dWVHUFIyID0gWDg2UmVnaXN0ZXJzOjplZHg7IC8vIHJlZ1QxCisKKyAgICBzdGF0aWMgR1BSUmVn IHRvUmVnaXN0ZXIodW5zaWduZWQgaW5kZXgpCisgICAgeworICAgICAgICBBU1NFUlQoaW5kZXgg PCBudW1iZXJPZlJlZ2lzdGVycyk7CisgICAgICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnaXN0 ZXJGb3JJbmRleFtudW1iZXJPZlJlZ2lzdGVyc10gPSB7IHJlZ1QwLCByZWdUMSwgcmVnVDIsIHJl Z1QzLCB9OworICAgICAgICByZXR1cm4gcmVnaXN0ZXJGb3JJbmRleFtpbmRleF07CisgICAgfQor CisgICAgc3RhdGljIHVuc2lnbmVkIHRvSW5kZXgoR1BSUmVnIHJlZykKKyAgICB7CisgICAgICAg IEFTU0VSVChyZWcgIT0gSW52YWxpZEdQUlJlZyk7CisgICAgICAgIEFTU0VSVChyZWcgPCA4KTsK KyAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGluZGV4Rm9yUmVnaXN0ZXJbOF0gPSB7IDAs IDIsIDEsIDMsIEludmFsaWRJbmRleCwgSW52YWxpZEluZGV4LCBJbnZhbGlkSW5kZXgsIEludmFs aWRJbmRleCB9OworICAgICAgICB1bnNpZ25lZCByZXN1bHQgPSBpbmRleEZvclJlZ2lzdGVyW3Jl Z107CisgICAgICAgIEFTU0VSVChyZXN1bHQgIT0gSW52YWxpZEluZGV4KTsKKyAgICAgICAgcmV0 dXJuIHJlc3VsdDsKKyAgICB9CisKKyNpZm5kZWYgTkRFQlVHCisgICAgc3RhdGljIGNvbnN0IGNo YXIqIGRlYnVnTmFtZShHUFJSZWcgcmVnKQorICAgIHsKKyAgICAgICAgQVNTRVJUKHJlZyAhPSBJ bnZhbGlkR1BSUmVnKTsKKyAgICAgICAgQVNTRVJUKHJlZyA8IDgpOworICAgICAgICBzdGF0aWMg Y29uc3QgY2hhciogbmFtZUZvclJlZ2lzdGVyWzhdID0geworICAgICAgICAgICAgInJheCIsICJy Y3giLCAicmR4IiwgInJieCIsCisgICAgICAgICAgICAicnNwIiwgInJicCIsICJyc2kiLCAicmRp IiwKKyAgICAgICAgfTsKKyAgICAgICAgcmV0dXJuIG5hbWVGb3JSZWdpc3RlcltyZWddOworICAg IH0KKyNlbmRpZgorcHJpdmF0ZToKKworICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBJbnZhbGlk SW5kZXggPSAweGZmZmZmZmZmOworfTsKKworI2VuZGlmCisKKyNpZiBDUFUoWDg2XzY0KQorCiBj bGFzcyBHUFJJbmZvIHsKIHB1YmxpYzoKICAgICB0eXBlZGVmIEdQUlJlZyBSZWdpc3RlclR5cGU7 CkBAIC0xMDEsNiArMTYxLDggQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQg SW52YWxpZEluZGV4ID0gMHhmZmZmZmZmZjsKIH07CiAKKyNlbmRpZgorCiB0eXBlZGVmIFJlZ2lz dGVyQmFuazxHUFJJbmZvPjo6aXRlcmF0b3IgZ3ByX2l0ZXJhdG9yOwogCiB9IH0gLy8gbmFtZXNw YWNlIEpTQzo6REZHCg==