68571 2011-09-21 14:38:15 -0700 DFG JIT should be able to compile op_throw 2011-09-21 16:45:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 471162 0 fpizlo 2011-09-21 14:38:15 -0700 The DFG JIT cannot compile op_throw. So if a "throw" statement occurs anywhere in a code block, we cannot optimize it at all. 471213 1 108245 fpizlo 2011-09-21 15:32:13 -0700 Created attachment 108245 the patch 471218 2 108245 ggaren 2011-09-21 15:34:47 -0700 Comment on attachment 108245 the patch r=me 471263 3 fpizlo 2011-09-21 16:45:40 -0700 Landed in r95683. 108245 2011-09-21 15:32:13 -0700 2011-09-21 15:34:47 -0700 the patch opthrow_patch_1.diff text/plain 4750 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTU2NzMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAK KzIwMTEtMDktMjEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHNob3VsZCBiZSBhYmxlIHRvIGNvbXBpbGUgb3BfdGhyb3cKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NTcxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIGNvbXBpbGVzIG9w X3Rocm93IGluIHRoZSBzaW1wbGVzdCB3YXkgcG9zc2libGU6IGl0J3MgYW4gT1NSCisgICAgICAg IHBvaW50IGJhY2sgdG8gdGhlIG9sZCBKSVQuIFRoaXMgaXMgYSBnb29kIHN0ZXAgdG93YXJkcyBp bmNyZWFzaW5nCisgICAgICAgIGNvdmVyYWdlLCBwYXJ0aWN1bGFybHkgb24gS3Jha2VuLCBidXQg aXQncyBuZXV0cmFsIGJlY2F1c2UgdGhlCisgICAgICAgIHNhbWUgZnVuY3Rpb25zIHRoYXQgZG8g dGhyb3cgYWxzbyB1c2Ugc29tZSBvdGhlciB1bnN1cHBvcnRlZAorICAgICAgICBvcGNvZGVzLgor CisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayk6CisgICAgICAgICogZGZnL0RGR0NhcGFiaWxp dGllcy5oOgorICAgICAgICAoSlNDOjpERkc6OmNhbkNvbXBpbGVPcGNvZGUpOgorICAgICAgICAq IGRmZy9ERkdOb2RlLmg6CisgICAgICAgICogZGZnL0RGR1Byb3BhZ2F0b3IuY3BwOgorICAgICAg ICAoSlNDOjpERkc6OlByb3BhZ2F0b3I6OnByb3BhZ2F0ZU5vZGVQcmVkaWN0aW9ucyk6CisgICAg ICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVj dWxhdGl2ZUpJVDo6Y29tcGlsZSk6CisKIDIwMTEtMDktMjEgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgZG9lcyBub3Qgc3VwcG9ydCBjb21waWxpbmcgZnVu Y3Rpb25zIGFzIGNvbnN0cnVjdG9ycwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDk1NjY5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTEzMDMsNiArMTMwMywxNCBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJsb2NrKHVuc2ln bmVkCiAgICAgICAgICAgICBhZGRUb0dyYXBoKFJldHVybiwgZ2V0KGN1cnJlbnRJbnN0cnVjdGlv blsxXS51Lm9wZXJhbmQpKTsKICAgICAgICAgICAgIExBU1RfT1BDT0RFKG9wX2VuZCk7CiAgICAg ICAgICAgICAKKyAgICAgICAgY2FzZSBvcF90aHJvdzoKKyAgICAgICAgICAgIGFkZFRvR3JhcGgo VGhyb3csIGdldChjdXJyZW50SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kKSk7CisgICAgICAgICAg ICBMQVNUX09QQ09ERShvcF90aHJvdyk7CisgICAgICAgICAgICAKKyAgICAgICAgY2FzZSBvcF90 aHJvd19yZWZlcmVuY2VfZXJyb3I6CisgICAgICAgICAgICBhZGRUb0dyYXBoKFRocm93UmVmZXJl bmNlRXJyb3IpOworICAgICAgICAgICAgTEFTVF9PUENPREUob3BfdGhyb3dfcmVmZXJlbmNlX2Vy cm9yKTsKKyAgICAgICAgICAgIAogICAgICAgICBjYXNlIG9wX2NhbGw6IHsKICAgICAgICAgICAg IE5vZGVJbmRleCBjYWxsVGFyZ2V0ID0gZ2V0KGN1cnJlbnRJbnN0cnVjdGlvblsxXS51Lm9wZXJh bmQpOwogICAgICAgICAgICAgaWYgKG1fZ3JhcGguaXNGdW5jdGlvbkNvbnN0YW50KG1fY29kZUJs b2NrLCBjYWxsVGFyZ2V0KSkgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdD YXBhYmlsaXRpZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0NhcGFiaWxpdGllcy5oCShyZXZpc2lvbiA5NTY2OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQ2FwYWJpbGl0aWVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExMiw2ICsxMTIsOCBA QCBpbmxpbmUgYm9vbCBjYW5Db21waWxlT3Bjb2RlKE9wY29kZUlEIG9wCiAgICAgY2FzZSBvcF9j YWxsX3B1dF9yZXN1bHQ6CiAgICAgY2FzZSBvcF9yZXNvbHZlOgogICAgIGNhc2Ugb3BfcmVzb2x2 ZV9iYXNlOgorICAgIGNhc2Ugb3BfdGhyb3c6CisgICAgY2FzZSBvcF90aHJvd19yZWZlcmVuY2Vf ZXJyb3I6CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIHJldHVy biBmYWxzZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCShyZXZpc2lvbiA5 NTY2OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0yOTMsNyArMjkzLDkgQEAgc3RhdGljIGlubGluZSBjb25zdCBjaGFyKiBhcml0aE5v ZGVGbGFncwogICAgIC8qIEJsb2NrIHRlcm1pbmFscy4gKi9cCiAgICAgbWFjcm8oSnVtcCwgTm9k ZU11c3RHZW5lcmF0ZSB8IE5vZGVJc1Rlcm1pbmFsIHwgTm9kZUlzSnVtcCkgXAogICAgIG1hY3Jv KEJyYW5jaCwgTm9kZU11c3RHZW5lcmF0ZSB8IE5vZGVJc1Rlcm1pbmFsIHwgTm9kZUlzQnJhbmNo KSBcCi0gICAgbWFjcm8oUmV0dXJuLCBOb2RlTXVzdEdlbmVyYXRlIHwgTm9kZUlzVGVybWluYWwp CisgICAgbWFjcm8oUmV0dXJuLCBOb2RlTXVzdEdlbmVyYXRlIHwgTm9kZUlzVGVybWluYWwpIFwK KyAgICBtYWNybyhUaHJvdywgTm9kZU11c3RHZW5lcmF0ZSB8IE5vZGVJc1Rlcm1pbmFsKSBcCisg ICAgbWFjcm8oVGhyb3dSZWZlcmVuY2VFcnJvciwgTm9kZU11c3RHZW5lcmF0ZSB8IE5vZGVJc1Rl cm1pbmFsKQogCiAvLyBUaGlzIGVudW0gZ2VuZXJhdGVzIGEgbW9ub3RvbmljYWxseSBpbmNyZWFz aW5nIGlkIGZvciBhbGwgTm9kZSB0eXBlcywKIC8vIGFuZCBpcyB1c2VkIGJ5IHRoZSBzdWJzZXF1 ZW50IGVudW0gdG8gZmlsbCBvdXQgdGhlIGlkIChhcyBhY2Nlc3NlZCB2aWEgdGhlIE5vZGVJZE1h c2spLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcm9wYWdhdG9yLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Byb3BhZ2F0b3IuY3Bw CShyZXZpc2lvbiA5NTY2OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJvcGFn YXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0MSw2ICs1NDEsOCBAQCBwcml2YXRlOgogICAg ICAgICBjYXNlIFJldHVybjoKICAgICAgICAgY2FzZSBDaGVja0hhc0luc3RhbmNlOgogICAgICAg ICBjYXNlIFBoaToKKyAgICAgICAgY2FzZSBUaHJvdzoKKyAgICAgICAgY2FzZSBUaHJvd1JlZmVy ZW5jZUVycm9yOgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAKICAgICAgICAgLy8g VGhlc2UgZ2V0IGlnbm9yZWQgYmVjYXVzZSB3ZSBkb24ndCBoYXZlIHByb2ZpbGluZyBmb3IgdGhl bSwgeWV0LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAJKHJldmlzaW9uIDk1NjY5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MTgsNiArMTUxOCwx NCBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAgICAgICAgIG5v UmVzdWx0KG1fY29tcGlsZUluZGV4KTsKICAgICAgICAgYnJlYWs7CiAgICAgfQorICAgICAgICAK KyAgICBjYXNlIFRocm93OgorICAgIGNhc2UgVGhyb3dSZWZlcmVuY2VFcnJvcjogeworICAgICAg ICAvLyBXZSBleHBlY3QgdGhhdCB0aHJvdyBzdGF0ZW1lbnRzIGFyZSByYXJlIGFuZCBhcmUgaW50 ZW5kZWQgdG8gZXhpdCB0aGUgY29kZSBibG9jaworICAgICAgICAvLyBhbnl3YXksIHNvIHdlIGp1 c3QgT1NSIGJhY2sgdG8gdGhlIG9sZCBKSVQgZm9yIG5vdy4KKyAgICAgICAgdGVybWluYXRlU3Bl Y3VsYXRpdmVFeGVjdXRpb24oKTsKKyAgICAgICAgYnJlYWs7CisgICAgfQogCiAgICAgY2FzZSBD b252ZXJ0VGhpczogewogICAgICAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCB0aGlzVmFsdWUodGhp cywgbm9kZS5jaGlsZDEoKSk7Cg==