68570 2011-09-21 14:36:59 -0700 Remove Widget::beforeMouseDown and Widget::afterMouseDown 2011-09-22 13:36:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin rniwa oldest_to_newest 471160 0 andersca 2011-09-21 14:36:59 -0700 Remove Widget::beforeMouseDown and Widget::afterMouseDown 471163 1 108235 andersca 2011-09-21 14:40:48 -0700 Created attachment 108235 Patch 471201 2 andersca 2011-09-21 15:19:01 -0700 Committed r95673: <http://trac.webkit.org/changeset/95673> 471202 3 darin 2011-09-21 15:21:07 -0700 I think these might have still been relevant with WebKit1 and WebKit plug-ins. 471215 4 andersca 2011-09-21 15:34:13 -0700 (In reply to comment #3) > I think these might have still been relevant with WebKit1 and WebKit plug-ins. I'm not sure if this code path is taken for WebKit plug-ins but I'll double check. We can always fix that by surrounding the call with RenderWidget::suspendWidgetHierarchyUpdates() and RenderWidget::resumeWidgetHierarchyUpdates() 471753 5 rniwa 2011-09-22 11:52:58 -0700 Apparently this patch caused hundreds of tests to fail on Leopard / Snow Leopard WebKit1. http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/33283 471755 6 rniwa 2011-09-22 11:54:55 -0700 Roll out the patch in http://trac.webkit.org/changeset/95743 after IRC discussion with andersca. 471825 7 andersca 2011-09-22 13:36:33 -0700 Committed r95749: <http://trac.webkit.org/changeset/95749> 108235 2011-09-21 14:40:48 -0700 2011-09-21 15:17:11 -0700 Patch bug-68570-20110921144048.patch text/plain 5009 andersca SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NjY5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDktMjEgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgV2lkZ2V0Ojpi ZWZvcmVNb3VzZURvd24gYW5kIFdpZGdldDo6YWZ0ZXJNb3VzZURvd24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NTcwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgdHdvIG1lbWJlciBmdW5jdGlv bnMgd2VyZSBvcmlnaW5hbGx5IGFkZGVkIHRvIGF2b2lkIGNyYXNoZXMgZHVlIHRvIHJlbW92aW5n IE5TVmlld3Mgd2hpbGUgdGhleSB3ZXJlCisgICAgICAgIGJlaW5nIHRyYWNrZWQgYnkgQXBwS2l0 LiBTaW5jZSB0aGV5IHdlcmUgYWRkZWQsIHdlJ3ZlIG1vdmVkIGF3YXkgZnJvbSBOU1ZpZXdzIGZv ciBmb3JtIGNvbnRyb2xzLCBhbmQgdGhlIG9ubHkKKyAgICAgICAgcGxhY2UgdGhleSdyZSB1c2Vk IGlzIHN1YmZyYW1lcyBhbmQgcGx1Zy1pbnMgYW5kIHdlIGFscmVhZHkgaGF2ZSBhIG1lY2hhbmlz bSBpbiBwbGFjZSBpbiBSZW5kZXJXaWRnZXQgZm9yIGRlZmVycmluZworICAgICAgICB3aWRnZXQg aGllcmFyY2h5IHVwZGF0ZXMgZHVyaW5nIHN0eWxlIHJlY2FsYyBhbmQgYXR0YWNoaW5nL2RldGFj aGluZyBOb2Rlcywgd2hpY2ggaXMgbm93IHRoZSBvbmx5IHBsYWNlIHdoZXJlIHRoZSBOU1ZpZXdz CisgICAgICAgIGNvdWxkIG5vdyBiZSByZW1vdmVkIGZyb20gdGhlIHZpZXcgaGllcmFyY2h5Lgor CisgICAgICAgICogcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tOgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpwYXNzTW91c2VEb3duRXZlbnRUb1dpZGdldCk6CisgICAgICAgICog cGxhdGZvcm0vV2lkZ2V0Lmg6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1dpZGdldE1hYy5tbToK KyAgICAgICAgKFdlYkNvcmU6OldpZGdldDo6V2lkZ2V0KToKKyAgICAgICAgKFdlYkNvcmU6Oldp ZGdldDo6cmVtb3ZlRnJvbVN1cGVydmlldyk6CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy V2lkZ2V0LmNwcDoKKyAgICAgICAgQ2hhbmdlIHdpZGdldEhpZXJhcmNoeVVwZGF0ZVN1c3BlbmRD b3VudCB0byBiZSBhbiB1bnNpZ25lZCBpbnRlZ2VyIGluc3RlYWQgb2YgYSBzaXplX3QuCisKIDIw MTEtMDktMjEgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIFNoYXJlZEdyYXBoaWNzQ29udGV4dDNEJ3MgY29udGV4dCBzaG91bGQgbm90 IGJlIGRlc3Ryb3llZCBkdXJpbmcgYXRleGl0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL21h Yy9FdmVudEhhbmRsZXJNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9t YWMvRXZlbnRIYW5kbGVyTWFjLm1tCShyZXZpc2lvbiA5NTY0NykKKysrIFNvdXJjZS9XZWJDb3Jl L3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjM2LDExICsy MzYsOCBAQCBib29sIEV2ZW50SGFuZGxlcjo6cGFzc01vdXNlRG93bkV2ZW50VG9XCiAKICAgICBB U1NFUlQoIW1fc2VuZGluZ0V2ZW50VG9TdWJ2aWV3KTsKICAgICBtX3NlbmRpbmdFdmVudFRvU3Vi dmlldyA9IHRydWU7Ci0gICAgTlNWaWV3ICpvdXRlclZpZXcgPSB3aWRnZXQtPmdldE91dGVyVmll dygpOwotICAgIHdpZGdldC0+YmVmb3JlTW91c2VEb3duKG91dGVyVmlldywgd2lkZ2V0LmdldCgp KTsKKwogICAgIFt2aWV3IG1vdXNlRG93bjpjdXJyZW50TlNFdmVudCgpXTsKLSAgICB3aWRnZXQt PmFmdGVyTW91c2VEb3duKG91dGVyVmlldywgd2lkZ2V0LmdldCgpKTsKLSAgICBtX3NlbmRpbmdF dmVudFRvU3VidmlldyA9IGZhbHNlOwogICAgIAogICAgIGlmICghd2FzRGVmZXJyaW5nTG9hZGlu ZykKICAgICAgICAgcGFnZS0+c2V0RGVmZXJzTG9hZGluZyhmYWxzZSk7CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9XaWRnZXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9XaWRnZXQuaAkocmV2aXNpb24gOTU2NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9XaWRnZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMjA5LDkgKzIwOSw2IEBAIHB1YmxpYzoK ICNpZiBQTEFURk9STShNQUMpCiAgICAgTlNWaWV3KiBnZXRPdXRlclZpZXcoKSBjb25zdDsKIAot ICAgIHN0YXRpYyB2b2lkIGJlZm9yZU1vdXNlRG93bihOU1ZpZXcqLCBXaWRnZXQqKTsKLSAgICBz dGF0aWMgdm9pZCBhZnRlck1vdXNlRG93bihOU1ZpZXcqLCBXaWRnZXQqKTsKLQogICAgIHZvaWQg cmVtb3ZlRnJvbVN1cGVydmlldygpOwogI2VuZGlmCiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9XaWRnZXRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1dpZGdldE1hYy5tbQkocmV2aXNpb24gOTU2NDcpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvV2lkZ2V0TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02Niw4ICs2Niw2 IEBAIHB1YmxpYzoKICAgICB7CiAgICAgfQogCi0gICAgYm9vbCBtdXN0U3RheUluV2luZG93Owot ICAgIGJvb2wgcmVtb3ZlRnJvbVN1cGVydmlld1Nvb247CiAgICAgTlNSZWN0IHByZXZpb3VzVmlz aWJsZVJlY3Q7CiB9OwogCkBAIC05MSw4ICs4OSw2IEBAIFdpZGdldDo6V2lkZ2V0KE5TVmlldyAq dmlldykKICAgICA6IG1fZGF0YShuZXcgV2lkZ2V0UHJpdmF0ZSkKIHsKICAgICBpbml0KHZpZXcp OwotICAgIG1fZGF0YS0+bXVzdFN0YXlJbldpbmRvdyA9IGZhbHNlOwotICAgIG1fZGF0YS0+cmVt b3ZlRnJvbVN1cGVydmlld1Nvb24gPSBmYWxzZTsKIH0KIAogV2lkZ2V0Ojp+V2lkZ2V0KCkKQEAg LTMyNCwzNyArMzIwLDkgQEAgdm9pZCBXaWRnZXQ6OnNldElzU2VsZWN0ZWQoYm9vbCBpc1NlbGVj dAogCiB2b2lkIFdpZGdldDo6cmVtb3ZlRnJvbVN1cGVydmlldygpCiB7Ci0gICAgaWYgKG1fZGF0 YS0+bXVzdFN0YXlJbldpbmRvdykKLSAgICAgICAgbV9kYXRhLT5yZW1vdmVGcm9tU3VwZXJ2aWV3 U29vbiA9IHRydWU7Ci0gICAgZWxzZSB7Ci0gICAgICAgIG1fZGF0YS0+cmVtb3ZlRnJvbVN1cGVy dmlld1Nvb24gPSBmYWxzZTsKLSAgICAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwot ICAgICAgICBzYWZlUmVtb3ZlRnJvbVN1cGVydmlldyhnZXRPdXRlclZpZXcoKSk7Ci0gICAgICAg IEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7Ci0gICAgfQotfQotCi12b2lkIFdpZGdldDo6YmVm b3JlTW91c2VEb3duKE5TVmlldyAqdW51c2VkVmlldywgV2lkZ2V0KiB3aWRnZXQpCi17Ci0gICAg aWYgKHdpZGdldCkgewotICAgICAgICBBU1NFUlRfVU5VU0VEKHVudXNlZFZpZXcsIHVudXNlZFZp ZXcgPT0gd2lkZ2V0LT5nZXRPdXRlclZpZXcoKSk7Ci0gICAgICAgIEFTU0VSVCghd2lkZ2V0LT5t X2RhdGEtPm11c3RTdGF5SW5XaW5kb3cpOwotICAgICAgICB3aWRnZXQtPm1fZGF0YS0+bXVzdFN0 YXlJbldpbmRvdyA9IHRydWU7Ci0gICAgfQotfQotCi12b2lkIFdpZGdldDo6YWZ0ZXJNb3VzZURv d24oTlNWaWV3ICp2aWV3LCBXaWRnZXQqIHdpZGdldCkKLXsKLSAgICBpZiAoIXdpZGdldCkgewot ICAgICAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlM7Ci0gICAgICAgIHNhZmVSZW1vdmVG cm9tU3VwZXJ2aWV3KHZpZXcpOwotICAgICAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TOwot ICAgIH0gZWxzZSB7Ci0gICAgICAgIEFTU0VSVCh3aWRnZXQtPm1fZGF0YS0+bXVzdFN0YXlJbldp bmRvdyk7Ci0gICAgICAgIHdpZGdldC0+bV9kYXRhLT5tdXN0U3RheUluV2luZG93ID0gZmFsc2U7 Ci0gICAgICAgIGlmICh3aWRnZXQtPm1fZGF0YS0+cmVtb3ZlRnJvbVN1cGVydmlld1Nvb24pCi0g ICAgICAgICAgICB3aWRnZXQtPnJlbW92ZUZyb21TdXBlcnZpZXcoKTsKLSAgICB9CisgICAgQkVH SU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOworICAgIHNhZmVSZW1vdmVGcm9tU3VwZXJ2aWV3KGdl dE91dGVyVmlldygpKTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogfQogCiAvLyBU aGVzZSBhcmUgaGVyZSB0byBkZWFsIHdpdGggZmxpcHBlZCBjb29yZHMgb24gTWFjLgpJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAJKHJldmlzaW9uIDk1NjQ3 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTQ3LDcgKzQ3LDcgQEAgc3RhdGljIEhhc2hNYXA8Y29uc3QgV2lkZ2V0KiwgUmVu ZGVyV2lkZwogICAgIHJldHVybiAqc3RhdGljV2lkZ2V0UmVuZGVyZXJNYXA7CiB9CiAKLXN0YXRp YyBzaXplX3Qgd2lkZ2V0SGllcmFyY2h5VXBkYXRlU3VzcGVuZENvdW50Oworc3RhdGljIHVuc2ln bmVkIHdpZGdldEhpZXJhcmNoeVVwZGF0ZVN1c3BlbmRDb3VudDsKIAogdHlwZWRlZiBIYXNoTWFw PFJlZlB0cjxXaWRnZXQ+LCBGcmFtZVZpZXcqPiBXaWRnZXRUb1BhcmVudE1hcDsKIAo=