68568 2011-09-21 13:32:12 -0700 Fix full-page rubber band overhang appearing when gesturing during a slow page load. 2011-09-26 14:43:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 asvitkine webkit-unassigned bdakin dglazkov mark sail sam thakis webkit.review.bot oldest_to_newest 471119 0 asvitkine 2011-09-21 13:32:12 -0700 Fix full-page rubber band overhang appearing when gesturing during a slow page load. 471120 1 108225 asvitkine 2011-09-21 13:35:32 -0700 Created attachment 108225 Patch 471122 2 asvitkine 2011-09-21 13:36:38 -0700 bdakin@, do these changes makes sense to you? 471127 3 108225 abarth 2011-09-21 13:46:56 -0700 Comment on attachment 108225 Patch This approach looks much better than asking FrameLoader about the state of the load. Thanks for investigating further. 473186 4 asvitkine 2011-09-26 10:34:05 -0700 Ping! Any comments? 473226 5 bdakin 2011-09-26 11:22:24 -0700 Sorry for the delay! Yes, I think this change looks okay. 473251 6 108225 abarth 2011-09-26 11:46:43 -0700 Comment on attachment 108225 Patch Sounds like we should rock and roll. 473399 7 108225 webkit.review.bot 2011-09-26 14:43:34 -0700 Comment on attachment 108225 Patch Clearing flags on attachment: 108225 Committed r95997: <http://trac.webkit.org/changeset/95997> 473400 8 webkit.review.bot 2011-09-26 14:43:38 -0700 All reviewed patches have been landed. Closing bug. 108225 2011-09-21 13:35:32 -0700 2011-09-26 14:43:34 -0700 Patch bug-68568-20110921163531.patch text/plain 4091 asvitkine SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NjY3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDktMjEgIEFsZXhlaSBT dml0a2luZSAgPGFzdml0a2luZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IGZ1bGwtcGFn ZSBydWJiZXIgYmFuZCBvdmVyaGFuZyBhcHBlYXJpbmcgd2hlbiBnZXN0dXJpbmcgZHVyaW5nIGEg c2xvdyBwYWdlIGxvYWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02ODU2OAorCisgICAgICAgIENocm9taXVtIGJ1ZzogaHR0cDovL2NvZGUuZ29vZ2xl LmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9OTcyNDMKKworICAgICAgICAoVGhpcyBh bHNvIGhhcHBlbnMgb24gU2FmYXJpLikKKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCBT Y3JvbGxWaWV3OjpvdmVyaGFuZ0Ftb3VudCgpIHdhcyByZXR1cm5pbmcgYSBmdWxsLXBhZ2Ugb3Zl cmhhbmcgZHVlIHRvIGNvbnRlbnRzU2l6ZSgpIGJlaW5nIDAgYnJpZWZseSBkdXJpbmcgYSBwYWdl IGxvYWQsIHdoaWNoIHdhcyB0aGVuIGdldHRpbmcgdXNlZCBieSBTY3JvbGxBbmltYXRvckNocm9t aXVtTWFjLm1tIHRvIHVwZGF0ZSB0aGUgb3Zlcmhhbmcgb24gYSBnZXN0dXJlIGV2ZW50LiBUaGlz IGNoYW5nZSBtYWtlcyB0aGUgcmVsZXZhbnQgbG9naWMgbm90IHJldHVybiBhbiBvdmVyaGFuZyBp ZiB0aGUgY29udGVudHNTaXplKCkgaXMgZW1wdHkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSB0aGlzIGlzIGhpZ2hs eSB0aW1pbmctcmVsYXRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6b3ZlcmhhbmdBbW91bnQpOgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsVmlldzo6d2hlZWxFdmVudCk6CisKIDIwMTEtMDktMjEgIFNlcmdleSBH bGF6dW5vdiAgPHNlcmcuZ2xhenVub3ZAZ21haWwuY29tPgogCiAgICAgICAgIFtDaHJvbWl1bV0g UHJvdGVjdCB0aGUgRnJhbWUgaW4gVjhIVE1MRG9jdW1lbnQ6Om9wZW5DYWxsYmFjawpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAJKHJldmlzaW9uIDk1NjY3KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQxMSwxNCArNDExLDE0IEBAIEludFNpemUgU2Nyb2xsVmlldzo6b3ZlcmhhbmdBbW91bnQoKSBj b24KICAgICBpbnQgcGh5c2ljYWxTY3JvbGxZID0gc2Nyb2xsUG9zaXRpb24oKS55KCkgKyBtX3Nj cm9sbE9yaWdpbi55KCk7CiAgICAgaWYgKHBoeXNpY2FsU2Nyb2xsWSA8IDApCiAgICAgICAgIHN0 cmV0Y2guc2V0SGVpZ2h0KHBoeXNpY2FsU2Nyb2xsWSk7Ci0gICAgZWxzZSBpZiAocGh5c2ljYWxT Y3JvbGxZID4gY29udGVudHNIZWlnaHQoKSAtIHZpc2libGVDb250ZW50UmVjdCgpLmhlaWdodCgp KQotICAgICAgICBzdHJldGNoLnNldEhlaWdodChwaHlzaWNhbFNjcm9sbFkgLSAoY29udGVudHNI ZWlnaHQoKSAtIHZpc2libGVDb250ZW50UmVjdCgpLmhlaWdodCgpKSk7CisgICAgZWxzZSBpZiAo Y29udGVudHNIZWlnaHQoKSAmJiBwaHlzaWNhbFNjcm9sbFkgPiBjb250ZW50c0hlaWdodCgpIC0g dmlzaWJsZUhlaWdodCgpKQorICAgICAgICBzdHJldGNoLnNldEhlaWdodChwaHlzaWNhbFNjcm9s bFkgLSAoY29udGVudHNIZWlnaHQoKSAtIHZpc2libGVIZWlnaHQoKSkpOwogCiAgICAgaW50IHBo eXNpY2FsU2Nyb2xsWCA9IHNjcm9sbFBvc2l0aW9uKCkueCgpICsgbV9zY3JvbGxPcmlnaW4ueCgp OwogICAgIGlmIChwaHlzaWNhbFNjcm9sbFggPCAwKQogICAgICAgICBzdHJldGNoLnNldFdpZHRo KHBoeXNpY2FsU2Nyb2xsWCk7Ci0gICAgZWxzZSBpZiAocGh5c2ljYWxTY3JvbGxYID4gY29udGVu dHNXaWR0aCgpIC0gdmlzaWJsZUNvbnRlbnRSZWN0KCkud2lkdGgoKSkKLSAgICAgICAgc3RyZXRj aC5zZXRXaWR0aChwaHlzaWNhbFNjcm9sbFggLSAoY29udGVudHNXaWR0aCgpIC0gdmlzaWJsZUNv bnRlbnRSZWN0KCkud2lkdGgoKSkpOworICAgIGVsc2UgaWYgKGNvbnRlbnRzV2lkdGgoKSAmJiBw aHlzaWNhbFNjcm9sbFggPiBjb250ZW50c1dpZHRoKCkgLSB2aXNpYmxlV2lkdGgoKSkKKyAgICAg ICAgc3RyZXRjaC5zZXRXaWR0aChwaHlzaWNhbFNjcm9sbFggLSAoY29udGVudHNXaWR0aCgpIC0g dmlzaWJsZVdpZHRoKCkpKTsKIAogICAgIHJldHVybiBzdHJldGNoOwogfQpAQCAtMTA2NSw4ICsx MDY1LDggQEAgdm9pZCBTY3JvbGxWaWV3OjpjYWxjdWxhdGVPdmVyaGFuZ0FyZWFzRgogICAgIGlm IChwaHlzaWNhbFNjcm9sbFkgPCAwKSB7CiAgICAgICAgIGhvcml6b250YWxPdmVyaGFuZ1JlY3Qg PSBmcmFtZVJlY3QoKTsKICAgICAgICAgaG9yaXpvbnRhbE92ZXJoYW5nUmVjdC5zZXRIZWlnaHQo LXBoeXNpY2FsU2Nyb2xsWSk7Ci0gICAgfSBlbHNlIGlmIChwaHlzaWNhbFNjcm9sbFkgPiBjb250 ZW50c0hlaWdodCgpIC0gdmlzaWJsZUNvbnRlbnRSZWN0KCkuaGVpZ2h0KCkpIHsKLSAgICAgICAg aW50IGhlaWdodCA9IHBoeXNpY2FsU2Nyb2xsWSAtIChjb250ZW50c0hlaWdodCgpIC0gdmlzaWJs ZUNvbnRlbnRSZWN0KCkuaGVpZ2h0KCkpOworICAgIH0gZWxzZSBpZiAoY29udGVudHNIZWlnaHQo KSAmJiBwaHlzaWNhbFNjcm9sbFkgPiBjb250ZW50c0hlaWdodCgpIC0gdmlzaWJsZUhlaWdodCgp KSB7CisgICAgICAgIGludCBoZWlnaHQgPSBwaHlzaWNhbFNjcm9sbFkgLSAoY29udGVudHNIZWln aHQoKSAtIHZpc2libGVIZWlnaHQoKSk7CiAgICAgICAgIGhvcml6b250YWxPdmVyaGFuZ1JlY3Qg PSBmcmFtZVJlY3QoKTsKICAgICAgICAgaG9yaXpvbnRhbE92ZXJoYW5nUmVjdC5zZXRZKGZyYW1l UmVjdCgpLm1heFkoKSAtIGhlaWdodCAtIGhvcml6b250YWxTY3JvbGxiYXJIZWlnaHQpOwogICAg ICAgICBob3Jpem9udGFsT3ZlcmhhbmdSZWN0LnNldEhlaWdodChoZWlnaHQpOwpAQCAtMTA4MSw4 ICsxMDgxLDggQEAgdm9pZCBTY3JvbGxWaWV3OjpjYWxjdWxhdGVPdmVyaGFuZ0FyZWFzRgogICAg ICAgICAgICAgdmVydGljYWxPdmVyaGFuZ1JlY3Quc2V0WShmcmFtZVJlY3QoKS55KCkgKyBob3Jp em9udGFsT3ZlcmhhbmdSZWN0LmhlaWdodCgpKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAg dmVydGljYWxPdmVyaGFuZ1JlY3Quc2V0WShmcmFtZVJlY3QoKS55KCkpOwotICAgIH0gZWxzZSBp ZiAocGh5c2ljYWxTY3JvbGxYID4gY29udGVudHNXaWR0aCgpIC0gdmlzaWJsZUNvbnRlbnRSZWN0 KCkud2lkdGgoKSkgewotICAgICAgICBpbnQgd2lkdGggPSBwaHlzaWNhbFNjcm9sbFggLSAoY29u dGVudHNXaWR0aCgpIC0gdmlzaWJsZUNvbnRlbnRSZWN0KCkud2lkdGgoKSk7CisgICAgfSBlbHNl IGlmIChjb250ZW50c1dpZHRoKCkgJiYgcGh5c2ljYWxTY3JvbGxYID4gY29udGVudHNXaWR0aCgp IC0gdmlzaWJsZVdpZHRoKCkpIHsKKyAgICAgICAgaW50IHdpZHRoID0gcGh5c2ljYWxTY3JvbGxY IC0gKGNvbnRlbnRzV2lkdGgoKSAtIHZpc2libGVXaWR0aCgpKTsKICAgICAgICAgdmVydGljYWxP dmVyaGFuZ1JlY3Quc2V0V2lkdGgod2lkdGgpOwogICAgICAgICB2ZXJ0aWNhbE92ZXJoYW5nUmVj dC5zZXRIZWlnaHQoZnJhbWVSZWN0KCkuaGVpZ2h0KCkgLSBob3Jpem9udGFsT3ZlcmhhbmdSZWN0 LmhlaWdodCgpKTsKICAgICAgICAgdmVydGljYWxPdmVyaGFuZ1JlY3Quc2V0WChmcmFtZVJlY3Qo KS5tYXhYKCkgLSB3aWR0aCAtIHZlcnRpY2FsU2Nyb2xsYmFyV2lkdGgpOwo=