68553 2011-09-21 11:56:15 -0700 [GTK][WK2] Error loading libMiniBrowserWebBundle.so 2022-03-01 03:10:17 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ravi.kasibhatla webkit-unassigned cgarcia mrobinson pnormand webkit.review.bot oldest_to_newest 471001 0 ravi.kasibhatla 2011-09-21 11:56:15 -0700 We encounter following message on MiniBrowser launch: Error loading the injected bundle (Libraries/.libs/libMiniBrowserWebBundle.so): Libraries/.libs/libMiniBrowserWebBundle.so: cannot open shared object file: No such file or directory Path of the library file to be corrected. 471010 1 108200 ravi.kasibhatla 2011-09-21 12:02:04 -0700 Created attachment 108200 Corrected libMiniBrowserWebBundle.so loading path Remove this unrelated change from https://bugs.webkit.org/show_bug.cgi?id=68235 patch and adding it separately. 471020 2 108200 mrobinson 2011-09-21 12:09:10 -0700 Comment on attachment 108200 Corrected libMiniBrowserWebBundle.so loading path View in context: https://bugs.webkit.org/attachment.cgi?id=108200&action=review I'm going to add a helper function soon that discovers the binary location. Could this patch be changed to simply find the shared object relative to the binary location after that patch lands? > Tools/MiniBrowser/gtk/main.c:48 > + g_free((gpointer)webBundlePath); It's totally unecessary to cast to gpointer here. 471035 3 ravi.kasibhatla 2011-09-21 12:19:42 -0700 (In reply to comment #2) > (From update of attachment 108200 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108200&action=review > > I'm going to add a helper function soon that discovers the binary location. Could this patch be changed to simply find the shared object relative to the binary location after that patch lands? > > > Tools/MiniBrowser/gtk/main.c:48 > > + g_free((gpointer)webBundlePath); > > It's totally unecessary to cast to gpointer here. Actually I was getting a compiler warning for passing const gchar to g_free though it expects a gpointer. So I casted it. 471043 4 108200 mrobinson 2011-09-21 12:23:55 -0700 Comment on attachment 108200 Corrected libMiniBrowserWebBundle.so loading path View in context: https://bugs.webkit.org/attachment.cgi?id=108200&action=review > Tools/MiniBrowser/gtk/main.c:37 > + const gchar* webBundlePath = g_build_filename(bundleEnvPath ? bundleEnvPath : LIBEXECDIR, "libMiniBrowserWebBundle.so", NULL); This should not be a const pointer, since g_build_filename allocaetes heap memory to hold the new string. 471044 5 108206 ravi.kasibhatla 2011-09-21 12:26:28 -0700 Created attachment 108206 Corrected libMiniBrowserWebBundle.so loading path Addressing comments. 471046 6 webkit.review.bot 2011-09-21 12:29:28 -0700 Attachment 108206 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/gtk/..." exit_code: 1 Tools/MiniBrowser/gtk/main.c:37: Declaration has space between * and variable name in gchar* webBundlePath [whitespace/declaration] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 471387 7 108206 cgarcia 2011-09-22 00:03:44 -0700 Comment on attachment 108206 Corrected libMiniBrowserWebBundle.so loading path LIBEXECDIR is where executables for the library are installed. In this case, injected bundle is a library, not an executable. MiniBrowser is not installed, and the injected bundle library either. 471394 8 108206 pnormand 2011-09-22 00:17:20 -0700 Comment on attachment 108206 Corrected libMiniBrowserWebBundle.so loading path View in context: https://bugs.webkit.org/attachment.cgi?id=108206&action=review As Martin says in comment 2 he has another plan for this bug as well. Maybe discuss a bit more about the approach to take to fix this bug? r- because of wrong use of libexecdir. > Tools/MiniBrowser/gtk/GNUmakefile.am:8 > + -DLIBEXECDIR=\""$(libexecdir)"\" \ This should point to the directory in $(top_builddir) storing the libMiniBrowserWebBundle.so. As Carlos points out it's not installed, so not available outside the build directory. 500620 9 cgarcia 2011-11-11 03:15:11 -0800 MiniBrowser doesn't use injected bundle anymore, so this problem is now fixed. 108200 2011-09-21 12:02:04 -0700 2011-09-21 12:26:28 -0700 Corrected libMiniBrowserWebBundle.so loading path 68553_fix.diff text/plain 2528 ravi.kasibhatla SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1NjU2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMjEgIFJhdmkgUGhhbmVlbmRyYSBLYXNpYmhhdGxhICA8cmF2aS5r YXNpYmhhdGxhQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBDb3JyZWN0IHRoZSBsb2FkaW5nIHBh dGggZm9yIGxpYk1pbmlCcm93c2VyV2ViQnVuZGxlLnNvCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODU1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFt OiBBZGRlZCBMSUJFWEVDX0RJUiBmb3IgdXNhZ2UgaW4gYXBwLgorICAgICAgICAqIE1pbmlCcm93 c2VyL2d0ay9tYWluLmM6IENvcnJlY3RlZCBwYXRoIGZvciBsaWJNaW5pQnJvd3NlcldlYkJ1bmRs ZS5zbyB0byBiZSBwaWNrZWQgZnJvbQorICAgICAgICBlbnZpcm9ubWVudCBwYXRoIFdFQktJVDJf QlJPV1NFUl9CVU5ETEVfUEFUSCBvciBMSUJFWEVDX0RJUiBwYXRoLgorICAgICAgICAoY3JlYXRl V0tDb250ZXh0V2l0aEluamVjdGVkQnVuZGxlKToKKwogMjAxMS0wOS0yMSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFRvb2xzIHBhcnQgb2Y6IFByZXZlbnQgdGhl IFdlYktpdCBmcmFtZXdvcmtzIGZyb20gZGVmaW5pbmcgaW5hcHByb3ByaWF0ZWx5LW5hbWVkIE9i amVjdGl2ZS1DIGNsYXNzZXMKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmls ZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0J KHJldmlzaW9uIDk1MzczKQorKysgVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFt CSh3b3JraW5nIGNvcHkpCkBAIC01LDYgKzUsNyBAQCBQcm9ncmFtc19NaW5pQnJvd3Nlcl9DUFBG TEFHUyA9IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UgXAogCS1JJCh0b3BfYnVpbGRkaXIpL0Rlcml2 ZWRTb3VyY2VzL1dlYktpdDIvaW5jbHVkZSBcCiAJLURXRUJLSVRfRVhFQ19QQVRIPVwiJHtzaGVs bCBwd2R9LyQodG9wX2J1aWxkZGlyKS9Qcm9ncmFtcy9cIiBcCisJLURMSUJFWEVDRElSPVwiIiQo bGliZXhlY2RpcikiXCIgXAogCSQoZ2xvYmFsX2NwcGZsYWdzKSBcCiAJJChHTElCX0NGTEFHUykg XAogCSQoR1RLX0NGTEFHUykKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYwkocmV2aXNpb24gOTUzNzMp CisrKyBUb29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3 ICszMyw5IEBAIHN0YXRpYyBjb25zdCBnY2hhciAqKnVyaUFyZ3VtZW50cyA9IE5VTEwKIAogc3Rh dGljIFdLQ29udGV4dFJlZiBjcmVhdGVXS0NvbnRleHRXaXRoSW5qZWN0ZWRCdW5kbGUoKQogewot ICAgIFdLU3RyaW5nUmVmIGJ1bmRsZVBhdGggPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmlu ZygiTGlicmFyaWVzLy5saWJzL2xpYk1pbmlCcm93c2VyV2ViQnVuZGxlLnNvIik7CisgICAgY29u c3QgZ2NoYXIqIGJ1bmRsZUVudlBhdGggPSBnX2dldGVudigiV0VCS0lUMl9CUk9XU0VSX0JVTkRM RV9QQVRIIik7CisgICAgY29uc3QgZ2NoYXIqIHdlYkJ1bmRsZVBhdGggPSBnX2J1aWxkX2ZpbGVu YW1lKGJ1bmRsZUVudlBhdGggPyBidW5kbGVFbnZQYXRoIDogTElCRVhFQ0RJUiwgImxpYk1pbmlC cm93c2VyV2ViQnVuZGxlLnNvIiwgTlVMTCk7CisgICAgV0tTdHJpbmdSZWYgYnVuZGxlUGF0aCA9 IFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKHdlYkJ1bmRsZVBhdGgpOwogICAgIFdLQ29u dGV4dFJlZiBwcm9jZXNzQ29udGV4dCA9IFdLQ29udGV4dENyZWF0ZVdpdGhJbmplY3RlZEJ1bmRs ZVBhdGgoYnVuZGxlUGF0aCk7CiAgICAgV0tDb250ZXh0SW5qZWN0ZWRCdW5kbGVDbGllbnQgYnVu ZGxlQ2xpZW50ID0gewogICAgICAgICBrV0tDb250ZXh0SW5qZWN0ZWRCdW5kbGVDbGllbnRDdXJy ZW50VmVyc2lvbiwKQEAgLTQzLDYgKzQ1LDcgQEAgc3RhdGljIFdLQ29udGV4dFJlZiBjcmVhdGVX S0NvbnRleHRXaXRoSQogICAgIH07CiAgICAgV0tDb250ZXh0U2V0SW5qZWN0ZWRCdW5kbGVDbGll bnQocHJvY2Vzc0NvbnRleHQsICZidW5kbGVDbGllbnQpOwogICAgIFdLUmVsZWFzZShidW5kbGVQ YXRoKTsKKyAgICBnX2ZyZWUoKGdwb2ludGVyKXdlYkJ1bmRsZVBhdGgpOwogCiAgICAgcmV0dXJu IHByb2Nlc3NDb250ZXh0OwogfQo= 108206 2011-09-21 12:26:28 -0700 2022-03-01 03:10:17 -0800 Corrected libMiniBrowserWebBundle.so loading path 68553_fix.diff text/plain 2512 ravi.kasibhatla SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1NjU2KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMjEgIFJhdmkgUGhhbmVlbmRyYSBLYXNpYmhhdGxhICA8cmF2aS5r YXNpYmhhdGxhQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBDb3JyZWN0IHRoZSBsb2FkaW5nIHBh dGggZm9yIGxpYk1pbmlCcm93c2VyV2ViQnVuZGxlLnNvCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODU1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFt OiBBZGRlZCBMSUJFWEVDX0RJUiBmb3IgdXNhZ2UgaW4gYXBwLgorICAgICAgICAqIE1pbmlCcm93 c2VyL2d0ay9tYWluLmM6IENvcnJlY3RlZCBwYXRoIGZvciBsaWJNaW5pQnJvd3NlcldlYkJ1bmRs ZS5zbyB0byBiZSBwaWNrZWQgZnJvbQorICAgICAgICBlbnZpcm9ubWVudCBwYXRoIFdFQktJVDJf QlJPV1NFUl9CVU5ETEVfUEFUSCBvciBMSUJFWEVDX0RJUiBwYXRoLgorICAgICAgICAoY3JlYXRl V0tDb250ZXh0V2l0aEluamVjdGVkQnVuZGxlKToKKwogMjAxMS0wOS0yMSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFRvb2xzIHBhcnQgb2Y6IFByZXZlbnQgdGhl IFdlYktpdCBmcmFtZXdvcmtzIGZyb20gZGVmaW5pbmcgaW5hcHByb3ByaWF0ZWx5LW5hbWVkIE9i amVjdGl2ZS1DIGNsYXNzZXMKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmls ZS5hbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0J KHJldmlzaW9uIDk1MzczKQorKysgVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFt CSh3b3JraW5nIGNvcHkpCkBAIC01LDYgKzUsNyBAQCBQcm9ncmFtc19NaW5pQnJvd3Nlcl9DUFBG TEFHUyA9IFwKIAktSSQoc3JjZGlyKS9Tb3VyY2UgXAogCS1JJCh0b3BfYnVpbGRkaXIpL0Rlcml2 ZWRTb3VyY2VzL1dlYktpdDIvaW5jbHVkZSBcCiAJLURXRUJLSVRfRVhFQ19QQVRIPVwiJHtzaGVs bCBwd2R9LyQodG9wX2J1aWxkZGlyKS9Qcm9ncmFtcy9cIiBcCisJLURMSUJFWEVDRElSPVwiIiQo bGliZXhlY2RpcikiXCIgXAogCSQoZ2xvYmFsX2NwcGZsYWdzKSBcCiAJJChHTElCX0NGTEFHUykg XAogCSQoR1RLX0NGTEFHUykKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYwkocmV2aXNpb24gOTUzNzMp CisrKyBUb29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3 ICszMyw5IEBAIHN0YXRpYyBjb25zdCBnY2hhciAqKnVyaUFyZ3VtZW50cyA9IE5VTEwKIAogc3Rh dGljIFdLQ29udGV4dFJlZiBjcmVhdGVXS0NvbnRleHRXaXRoSW5qZWN0ZWRCdW5kbGUoKQogewot ICAgIFdLU3RyaW5nUmVmIGJ1bmRsZVBhdGggPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmlu ZygiTGlicmFyaWVzLy5saWJzL2xpYk1pbmlCcm93c2VyV2ViQnVuZGxlLnNvIik7CisgICAgY29u c3QgZ2NoYXIqIGJ1bmRsZUVudlBhdGggPSBnX2dldGVudigiV0VCS0lUMl9CUk9XU0VSX0JVTkRM RV9QQVRIIik7CisgICAgZ2NoYXIqIHdlYkJ1bmRsZVBhdGggPSBnX2J1aWxkX2ZpbGVuYW1lKGJ1 bmRsZUVudlBhdGggPyBidW5kbGVFbnZQYXRoIDogTElCRVhFQ0RJUiwgImxpYk1pbmlCcm93c2Vy V2ViQnVuZGxlLnNvIiwgTlVMTCk7CisgICAgV0tTdHJpbmdSZWYgYnVuZGxlUGF0aCA9IFdLU3Ry aW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKHdlYkJ1bmRsZVBhdGgpOwogICAgIFdLQ29udGV4dFJl ZiBwcm9jZXNzQ29udGV4dCA9IFdLQ29udGV4dENyZWF0ZVdpdGhJbmplY3RlZEJ1bmRsZVBhdGgo YnVuZGxlUGF0aCk7CiAgICAgV0tDb250ZXh0SW5qZWN0ZWRCdW5kbGVDbGllbnQgYnVuZGxlQ2xp ZW50ID0gewogICAgICAgICBrV0tDb250ZXh0SW5qZWN0ZWRCdW5kbGVDbGllbnRDdXJyZW50VmVy c2lvbiwKQEAgLTQzLDYgKzQ1LDcgQEAgc3RhdGljIFdLQ29udGV4dFJlZiBjcmVhdGVXS0NvbnRl eHRXaXRoSQogICAgIH07CiAgICAgV0tDb250ZXh0U2V0SW5qZWN0ZWRCdW5kbGVDbGllbnQocHJv Y2Vzc0NvbnRleHQsICZidW5kbGVDbGllbnQpOwogICAgIFdLUmVsZWFzZShidW5kbGVQYXRoKTsK KyAgICBnX2ZyZWUod2ViQnVuZGxlUGF0aCk7CiAKICAgICByZXR1cm4gcHJvY2Vzc0NvbnRleHQ7 CiB9Cg==