68537 2011-09-21 08:25:50 -0700 Web Inspector: add minimal error handling to the DOM breakpoints. 2011-09-21 08:39:03 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 470822 0 pfeldman 2011-09-21 08:25:50 -0700 Patch to follow. 470823 1 108166 pfeldman 2011-09-21 08:27:32 -0700 Created attachment 108166 Patch 470828 2 108166 yurys 2011-09-21 08:31:55 -0700 Comment on attachment 108166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108166&action=review > Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:189 > + *errorString = "Unknown DOM breakpoint type: " + typeString; Use makeString instead? 470831 3 pfeldman 2011-09-21 08:39:03 -0700 Committed r95634: <http://trac.webkit.org/changeset/95634> 108166 2011-09-21 08:27:32 -0700 2011-09-21 08:32:08 -0700 Patch bug-68537-20110921192730.patch text/plain 4286 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogOTU2MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZjNjYzc4YThkNTZhMzk5 ZDdkNWY3YWI5ZWNhNWExMWYzNjJjYTg0Li42ZDJiOTk5MmU0ZDZhYzExOTEzNjkyM2ViMDlhYmU5 NmUzNmI4OWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMDktMjEgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGFkZCBtaW5pbWFsIGVycm9yIGhhbmRsaW5nIHRvIHRoZSBET00gYnJlYWtwb2ludHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODUzNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0lu c3BlY3RvckRPTUFnZW50Lmg6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTURlYnVn Z2VyQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZG9tVHlwZUZvck5hbWUpOgorICAgICAg ICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NRGVidWdnZXJBZ2VudDo6c2V0RE9NQnJlYWtwb2ludCk6 CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01EZWJ1Z2dlckFnZW50OjpyZW1vdmVET01C cmVha3BvaW50KToKKworMjAxMS0wOS0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2ds ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogcGFpbnQgYm94IG1vZGVsIGNvbG9ycyBp biBNZXRyaWNzIHNpZGViYXIgYXQgYWxsIHRpbWVzLCBkbyBub3QgZHJhdyBib3ggb3V0bGluZXMu CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODI0MAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQu aCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCmluZGV4IDM4 NDU0OWY0MTUxZmM4ZmFkZGI3NDk2M2ViMDllMmExYWZkZDJiY2UuLjFkYmQwOWU0N2RiNGZhNDhi NzU4Y2ZhNzZlMjE3MDZlOTRjNDQ5MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JET01BZ2VudC5oCkBAIC0xODAsNiArMTgwLDggQEAgcHVibGljOgogICAgIHN0YXRp YyBOb2RlKiBpbm5lclBhcmVudE5vZGUoTm9kZSopOwogICAgIHN0YXRpYyBib29sIGlzV2hpdGVz cGFjZShOb2RlKik7CiAKKyAgICBOb2RlKiBhc3NlcnROb2RlKEVycm9yU3RyaW5nKiwgaW50IG5v ZGVJZCk7CisKIHByaXZhdGU6CiAgICAgSW5zcGVjdG9yRE9NQWdlbnQoSW5zdHJ1bWVudGluZ0Fn ZW50cyosIEluc3BlY3RvclBhZ2VBZ2VudCosIEluc3BlY3RvckNsaWVudCosIEluc3BlY3RvclN0 YXRlKiwgSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKik7CiAKQEAgLTE5MSw3ICsxOTMsNiBAQCBwcml2 YXRlOgogICAgIHR5cGVkZWYgSGFzaE1hcDxSZWZQdHI8Tm9kZT4sIGludD4gTm9kZVRvSWRNYXA7 CiAgICAgaW50IGJpbmQoTm9kZSosIE5vZGVUb0lkTWFwKik7CiAgICAgdm9pZCB1bmJpbmQoTm9k ZSosIE5vZGVUb0lkTWFwKik7Ci0gICAgTm9kZSogYXNzZXJ0Tm9kZShFcnJvclN0cmluZyosIGlu dCBub2RlSWQpOwogICAgIEVsZW1lbnQqIGFzc2VydEVsZW1lbnQoRXJyb3JTdHJpbmcqLCBpbnQg bm9kZUlkKTsKICAgICBIVE1MRWxlbWVudCogYXNzZXJ0SFRNTEVsZW1lbnQoRXJyb3JTdHJpbmcq LCBpbnQgbm9kZUlkKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTURlYnVnZ2VyQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckRPTURlYnVnZ2VyQWdlbnQuY3BwCmluZGV4IDMxZjhhZTU3MDUyNjc2NjI2YzcyYzFl NWIxMmFhYWQ2NDRjNmNjMjEuLmVjNDUxOWUxODUyNWUxMGI0ZmE3YWVmMDkzZGNjYjllOGExNTJi ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01EZWJ1 Z2dlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9N RGVidWdnZXJBZ2VudC5jcHAKQEAgLTE3OCw3ICsxNzgsNyBAQCB2b2lkIEluc3BlY3RvckRPTURl YnVnZ2VyQWdlbnQ6OmRpZFJlbW92ZURPTU5vZGUoTm9kZSogbm9kZSkKICAgICB9CiB9CiAKLXN0 YXRpYyBpbnQgZG9tVHlwZUZvck5hbWUoY29uc3QgU3RyaW5nJiB0eXBlU3RyaW5nKQorc3RhdGlj IGludCBkb21UeXBlRm9yTmFtZShFcnJvclN0cmluZyogZXJyb3JTdHJpbmcsIGNvbnN0IFN0cmlu ZyYgdHlwZVN0cmluZykKIHsKICAgICBpZiAodHlwZVN0cmluZyA9PSAic3VidHJlZS1tb2RpZmll ZCIpCiAgICAgICAgIHJldHVybiBTdWJ0cmVlTW9kaWZpZWQ7CkBAIC0xODYsNyArMTg2LDggQEAg c3RhdGljIGludCBkb21UeXBlRm9yTmFtZShjb25zdCBTdHJpbmcmIHR5cGVTdHJpbmcpCiAgICAg ICAgIHJldHVybiBBdHRyaWJ1dGVNb2RpZmllZDsKICAgICBpZiAodHlwZVN0cmluZyA9PSAibm9k ZS1yZW1vdmVkIikKICAgICAgICAgcmV0dXJuIE5vZGVSZW1vdmVkOwotICAgIHJldHVybiBTdWJ0 cmVlTW9kaWZpZWQ7CisgICAgKmVycm9yU3RyaW5nID0gIlVua25vd24gRE9NIGJyZWFrcG9pbnQg dHlwZTogIiArIHR5cGVTdHJpbmc7CisgICAgcmV0dXJuIC0xOwogfQogCiBzdGF0aWMgU3RyaW5n IGRvbVR5cGVOYW1lKGludCB0eXBlKQpAQCAtMjAwLDEyICsyMDEsMTUgQEAgc3RhdGljIFN0cmlu ZyBkb21UeXBlTmFtZShpbnQgdHlwZSkKICAgICByZXR1cm4gIiI7CiB9CiAKLXZvaWQgSW5zcGVj dG9yRE9NRGVidWdnZXJBZ2VudDo6c2V0RE9NQnJlYWtwb2ludChFcnJvclN0cmluZyosIGludCBu b2RlSWQsIGNvbnN0IFN0cmluZyYgdHlwZVN0cmluZykKK3ZvaWQgSW5zcGVjdG9yRE9NRGVidWdn ZXJBZ2VudDo6c2V0RE9NQnJlYWtwb2ludChFcnJvclN0cmluZyogZXJyb3JTdHJpbmcsIGludCBu b2RlSWQsIGNvbnN0IFN0cmluZyYgdHlwZVN0cmluZykKIHsKLSAgICBOb2RlKiBub2RlID0gbV9k b21BZ2VudC0+bm9kZUZvcklkKG5vZGVJZCk7CisgICAgTm9kZSogbm9kZSA9IG1fZG9tQWdlbnQt PmFzc2VydE5vZGUoZXJyb3JTdHJpbmcsIG5vZGVJZCk7CiAgICAgaWYgKCFub2RlKQogICAgICAg ICByZXR1cm47Ci0gICAgaW50IHR5cGUgPSBkb21UeXBlRm9yTmFtZSh0eXBlU3RyaW5nKTsKKwor ICAgIGludCB0eXBlID0gZG9tVHlwZUZvck5hbWUoZXJyb3JTdHJpbmcsIHR5cGVTdHJpbmcpOwor ICAgIGlmICh0eXBlID09IC0xKQorICAgICAgICByZXR1cm47CiAKICAgICB1aW50MzJfdCByb290 Qml0ID0gMSA8PCB0eXBlOwogICAgIG1fZG9tQnJlYWtwb2ludHMuc2V0KG5vZGUsIG1fZG9tQnJl YWtwb2ludHMuZ2V0KG5vZGUpIHwgcm9vdEJpdCk7CkBAIC0yMTUsMTIgKzIxOSwxNCBAQCB2b2lk IEluc3BlY3RvckRPTURlYnVnZ2VyQWdlbnQ6OnNldERPTUJyZWFrcG9pbnQoRXJyb3JTdHJpbmcq LCBpbnQgbm9kZUlkLCBjb25zdAogICAgIH0KIH0KIAotdm9pZCBJbnNwZWN0b3JET01EZWJ1Z2dl ckFnZW50OjpyZW1vdmVET01CcmVha3BvaW50KEVycm9yU3RyaW5nKiwgaW50IG5vZGVJZCwgY29u c3QgU3RyaW5nJiB0eXBlU3RyaW5nKQordm9pZCBJbnNwZWN0b3JET01EZWJ1Z2dlckFnZW50Ojpy ZW1vdmVET01CcmVha3BvaW50KEVycm9yU3RyaW5nKiBlcnJvclN0cmluZywgaW50IG5vZGVJZCwg Y29uc3QgU3RyaW5nJiB0eXBlU3RyaW5nKQogewotICAgIE5vZGUqIG5vZGUgPSBtX2RvbUFnZW50 LT5ub2RlRm9ySWQobm9kZUlkKTsKKyAgICBOb2RlKiBub2RlID0gbV9kb21BZ2VudC0+YXNzZXJ0 Tm9kZShlcnJvclN0cmluZywgbm9kZUlkKTsKICAgICBpZiAoIW5vZGUpCiAgICAgICAgIHJldHVy bjsKLSAgICBpbnQgdHlwZSA9IGRvbVR5cGVGb3JOYW1lKHR5cGVTdHJpbmcpOworICAgIGludCB0 eXBlID0gZG9tVHlwZUZvck5hbWUoZXJyb3JTdHJpbmcsIHR5cGVTdHJpbmcpOworICAgIGlmICh0 eXBlID09IC0xKQorICAgICAgICByZXR1cm47CiAKICAgICB1aW50MzJfdCByb290Qml0ID0gMSA8 PCB0eXBlOwogICAgIHVpbnQzMl90IG1hc2sgPSBtX2RvbUJyZWFrcG9pbnRzLmdldChub2RlKSAm IH5yb290Qml0Owo=