68522 2011-09-21 05:26:52 -0700 WebSocket: Split Hixie76 length-prefixed frames aren't handled correctly 2011-11-29 00:58:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pnormand yutak ap danw mrobinson tkent webkit.review.bot yutak oldest_to_newest 470726 0 pnormand 2011-09-21 05:26:52 -0700 Diff: --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hixie76/error-detect-expected.txt +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/http/tests/websocket/tests/hixie76/error-detect-actual.txt @@ -3,9 +3,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". WebSocket is open -received:done WebSocket is closed -PASS errorCount is 255 +FAIL errorCount should be 255. Was 241. PASS successfullyParsed is true TEST COMPLETE 509760 1 yutak 2011-11-28 05:21:21 -0800 I was digging this issue these days, and this turned out to be a real bug in WebSocketChannel. This happens only when the following conditions are met: - Hixie76 binary (length-prefixed) frame is sent from the server. - The client receives only the first byte of the frame, and the remaining bytes later (i.e. split into two different WebSocketChannel::didReceiveData() calls). GTK tests have reproduced this situation (somewhat) reliably. I will upload a patch that fixes this problem shortly. 509762 2 yutak 2011-11-28 05:24:46 -0800 Updating bug summary to reflect the actual problem 509777 3 116746 yutak 2011-11-28 06:20:00 -0800 Created attachment 116746 Patch 509792 4 mrobinson 2011-11-28 06:42:06 -0800 (In reply to comment #3) > Created an attachment (id=116746) [details] > Patch Would you mind also removing http/tests/websocket/tests/hixie76/error-detect.html from the GTK+ test_expectation.txt file? 510403 5 116746 tkent 2011-11-28 19:05:44 -0800 Comment on attachment 116746 Patch Looks ok. 510467 6 yutak 2011-11-28 21:24:12 -0800 Thanks. 510496 7 116746 webkit.review.bot 2011-11-28 22:21:53 -0800 Comment on attachment 116746 Patch Clearing flags on attachment: 116746 Committed r101326: <http://trac.webkit.org/changeset/101326> 510497 8 webkit.review.bot 2011-11-28 22:21:58 -0800 All reviewed patches have been landed. Closing bug. 510574 9 pnormand 2011-11-29 00:53:26 -0800 (In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=116746) [details] [details] > > Patch > > Would you mind also removing http/tests/websocket/tests/hixie76/error-detect.html from the GTK+ test_expectation.txt file? I unskipped it in r101338. 510577 10 yutak 2011-11-29 00:58:05 -0800 Thanks! 116746 2011-11-28 06:20:00 -0800 2011-11-28 22:21:53 -0800 Patch bug-68522-20111128231959.patch text/plain 6676 yutak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAxMTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQxOTRiMjkwNWQwNDll OGQ1MjZlMmRmYzMyMmY5Mjc4ZDg1NzQzZS4uYmQxMWRiNzk3OWM2MmMyNTQxM2YzM2YwZDJjMTdi OWFjMGVkYTFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTI4ICBZdXRh IEtpdGFtdXJhICA8eXV0YWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYlNvY2tldDogU3Bs aXQgSGl4aWU3NiBsZW5ndGgtcHJlZml4ZWQgZnJhbWVzIGFyZW4ndCBoYW5kbGVkIGNvcnJlY3Rs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg1MjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBo dHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3NwbGl0LWJpbmFyeS1mcmFtZS1oZWFk ZXIuaHRtbAorCisgICAgICAgICogd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYlNvY2tldENoYW5uZWw6OnByb2Nlc3NGcmFtZUhpeGllNzYpOgor ICAgICAgICBEbyBub3QgY29uc3VtZSB0aGUgZGF0YSBpZiB0aGUgbGVuZ3RoIGZpZWxkIGlzIG5v dCBmaW5pc2hlZC4KKwogMjAxMS0xMS0yNSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFdlYiBJbnNwZWN0b3I6IGdldCByaWQgb2Yg V2ViRGV2VG9vbHNGcm9udGVuZENsaWVudDo6c2VuZEZyb250ZW5kTG9hZGVkIG1ldGhvZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAKaW5kZXggMDYx MGZiZjBiNzRmNmQ5ODM2YTE5MGZlNjhjMTUxNTI0OGIwM2Q0OS4uMTY2ZjM2YzMyZDk1YjhmMGYx ZDExMTZkYTY1ZjMzMTNlMjcwYTcyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd2Vic29j a2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRz L1dlYlNvY2tldENoYW5uZWwuY3BwCkBAIC03NTksNiArNzU5LDcgQEAgYm9vbCBXZWJTb2NrZXRD aGFubmVsOjpwcm9jZXNzRnJhbWVIaXhpZTc2KCkKICAgICBpZiAoKGZyYW1lQnl0ZSAmIDB4ODAp ID09IDB4ODApIHsKICAgICAgICAgc2l6ZV90IGxlbmd0aCA9IDA7CiAgICAgICAgIGJvb2wgZXJy b3JGcmFtZSA9IGZhbHNlOworICAgICAgICBib29sIGxlbmd0aEZpbmlzaGVkID0gZmFsc2U7CiAg ICAgICAgIHdoaWxlIChwIDwgZW5kKSB7CiAgICAgICAgICAgICBpZiAobGVuZ3RoID4gbnVtZXJp Y19saW1pdHM8c2l6ZV90Pjo6bWF4KCkgLyAxMjgpIHsKICAgICAgICAgICAgICAgICBMT0coTmV0 d29yaywgImZyYW1lIGxlbmd0aCBvdmVyZmxvdyAlbHUiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBs b25nPihsZW5ndGgpKTsKQEAgLTc4MSw5ICs3ODIsMTMgQEAgYm9vbCBXZWJTb2NrZXRDaGFubmVs Ojpwcm9jZXNzRnJhbWVIaXhpZTc2KCkKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGxlbmd0 aCA9IG5ld0xlbmd0aDsKICAgICAgICAgICAgICsrcDsKLSAgICAgICAgICAgIGlmICghKG1zZ0J5 dGUgJiAweDgwKSkKKyAgICAgICAgICAgIGlmICghKG1zZ0J5dGUgJiAweDgwKSkgeworICAgICAg ICAgICAgICAgIGxlbmd0aEZpbmlzaGVkID0gdHJ1ZTsKICAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIH0KICAgICAgICAgfQorICAgICAgICBpZiAoIWVycm9yRnJhbWUgJiYgIWxl bmd0aEZpbmlzaGVkKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBpZiAocCAr IGxlbmd0aCA8IHApIHsKICAgICAgICAgICAgIExPRyhOZXR3b3JrLCAiZnJhbWUgYnVmZmVyIHBv aW50ZXIgd3JhcCAlcCslbHUtPiVwIiwgcCwgc3RhdGljX2Nhc3Q8dW5zaWduZWQgbG9uZz4obGVu Z3RoKSwgcCArIGxlbmd0aCk7CiAgICAgICAgICAgICBlcnJvckZyYW1lID0gdHJ1ZTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA5N2FhNWEwYjgxYTNmZTY2YzAzMTViNGY4ZDdhYTdmY2U1MGU2NTZhLi4wYzhhNGUzY2VmYzMw OWJkZjY2ZGExMWIyZDk2NmRiMTAzZWM3MzU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MTEtMjggIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2Vi U29ja2V0OiBTcGxpdCBIaXhpZTc2IGxlbmd0aC1wcmVmaXhlZCBmcmFtZXMgYXJlbid0IGhhbmRs ZWQgY29ycmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02ODUyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGl4aWU3Ni9zcGxpdC1iaW5hcnktZnJh bWUtaGVhZGVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy93ZWJz b2NrZXQvdGVzdHMvaGl4aWU3Ni9zcGxpdC1iaW5hcnktZnJhbWUtaGVhZGVyLmh0bWw6IEFkZGVk LgorICAgICAgICAqIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hpeGllNzYvc3BsaXQtYmlu YXJ5LWZyYW1lLWhlYWRlcl93c2gucHk6CisgICAgICAgIEFkZGVkLiBTZW5kIFdlYlNvY2tldCBm cmFtZXMgdGhhdCBvbGRlciBXZWJTb2NrZXRDaGFubmVsIGltcGxlbWVudGF0aW9uIGZhaWxzIHRv IHBhcnNlLgorICAgICAgICBUaGUgY2xpZW50IHNob3VsZCBub3QgcmVjZWl2ZSBhbiBlbXB0eSB0 ZXh0IG1lc3NhZ2UuCisKIDIwMTEtMTEtMjUgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29n bGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlc291cmNlLXRyZWUtZXJyb3JzLXJl bG9hZC5odG1sIGlzIGZsYWt5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93 ZWJzb2NrZXQvdGVzdHMvaGl4aWU3Ni9zcGxpdC1iaW5hcnktZnJhbWUtaGVhZGVyLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hpeGllNzYvc3Bs aXQtYmluYXJ5LWZyYW1lLWhlYWRlci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2M4NmY5MGQ0 ZDU4MWIwMjg1NTIxMjYzYmViYTVmYTJiYzM1N2ExNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hpeGllNzYvc3BsaXQtYmluYXJ5LWZy YW1lLWhlYWRlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMyBAQAorV2ViU29ja2V0OiBIaXhp ZTc2IGJpbmFyeSBmcmFtZXMgc2hvdWxkIGJlIGhhbmRsZWQgY29ycmVjdGx5IGV2ZW4gaWYgZnJh bWUgaGVhZGVyIGlzIHNwbGl0IGludG8gbXVsdGlwbGUgVENQIHBhY2tldHMuCisKK09uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KKworQ29ubmVjdGVkLgorRXJyb3Igb2NjdXJyZWQuCitDbG9zZWQu CitQQVNTIGNsb3NlRXZlbnQud2FzQ2xlYW4gaXMgdHJ1ZQorUEFTUyBlcnJvckNvdW50IGlzIDEK K1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3Nw bGl0LWJpbmFyeS1mcmFtZS1oZWFkZXIuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vi c29ja2V0L3Rlc3RzL2hpeGllNzYvc3BsaXQtYmluYXJ5LWZyYW1lLWhlYWRlci5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjhiNDc4MzliYTQ4MWU4MzNmNjljMDdhYzZhOGFmNmE4Mzk4MmI1NWYKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2 L3NwbGl0LWJpbmFyeS1mcmFtZS1oZWFkZXIuaHRtbApAQCAtMCwwICsxLDQ3IEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vanMtdGVz dC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8 ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxz Y3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2Rlc2NyaXB0aW9uKCJXZWJTb2NrZXQ6IEhp eGllNzYgYmluYXJ5IGZyYW1lcyBzaG91bGQgYmUgaGFuZGxlZCBjb3JyZWN0bHkgZXZlbiBpZiBm cmFtZSBoZWFkZXIgaXMgc3BsaXQgaW50byBtdWx0aXBsZSBUQ1AgcGFja2V0cy4iKTsKKword2lu ZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCit2YXIgd3MgPSBuZXcgV2ViU29ja2V0KCJ3czov L2xvY2FsaG9zdDo4ODgwL3dlYnNvY2tldC90ZXN0cy9oaXhpZTc2L3NwbGl0LWJpbmFyeS1mcmFt ZS1oZWFkZXIiKTsKK3ZhciBlcnJvckNvdW50ID0gMDsKKword3Mub25vcGVuID0gZnVuY3Rpb24o KQoreworICAgIGRlYnVnKCJDb25uZWN0ZWQuIik7Cit9OworCit3cy5vbm1lc3NhZ2UgPSBmdW5j dGlvbihtZXNzYWdlRXZlbnQpCit7CisgICAgdGVzdEZhaWxlZCgiU2hvdWxkIG5vdCByZWNlaXZl IG1lc3NhZ2UgYnV0IHJlY2VpdmVkOiBcIiIgKyBtZXNzYWdlRXZlbnQuZGF0YSArICJcIiIpOwor fTsKKword3Mub25lcnJvciA9IGZ1bmN0aW9uKCkKK3sKKyAgICBkZWJ1ZygiRXJyb3Igb2NjdXJy ZWQuIik7CisgICAgZXJyb3JDb3VudCArPSAxOworfTsKKwordmFyIGNsb3NlRXZlbnQ7CisKK3dz Lm9uY2xvc2UgPSBmdW5jdGlvbihldmVudCkKK3sKKyAgICBkZWJ1ZygiQ2xvc2VkLiIpOworICAg IGNsb3NlRXZlbnQgPSBldmVudDsKKyAgICBzaG91bGRCZVRydWUoImNsb3NlRXZlbnQud2FzQ2xl YW4iKTsKKyAgICBzaG91bGRFdmFsdWF0ZVRvKCJlcnJvckNvdW50IiwgMSk7CisKKyAgICBmaW5p c2hKU1Rlc3QoKTsKK307Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi9qcy10 ZXN0LXJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaGl4 aWU3Ni9zcGxpdC1iaW5hcnktZnJhbWUtaGVhZGVyX3dzaC5weSBiL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvd2Vic29ja2V0L3Rlc3RzL2hpeGllNzYvc3BsaXQtYmluYXJ5LWZyYW1lLWhlYWRlcl93 c2gucHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uYmJiZjgzZDhjMDFjZTMxNTJhMGYwOGQ3ZmViMzZkNzY1ZDExZjJl MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rl c3RzL2hpeGllNzYvc3BsaXQtYmluYXJ5LWZyYW1lLWhlYWRlcl93c2gucHkKQEAgLTAsMCArMSwy MiBAQAoraW1wb3J0IHRpbWUKKworCitkZWYgd2ViX3NvY2tldF9kb19leHRyYV9oYW5kc2hha2Uo cmVxdWVzdCk6CisgICAgcGFzcworCisKK2RlZiB3ZWJfc29ja2V0X3RyYW5zZmVyX2RhdGEocmVx dWVzdCk6CisgICAgIyBGaXJzdCBmcmFtZSAoMSAtIDIgYnl0ZXMpOiBaZXJvLWxlbmd0aCBiaW5h cnkgZnJhbWUgd2l0aCBmcmFtZSB0eXBlIDB4ODAuCisgICAgIyBTZWNvbmQgZnJhbWUgKDMgLSA0 IGJ5dGVzKTogQ2xvc2UgZnJhbWUuCisgICAgZGF0YSA9ICdceDgwXHgwMFx4ZmZceDAwJworCisg ICAgIyBUaGVyZSBpcyBhIGJ1ZyB0aGF0IFdlYlNvY2tldENoYW5uZWwgaW5jb3JyZWN0bHkgY29u c3VtZXMgdGhlIGZpcnN0IGJ5dGUgb2YgYSBiaW5hcnkgZnJhbWUgaGVhZGVyCisgICAgIyB3aGVu IGl0IGlzIHNwbGl0IGZyb20gdGhlIGVudGlyZSBmcmFtZSBkYXRhLiBXaGVuIHRoaXMgaGFwcGVu cywgdGhlIGNsaWVudCByZWNvZ25pemVzIHRoZSBzZWNvbmQgYW5kCisgICAgIyB0aGlyZCBieXRl cyAoJ1x4MDBceGZmJykgYXMgYSB2YWxpZCB0ZXh0IGZyYW1lIGFuZCBpbnZva2VzIGEgbWVzc2Fn ZSBldmVudCAod2hpY2ggc2hvdWxkIG5vdCBoYXBwZW4KKyAgICAjIGluIGEgdmFsaWQgY2xpZW50 KS4KKworICAgIHJlcXVlc3QuY29ubmVjdGlvbi53cml0ZShkYXRhWzoxXSkKKyAgICB0aW1lLnNs ZWVwKDAuNSkgIyBXYWl0IGZvciA1MDBtcyB0byBtYWtlIHN1cmUgdGhlIGZpcnN0IG9jdGV0IGlz IHNlbnQgb3V0LgorICAgIHJlcXVlc3QuY29ubmVjdGlvbi53cml0ZShkYXRhWzE6XSkKKworICAg IHJhaXNlIGhhbmRzaGFrZS5BYm9ydGVkQnlVc2VyRXhjZXB0aW9uKCdBYm9ydCB0aGUgY29ubmVj dGlvbicpCg==