68507 2011-09-21 01:05:09 -0700 Syntax error in media/audio-delete-while-step-button-clicked.html 2011-09-21 07:48:33 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric.carlson oldest_to_newest 470645 0 pnormand 2011-09-21 01:05:09 -0700 --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/audio-delete-while-step-button-clicked-expected.txt +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/audio-delete-while-step-button-clicked-actual.txt @@ -1,13 +1,8 @@ +CONSOLE MESSAGE: line 58: SyntaxError: Expected token '{' +CONSOLE MESSAGE: line 86: ReferenceError: Can't find variable: start +FAIL: Timed out waiting for notifyDone to be called This tests that events don't continue to target a step button if the media element is deleted while mouse down on button. -clicking step forward -clicking step forward -timeupdate -deleting audio element - -clicking button -button click! - http://trac.webkit.org/changeset/95133 is the culprit, the fix is trivial though :) 470646 1 108118 pnormand 2011-09-21 01:07:39 -0700 Created attachment 108118 proposed patch 470790 2 eric.carlson 2011-09-21 07:37:09 -0700 (In reply to comment #0) > > http://trac.webkit.org/changeset/95133 is the culprit, the fix is trivial though :) Oh dear, that was me! I saw and fixed that, but it looks like I checked in the wrong version of that file :-( 470791 3 108118 eric.carlson 2011-09-21 07:37:34 -0700 Comment on attachment 108118 proposed patch Thanks! 470795 4 pnormand 2011-09-21 07:48:33 -0700 Committed r95628: <http://trac.webkit.org/changeset/95628> 108118 2011-09-21 01:07:39 -0700 2011-09-21 07:37:34 -0700 proposed patch proposed-patch.patch text/plain 1824 pnormand RnJvbSA1MTRhYjNjNDQzZDMyNzQ0YmM1MTYyMGFkMGRiOTYzNmJmMzViZWU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIxIFNlcCAyMDExIDEwOjA3OjEwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysKIC4uLi9hdWRpby1kZWxldGUtd2hpbGUt c3RlcC1idXR0b24tY2xpY2tlZC5odG1sICAgIHwgICAgNiArKystLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMTMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmFkZjAzNS4uYzU0 ZGQ5MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTA5LTIxICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBTeW50YXggZXJyb3IgaW4gbWVkaWEv YXVkaW8tZGVsZXRlLXdoaWxlLXN0ZXAtYnV0dG9uLWNsaWNrZWQuaHRtbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg1MDcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL2F1ZGlvLWRlbGV0ZS13 aGlsZS1zdGVwLWJ1dHRvbi1jbGlja2VkLmh0bWw6IFNvbWUgY3VybHkKKyAgICAgICAgYnJhY2Vz IHdlcmUgbWlzc2luZyBpbiBhIHRyeS9jYXRjaCBzdGF0ZW1lbnQuCisKIDIwMTEtMDktMjEgIE1P UklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBT a2lwcGVkIGxpc3QgdXBkYXRlIGZvciBtZXRlci1lbGVtZW50LXJlcGFpbnQtb24tdXBkYXRlLXZh bHVlLmh0bWwsCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1kZWxldGUtd2hp bGUtc3RlcC1idXR0b24tY2xpY2tlZC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvYXVkaW8tZGVs ZXRlLXdoaWxlLXN0ZXAtYnV0dG9uLWNsaWNrZWQuaHRtbAppbmRleCA4MDkyMjgyLi4wMDRjOTU3 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS9hdWRpby1kZWxldGUtd2hpbGUtc3RlcC1i dXR0b24tY2xpY2tlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL2F1ZGlvLWRlbGV0ZS13 aGlsZS1zdGVwLWJ1dHRvbi1jbGlja2VkLmh0bWwKQEAgLTUzLDEwICs1MywxMCBAQAogCiAgICAg ICAgICAgICAgICAgdmFyIGF1ZGlvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2F1ZGlvJyk7 CiAKLSAgICAgICAgICAgICAgICB2YXIgc2Vla0Nvb3JkcwotICAgICAgICAgICAgICAgIHRyeQor ICAgICAgICAgICAgICAgIHZhciBzZWVrQ29vcmRzOworICAgICAgICAgICAgICAgIHRyeSB7CiAg ICAgICAgICAgICAgICAgICAgIHNlZWtDb29yZHMgPSBtZWRpYUNvbnRyb2xzQnV0dG9uQ29vcmRp bmF0ZXMoYXVkaW8sICJzZWVrLWZvcndhcmQtYnV0dG9uIik7Ci0gICAgICAgICAgICAgICAgY2F0 Y2ggKGV4Y2VwdGlvbikgeworICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGV4Y2VwdGlvbikgewog ICAgICAgICAgICAgICAgICAgICBmYWlsVGVzdChleGNlcHRpb24uZGVzY3JpcHRpb24pOwogICAg ICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQotLSAKMS43LjcucmMx