68505 2011-09-21 00:23:56 -0700 [EFL] Fix alphabetical sorting problem 2011-09-21 07:27:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 1 gyuyoung.kim webkit-unassigned gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 470628 0 gyuyoung.kim 2011-09-21 00:23:56 -0700 Fix wrong alphabetical sorting in ewk_util.cpp. 470636 1 108114 gyuyoung.kim 2011-09-21 00:45:30 -0700 Created attachment 108114 Patch Fix below problem. Source/WebKit/efl/ewk/ewk_util.cpp:27: Alphabetical sorting problem. [build/include_order] [4] 470647 2 108114 zoltan 2011-09-21 01:13:59 -0700 Comment on attachment 108114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108114&action=review > Source/WebKit/efl/ewk/ewk_util.cpp:28 > #include "workers/WorkerThread.h" > > -#include "ewk_private.h" > #include <eina_safety_checks.h> You don't need this blank line. Otherwise the change is okay, but I'm not a reviewer yet. 470649 3 108119 gyuyoung.kim 2011-09-21 01:16:55 -0700 Created attachment 108119 Patch Fixed. 470787 4 108119 webkit.review.bot 2011-09-21 07:27:25 -0700 Comment on attachment 108119 Patch Clearing flags on attachment: 108119 Committed r95627: <http://trac.webkit.org/changeset/95627> 470788 5 webkit.review.bot 2011-09-21 07:27:30 -0700 All reviewed patches have been landed. Closing bug. 108114 2011-09-21 00:45:30 -0700 2011-09-21 01:16:55 -0700 Patch patch-soring.patch text/plain 1019 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4MDUwMTExLi40YWIzNDk3IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYWxwaGFiZXRpY2FsIHNvcnRpbmcgcHJv YmxlbSAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4 NTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBl d2svZXdrX3V0aWwuY3BwOiBGaXggd3JvbmcgYWxwaGFiZXRpY2FsIHNvcnRpbmcgcHJvYmxlbS4K KwogMjAxMS0wOS0yMCAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9mdXNpb24ubW9i aT4KIAogICAgICAgICBbRUZMXSBDYWxsIEZyYW1lTG9hZGVyOjpkZXRhY2hGcm9tUGFyZW50KCkg d2hlbiBkZXN0cm95aW5nIGEgZnJhbWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3V0aWwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a191dGlsLmNwcAppbmRl eCAwOGIzYzAzLi5mYTllMDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3V0aWwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdXRpbC5jcHAKQEAgLTIy LDkgKzIyLDkgQEAKICNpbmNsdWRlICJld2tfdXRpbC5oIgogCiAjaW5jbHVkZSAiYmluZGluZ3Mv anMvR0NDb250cm9sbGVyLmgiCisjaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlICJ3 b3JrZXJzL1dvcmtlclRocmVhZC5oIgogCi0jaW5jbHVkZSAiZXdrX3ByaXZhdGUuaCIKICNpbmNs dWRlIDxlaW5hX3NhZmV0eV9jaGVja3MuaD4KIAogI2lmZGVmIEhBVkVfRUNPUkVfWAo= 108119 2011-09-21 01:16:55 -0700 2011-09-21 07:27:25 -0700 Patch patch-sorting.patch text/plain 1028 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4MDUwMTExLi40YWIzNDk3IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMDktMjAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBGaXggYWxwaGFiZXRpY2FsIHNvcnRpbmcgcHJv YmxlbSAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4 NTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBl d2svZXdrX3V0aWwuY3BwOiBGaXggd3JvbmcgYWxwaGFiZXRpY2FsIHNvcnRpbmcgcHJvYmxlbS4K KwogMjAxMS0wOS0yMCAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9mdXNpb24ubW9i aT4KIAogICAgICAgICBbRUZMXSBDYWxsIEZyYW1lTG9hZGVyOjpkZXRhY2hGcm9tUGFyZW50KCkg d2hlbiBkZXN0cm95aW5nIGEgZnJhbWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3V0aWwuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a191dGlsLmNwcAppbmRl eCAwOGIzYzAzLi4wMmIyMGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3V0aWwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdXRpbC5jcHAKQEAgLTIy LDkgKzIyLDggQEAKICNpbmNsdWRlICJld2tfdXRpbC5oIgogCiAjaW5jbHVkZSAiYmluZGluZ3Mv anMvR0NDb250cm9sbGVyLmgiCi0jaW5jbHVkZSAid29ya2Vycy9Xb3JrZXJUaHJlYWQuaCIKLQog I2luY2x1ZGUgImV3a19wcml2YXRlLmgiCisjaW5jbHVkZSAid29ya2Vycy9Xb3JrZXJUaHJlYWQu aCIKICNpbmNsdWRlIDxlaW5hX3NhZmV0eV9jaGVja3MuaD4KIAogI2lmZGVmIEhBVkVfRUNPUkVf WAo=