68490 2011-09-20 17:04:27 -0700 [css3-flexbox] cleanup padding width calculations 2011-09-20 18:29:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan hyatt tony webkit.review.bot oldest_to_newest 470480 0 ojan 2011-09-20 17:04:27 -0700 [css3-flexbox] cleanup padding width calculations 470484 1 108081 ojan 2011-09-20 17:07:19 -0700 Created attachment 108081 Patch 470541 2 ojan 2011-09-20 18:29:08 -0700 Committed r95591: <http://trac.webkit.org/changeset/95591> 108081 2011-09-20 17:07:19 -0700 2011-09-20 18:22:29 -0700 Patch bug-68490-20110920170718.patch text/plain 6646 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTU1NzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NWJmYzdjODEyYTAwOTRk M2IxYWFmNWYxYzBhNWI5NDJmNjA1Y2ViLi5iMjIzMGZkMzkyN2ZhMDg2MGY1MGRlM2JmOTZjMWFi OThlZmQyMDc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMjAgIE9qYW4g VmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY3NzMy1mbGV4Ym94XSBjbGVh bnVwIHBhZGRpbmcgd2lkdGggY2FsY3VsYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhpc3RpbmcgdGVzdHMgY292ZXIg dGhlIHJlZmFjdG9yLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94Ojpsb2dpY2FsQm9yZGVyQW5k UGFkZGluZ1dpZHRoRm9yQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVC b3g6OmxvZ2ljYWxTY3JvbGxiYXJIZWlnaHRGb3JDaGlsZCk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJGbGV4aWJsZUJveDo6cHJlZmVycmVkTG9naWNhbENvbnRlbnRXaWR0aEZvckZsZXhJdGVt KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlUHJlZmVycmVk TG9naWNhbFdpZHRoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94OjpsYXlv dXRBbmRQbGFjZUNoaWxkcmVuSW5saW5lRGlyZWN0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyRmxleGlibGVCb3guaDoKKwogMjAxMS0wOS0xOCAgT2phbiBWYWZhaSAgPG9qYW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIGNoYW5nZSBSZW5kZXJGbGV4aWJsZUJveCB0byBhY3Qgb24g bG9naWNhbCBjb29yZGluYXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bGV4aWJsZUJveC5jcHAKaW5kZXggNThjZTc0YmRlZDY5OGRjNWVmMzc5YmJlM2U4NzVjNDBhNDQw Y2JhMy4uYjVjODZhZDhiMWNkMDA4M2JmMTRjMzJiNDU2MmJlMWU0Mjk1OTE5NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC0xMTMsMjUg KzExMywxNCBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94OjpsYXlvdXRCbG9jayhib29sIHJlbGF5 b3V0Q2hpbGRyZW4sIGludCwgQmxvY2tMYXlvdXRQYXNzKQogICAgIHNldE5lZWRzTGF5b3V0KGZh bHNlKTsKIH0KIAotTGF5b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6bG9naWNhbEJvcmRlcldp ZHRoRm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCkKK0xheW91dFVuaXQgUmVuZGVyRmxleGlibGVC b3g6OmxvZ2ljYWxCb3JkZXJBbmRQYWRkaW5nV2lkdGhGb3JDaGlsZChSZW5kZXJCb3gqIGNoaWxk KQogewotICAgIGlmIChpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKQotICAgICAgICByZXR1cm4g Y2hpbGQtPmJvcmRlckxlZnQoKSArIGNoaWxkLT5ib3JkZXJSaWdodCgpOwotICAgIHJldHVybiBj aGlsZC0+Ym9yZGVyVG9wKCkgKyBjaGlsZC0+Ym9yZGVyQm90dG9tKCk7Ci19Ci0KLUxheW91dFVu aXQgUmVuZGVyRmxleGlibGVCb3g6OmxvZ2ljYWxQYWRkaW5nV2lkdGhGb3JDaGlsZChSZW5kZXJC b3gqIGNoaWxkKQotewotICAgIGlmIChpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKQotICAgICAg ICByZXR1cm4gY2hpbGQtPnBhZGRpbmdMZWZ0KCkgKyBjaGlsZC0+cGFkZGluZ1JpZ2h0KCk7Ci0g ICAgcmV0dXJuIGNoaWxkLT5wYWRkaW5nVG9wKCkgKyBjaGlsZC0+cGFkZGluZ0JvdHRvbSgpOwor ICAgIHJldHVybiBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gY2hpbGQtPmJvcmRlckFuZFBh ZGRpbmdXaWR0aCgpIDogY2hpbGQtPmJvcmRlckFuZFBhZGRpbmdIZWlnaHQoKTsKIH0KIAogTGF5 b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6bG9naWNhbFNjcm9sbGJhckhlaWdodEZvckNoaWxk KFJlbmRlckJveCogY2hpbGQpCiB7Ci0gICAgaWYgKGlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkp Ci0gICAgICAgIHJldHVybiBjaGlsZC0+aG9yaXpvbnRhbFNjcm9sbGJhckhlaWdodCgpOwotICAg IHJldHVybiBjaGlsZC0+dmVydGljYWxTY3JvbGxiYXJXaWR0aCgpOworICAgIHJldHVybiBpc0hv cml6b250YWxXcml0aW5nTW9kZSgpID8gY2hpbGQtPnZlcnRpY2FsU2Nyb2xsYmFyV2lkdGgoKSA6 IGNoaWxkLT5ob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KCk7CiB9CiAKIExlbmd0aCBSZW5kZXJG bGV4aWJsZUJveDo6bWFyZ2luU3RhcnRTdHlsZUZvckNoaWxkKFJlbmRlckJveCogY2hpbGQpCkBA IC0xNTMsNyArMTQyLDcgQEAgTGF5b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6cHJlZmVycmVk TG9naWNhbENvbnRlbnRXaWR0aEZvckZsZXhJdGVtKFJlbmRlckJveCoKICAgICBMZW5ndGggd2lk dGggPSBpc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gY2hpbGQtPnN0eWxlKCktPndpZHRoKCkg OiBjaGlsZC0+c3R5bGUoKS0+aGVpZ2h0KCk7CiAgICAgaWYgKHdpZHRoLmlzQXV0bygpKSB7CiAg ICAgICAgIExheW91dFVuaXQgbG9naWNhbFdpZHRoID0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUo KSA9PSBjaGlsZC0+aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/IGNoaWxkLT5tYXhQcmVmZXJy ZWRMb2dpY2FsV2lkdGgoKSA6IGNoaWxkLT5sb2dpY2FsSGVpZ2h0KCk7Ci0gICAgICAgIHJldHVy biBsb2dpY2FsV2lkdGggLSBsb2dpY2FsQm9yZGVyV2lkdGhGb3JDaGlsZChjaGlsZCkgLSBsb2dp Y2FsU2Nyb2xsYmFySGVpZ2h0Rm9yQ2hpbGQoY2hpbGQpIC0gbG9naWNhbFBhZGRpbmdXaWR0aEZv ckNoaWxkKGNoaWxkKTsKKyAgICAgICAgcmV0dXJuIGxvZ2ljYWxXaWR0aCAtIGxvZ2ljYWxCb3Jk ZXJBbmRQYWRkaW5nV2lkdGhGb3JDaGlsZChjaGlsZCkgLSBsb2dpY2FsU2Nyb2xsYmFySGVpZ2h0 Rm9yQ2hpbGQoY2hpbGQpOwogICAgIH0KICAgICByZXR1cm4gaXNIb3Jpem9udGFsV3JpdGluZ01v ZGUoKSA/IGNoaWxkLT5jb250ZW50V2lkdGgoKSA6IGNoaWxkLT5jb250ZW50SGVpZ2h0KCk7CiB9 CkBAIC0yMDQsMTYgKzE5MywxMyBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlUHJl ZmVycmVkTG9naWNhbFdpZHRoKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgRmxleAogICAgICAgICAg ICAgY2hpbGQtPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSk7CiAgICAgICAgIGNoaWxkLT5sYXlv dXRJZk5lZWRlZCgpOwogCisgICAgICAgIC8vIFdlIGNhbid0IGp1c3QgdXNlIG1hcmdpblN0YXJ0 Rm9yQ2hpbGQsIGV0LiBhbC4gYmVjYXVzZSAiYXV0byIgbmVlZHMgdG8gYmUgdHJlYXRlZCBhcyAw LgogICAgICAgICBpZiAoaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSkgewogICAgICAgICAgICAg cHJlZmVycmVkTG9naWNhbFdpZHRoICs9IGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5MZWZ0KCkuY2Fs Y01pblZhbHVlKGZsZXhib3hBdmFpbGFibGVMb2dpY2FsV2lkdGgpOwogICAgICAgICAgICAgcHJl ZmVycmVkTG9naWNhbFdpZHRoICs9IGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5SaWdodCgpLmNhbGNN aW5WYWx1ZShmbGV4Ym94QXZhaWxhYmxlTG9naWNhbFdpZHRoKTsKLSAgICAgICAgICAgIHByZWZl cnJlZExvZ2ljYWxXaWR0aCArPSBjaGlsZC0+c3R5bGUoKS0+cGFkZGluZ0xlZnQoKS5jYWxjTWlu VmFsdWUoZmxleGJveEF2YWlsYWJsZUxvZ2ljYWxXaWR0aCk7Ci0gICAgICAgICAgICBwcmVmZXJy ZWRMb2dpY2FsV2lkdGggKz0gY2hpbGQtPnN0eWxlKCktPnBhZGRpbmdSaWdodCgpLmNhbGNNaW5W YWx1ZShmbGV4Ym94QXZhaWxhYmxlTG9naWNhbFdpZHRoKTsKICAgICAgICAgfSBlbHNlIHsKICAg ICAgICAgICAgIHByZWZlcnJlZExvZ2ljYWxXaWR0aCArPSBjaGlsZC0+c3R5bGUoKS0+bWFyZ2lu VG9wKCkuY2FsY01pblZhbHVlKGZsZXhib3hBdmFpbGFibGVMb2dpY2FsV2lkdGgpOwogICAgICAg ICAgICAgcHJlZmVycmVkTG9naWNhbFdpZHRoICs9IGNoaWxkLT5zdHlsZSgpLT5tYXJnaW5Cb3R0 b20oKS5jYWxjTWluVmFsdWUoZmxleGJveEF2YWlsYWJsZUxvZ2ljYWxXaWR0aCk7Ci0gICAgICAg ICAgICBwcmVmZXJyZWRMb2dpY2FsV2lkdGggKz0gY2hpbGQtPnN0eWxlKCktPnBhZGRpbmdUb3Ao KS5jYWxjTWluVmFsdWUoZmxleGJveEF2YWlsYWJsZUxvZ2ljYWxXaWR0aCk7Ci0gICAgICAgICAg ICBwcmVmZXJyZWRMb2dpY2FsV2lkdGggKz0gY2hpbGQtPnN0eWxlKCktPnBhZGRpbmdCb3R0b20o KS5jYWxjTWluVmFsdWUoZmxleGJveEF2YWlsYWJsZUxvZ2ljYWxXaWR0aCk7CiAgICAgICAgIH0K IAogICAgICAgICBpZiAobWFyZ2luU3RhcnRTdHlsZUZvckNoaWxkKGNoaWxkKS5pc0F1dG8oKSkK QEAgLTIyMSw3ICsyMDcsNyBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94Ojpjb21wdXRlUHJlZmVy cmVkTG9naWNhbFdpZHRoKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgRmxleAogICAgICAgICBpZiAo bWFyZ2luRW5kU3R5bGVGb3JDaGlsZChjaGlsZCkuaXNBdXRvKCkpCiAgICAgICAgICAgICB0b3Rh bFBvc2l0aXZlRmxleGliaWxpdHkgKz0gMTsKIAotICAgICAgICBwcmVmZXJyZWRMb2dpY2FsV2lk dGggKz0gbG9naWNhbEJvcmRlcldpZHRoRm9yQ2hpbGQoY2hpbGQpOworICAgICAgICBwcmVmZXJy ZWRMb2dpY2FsV2lkdGggKz0gbG9naWNhbEJvcmRlckFuZFBhZGRpbmdXaWR0aEZvckNoaWxkKGNo aWxkKTsKICAgICAgICAgcHJlZmVycmVkTG9naWNhbFdpZHRoICs9IHByZWZlcnJlZExvZ2ljYWxD b250ZW50V2lkdGhGb3JGbGV4SXRlbShjaGlsZCk7CiAKICAgICAgICAgdG90YWxQb3NpdGl2ZUZs ZXhpYmlsaXR5ICs9IGxvZ2ljYWxQb3NpdGl2ZUZsZXhGb3JDaGlsZChjaGlsZCk7CkBAIC0zMDUs NyArMjkxLDcgQEAgdm9pZCBSZW5kZXJGbGV4aWJsZUJveDo6bGF5b3V0QW5kUGxhY2VDaGlsZHJl bklubGluZURpcmVjdGlvbihjb25zdCBXVEY6OlZlY3RvcjwKICAgICBzaXplX3QgaSA9IDA7CiAg ICAgZm9yIChSZW5kZXJCb3gqIGNoaWxkID0gaXRlcmF0b3IuZmlyc3QoKTsgY2hpbGQ7IGNoaWxk ID0gaXRlcmF0b3IubmV4dCgpLCArK2kpIHsKICAgICAgICAgLy8gRklYTUU6IERvZXMgdGhpcyBu ZWVkIHRvIHRha2UgdGhlIHNjcm9sbGJhciB3aWR0aCBpbnRvIGFjY291bnQ/Ci0gICAgICAgIExh eW91dFVuaXQgY2hpbGRQcmVmZXJyZWRTaXplID0gY2hpbGRTaXplc1tpXSArIGxvZ2ljYWxCb3Jk ZXJXaWR0aEZvckNoaWxkKGNoaWxkKSArIGxvZ2ljYWxQYWRkaW5nV2lkdGhGb3JDaGlsZChjaGls ZCk7CisgICAgICAgIExheW91dFVuaXQgY2hpbGRQcmVmZXJyZWRTaXplID0gY2hpbGRTaXplc1tp XSArIGxvZ2ljYWxCb3JkZXJBbmRQYWRkaW5nV2lkdGhGb3JDaGlsZChjaGlsZCk7CiAgICAgICAg IHNldExvZ2ljYWxPdmVycmlkZVNpemUoY2hpbGQsIGNoaWxkUHJlZmVycmVkU2l6ZSk7CiAgICAg ICAgIGNoaWxkLT5zZXRDaGlsZE5lZWRzTGF5b3V0KHRydWUpOwogICAgICAgICBjaGlsZC0+bGF5 b3V0SWZOZWVkZWQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJGbGV4aWJsZUJveC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxl Qm94LmgKaW5kZXggY2E1OTAyNzk1ZDg1MDM0M2VmODRmOGY1MjFlOGU1MDFiZTU2NDY4Yi4uMTNl MTIyMTMxNjczZTFhODg0YWE4NjRlODVlMzJhNTM3NDE4MjQxNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmgKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmgKQEAgLTUyLDggKzUyLDcgQEAgcHJpdmF0 ZToKICAgICBjbGFzcyBGbGV4aWJsZUJveEl0ZXJhdG9yOwogICAgIHR5cGVkZWYgV1RGOjpIYXNo TWFwPGNvbnN0IFJlbmRlckJveCosIExheW91dFVuaXQ+IEluZmxleGlibGVGbGV4SXRlbVNpemU7 CiAKLSAgICBMYXlvdXRVbml0IGxvZ2ljYWxCb3JkZXJXaWR0aEZvckNoaWxkKFJlbmRlckJveCog Y2hpbGQpOwotICAgIExheW91dFVuaXQgbG9naWNhbFBhZGRpbmdXaWR0aEZvckNoaWxkKFJlbmRl ckJveCogY2hpbGQpOworICAgIExheW91dFVuaXQgbG9naWNhbEJvcmRlckFuZFBhZGRpbmdXaWR0 aEZvckNoaWxkKFJlbmRlckJveCogY2hpbGQpOwogICAgIExheW91dFVuaXQgbG9naWNhbFNjcm9s bGJhckhlaWdodEZvckNoaWxkKFJlbmRlckJveCogY2hpbGQpOwogICAgIExlbmd0aCBtYXJnaW5T dGFydFN0eWxlRm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCk7CiAgICAgTGVuZ3RoIG1hcmdpbkVu ZFN0eWxlRm9yQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCk7Cg==