<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>68488</bug_id>
          
          <creation_ts>2011-09-20 16:14:07 -0700</creation_ts>
          <short_desc>garden-o-matic results view should sort test and builder names</short_desc>
          <delta_ts>2011-09-27 10:52:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>64188</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>470440</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-20 16:14:07 -0700</bug_when>
    <thetext>garden-o-matic results view should sort test and builder names</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>470443</commentid>
    <comment_count>1</comment_count>
      <attachid>108073</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-20 16:15:45 -0700</bug_when>
    <thetext>Created attachment 108073
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472076</commentid>
    <comment_count>2</comment_count>
      <attachid>108073</attachid>
    <who name="Andy Estes">aestes</who>
    <bug_when>2011-09-22 22:25:53 -0700</bug_when>
    <thetext>Comment on attachment 108073
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108073&amp;action=review

r=me

&gt; Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:172
&gt; +        Object.keys(resultsByTest).sort().forEach(function (testName) {

Super nit: you probably don&apos;t want that space before the anonymous function&apos;s parameter list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>472088</commentid>
    <comment_count>3</comment_count>
      <attachid>108073</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-22 23:24:28 -0700</bug_when>
    <thetext>Comment on attachment 108073
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=108073&amp;action=review

&gt;&gt; Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:172
&gt;&gt; +        Object.keys(resultsByTest).sort().forEach(function (testName) {
&gt; 
&gt; Super nit: you probably don&apos;t want that space before the anonymous function&apos;s parameter list.

Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>474071</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-09-27 10:52:30 -0700</bug_when>
    <thetext>Committed r96129: &lt;http://trac.webkit.org/changeset/96129&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108073</attachid>
            <date>2011-09-20 16:15:45 -0700</date>
            <delta_ts>2011-09-22 23:24:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-68488-20110920161550.patch</filename>
            <type>text/plain</type>
            <size>2309</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTU1NzQKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT
dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z
Y3JpcHRzL3VpL3Jlc3VsdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr
aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1bHRz
LmpzCmluZGV4IGY2YjQ5ZmEwZDQxYzEyYjAwZmI0NmYxMDIzZWJlOWIzMWNiZTJmZGYuLjY4MDZj
ZTM0YWNhMTllNDc2ZjYyYTUzODRiYWVjMWE0MDMyMGEyYjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1
aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RG
YWlsdXJlcy9zY3JpcHRzL3VpL3Jlc3VsdHMuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv
cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Njcmlw
dHMvdWkvcmVzdWx0cy5qcwpAQCAtMTY5LDcgKzE2OSw3IEBAIHVpLnJlc3VsdHMuVGVzdFNlbGVj
dG9yID0gYmFzZS5leHRlbmRzKCdkaXYnLCB7CiAgICAgICAgIHRoaXMuX2RlbGVnYXRlID0gZGVs
ZWdhdGU7CiAgICAgICAgIHRoaXMuX2xlbmd0aCA9IDA7CiAKLSAgICAgICAgT2JqZWN0LmtleXMo
cmVzdWx0c0J5VGVzdCkuZm9yRWFjaChmdW5jdGlvbiAodGVzdE5hbWUpIHsKKyAgICAgICAgT2Jq
ZWN0LmtleXMocmVzdWx0c0J5VGVzdCkuc29ydCgpLmZvckVhY2goZnVuY3Rpb24gKHRlc3ROYW1l
KSB7CiAgICAgICAgICAgICB2YXIgbGluayA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2EnKTsK
ICAgICAgICAgICAgICQobGluaykuYXR0cignaHJlZicsICcjJykudGV4dCh0ZXN0TmFtZSk7CiAK
QEAgLTI0NSw3ICsyNDUsNyBAQCB1aS5yZXN1bHRzLkJ1aWxkZXJTZWxlY3RvciA9IGJhc2UuZXh0
ZW5kcygnZGl2JywgewogCiAgICAgICAgIHZhciB0YWJTdHJpcCA9IHRoaXMuYXBwZW5kQ2hpbGQo
ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgndWwnKSk7CiAKLSAgICAgICAgT2JqZWN0LmtleXMocmVz
dWx0c0J5QnVpbGRlcikuZm9yRWFjaChmdW5jdGlvbihidWlsZGVyTmFtZSkgeworICAgICAgICBP
YmplY3Qua2V5cyhyZXN1bHRzQnlCdWlsZGVyKS5zb3J0KCkuZm9yRWFjaChmdW5jdGlvbihidWls
ZGVyTmFtZSkgewogICAgICAgICAgICAgdmFyIGJ1aWxkZXJEaXJlY3RvcnkgPSByZXN1bHRzLmRp
cmVjdG9yeUZvckJ1aWxkZXIoYnVpbGRlck5hbWUpOwogCiAgICAgICAgICAgICB2YXIgbGluayA9
IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2EnKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv
ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNmNmZmEwNjE4NzczODMyYWY5NzQxMWNiMTIzZTk4
NzFiZDBiMzBjLi5hOWExYjQ0OGJlMzdmNDI3NzFkNjk2YmQ1ZDdkYjRjZmM2M2Q2YzZlIDEwMDY0
NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs
MTkgQEAKIDIwMTEtMDktMjAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAg
ICAgICBnYXJkZW4tby1tYXRpYyByZXN1bHRzIHZpZXcgc2hvdWxkIHNvcnQgdGVzdCBhbmQgYnVp
bGRlciBuYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9Njg0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICBQcmV2aW91c2x5LCB0aGUgdGVzdCBhbmQgYnVpbGRlciBuYW1lcyB3ZXJlIGRpc3BsYXllZCBp
biBhbiBhcmJpdHJhcnkKKyAgICAgICAgb3JkZXIgdGhhdCBjaGFuZ2VkIGZyb20gdGltZSB0byB0
aW1lLiAgVGhhdCBjb25mdXNlZCBvbmUgdXNlciBzdHVkeQorICAgICAgICBwYXJ0aWNpcGFudC4g
IFRoaXMgcGF0Y2ggc29ydHMgdGhlIGxpc3RzIHNvIHRoYXQgdGhleSBvY2N1ciBpbiBhCisgICAg
ICAgIHByZWRpY3RhYmxlIG9yZGVyLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp
bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkv
cmVzdWx0cy5qczoKKworMjAxMS0wOS0yMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn
PgorCiAgICAgICAgIGdhcmRlbi1vLW1hdGljIGNvbW1hbmQgc2hvdWxkIGV4cGxhaW4gdGhhdCBp
dCBpcyBzdGFydGluZyBhIGxvY2FsIHNlcnZlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg0ODYKIAo=
</data>
<flag name="review"
          id="104942"
          type_id="1"
          status="+"
          setter="aestes"
    />
    <flag name="commit-queue"
          id="104943"
          type_id="3"
          status="-"
          setter="aestes"
    />
          </attachment>
      

    </bug>

</bugzilla>