68480 2011-09-20 15:02:47 -0700 De-virtualize containingBlock(). 2011-09-27 14:35:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68938 1 hyatt hyatt oldest_to_newest 470375 0 hyatt 2011-09-20 15:02:47 -0700 De-virtualize containingBlock() and make RenderView return 0 instead of itself to make the construction of normal loops that terminate via a null-check possible. 470377 1 108059 hyatt 2011-09-20 15:04:24 -0700 Created attachment 108059 Patch 470395 2 hyatt 2011-09-20 15:22:45 -0700 Fixed in r95573. 108059 2011-09-20 15:04:24 -0700 2011-09-20 15:09:09 -0700 Patch patch.txt text/plain 6304 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NTcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTEtMDktMjAgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02ODQ4MAorICAgICAgICAKKyAgICAgICAgRGUtdmlydHVhbGl6ZSBj b250YWluaW5nQmxvY2soKSBhbmQgbWFrZSBSZW5kZXJWaWV3IHJldHVybiAwIGluc3RlYWQKKyAg ICAgICAgb2YgaXRzZWxmIHRvIG1ha2UgdGhlIGNvbnN0cnVjdGlvbiBvZiBub3JtYWwgbG9vcHMg dGhhdCB0ZXJtaW5hdGUgdmlhCisgICAgICAgIGEgbnVsbC1jaGVjayBwb3NzaWJsZS4KKworICAg ICAgICBGaXggdGhlIG9ubHkgdHdvIHBsYWNlcyBpbiB0aGUgdHJlZSB0aGF0IG5lZWRlZCBudWxs IGNoZWNrcy4KKworICAgICAgICBFbGltaW5hdGluZyBSZW5kZXJUYWJsZUNlbGw6OmNvbnRhaW5p bmdCbG9jaygpIGlzIGZpbmUgc2luY2UgdGhlIGJhc2UgY2xhc3MKKyAgICAgICAgZG9lcyB0aGUg c2FtZSB0aGluZyBhbnl3YXkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBlZGl0aW5nL1Zpc2libGVQb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWaXNpYmxlUG9zaXRpb246OmxpbmVEaXJlY3Rpb25Qb2ludEZvckJsb2NrRGlyZWN0aW9u TmF2aWdhdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmNvbnRhaW5pbmdCbG9jayk6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJs ZUNlbGwuY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaDoKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUcmVlQXNUZXh0Ojp3cml0ZVJlbmRlck9iamVjdCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlclZpZXcuY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3Lmg6CisKIDIw MTEtMDktMjAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgU2Nyb2xsVmlldzo6cGxhdGZvcm1Db250ZW50c1NpemUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVBvc2l0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL1Zpc2libGVQb3NpdGlvbi5jcHAJKHJldmlzaW9uIDk1NTY3KQorKysg U291cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlUG9zaXRpb24uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02MDcsNyArNjA3LDEwIEBAIGludCBWaXNpYmxlUG9zaXRpb246OmxpbmVEaXJlY3Rpb25Q b2ludEYKICAgICAvLyB3aXRob3V0IGNvbnN1bHRpbmcgdHJhbnNmb3Jtcywgc28gdGhhdCAndXAn IGluIHRyYW5zZm9ybWVkIHRleHQgaXMgJ3VwJwogICAgIC8vIHJlbGF0aXZlIHRvIHRoZSB0ZXh0 LCBub3QgYWJzb2x1dGUgJ3VwJy4KICAgICBGbG9hdFBvaW50IGNhcmV0UG9pbnQgPSByZW5kZXJl ci0+bG9jYWxUb0Fic29sdXRlKGxvY2FsUmVjdC5sb2NhdGlvbigpKTsKLSAgICByZXR1cm4gcmVu ZGVyZXItPmNvbnRhaW5pbmdCbG9jaygpLT5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gY2Fy ZXRQb2ludC54KCkgOiBjYXJldFBvaW50LnkoKTsKKyAgICBSZW5kZXJPYmplY3QqIGNvbnRhaW5p bmdCbG9jayA9IHJlbmRlcmVyLT5jb250YWluaW5nQmxvY2soKTsKKyAgICBpZiAoIWNvbnRhaW5p bmdCbG9jaykKKyAgICAgICAgY29udGFpbmluZ0Jsb2NrID0gcmVuZGVyZXI7IC8vIEp1c3QgdXNl IG91cnNlbHZlcyB0byBkZXRlcm1pbmUgdGhlIHdyaXRpbmcgbW9kZSBpZiB3ZSBoYXZlIG5vIGNv bnRhaW5pbmcgYmxvY2suCisgICAgcmV0dXJuIGNvbnRhaW5pbmdCbG9jay0+aXNIb3Jpem9udGFs V3JpdGluZ01vZGUoKSA/IGNhcmV0UG9pbnQueCgpIDogY2FyZXRQb2ludC55KCk7CiB9CiAKICNp Zm5kZWYgTkRFQlVHCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmNwcAkocmV2aXNpb24gOTU1NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjM2LDkgKzYzNiw2IEBAIHZvaWQgUmVuZGVy T2JqZWN0OjpzZXRMYXllck5lZWRzRnVsbFJlcGEKIAogUmVuZGVyQmxvY2sqIFJlbmRlck9iamVj dDo6Y29udGFpbmluZ0Jsb2NrKCkgY29uc3QKIHsKLSAgICBBU1NFUlQoIWlzVGFibGVDZWxsKCkp OwotICAgIEFTU0VSVCghaXNSZW5kZXJWaWV3KCkpOwotCiAgICAgUmVuZGVyT2JqZWN0KiBvID0g cGFyZW50KCk7CiAgICAgaWYgKCFpc1RleHQoKSAmJiBtX3N0eWxlLT5wb3NpdGlvbigpID09IEZp eGVkUG9zaXRpb24pIHsKICAgICAgICAgd2hpbGUgKG8gJiYgIW8tPmlzUmVuZGVyVmlldygpICYm ICEoby0+aGFzVHJhbnNmb3JtKCkgJiYgby0+aXNSZW5kZXJCbG9jaygpKSkKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgJKHJldmlzaW9uIDk1NTY3KQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC02 MDAsNyArNjAwLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0U3R5bGVJbnRlcm5hbChQYXNzUmVm UHRyPFJlbmRlclN0eWxlPik7CiAKICAgICAvLyByZXR1cm5zIHRoZSBjb250YWluaW5nIGJsb2Nr IGxldmVsIGVsZW1lbnQgZm9yIHRoaXMgZWxlbWVudC4KLSAgICB2aXJ0dWFsIFJlbmRlckJsb2Nr KiBjb250YWluaW5nQmxvY2soKSBjb25zdDsKKyAgICBSZW5kZXJCbG9jayogY29udGFpbmluZ0Js b2NrKCkgY29uc3Q7CiAKICAgICAvLyBDb252ZXJ0IHRoZSBnaXZlbiBsb2NhbCBwb2ludCB0byBh YnNvbHV0ZSBjb29yZGluYXRlcwogICAgIC8vIEZJWE1FOiBUZW1wb3JhcnkuIElmIHVzZVRyYW5z Zm9ybXMgaXMgdHJ1ZSwgdGFrZSB0cmFuc2Zvcm1zIGludG8gYWNjb3VudC4gRXZlbnR1YWxseSBs b2NhbFRvQWJzb2x1dGUoKSB3aWxsIGFsd2F5cyBiZSB0cmFuc2Zvcm0tYXdhcmUuCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAkocmV2aXNpb24g OTU1NjcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzE5LDEzICszMTksNiBAQCB2b2lkIFJlbmRlclRhYmxlQ2VsbDo6 c3R5bGVEaWRDaGFuZ2UoU3R5CiAgICAgc2V0SGFzQm94RGVjb3JhdGlvbnModHJ1ZSk7CiB9CiAK LVJlbmRlckJsb2NrKiBSZW5kZXJUYWJsZUNlbGw6OmNvbnRhaW5pbmdCbG9jaygpIGNvbnN0Ci17 Ci0gICAgaWYgKHBhcmVudCgpICYmIHNlY3Rpb24oKSkKLSAgICAgICAgcmV0dXJuIHRhYmxlKCk7 Ci0gICAgcmV0dXJuIDA7Ci19Ci0KIC8vIFRoZSBmb2xsb3dpbmcgcnVsZXMgYXBwbHkgZm9yIHJl c29sdmluZyBjb25mbGljdHMgYW5kIGZpZ3VyaW5nIG91dCB3aGljaCBib3JkZXIKIC8vIHRvIHVz ZS4KIC8vICgxKSBCb3JkZXJzIHdpdGggdGhlICdib3JkZXItc3R5bGUnIG9mICdoaWRkZW4nIHRh a2UgcHJlY2VkZW5jZSBvdmVyIGFsbCBvdGhlciBjb25mbGljdGluZyAKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmgJKHJldmlzaW9uIDk1NTY3KQorKysg U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5oCSh3b3JraW5nIGNvcHkp CkBAIC0xMzcsOCArMTM3LDYgQEAgcHJpdmF0ZToKIAogICAgIHZpcnR1YWwgYm9vbCBpc1RhYmxl Q2VsbCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAotICAgIHZpcnR1YWwgUmVuZGVyQmxvY2sq IGNvbnRhaW5pbmdCbG9jaygpIGNvbnN0OwotCiAgICAgdmlydHVhbCB2b2lkIHdpbGxCZURlc3Ry b3llZCgpOwogCiAgICAgdmlydHVhbCB2b2lkIGNvbXB1dGVMb2dpY2FsV2lkdGgoKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUcmVlQXNUZXh0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVHJlZUFzVGV4dC5jcHAJKHJldmlz aW9uIDk1NTY3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRyZWVBc1RleHQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYsNyArMjQ2LDggQEAgdm9pZCBSZW5kZXJUcmVlQXNU ZXh0Ojp3cml0ZVJlbmRlck9iamVjdAogICAgICAgICB9CiAgICAgfQogICAgIAotICAgIGJvb2wg YWRqdXN0Rm9yVGFibGVDZWxscyA9IG8uY29udGFpbmluZ0Jsb2NrKCktPmlzVGFibGVDZWxsKCk7 CisgICAgUmVuZGVyQmxvY2sqIGNiID0gby5jb250YWluaW5nQmxvY2soKTsKKyAgICBib29sIGFk anVzdEZvclRhYmxlQ2VsbHMgPSBjYiA/IGNiLT5pc1RhYmxlQ2VsbCgpIDogZmFsc2U7CiAKICAg ICBJbnRSZWN0IHI7CiAgICAgaWYgKG8uaXNUZXh0KCkpIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAJKHJldmlzaW9uIDk1NTY3KQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjUsMTEgKzI2 NSw2IEBAIGJvb2wgUmVuZGVyVmlldzo6c2hvdWxkUmVwYWludChjb25zdCBJbnQKICAgICByZXR1 cm4gdHJ1ZTsKIH0KIAotUmVuZGVyQmxvY2sqIFJlbmRlclZpZXc6OmNvbnRhaW5pbmdCbG9jaygp IGNvbnN0Ci17Ci0gICAgcmV0dXJuIGNvbnN0X2Nhc3Q8UmVuZGVyVmlldyo+KHRoaXMpOwotfQot CiB2b2lkIFJlbmRlclZpZXc6OnJlcGFpbnRWaWV3UmVjdGFuZ2xlKGNvbnN0IEludFJlY3QmIHVy LCBib29sIGltbWVkaWF0ZSkKIHsKICAgICBpZiAoIXNob3VsZFJlcGFpbnQodXIpKQpJbmRleDog U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCShyZXZpc2lvbiA5NTU2NykKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTE5 Myw4ICsxOTMsNiBAQCBwcm90ZWN0ZWQ6CiAKIHByaXZhdGU6CiAgICAgYm9vbCBzaG91bGRSZXBh aW50KGNvbnN0IEludFJlY3QmIHIpIGNvbnN0OwotICAgIAotICAgIHZpcnR1YWwgUmVuZGVyQmxv Y2sqIGNvbnRhaW5pbmdCbG9jaygpIGNvbnN0OwogCiAgICAgLy8gVGhlc2UgZnVuY3Rpb25zIG1h eSBvbmx5IGJlIGFjY2Vzc2VkIGJ5IExheW91dFN0YXRlTWFpbnRhaW5lci4KICAgICB2b2lkIHB1 c2hMYXlvdXRTdGF0ZShSZW5kZXJGbG93VGhyZWFkKik7Cg==