68465 2011-09-20 13:34:02 -0700 Do not consider SQLITE_BUSY an error in turnOnIncrementalAutoVacuum 2024-03-06 00:22:25 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 rakuco rakuco abarth annevk eric ggaren krit leandro michaeln mitz zimmermann oldest_to_newest 470298 0 rakuco 2011-09-20 13:34:02 -0700 Do not consider SQLITE_BUSY an error in turnOnIncrementalAutoVacuum 470301 1 108049 rakuco 2011-09-20 13:38:56 -0700 Created attachment 108049 Patch 500025 2 108049 bfulgham 2011-11-10 10:09:38 -0800 Comment on attachment 108049 Patch Is it possible that this code was actually meant to be "if (error != SQLITE_BUSY)" rather than the original "if (error != SQLITE_ROW)"? I don't see anything in the SQLite documentation that mentions that SQLITE_ROW is an expected error result of PRAGMA auto_vacuum. 501194 3 rakuco 2011-11-11 16:01:52 -0800 Perhaps SQLITE_ROW can come from some call invoked in SQLiteStatement::getColumnInt? I'm not sure either. 606286 4 michaeln 2012-04-19 19:09:31 -0700 In the context of WebSQLDatabase, this change looks harmless. Afaict the net effect is to avoid making a LOG_ERROR() call when the error is BUSY. I don't see any other callsites in the codebase to this method other than the one the AbstractDatabase class. But a return value of true in this case might be misleading, the auto_vacuum setting may or may not be set to the incremental mode. Another way to avoid the LOG_ERROR() output could be to test lastError() for the BUSY value after a false return at the callsite in AbstractDatabase. I'm not a reviewer here, so i can't help you out any further than that :) 976818 5 108049 andersca 2014-02-05 10:50:47 -0800 Comment on attachment 108049 Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag. 2019012 6 annevk 2024-03-06 00:22:25 -0800 This is a feature that's disabled/removed. 108049 2011-09-20 13:38:56 -0700 2014-02-05 10:50:47 -0800 Patch bug-68465-20110920173857.patch text/plain 2090 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTU1NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNjNmMTI1NTNjNDkyZDI2 Mzc0NjEyZTE2ZmJmNTlhOTdlODIzOWFhLi5lNWJlYjEzNjY2NWJiODYwOWJkZWVmZWFhNTExZWE3 YzU2N2QzN2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDktMjAgIFJhcGhh ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgRG8gbm90 IGNvbnNpZGVyIFNRTElURV9CVVNZIGFuIGVycm9yIGluIHR1cm5PbkluY3JlbWVudGFsQXV0b1Zh Y3V1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njg0 NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg Y29tbWVudCBpbiBTUUxpdGVEYXRhYmFzZTo6dHVybk9uSW5jcmVtZW50YWxBdXRvVmFjdXVtKCkg c2F5cworICAgICAgICBTUUxJVEVfQlVTWSBzaG91bGQgbm90IGJlIGNvbnNpZGVyZWQgYW4gZXJy b3IgaGVyZSwgaW4gdGhlIHNlbnNlIHRoYXQKKyAgICAgICAgaXQganVzdCBtZWFucyBhbm90aGVy IHRyYW5zYWN0aW9uIGlzIGJlaW5nIHBlcmZvcm1lZCBvbiB0aGUgZGF0YWJhc2UuCisgICAgICAg IElmIHdlIGp1c3QgcmV0dXJuIGZhbHNlLCB0aGlzIHdpbGwgYmUgY29uc2lkZXJlZCBhbiBlcnJv ciBieQorICAgICAgICBBYnN0cmFjdERhdGFiYXNlOjpwZXJmb3JtT3BlbkFuZFZlcmlmeSwgd2hp Y2ggd2lsbCB3cml0ZSBhIG1lc3NhZ2UgdG8KKyAgICAgICAgc3RkZXJyICh0aGUgY29tbWVudCBz dWdnZXN0cyB0aGlzIHNob3VsZCBoYXBwZW4gb25seSBpZiB0aGUgZXJyb3IgY29kZQorICAgICAg ICBpcyBub3QgU1FMSVRFX0JVU1kpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc3BvdHRlZCBi eSBydW5uaW5nIHRoZSB0ZXN0cyBpbiBmYXN0L3dvcmtlcnMvc3RvcmFnZQorICAgICAgICAoY2hh bmdlLXZlcnNpb24taGFuZGxlLXJldXNlLXN5bmMuaHRtbCwgZm9yIGV4YW1wbGUpLgorCisgICAg ICAgICogcGxhdGZvcm0vc3FsL1NRTGl0ZURhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNRTGl0ZURhdGFiYXNlOjp0dXJuT25JbmNyZW1lbnRhbEF1dG9WYWN1dW0pOgorCiAyMDExLTA5 LTIwICBBYXJvbiBCb29kbWFuICA8YWFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJld29yayBz Y3JpcHQgY29udGV4dCBjcmVhdGlvbi9yZWxlYXNlIG5vdGlmaWNhdGlvbnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVEYXRhYmFzZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlRGF0YWJhc2UuY3BwCmluZGV4IDRhMWI0ODRjZGVi OGY5YjZhZmE3NTQ0ZDVkZGVmZWViNDg4NGI4NjMuLjZhODM5ZTllYzJkNmQ3ZDdmY2IzZTFjOGVj MTcwZGRlZTQzYzIxODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9T UUxpdGVEYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3FsL1NRTGl0 ZURhdGFiYXNlLmNwcApAQCAtNDUyLDYgKzQ1Miw4IEBAIGJvb2wgU1FMaXRlRGF0YWJhc2U6OnR1 cm5PbkluY3JlbWVudGFsQXV0b1ZhY3V1bSgpCiAgICAgLy8gYXV0b192YWN1dW0gZmxhZyBhbmQg dHJ5IHRvIHNldCBpdCB0byBJTkNSRU1FTlRBTCB0aGUgbmV4dCB0aW1lIHdlIG9wZW4gdGhpcwog ICAgIC8vIGRhdGFiYXNlLiBJZiB0aGUgZXJyb3IgaXMgbm90IFNRTElURV9CVVNZLCB0aGVuIHdl IHByb2JhYmx5IHJhbiBpbnRvIGEgbW9yZQogICAgIC8vIHNlcmlvdXMgcHJvYmxlbSBhbmQgc2hv dWxkIHJldHVybiBmYWxzZSAodG8gbG9nIGFuIGVycm9yIG1lc3NhZ2UpLgorICAgIGlmIChlcnJv ciA9PSBTUUxJVEVfQlVTWSkKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgaWYgKGVycm9yICE9 IFNRTElURV9ST1cpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAo=