68456 2011-09-20 11:52:12 -0700 [Qt][WK2] Build dependency problems 2011-10-17 08:26:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Major --- 1 ossy kkristof kling menard ossy webkit.review.bot oldest_to_newest 470233 0 ossy 2011-09-20 11:52:12 -0700 https://bugs.webkit.org/show_bug.cgi?id=38054 fixed a general Qt specific build dependency problem if a define changes in features.pri. But it is a buggy little bit, because it doesn't respect WK2 build. (This bug was revealed by http://trac.webkit.org/changeset/95551) We should pass all config to compute_defaults call, like wk2 build. 480941 1 110355 kkristof 2011-10-10 07:01:20 -0700 Created attachment 110355 proposed fix 480942 2 110355 ossy 2011-10-10 07:09:42 -0700 Comment on attachment 110355 proposed fix r- now, because it doesn't solve the original problem. ENABLE_FULLSCREEN_API=1 is still missing. 480947 3 110355 ossy 2011-10-10 07:16:43 -0700 Comment on attachment 110355 proposed fix I think CONFIG+="compute_defaults webkit2" would be better for wk2 build. But the best solution would be if we pass everything to qmake to match the real build session. For example: minimal build, defines, etc. 481595 4 110506 kkristof 2011-10-11 06:12:31 -0700 Created attachment 110506 proposed fix 485042 5 110506 ossy 2011-10-17 03:55:29 -0700 Comment on attachment 110506 proposed fix r=me 485044 6 110506 webkit.review.bot 2011-10-17 03:58:01 -0700 Comment on attachment 110506 proposed fix Rejecting attachment 110506 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/10080753 485165 7 110506 ossy 2011-10-17 08:25:59 -0700 Comment on attachment 110506 proposed fix Clearing flags on attachment: 110506 Committed r97622: <http://trac.webkit.org/changeset/97622> 485166 8 ossy 2011-10-17 08:26:06 -0700 All reviewed patches have been landed. Closing bug. 110355 2011-10-10 07:01:20 -0700 2011-10-11 06:12:31 -0700 proposed fix 10.patch text/plain 1161 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkNjdm OTMyLi5lZmEwZTIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMTAgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF1bV0syXSBCdWlsZCBkZXBl bmRlbmN5IHByb2JsZW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02ODQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRRTWFrZVByb2pl Y3QpOgorCiAyMDExLTEwLTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmVtb3ZlICJuZWFyIG1pc3MiIFhTUyB2dWxuZXJhYmlsaXRpZXMgaW4gZ2FyZGVuLW8t bWF0aWMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBiYzVjOWJlLi45MWIzMDZkIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCkBAIC0xNzA1LDcgKzE3MDUsMTEgQEAgc3ViIGJ1aWxkUU1ha2VQcm9qZWN0KCRAKQogICAg IG15ICRkaXIgPSBGaWxlOjpTcGVjLT5jYW5vbnBhdGgocHJvZHVjdERpcigpKTsKIAogICAgIG15 ICRvcmlnaW5hbEN3ZCA9IGdldGN3ZCgpOwotICAgIGNoZGlyIEZpbGU6OlNwZWMtPmNhdGZpbGUo c291cmNlRGlyKCksICJTb3VyY2UiLCAiV2ViQ29yZSIpOworICAgIGlmIChpc1dLMigpKSB7Cisg ICAgICAgIGNoZGlyIEZpbGU6OlNwZWMtPmNhdGZpbGUoc291cmNlRGlyKCksICJTb3VyY2UiLCAi V2ViS2l0MiIpOworICAgIH0gZWxzZSB7CisgICAgICAgIGNoZGlyIEZpbGU6OlNwZWMtPmNhdGZp bGUoc291cmNlRGlyKCksICJTb3VyY2UiLCAiV2ViQ29yZSIpOworICAgIH0KICAgICBteSAkZGVm YXVsdHMgPSBgJHFtYWtlYmluIENPTkZJRys9Y29tcHV0ZV9kZWZhdWx0cyAyPiYxYDsKICAgICBj aGRpciAkb3JpZ2luYWxDd2Q7CiAK 110506 2011-10-11 06:12:31 -0700 2011-10-17 08:25:58 -0700 proposed fix 11a.patch text/plain 1437 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MjUy YzIxLi5jMWY5ODI4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTAtMTEgIEtyaXN0w7NmIEtvc3p0ecOzICA8 a2tyaXN0b2ZAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFtRdF1bV0syXSBCdWlsZCBkZXBl bmRlbmN5IHByb2JsZW1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02ODQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRRTWFrZVByb2pl Y3QpOgorCiAyMDExLTEwLTExICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lv bi5tb2JpPgogCiAgICAgICAgIFtFRkxdIERSVDogTWFrZSBzdXJlIEljb25EYXRhYmFzZSBpcyBj bG9zZWQgYmVmb3JlIHRyeWluZyB0byBvcGVuIGl0IGFnYWluLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IGJjNWM5YmUuLmYzOWM0OGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE3MDUsOCArMTcwNSwxNCBA QCBzdWIgYnVpbGRRTWFrZVByb2plY3QoJEApCiAgICAgbXkgJGRpciA9IEZpbGU6OlNwZWMtPmNh bm9ucGF0aChwcm9kdWN0RGlyKCkpOwogCiAgICAgbXkgJG9yaWdpbmFsQ3dkID0gZ2V0Y3dkKCk7 Ci0gICAgY2hkaXIgRmlsZTo6U3BlYy0+Y2F0ZmlsZShzb3VyY2VEaXIoKSwgIlNvdXJjZSIsICJX ZWJDb3JlIik7Ci0gICAgbXkgJGRlZmF1bHRzID0gYCRxbWFrZWJpbiBDT05GSUcrPWNvbXB1dGVf ZGVmYXVsdHMgMj4mMWA7CisgICAgbXkgJGNvbmZpZ0FyZ3MgPSAiQ09ORklHKz1jb21wdXRlX2Rl ZmF1bHRzIjsKKyAgICBpZiAoaXNXSzIoKSkgeworICAgICAgICBjaGRpciBGaWxlOjpTcGVjLT5j YXRmaWxlKHNvdXJjZURpcigpLCAiU291cmNlIiwgIldlYktpdDIiKTsKKyAgICAgICAgJGNvbmZp Z0FyZ3MgPSAiQ09ORklHKz13ZWJraXQyICRjb25maWdBcmdzIjsKKyAgICB9IGVsc2UgeworICAg ICAgICBjaGRpciBGaWxlOjpTcGVjLT5jYXRmaWxlKHNvdXJjZURpcigpLCAiU291cmNlIiwgIldl YkNvcmUiKTsKKyAgICB9CisgICAgbXkgJGRlZmF1bHRzID0gYCRxbWFrZWJpbiAkY29uZmlnQXJn cyAyPiYxYDsKICAgICBjaGRpciAkb3JpZ2luYWxDd2Q7CiAKICAgICAjIE9uIFN5bWJpYW4gcW1h a2UgbmVlZHMgdG8gcnVuIGluIHRoZSBzYW1lIGRpcmVjdG9yeSB3aGVyZSB0aGUgcHJvIGZpbGUg aXMgbG9jYXRlZC4K