68449 2011-09-20 10:21:15 -0700 [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff. 2011-10-05 10:50:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 470144 0 rakuco 2011-09-20 10:21:15 -0700 [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff. 470146 1 108017 rakuco 2011-09-20 10:22:17 -0700 Created attachment 108017 Patch 478439 2 rakuco 2011-10-05 09:46:39 -0700 CC'ing tonikitoo. 478465 3 108017 tonikitoo 2011-10-05 10:10:46 -0700 Comment on attachment 108017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108017&action=review > Tools/DumpRenderTree/efl/ImageDiff.cpp:220 > -static void printImageDifferences(const Evas_Object* baselineImage, Evas_Object* actualImage) > +static void printImageDifferences(Evas_Object* baselineImage, Evas_Object* actualImage) is this related? 478475 4 rakuco 2011-10-05 10:26:23 -0700 (In reply to comment #3) > (From update of attachment 108017 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=108017&action=review > > > Tools/DumpRenderTree/efl/ImageDiff.cpp:220 > > -static void printImageDifferences(const Evas_Object* baselineImage, Evas_Object* actualImage) > > +static void printImageDifferences(Evas_Object* baselineImage, Evas_Object* actualImage) > > is this related? Yes, otherwise we can't pass the non-const values to calculateDifference (which has also had its signature changed). 478503 5 108017 webkit.review.bot 2011-10-05 10:50:31 -0700 Comment on attachment 108017 Patch Clearing flags on attachment: 108017 Committed r96723: <http://trac.webkit.org/changeset/96723> 478504 6 webkit.review.bot 2011-10-05 10:50:36 -0700 All reviewed patches have been landed. Closing bug. 108017 2011-09-20 10:22:17 -0700 2011-10-05 10:50:31 -0700 Patch bug-68449-20110920142218.patch text/plain 3446 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogOTU1NTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZDQ3MWY1OGRmYWJhMTU0MTIxODY2MTg1NDYwYTA0ZGI1 MzdlYzBmLi5hZTY5ZTRhY2RjN2ViNzc1N2YwZTY3YmRjNTYzNWE1Yzc4ZTcwNzdjIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMDktMjAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1v Ymk+CisKKyAgICAgICAgW0VGTF0gRml4IEV2YXNfT2JqZWN0X0ltYWdlIHJlZmVyZW5jZSBjb3Vu dHMgYW5kIGZpbGUgZGVzY3JpcHRvciBsZWFrYWdlIGluIEltYWdlRGlmZi4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4NDQ5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZXZhc19yZW5kZXIoKSBtdXN0IGJl IGNhbGxlZCB0byBjbG9zZSB1cCB0ZW1wb3JhcnkgZmlsZXMgYW5kIHVubWFwIHVudXNlZAorICAg ICAgICByZXNvdXJjZXMuIGV2YXNfb2JqZWN0X2ltYWdlX2RhdGFfc2V0KCkgbXVzdCBiZSBjYWxs ZWQgYWZ0ZXIgYW4KKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0YV9nZXQoKSB0byBiYWxh bmNlIGFuIGludGVybmFsIHJlZmVyZW5jZSBjb3VudC4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL2VmbC9JbWFnZURpZmYuY3BwOgorICAgICAgICAoZGlmZmVyZW5jZUltYWdlRnJvbURpZmZl cmVuY2VCdWZmZXIpOgorICAgICAgICAoY2FsY3VsYXRlRGlmZmVyZW5jZSk6CisgICAgICAgIChw cmludEltYWdlKToKKyAgICAgICAgKHByaW50SW1hZ2VEaWZmZXJlbmNlcyk6CisKIDIwMTEtMDkt MjAgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAg Q2hhbmdlbG9nIGNsYXNzIHNob3VsZCBoYXZlIGEgbWV0aG9kIHRvIHJldHVybiBhbGwgZW50cmll cwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0ltYWdlRGlmZi5jcHAgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VEaWZmLmNwcAppbmRleCBhY2Y2OWMyMjlmMGYw OTliYzkxMDYyYTlhZWQ2MDg2MDI4Mjk1OTk2Li44MGU3ZDM2MmE0ZWJjZDA3MGU4NWQ0ODAwZWQ1 MTUzYjMzMzc2MmQyIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VE aWZmLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvSW1hZ2VEaWZmLmNwcApAQCAt ODIsNiArODIsOCBAQCBzdGF0aWMgRXZhc19PYmplY3QqIGRpZmZlcmVuY2VJbWFnZUZyb21EaWZm ZXJlbmNlQnVmZmVyKEV2YXMqIGV2YXMsIHVuc2lnbmVkIGNoYQogICAgICAgICB9CiAgICAgfQog CisgICAgZXZhc19vYmplY3RfaW1hZ2VfZGF0YV9zZXQoaW1hZ2UsIGRpZmZQaXhlbHMpOworCiAg ICAgcmV0dXJuIGltYWdlOwogfQogCkBAIC0xMDQsNyArMTA2LDcgQEAgc3RhdGljIGZsb2F0IGNh bGN1bGF0ZVBpeGVsRGlmZmVyZW5jZSh1bnNpZ25lZCBjaGFyKiBiYXNlUGl4ZWwsIHVuc2lnbmVk IGNoYXIqIGEKICAgICByZXR1cm4gc3FydGYocmVkICogcmVkICsgZ3JlZW4gKiBncmVlbiArIGJs dWUgKiBibHVlICsgYWxwaGEgKiBhbHBoYSkgLyAyLjBmOwogfQogCi1zdGF0aWMgZmxvYXQgY2Fs Y3VsYXRlRGlmZmVyZW5jZShjb25zdCBFdmFzX09iamVjdCogYmFzZWxpbmVJbWFnZSwgY29uc3Qg RXZhc19PYmplY3QqIGFjdHVhbEltYWdlLCBPd25QdHI8RXZhc19PYmplY3Q+JiBkaWZmZXJlbmNl SW1hZ2UpCitzdGF0aWMgZmxvYXQgY2FsY3VsYXRlRGlmZmVyZW5jZShFdmFzX09iamVjdCogYmFz ZWxpbmVJbWFnZSwgRXZhc19PYmplY3QqIGFjdHVhbEltYWdlLCBPd25QdHI8RXZhc19PYmplY3Q+ JiBkaWZmZXJlbmNlSW1hZ2UpCiB7CiAgICAgaW50IHdpZHRoLCBoZWlnaHQsIGJhc2VsaW5lV2lk dGgsIGJhc2VsaW5lSGVpZ2h0OwogICAgIGV2YXNfb2JqZWN0X2ltYWdlX3NpemVfZ2V0KGFjdHVh bEltYWdlLCAmd2lkdGgsICZoZWlnaHQpOwpAQCAtMTQ0LDYgKzE0NiwxMSBAQCBzdGF0aWMgZmxv YXQgY2FsY3VsYXRlRGlmZmVyZW5jZShjb25zdCBFdmFzX09iamVjdCogYmFzZWxpbmVJbWFnZSwg Y29uc3QgRXZhc19PYgogICAgICAgICB9CiAgICAgfQogCisgICAgLy8gV2hlbiB1c2luZyBldmFz X29iamVjdF9pbWFnZV9kYXRhX2dldCgpLCBhIGNvbXBsZW1lbnRhcnkgZXZhc19vYmplY3RfZGF0 YV9zZXQoKSBtdXN0IGJlCisgICAgLy8gaXNzdWVkIHRvIGJhbGFuY2UgdGhlIHJlZmVyZW5jZSBj b3VudCwgZXZlbiBpZiB0aGUgaW1hZ2UgaGFzbid0IGJlZW4gY2hhbmdlZC4KKyAgICBldmFzX29i amVjdF9pbWFnZV9kYXRhX3NldChiYXNlbGluZUltYWdlLCBiYXNlUGl4ZWxzKTsKKyAgICBldmFz X29iamVjdF9pbWFnZV9kYXRhX3NldChhY3R1YWxJbWFnZSwgYWN0dWFsUGl4ZWxzKTsKKwogICAg IC8vIENvbXB1dGUgdGhlIGRpZmZlcmVuY2UgYXMgYSBwZXJjZW50YWdlIGNvbWJpbmluZyBib3Ro IHRoZSBudW1iZXIgb2YKICAgICAvLyBkaWZmZXJlbnQgcGl4ZWxzIGFuZCB0aGVpciBkaWZmZXJl bmNlIGFtb3VudCBpLmUuIHRoZSBhdmVyYWdlIGRpc3RhbmNlCiAgICAgLy8gb3ZlciB0aGUgZW50 aXJlIGltYWdlCkBAIC0xOTIsNiArMTk5LDggQEAgc3RhdGljIHZvaWQgcHJpbnRJbWFnZShFdmFz X09iamVjdCogaW1hZ2UpCiAgICAgaWYgKHRlbXBJbWFnZUZkID09IC0xKQogICAgICAgICBhYm9y dFdpdGhFcnJvck1lc3NhZ2UoImNvdWxkIG5vdCBjcmVhdGUgdGVtcG9yYXJ5IGZpbGUiKTsKIAor ICAgIGV2YXNfcmVuZGVyKGV2YXNfb2JqZWN0X2V2YXNfZ2V0KGltYWdlKSk7CisKICAgICBpZiAo ZXZhc19vYmplY3RfaW1hZ2Vfc2F2ZShpbWFnZSwgZmlsZU5hbWUsIDAsIDApKSB7CiAgICAgICAg IHN0cnVjdCBzdGF0IGZpbGVJbmZvOwogICAgICAgICBpZiAoIXN0YXQoZmlsZU5hbWUsICZmaWxl SW5mbykpIHsKQEAgLTIwOCw3ICsyMTcsNyBAQCBzdGF0aWMgdm9pZCBwcmludEltYWdlKEV2YXNf T2JqZWN0KiBpbWFnZSkKICAgICB1bmxpbmsoZmlsZU5hbWUpOwogfQogCi1zdGF0aWMgdm9pZCBw cmludEltYWdlRGlmZmVyZW5jZXMoY29uc3QgRXZhc19PYmplY3QqIGJhc2VsaW5lSW1hZ2UsIEV2 YXNfT2JqZWN0KiBhY3R1YWxJbWFnZSkKK3N0YXRpYyB2b2lkIHByaW50SW1hZ2VEaWZmZXJlbmNl cyhFdmFzX09iamVjdCogYmFzZWxpbmVJbWFnZSwgRXZhc19PYmplY3QqIGFjdHVhbEltYWdlKQog ewogICAgIE93blB0cjxFdmFzX09iamVjdD4gZGlmZmVyZW5jZUltYWdlOwogICAgIGNvbnN0IGZs b2F0IGRpZmZlcmVuY2UgPSBjYWxjdWxhdGVEaWZmZXJlbmNlKGJhc2VsaW5lSW1hZ2UsIGFjdHVh bEltYWdlLCBkaWZmZXJlbmNlSW1hZ2UpOwo=