<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>68439</bug_id>
          
          <creation_ts>2011-09-20 08:00:07 -0700</creation_ts>
          <short_desc>[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.</short_desc>
          <delta_ts>2011-10-03 07:03:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zeno Albisser">zeno</reporter>
          <assigned_to name="Zeno Albisser">zeno</assigned_to>
          <cc>andersca</cc>
    
    <cc>aroben</cc>
    
    <cc>kling</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>470062</commentid>
    <comment_count>0</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-20 08:00:07 -0700</bug_when>
    <thetext>[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>470068</commentid>
    <comment_count>1</comment_count>
      <attachid>108003</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-20 08:09:22 -0700</bug_when>
    <thetext>Created attachment 108003
patch for feedback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>471569</commentid>
    <comment_count>2</comment_count>
      <attachid>108336</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-22 08:22:21 -0700</bug_when>
    <thetext>Created attachment 108336
patch for feedback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>471571</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-09-22 08:28:07 -0700</bug_when>
    <thetext>This should already be happening via WebProcess::didClose. Is that not being called for you?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>471574</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-09-22 08:29:49 -0700</bug_when>
    <thetext>WebProcess::didClose will only be called if the main thread isn&apos;t hung. Even if the main thread *is* hung, ChildProcess::didCloseOnConnectionWorkQueue should be called. That function sets things up so that the web process will exit in 10 seconds if the main thread still hasn&apos;t responded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473090</commentid>
    <comment_count>5</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-26 07:24:31 -0700</bug_when>
    <thetext>It seems there are several issues with the current implementation.
The didClose / didCloseOnConnectionWorkQueue is not working with the Qt port because the unix sockets IPC mechanism does not provide us any meaningful notification when the ui process died.
Even when the UIProcess is exited &quot;properly&quot; by the user, this approach does not work due to Leaking a WebContext and therefor not closing the IPC socket properly either.


The scheduleWorkOnTermination function does not work either, because we use a SIGNAL/SLOT connection to bind to the QProcess own finished() signal. Which of course never triggers because it would only trigger when the process itself exited already.

I will try to come up with a sensible solution at least for the latter problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473102</commentid>
    <comment_count>6</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-26 07:54:15 -0700</bug_when>
    <thetext>actually i misunderstood the purpose of the scheduleWorkOnTermination function... so at least that one is working properly. :-)  ... but it does not serve the purpose i was assuming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473124</commentid>
    <comment_count>7</comment_count>
      <attachid>108672</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-26 08:53:40 -0700</bug_when>
    <thetext>Created attachment 108672
patch for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473125</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-26 08:55:34 -0700</bug_when>
    <thetext>Attachment 108672 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebKit2/ChangeLog&apos;, u&apos;Source/WebKit...&quot; exit_code: 1

Source/WebKit2/WebProcess/qt/WebProcessQt.cpp:70:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473128</commentid>
    <comment_count>9</comment_count>
      <attachid>108673</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-26 09:01:04 -0700</bug_when>
    <thetext>Created attachment 108673
patch for review - fixed coding style issues

i think this is the best thing we can do for now.
But unless we want to fix circular dependencies of WebContext, WebProcessProxy and WebPageProxy and change the IPC mechanism of the Qt port, this is probably the way to go.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473847</commentid>
    <comment_count>10</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-27 04:40:10 -0700</bug_when>
    <thetext>i will change it from using exit() to qApp-&gt;quit() and try that again. ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473848</commentid>
    <comment_count>11</comment_count>
      <attachid>108673</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-09-27 04:51:21 -0700</bug_when>
    <thetext>Comment on attachment 108673
patch for review - fixed coding style issues

Not sure if we will support Leopard but Grand Central Dispatch was added in Snow Leopard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473850</commentid>
    <comment_count>12</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-09-27 04:54:21 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 108673 [details])
&gt; Not sure if we will support Leopard but Grand Central Dispatch was added in Snow Leopard.

We should support whatever Qt 5 will support. I don&apos;t think there&apos;s a problem adding SL-only things to trunk right now, we can figure this out later if someone decides that Qt 5.0 needs to support Leopard.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>473851</commentid>
    <comment_count>13</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-09-27 04:55:30 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 108673 [details])
&gt; Not sure if we will support Leopard but Grand Central Dispatch was added in Snow Leopard.

I am aware of that, but i consider it a minor issue in this ecosystem.
Do we have any guidelines on that?
Or do we know of potential WK2 users using Pre Snow Leopard?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476893</commentid>
    <comment_count>14</comment_count>
      <attachid>109468</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-10-03 04:32:07 -0700</bug_when>
    <thetext>Created attachment 109468
patch for review. - use qApp-&gt;quit() instead of exit()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476909</commentid>
    <comment_count>15</comment_count>
      <attachid>109468</attachid>
    <who name="Alexis Menard (darktears)">menard</who>
    <bug_when>2011-10-03 05:00:55 -0700</bug_when>
    <thetext>Comment on attachment 109468
patch for review. - use qApp-&gt;quit() instead of exit()

I think its good as we use the same approach than the Mac port. Jut a nitpick QApplication::quit() it is way nicer to read and understand than this magic hacked qApp pointer :D.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476927</commentid>
    <comment_count>16</comment_count>
      <attachid>109476</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-10-03 05:56:54 -0700</bug_when>
    <thetext>Created attachment 109476
patch for review. - use QCoreApplication::quit() instead of qApp-&gt;quit()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476930</commentid>
    <comment_count>17</comment_count>
      <attachid>109476</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-10-03 06:00:20 -0700</bug_when>
    <thetext>Comment on attachment 109476
patch for review. - use QCoreApplication::quit() instead of qApp-&gt;quit()

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476945</commentid>
    <comment_count>18</comment_count>
      <attachid>109476</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-03 07:03:22 -0700</bug_when>
    <thetext>Comment on attachment 109476
patch for review. - use QCoreApplication::quit() instead of qApp-&gt;quit()

Clearing flags on attachment: 109476

Committed r96494: &lt;http://trac.webkit.org/changeset/96494&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476947</commentid>
    <comment_count>19</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-10-03 07:03:27 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108003</attachid>
            <date>2011-09-20 08:09:22 -0700</date>
            <delta_ts>2011-09-22 08:22:21 -0700</delta_ts>
            <desc>patch for feedback.</desc>
            <filename>68439.patch</filename>
            <type>text/plain</type>
            <size>3004</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA0NjQxYTM0Li5jOWU1ZTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMTEtMDktMjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K
KworICAgICAgICBbUXRdW1dlYktpdDJdW01hY10gV2ViUHJvY2VzcyBzaG91bGQgZXhpdCBhdXRv
bWF0aWNhbGx5IHdoZW4gVUlQcm9jZXNzIGRpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisgICAgICAg
ICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ
cm9jZXNzOjpwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTEtMDktMTkgIEFs
ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0
XSBVbnJldmlld2VkIGNvZGluZyBzdHlsZSBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi
UHJvY2Vzcy5oCmluZGV4IGQ5MDc4NGMuLjAwOTg1ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL
aXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl
c3MvV2ViUHJvY2Vzcy5oCkBAIC00Myw2ICs0Myw5IEBACiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQu
aD4KIAogI2lmIFBMQVRGT1JNKFFUKQorI2lmIGRlZmluZWQoUV9PU19NQUNYKQorI2luY2x1ZGUg
PHN5cy9ldmVudC5oPgorI2VuZGlmCiBjbGFzcyBRTmV0d29ya0FjY2Vzc01hbmFnZXI7CiAjZW5k
aWYKIApAQCAtNzMsNiArNzYsMTAgQEAgcHVibGljOgogCiAgICAgdm9pZCBpbml0aWFsaXplKENv
cmVJUEM6OkNvbm5lY3Rpb246OklkZW50aWZpZXIsIFJ1bkxvb3AqKTsKIAorI2lmIFBMQVRGT1JN
KFFUKSAmJiBkZWZpbmVkKFFfT1NfTUFDWCkKKyAgICBzdGF0aWMgdm9pZCBwYXJlbnRQcm9jZXNz
RGllZENhbGxiYWNrKENGRmlsZURlc2NyaXB0b3JSZWYsIENGT3B0aW9uRmxhZ3MsIHZvaWQqKTsK
KyNlbmRpZgorCiAgICAgQ29yZUlQQzo6Q29ubmVjdGlvbiogY29ubmVjdGlvbigpIGNvbnN0IHsg
cmV0dXJuIG1fY29ubmVjdGlvbi5nZXQoKTsgfQogICAgIFJ1bkxvb3AqIHJ1bkxvb3AoKSBjb25z
dCB7IHJldHVybiBtX3J1bkxvb3A7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi
UHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9x
dC9XZWJQcm9jZXNzUXQuY3BwCmluZGV4IDkxOTA0NGUuLmNkNzEzMmEgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcAorKysgYi9Tb3VyY2Uv
V2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAKQEAgLTQxLDYgKzQxLDEzIEBA
IHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1DbGVhclJlc291cmNlQ2FjaGVzKFJlc291cmNlQ2Fj
aGVzVG9DbGVhcikKIHsKIH0KIAorI2lmIGRlZmluZWQoUV9PU19NQUNYKQordm9pZCBXZWJQcm9j
ZXNzOjpwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKENGRmlsZURlc2NyaXB0b3JSZWYsIENGT3B0
aW9uRmxhZ3MsIHZvaWQqKQoreworICAgIGV4aXQoRVhJVF9TVUNDRVNTKTsKK30KKyNlbmRpZgor
CiB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoY29uc3QgV2Vi
UHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycywgQ29yZUlQQzo6QXJndW1lbnRE
ZWNvZGVyKiBhcmd1bWVudHMpCiB7CiAgICAgbV9uZXR3b3JrQWNjZXNzTWFuYWdlciA9IG5ldyBR
TmV0d29ya0FjY2Vzc01hbmFnZXI7CkBAIC01Myw2ICs2MCwxOCBAQCB2b2lkIFdlYlByb2Nlc3M6
OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoY29uc3QgV2ViUHJvY2Vzc0NyZWF0aW9uUGFy
YW1ldGVycwogI2lmIEVOQUJMRShTUEVFQ0hfSU5QVVQpCiAgICAgV2ViQ29yZTo6UnVudGltZUVu
YWJsZWRGZWF0dXJlczo6c2V0U3BlZWNoSW5wdXRFbmFibGVkKGZhbHNlKTsKICNlbmRpZgorCisj
aWYgZGVmaW5lZChRX09TX01BQ1gpCisgICAgaW50IGZkID0ga3F1ZXVlKCk7CisgICAgc3RydWN0
IGtldmVudCBrZXJuZWxFdmVudDsKKyAgICBFVl9TRVQoJmtlcm5lbEV2ZW50LCBnZXRwcGlkKCks
IEVWRklMVF9QUk9DLCBFVl9BREQgfCBFVl9FTkFCTEUsIE5PVEVfRVhJVCwgMCwgMCk7CisgICAg
a2V2ZW50KGZkLCAma2VybmVsRXZlbnQsIDEsIDAsIDAsIDApOworICAgIENGRmlsZURlc2NyaXB0
b3JSZWYgZmRSZWYgPSBDRkZpbGVEZXNjcmlwdG9yQ3JlYXRlKGtDRkFsbG9jYXRvckRlZmF1bHQs
IGZkLCB0cnVlLCBXZWJQcm9jZXNzOjpwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrLCAwKTsKKyAg
ICBDRkZpbGVEZXNjcmlwdG9yRW5hYmxlQ2FsbEJhY2tzKGZkUmVmLCBrQ0ZGaWxlRGVzY3JpcHRv
clJlYWRDYWxsQmFjayk7CisgICAgQ0ZSdW5Mb29wU291cmNlUmVmIHNvdXJjZSA9IENGRmlsZURl
c2NyaXB0b3JDcmVhdGVSdW5Mb29wU291cmNlKGtDRkFsbG9jYXRvckRlZmF1bHQsIGZkUmVmLCAw
KTsKKyAgICBDRlJ1bkxvb3BBZGRTb3VyY2UoQ0ZSdW5Mb29wR2V0TWFpbigpLCBzb3VyY2UsIGtD
RlJ1bkxvb3BEZWZhdWx0TW9kZSk7CisgICAgQ0ZSZWxlYXNlKHNvdXJjZSk7CisjZW5kaWYKIH0K
IAogdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybVRlcm1pbmF0ZSgpCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108336</attachid>
            <date>2011-09-22 08:22:21 -0700</date>
            <delta_ts>2011-09-26 08:53:40 -0700</delta_ts>
            <desc>patch for feedback.</desc>
            <filename>68439_2.patch</filename>
            <type>text/plain</type>
            <size>2221</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA0NjQxYTM0Li5jOWU1ZTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMTEtMDktMjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K
KworICAgICAgICBbUXRdW1dlYktpdDJdW01hY10gV2ViUHJvY2VzcyBzaG91bGQgZXhpdCBhdXRv
bWF0aWNhbGx5IHdoZW4gVUlQcm9jZXNzIGRpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisgICAgICAg
ICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ
cm9jZXNzOjpwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTEtMDktMTkgIEFs
ZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0
XSBVbnJldmlld2VkIGNvZGluZyBzdHlsZSBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j
ZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAKaW5kZXggOTE5MDQ0ZS4uZTZlNmUyNyAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcApAQCAtMzAsNiArMzAs
MTAgQEAKICNpbmNsdWRlIDxXZWJDb3JlL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuaD4KICNpbmNs
dWRlIDxRTmV0d29ya0FjY2Vzc01hbmFnZXI+CiAKKyNpZiBkZWZpbmVkIFFfT1NfTUFDWAorI2lu
Y2x1ZGUgPGRpc3BhdGNoL2Rpc3BhdGNoLmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYktpdCB7
CiAKIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1TZXRDYWNoZU1vZGVsKENhY2hlTW9kZWwpCkBA
IC00MSwxMCArNDUsMjggQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUNsZWFyUmVzb3VyY2VD
YWNoZXMoUmVzb3VyY2VDYWNoZXNUb0NsZWFyKQogewogfQogCisjaWYgZGVmaW5lZChRX09TX01B
Q1gpCitzdGF0aWMgdm9pZCBwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKHZvaWQqKQoreworICAg
IHNpZ25hbChTSUdTRUdWLCBTSUdfSUdOKTsKKyAgICBleGl0KEVYSVRfU1VDQ0VTUyk7Cit9Cisj
ZW5kaWYKKwogdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKGNv
bnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMsIENvcmVJUEM6OkFy
Z3VtZW50RGVjb2RlciogYXJndW1lbnRzKQogewogICAgIG1fbmV0d29ya0FjY2Vzc01hbmFnZXIg
PSBuZXcgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyOwogCisjaWYgZGVmaW5lZChRX09TX01BQ1gpCisg
ICAgcGlkX3QgcHBpZCA9IGdldHBwaWQoKTsKKyAgICBkaXNwYXRjaF9xdWV1ZV90IHF1ZXVlID0g
ZGlzcGF0Y2hfZ2V0X2dsb2JhbF9xdWV1ZShESVNQQVRDSF9RVUVVRV9QUklPUklUWV9ERUZBVUxU
LCAwKTsKKyAgICBkaXNwYXRjaF9zb3VyY2VfdCBzb3VyY2UgPSBkaXNwYXRjaF9zb3VyY2VfY3Jl
YXRlKERJU1BBVENIX1NPVVJDRV9UWVBFX1BST0MscHBpZCxESVNQQVRDSF9QUk9DX0VYSVQsIHF1
ZXVlKTsKKyAgICBpZiAoc291cmNlKSB7CisgICAgICAgIGRpc3BhdGNoX3NvdXJjZV9zZXRfZXZl
bnRfaGFuZGxlcl9mKHNvdXJjZSwgcGFyZW50UHJvY2Vzc0RpZWRDYWxsYmFjayk7CisgICAgICAg
IGRpc3BhdGNoX3Jlc3VtZShzb3VyY2UpOworICAgIH0KKyNlbmRpZgorCiAgICAgLy8gRGlzYWJs
ZSBydW50aW1lIGVuYWJsZWQgZmVhdHVyZXMgdGhhdCBoYXZlIG5vIFdlYktpdDIgaW1wbGVtZW50
YXRpb24geWV0LgogI2lmIEVOQUJMRShERVZJQ0VfT1JJRU5UQVRJT04pCiAgICAgV2ViQ29yZTo6
UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2V0RGV2aWNlTW90aW9uRW5hYmxlZChmYWxzZSk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108672</attachid>
            <date>2011-09-26 08:53:40 -0700</date>
            <delta_ts>2011-09-26 09:01:04 -0700</delta_ts>
            <desc>patch for review.</desc>
            <filename>68439_3.patch</filename>
            <type>text/plain</type>
            <size>2394</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCBjYmQzMmJlLi5kMWE5MmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMTEtMDktMjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K
KworICAgICAgICBbUXRdW1dlYktpdDJdW01hY10gV2ViUHJvY2VzcyBzaG91bGQgZXhpdCBhdXRv
bWF0aWNhbGx5IHdoZW4gVUlQcm9jZXNzIGRpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisgICAgICAg
ICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ
cm9jZXNzOjpwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTEtMDktMjUgIE1h
cmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgY3Vz
dG9tIHZ0YWJsZSBzdHJ1Y3QgdG8gQ2xhc3NJbmZvIHN0cnVjdApkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwIGIvU291cmNlL1dlYktpdDIv
V2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCmluZGV4IDQwZmI3MDIuLmY5NmViOGMgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcAor
KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAKQEAgLTMy
LDYgKzMyLDEwIEBACiAjaW5jbHVkZSA8UU5ldHdvcmtDb29raWVKYXI+CiAjaW5jbHVkZSA8V2Vi
Q29yZS9Db29raWVKYXJRdC5oPgogCisjaWYgZGVmaW5lZChRX09TX01BQ1gpCisjaW5jbHVkZSA8
ZGlzcGF0Y2gvZGlzcGF0Y2guaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogdm9p
ZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybVNldENhY2hlTW9kZWwoQ2FjaGVNb2RlbCkKQEAgLTQzLDYg
KzQ3LDE0IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1DbGVhclJlc291cmNlQ2FjaGVzKFJl
c291cmNlQ2FjaGVzVG9DbGVhcikKIHsKIH0KIAorI2lmIGRlZmluZWQoUV9PU19NQUNYKQorc3Rh
dGljIHZvaWQgcGFyZW50UHJvY2Vzc0RpZWRDYWxsYmFjayh2b2lkKikKK3sKKyAgICBzaWduYWwo
U0lHU0VHViwgU0lHX0lHTik7CisgICAgZXhpdChFWElUX1NVQ0NFU1MpOworfQorI2VuZGlmCisK
IHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQ
cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzLCBDb3JlSVBDOjpBcmd1bWVudERl
Y29kZXIqIGFyZ3VtZW50cykKIHsKICAgICBtX25ldHdvcmtBY2Nlc3NNYW5hZ2VyID0gbmV3IFFO
ZXR3b3JrQWNjZXNzTWFuYWdlcjsKQEAgLTUyLDYgKzY0LDE2IEBAIHZvaWQgV2ViUHJvY2Vzczo6
cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJh
bWV0ZXJzCiAgICAgLy8gRG8gbm90IGxldCBRTmV0d29ya0FjY2Vzc01hbmFnZXIgZGVsZXRlIHRo
ZSBqYXIuCiAgICAgamFyLT5zZXRQYXJlbnQoMCk7CiAKKyNpZiBkZWZpbmVkKFFfT1NfTUFDWCkK
KyAgICBwaWRfdCBwcGlkID0gZ2V0cHBpZCgpOworICAgIGRpc3BhdGNoX3F1ZXVlX3QgcXVldWUg
PSBkaXNwYXRjaF9nZXRfZ2xvYmFsX3F1ZXVlKERJU1BBVENIX1FVRVVFX1BSSU9SSVRZX0RFRkFV
TFQsIDApOworICAgIGRpc3BhdGNoX3NvdXJjZV90IHNvdXJjZSA9IGRpc3BhdGNoX3NvdXJjZV9j
cmVhdGUoRElTUEFUQ0hfU09VUkNFX1RZUEVfUFJPQyxwcGlkLERJU1BBVENIX1BST0NfRVhJVCwg
cXVldWUpOworICAgIGlmIChzb3VyY2UpIHsKKyAgICAgICAgZGlzcGF0Y2hfc291cmNlX3NldF9l
dmVudF9oYW5kbGVyX2Yoc291cmNlLCBwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKTsKKyAgICAg
ICAgZGlzcGF0Y2hfcmVzdW1lKHNvdXJjZSk7CisgICAgfQorI2VuZGlmCisKICAgICAvLyBEaXNh
YmxlIHJ1bnRpbWUgZW5hYmxlZCBmZWF0dXJlcyB0aGF0IGhhdmUgbm8gV2ViS2l0MiBpbXBsZW1l
bnRhdGlvbiB5ZXQuCiAjaWYgRU5BQkxFKERFVklDRV9PUklFTlRBVElPTikKICAgICBXZWJDb3Jl
OjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXREZXZpY2VNb3Rpb25FbmFibGVkKGZhbHNlKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>108673</attachid>
            <date>2011-09-26 09:01:04 -0700</date>
            <delta_ts>2011-10-03 05:56:54 -0700</delta_ts>
            <desc>patch for review - fixed coding style issues</desc>
            <filename>68439_4.patch</filename>
            <type>text/plain</type>
            <size>2396</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCBjYmQzMmJlLi5kMWE5MmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMTEtMDktMjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K
KworICAgICAgICBbUXRdW1dlYktpdDJdW01hY10gV2ViUHJvY2VzcyBzaG91bGQgZXhpdCBhdXRv
bWF0aWNhbGx5IHdoZW4gVUlQcm9jZXNzIGRpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisgICAgICAg
ICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ
cm9jZXNzOjpwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKToKKyAgICAgICAgKFdlYktpdDo6V2Vi
UHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTEtMDktMjUgIE1h
cmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgY3Vz
dG9tIHZ0YWJsZSBzdHJ1Y3QgdG8gQ2xhc3NJbmZvIHN0cnVjdApkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwIGIvU291cmNlL1dlYktpdDIv
V2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCmluZGV4IDQwZmI3MDIuLjk4OWI3M2MgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcAor
KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAKQEAgLTMy
LDYgKzMyLDEwIEBACiAjaW5jbHVkZSA8UU5ldHdvcmtDb29raWVKYXI+CiAjaW5jbHVkZSA8V2Vi
Q29yZS9Db29raWVKYXJRdC5oPgogCisjaWYgZGVmaW5lZChRX09TX01BQ1gpCisjaW5jbHVkZSA8
ZGlzcGF0Y2gvZGlzcGF0Y2guaD4KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogdm9p
ZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybVNldENhY2hlTW9kZWwoQ2FjaGVNb2RlbCkKQEAgLTQzLDYg
KzQ3LDE0IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1DbGVhclJlc291cmNlQ2FjaGVzKFJl
c291cmNlQ2FjaGVzVG9DbGVhcikKIHsKIH0KIAorI2lmIGRlZmluZWQoUV9PU19NQUNYKQorc3Rh
dGljIHZvaWQgcGFyZW50UHJvY2Vzc0RpZWRDYWxsYmFjayh2b2lkKikKK3sKKyAgICBzaWduYWwo
U0lHU0VHViwgU0lHX0lHTik7CisgICAgZXhpdChFWElUX1NVQ0NFU1MpOworfQorI2VuZGlmCisK
IHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQ
cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzLCBDb3JlSVBDOjpBcmd1bWVudERl
Y29kZXIqIGFyZ3VtZW50cykKIHsKICAgICBtX25ldHdvcmtBY2Nlc3NNYW5hZ2VyID0gbmV3IFFO
ZXR3b3JrQWNjZXNzTWFuYWdlcjsKQEAgLTUyLDYgKzY0LDE2IEBAIHZvaWQgV2ViUHJvY2Vzczo6
cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJh
bWV0ZXJzCiAgICAgLy8gRG8gbm90IGxldCBRTmV0d29ya0FjY2Vzc01hbmFnZXIgZGVsZXRlIHRo
ZSBqYXIuCiAgICAgamFyLT5zZXRQYXJlbnQoMCk7CiAKKyNpZiBkZWZpbmVkKFFfT1NfTUFDWCkK
KyAgICBwaWRfdCBwcGlkID0gZ2V0cHBpZCgpOworICAgIGRpc3BhdGNoX3F1ZXVlX3QgcXVldWUg
PSBkaXNwYXRjaF9nZXRfZ2xvYmFsX3F1ZXVlKERJU1BBVENIX1FVRVVFX1BSSU9SSVRZX0RFRkFV
TFQsIDApOworICAgIGRpc3BhdGNoX3NvdXJjZV90IHNvdXJjZSA9IGRpc3BhdGNoX3NvdXJjZV9j
cmVhdGUoRElTUEFUQ0hfU09VUkNFX1RZUEVfUFJPQywgcHBpZCwgRElTUEFUQ0hfUFJPQ19FWElU
LCBxdWV1ZSk7CisgICAgaWYgKHNvdXJjZSkgeworICAgICAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0
X2V2ZW50X2hhbmRsZXJfZihzb3VyY2UsIHBhcmVudFByb2Nlc3NEaWVkQ2FsbGJhY2spOworICAg
ICAgICBkaXNwYXRjaF9yZXN1bWUoc291cmNlKTsKKyAgICB9CisjZW5kaWYKKwogICAgIC8vIERp
c2FibGUgcnVudGltZSBlbmFibGVkIGZlYXR1cmVzIHRoYXQgaGF2ZSBubyBXZWJLaXQyIGltcGxl
bWVudGF0aW9uIHlldC4KICNpZiBFTkFCTEUoREVWSUNFX09SSUVOVEFUSU9OKQogICAgIFdlYkNv
cmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldERldmljZU1vdGlvbkVuYWJsZWQoZmFsc2Up
Owo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109468</attachid>
            <date>2011-10-03 04:32:07 -0700</date>
            <delta_ts>2011-10-03 05:56:54 -0700</delta_ts>
            <desc>patch for review. - use qApp-&gt;quit() instead of exit()</desc>
            <filename>68439_20111003-132729.patch</filename>
            <type>text/plain</type>
            <size>2699</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA5ZDdjZWFiLi5lODBjNzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTEtMTAtMDMgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K
KworICAgICAgICBbUXRdW1dlYktpdDJdW01hY10gV2ViUHJvY2VzcyBzaG91bGQgZXhpdCBhdXRv
bWF0aWNhbGx5IHdoZW4gVUlQcm9jZXNzIGRpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQzOQorCisgICAgICAgIFdlIHVzZSBhIGRpc3BhdGNo
IHF1ZXVlIGFuZCBhIGRpc3BhdGNoIHNvdXJjZSBpbiB0aGUgV2ViUHJvY2VzcworICAgICAgICB0
byByZWNlaXZlIGEgbm90aWZpY2F0aW9uIHdoZW4gdGhlIFVJIFByb2Nlc3MgZGllcy4KKyAgICAg
ICAgVGhlIFdlYlByb2Nlc3MgdGhlbiBjb21taXRzIHN1aWNpZGUuCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL3F0L1dlYlByb2Nl
c3NRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBhcmVudFByb2Nlc3NEaWVkQ2FsbGJhY2spOgor
ICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNz
KToKKwogMjAxMS0xMC0wMiAgWmVubyBBbGJpc3NlciAgPHplbm8uYWxiaXNzZXJAbm9raWEuY29t
PgogCiAgICAgICAgIFtRdF1bV0syXVtNYWNdIFdlYktpdDIgZG9lcyBub3QgYnVpbGQgb24gbWFj
IGFmdGVyIG1lcmdlIG9mIFF0NSByZWZhY3RvciBicmFuY2guCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X
ZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAKaW5kZXggNDBmYjcwMi4uMjk5ZmE4NCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCisr
KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcApAQCAtMjcs
MTAgKzI3LDE2IEBACiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgogCiAjaW5jbHVkZSAiV2ViUHJv
Y2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oIgotI2luY2x1ZGUgPFdlYkNvcmUvUnVudGltZUVuYWJs
ZWRGZWF0dXJlcy5oPgorCisjaW5jbHVkZSA8UUFwcGxpY2F0aW9uPgogI2luY2x1ZGUgPFFOZXR3
b3JrQWNjZXNzTWFuYWdlcj4KICNpbmNsdWRlIDxRTmV0d29ya0Nvb2tpZUphcj4KICNpbmNsdWRl
IDxXZWJDb3JlL0Nvb2tpZUphclF0Lmg+CisjaW5jbHVkZSA8V2ViQ29yZS9SdW50aW1lRW5hYmxl
ZEZlYXR1cmVzLmg+CisKKyNpZiBkZWZpbmVkKFFfT1NfTUFDWCkKKyNpbmNsdWRlIDxkaXNwYXRj
aC9kaXNwYXRjaC5oPgorI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCkBAIC00Myw2ICs0
OSwxMyBAQCB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtQ2xlYXJSZXNvdXJjZUNhY2hlcyhSZXNv
dXJjZUNhY2hlc1RvQ2xlYXIpCiB7CiB9CiAKKyNpZiBkZWZpbmVkKFFfT1NfTUFDWCkKK3N0YXRp
YyB2b2lkIHBhcmVudFByb2Nlc3NEaWVkQ2FsbGJhY2sodm9pZCopCit7CisgICAgcUFwcC0+cXVp
dCgpOworfQorI2VuZGlmCisKIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2Vi
UHJvY2Vzcyhjb25zdCBXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzLCBD
b3JlSVBDOjpBcmd1bWVudERlY29kZXIqIGFyZ3VtZW50cykKIHsKICAgICBtX25ldHdvcmtBY2Nl
c3NNYW5hZ2VyID0gbmV3IFFOZXR3b3JrQWNjZXNzTWFuYWdlcjsKQEAgLTUyLDYgKzY1LDE2IEBA
IHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyhjb25zdCBXZWJQ
cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzCiAgICAgLy8gRG8gbm90IGxldCBRTmV0d29ya0FjY2Vz
c01hbmFnZXIgZGVsZXRlIHRoZSBqYXIuCiAgICAgamFyLT5zZXRQYXJlbnQoMCk7CiAKKyNpZiBk
ZWZpbmVkKFFfT1NfTUFDWCkKKyAgICBwaWRfdCBwcGlkID0gZ2V0cHBpZCgpOworICAgIGRpc3Bh
dGNoX3F1ZXVlX3QgcXVldWUgPSBkaXNwYXRjaF9nZXRfZ2xvYmFsX3F1ZXVlKERJU1BBVENIX1FV
RVVFX1BSSU9SSVRZX0RFRkFVTFQsIDApOworICAgIGRpc3BhdGNoX3NvdXJjZV90IHNvdXJjZSA9
IGRpc3BhdGNoX3NvdXJjZV9jcmVhdGUoRElTUEFUQ0hfU09VUkNFX1RZUEVfUFJPQywgcHBpZCwg
RElTUEFUQ0hfUFJPQ19FWElULCBxdWV1ZSk7CisgICAgaWYgKHNvdXJjZSkgeworICAgICAgICBk
aXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hhbmRsZXJfZihzb3VyY2UsIHBhcmVudFByb2Nlc3NE
aWVkQ2FsbGJhY2spOworICAgICAgICBkaXNwYXRjaF9yZXN1bWUoc291cmNlKTsKKyAgICB9Cisj
ZW5kaWYKKwogICAgIC8vIERpc2FibGUgcnVudGltZSBlbmFibGVkIGZlYXR1cmVzIHRoYXQgaGF2
ZSBubyBXZWJLaXQyIGltcGxlbWVudGF0aW9uIHlldC4KICNpZiBFTkFCTEUoREVWSUNFX09SSUVO
VEFUSU9OKQogICAgIFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldERldmljZU1v
dGlvbkVuYWJsZWQoZmFsc2UpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>109476</attachid>
            <date>2011-10-03 05:56:54 -0700</date>
            <delta_ts>2011-10-03 07:03:22 -0700</delta_ts>
            <desc>patch for review. - use QCoreApplication::quit() instead of qApp-&gt;quit()</desc>
            <filename>68439_20111003-145534.patch</filename>
            <type>text/plain</type>
            <size>2715</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA5ZDdjZWFiLi5lODBjNzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg
QEAKKzIwMTEtMTAtMDMgIFplbm8gQWxiaXNzZXIgIDx6ZW5vLmFsYmlzc2VyQG5va2lhLmNvbT4K
KworICAgICAgICBbUXRdW1dlYktpdDJdW01hY10gV2ViUHJvY2VzcyBzaG91bGQgZXhpdCBhdXRv
bWF0aWNhbGx5IHdoZW4gVUlQcm9jZXNzIGRpZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQzOQorCisgICAgICAgIFdlIHVzZSBhIGRpc3BhdGNo
IHF1ZXVlIGFuZCBhIGRpc3BhdGNoIHNvdXJjZSBpbiB0aGUgV2ViUHJvY2VzcworICAgICAgICB0
byByZWNlaXZlIGEgbm90aWZpY2F0aW9uIHdoZW4gdGhlIFVJIFByb2Nlc3MgZGllcy4KKyAgICAg
ICAgVGhlIFdlYlByb2Nlc3MgdGhlbiBjb21taXRzIHN1aWNpZGUuCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL3F0L1dlYlByb2Nl
c3NRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBhcmVudFByb2Nlc3NEaWVkQ2FsbGJhY2spOgor
ICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNz
KToKKwogMjAxMS0xMC0wMiAgWmVubyBBbGJpc3NlciAgPHplbm8uYWxiaXNzZXJAbm9raWEuY29t
PgogCiAgICAgICAgIFtRdF1bV0syXVtNYWNdIFdlYktpdDIgZG9lcyBub3QgYnVpbGQgb24gbWFj
IGFmdGVyIG1lcmdlIG9mIFF0NSByZWZhY3RvciBicmFuY2guCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9X
ZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAKaW5kZXggNDBmYjcwMi4uMDVhMGM2NCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCisr
KyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcApAQCAtMjcs
MTAgKzI3LDE2IEBACiAjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgogCiAjaW5jbHVkZSAiV2ViUHJv
Y2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oIgotI2luY2x1ZGUgPFdlYkNvcmUvUnVudGltZUVuYWJs
ZWRGZWF0dXJlcy5oPgorCisjaW5jbHVkZSA8UUNvcmVBcHBsaWNhdGlvbj4KICNpbmNsdWRlIDxR
TmV0d29ya0FjY2Vzc01hbmFnZXI+CiAjaW5jbHVkZSA8UU5ldHdvcmtDb29raWVKYXI+CiAjaW5j
bHVkZSA8V2ViQ29yZS9Db29raWVKYXJRdC5oPgorI2luY2x1ZGUgPFdlYkNvcmUvUnVudGltZUVu
YWJsZWRGZWF0dXJlcy5oPgorCisjaWYgZGVmaW5lZChRX09TX01BQ1gpCisjaW5jbHVkZSA8ZGlz
cGF0Y2gvZGlzcGF0Y2guaD4KKyNlbmRpZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIApAQCAtNDMs
NiArNDksMTMgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUNsZWFyUmVzb3VyY2VDYWNoZXMo
UmVzb3VyY2VDYWNoZXNUb0NsZWFyKQogewogfQogCisjaWYgZGVmaW5lZChRX09TX01BQ1gpCitz
dGF0aWMgdm9pZCBwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKHZvaWQqKQoreworICAgIFFDb3Jl
QXBwbGljYXRpb246OnF1aXQoKTsKK30KKyNlbmRpZgorCiB2b2lkIFdlYlByb2Nlc3M6OnBsYXRm
b3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoY29uc3QgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVy
cyYgcGFyYW1ldGVycywgQ29yZUlQQzo6QXJndW1lbnREZWNvZGVyKiBhcmd1bWVudHMpCiB7CiAg
ICAgbV9uZXR3b3JrQWNjZXNzTWFuYWdlciA9IG5ldyBRTmV0d29ya0FjY2Vzc01hbmFnZXI7CkBA
IC01Miw2ICs2NSwxNiBAQCB2b2lkIFdlYlByb2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlBy
b2Nlc3MoY29uc3QgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycwogICAgIC8vIERvIG5vdCBs
ZXQgUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyIGRlbGV0ZSB0aGUgamFyLgogICAgIGphci0+c2V0UGFy
ZW50KDApOwogCisjaWYgZGVmaW5lZChRX09TX01BQ1gpCisgICAgcGlkX3QgcHBpZCA9IGdldHBw
aWQoKTsKKyAgICBkaXNwYXRjaF9xdWV1ZV90IHF1ZXVlID0gZGlzcGF0Y2hfZ2V0X2dsb2JhbF9x
dWV1ZShESVNQQVRDSF9RVUVVRV9QUklPUklUWV9ERUZBVUxULCAwKTsKKyAgICBkaXNwYXRjaF9z
b3VyY2VfdCBzb3VyY2UgPSBkaXNwYXRjaF9zb3VyY2VfY3JlYXRlKERJU1BBVENIX1NPVVJDRV9U
WVBFX1BST0MsIHBwaWQsIERJU1BBVENIX1BST0NfRVhJVCwgcXVldWUpOworICAgIGlmIChzb3Vy
Y2UpIHsKKyAgICAgICAgZGlzcGF0Y2hfc291cmNlX3NldF9ldmVudF9oYW5kbGVyX2Yoc291cmNl
LCBwYXJlbnRQcm9jZXNzRGllZENhbGxiYWNrKTsKKyAgICAgICAgZGlzcGF0Y2hfcmVzdW1lKHNv
dXJjZSk7CisgICAgfQorI2VuZGlmCisKICAgICAvLyBEaXNhYmxlIHJ1bnRpbWUgZW5hYmxlZCBm
ZWF0dXJlcyB0aGF0IGhhdmUgbm8gV2ViS2l0MiBpbXBsZW1lbnRhdGlvbiB5ZXQuCiAjaWYgRU5B
QkxFKERFVklDRV9PUklFTlRBVElPTikKICAgICBXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1
cmVzOjpzZXREZXZpY2VNb3Rpb25FbmFibGVkKGZhbHNlKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>