68415 2011-09-19 17:47:35 -0700 Sheriffbot rollout should be more intuitive. 2011-09-19 17:57:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 levin levin abarth eric oldest_to_newest 469827 0 levin 2011-09-19 17:47:35 -0700 For example, it should response to "revert" as well as "rollout". It should allow for comma separated revision numbers (with or without spaces after the comma). 469830 1 107948 levin 2011-09-19 17:49:36 -0700 Created attachment 107948 Patch 469833 2 levin 2011-09-19 17:57:02 -0700 Committed as http://trac.webkit.org/changeset/95500. 107948 2011-09-19 17:49:36 -0700 2011-09-19 17:51:55 -0700 Patch bug-68415-20110919174935.patch text/plain 7177 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0OTkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMjI0ODlmNzg5ZWUyODAyNjM3NDYzZDgxOWJiOTJkODEy OGY1MDczLi43N2ZmODA4NWM4MWRjMjY3N2NkNjJhYWMyOWI1NTZkODNlN2RiM2E5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTEtMDktMTkgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCisgICAg ICAgIFNoZXJpZmZib3Qgcm9sbG91dCBzaG91bGQgYmUgbW9yZSBpbnR1aXRpdmUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODQxNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL2JvdC9pcmNfY29tbWFuZC5weTogQWRkIHN1cHBvcnQgZm9yIHJldmVydCBhbmQgY29t bWEgc2VwYXJhdGVkIGFyZ3MuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9p cmNfY29tbWFuZF91bml0dGVzdC5weTogQWRkIHBhcnNpbmcgdGVzdHMgZm9yIGNvbW1hIHNlcGFy YXRlZCBhcmdzCisgICAgICAgICAgYW5kIGEgZmV3IG90aGVycyBjYXNlcy4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHk6IFZlcmlm eSB0aGF0IHJldmVydCB3b3Jrcy4KKworMjAxMS0wOS0xOSAgRGF2aWQgTGV2aW4gIDxsZXZpbkBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGdlbmVyYXRlcyBib2d1 cyB3YXJuaW5nIGZvciBTdHJ1Y3R1cmVkRXhjZXB0aW9uSGFuZGxlclN1cHJlc3Nvci5oCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODM5MQogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZC5weQppbmRleCBkYWQ1 MTgxYzUwMGIzYjIxYjRkY2Q3YTU2Y2Y1YmNmYTc0M2IxM2JkLi5iZmRiMzQ0NjU3ZjQxMzVlZmE5 NjMxZjljZjdiMzU1ZjVmMGE3YzQzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L2lyY19jb21tYW5kLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9ib3QvaXJjX2NvbW1hbmQucHkKQEAgLTY2LDI2ICs2Niw0MiBAQCBjbGFzcyBSZXN0YXJ0KElS Q0NvbW1hbmQpOgogCiAKIGNsYXNzIFJvbGxvdXQoSVJDQ29tbWFuZCk6CisgICAgZGVmIF9leHRy YWN0X3JldmlzaW9ucyhzZWxmLCBhcmcpOgorCisgICAgICAgIHJldmlzaW9uX2xpc3QgPSBbXQor ICAgICAgICBwb3NzaWJsZV9yZXZpc2lvbnMgPSBhcmcuc3BsaXQoIiwiKQorICAgICAgICBmb3Ig cmV2aXNpb24gaW4gcG9zc2libGVfcmV2aXNpb25zOgorICAgICAgICAgICAgcmV2aXNpb24gPSBy ZXZpc2lvbi5zdHJpcCgpCisgICAgICAgICAgICBpZiBub3QgcmV2aXNpb246CisgICAgICAgICAg ICAgICAgY29udGludWUKKyAgICAgICAgICAgIHJldmlzaW9uID0gcmV2aXNpb24ubHN0cmlwKCJy IikKKyAgICAgICAgICAgICMgSWYgb25lIHBhcnQgb2YgdGhlIGFyZyBpc24ndCBpbiB0aGUgY29y cmVjdCBmb3JtYXQsCisgICAgICAgICAgICAjIHRoZW4gbm9uZSBvZiB0aGUgYXJnIHNob3VsZCBi ZSBjb25zaWRlcmVkIGEgcmV2aXNpb24uCisgICAgICAgICAgICBpZiBub3QgcmV2aXNpb24uaXNk aWdpdCgpOgorICAgICAgICAgICAgICAgIHJldHVybiBOb25lCisgICAgICAgICAgICByZXZpc2lv bl9saXN0LmFwcGVuZChpbnQocmV2aXNpb24pKQorICAgICAgICByZXR1cm4gcmV2aXNpb25fbGlz dAorCiAgICAgZGVmIF9wYXJzZV9hcmdzKHNlbGYsIGFyZ3MpOgogICAgICAgICBpZiBub3QgYXJn czoKICAgICAgICAgICAgIHJldHVybiAoTm9uZSwgTm9uZSkKIAotICAgICAgICAjIHRoZSBmaXJz dCBhcmd1bWVudCBtdXN0IGJlIGEgcmV2aXNpb24gbnVtYmVyCi0gICAgICAgIGZpcnN0X3Jldmlz aW9uID0gYXJnc1swXS5sc3RyaXAoInIiKQotICAgICAgICBpZiBub3QgZmlyc3RfcmV2aXNpb24u aXNkaWdpdCgpOgorICAgICAgICBzdm5fcmV2aXNpb25fbGlzdCA9IFtdCisgICAgICAgIHJlbWFp bmluZ19hcmdzID0gYXJnc1s6XQorICAgICAgICAjIEZpcnN0IHByb2Nlc3MgYWxsIHJldmlzaW9u cy4KKyAgICAgICAgd2hpbGUgcmVtYWluaW5nX2FyZ3M6CisgICAgICAgICAgICBuZXdfcmV2aXNp b25zID0gc2VsZi5fZXh0cmFjdF9yZXZpc2lvbnMocmVtYWluaW5nX2FyZ3NbMF0pCisgICAgICAg ICAgICBpZiBub3QgbmV3X3JldmlzaW9uczoKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAg ICAgICAgc3ZuX3JldmlzaW9uX2xpc3QgKz0gbmV3X3JldmlzaW9ucworICAgICAgICAgICAgcmVt YWluaW5nX2FyZ3MgPSByZW1haW5pbmdfYXJnc1sxOl0KKworICAgICAgICAjIFdhcyB0aGVyZSBh IHJldmlzaW9uIG51bWJlcj8KKyAgICAgICAgaWYgbm90IGxlbihzdm5fcmV2aXNpb25fbGlzdCk6 CiAgICAgICAgICAgICByZXR1cm4gKE5vbmUsIE5vbmUpCiAKLSAgICAgICAgcGFyc2luZ19yZXZp c2lvbiA9IFRydWUKLSAgICAgICAgc3ZuX3JldmlzaW9uX2xpc3QgPSBbaW50KGZpcnN0X3Jldmlz aW9uKV0KLSAgICAgICAgcm9sbG91dF9yZWFzb24gPSBbXQotICAgICAgICBmb3IgYXJnIGluIGFy Z3NbMTpdOgotICAgICAgICAgICAgaWYgYXJnLmxzdHJpcCgiciIpLmlzZGlnaXQoKSBhbmQgcGFy c2luZ19yZXZpc2lvbjoKLSAgICAgICAgICAgICAgICBzdm5fcmV2aXNpb25fbGlzdC5hcHBlbmQo aW50KGFyZy5sc3RyaXAoInIiKSkpCi0gICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAg IHBhcnNpbmdfcmV2aXNpb24gPSBGYWxzZQotICAgICAgICAgICAgICAgIHJvbGxvdXRfcmVhc29u LmFwcGVuZChhcmcpCi0KLSAgICAgICAgcm9sbG91dF9yZWFzb24gPSAiICIuam9pbihyb2xsb3V0 X3JlYXNvbikKKyAgICAgICAgIyBFdmVyeXRoaW5nIGxlZnQgaXMgdGhlIHJlYXNvbi4KKyAgICAg ICAgcm9sbG91dF9yZWFzb24gPSAiICIuam9pbihyZW1haW5pbmdfYXJncykKICAgICAgICAgcmV0 dXJuIHN2bl9yZXZpc2lvbl9saXN0LCByb2xsb3V0X3JlYXNvbgogCiAgICAgZGVmIF9yZXNwb25z aWJsZV9uaWNrbmFtZXNfZnJvbV9yZXZpc2lvbnMoc2VsZiwgdG9vbCwgc2hlcmlmZiwgc3ZuX3Jl dmlzaW9uX2xpc3QpOgpAQCAtMTYxLDcgKzE3Nyw3IEBAIGNsYXNzIFJvbGxDaHJvbWl1bURFUFMo SVJDQ29tbWFuZCk6CiAKIGNsYXNzIEhlbHAoSVJDQ29tbWFuZCk6CiAgICAgZGVmIGV4ZWN1dGUo c2VsZiwgbmljaywgYXJncywgdG9vbCwgc2hlcmlmZik6Ci0gICAgICAgIHJldHVybiAiJXM6IEF2 YWlsYWJsZSBjb21tYW5kczogJXMiICUgKG5pY2ssICIsICIuam9pbihzb3J0ZWQoY29tbWFuZHMu a2V5cygpKSkpCisgICAgICAgIHJldHVybiAiJXM6IEF2YWlsYWJsZSBjb21tYW5kczogJXMiICUg KG5pY2ssICIsICIuam9pbihzb3J0ZWQodmlzaWJsZV9jb21tYW5kcy5rZXlzKCkpKSkKIAogCiBj bGFzcyBIaShJUkNDb21tYW5kKToKQEAgLTIzNSw3ICsyNTEsNyBAQCBjbGFzcyBDcmVhdGVCdWco SVJDQ29tbWFuZCk6CiAKIAogIyBGSVhNRTogTGFtZS4gIFdlIHNob3VsZCBoYXZlIGFuIGF1dG8t cmVnaXN0ZXJpbmcgQ29tbWFuZENlbnRlci4KLWNvbW1hbmRzID0gewordmlzaWJsZV9jb21tYW5k cyA9IHsKICAgICAiaGVscCI6IEhlbHAsCiAgICAgImhpIjogSGksCiAgICAgImxhc3QtZ3JlZW4t cmV2aXNpb24iOiBMYXN0R3JlZW5SZXZpc2lvbiwKQEAgLTI0NSwzICsyNjEsMTAgQEAgY29tbWFu ZHMgPSB7CiAgICAgImNyZWF0ZS1idWciOiBDcmVhdGVCdWcsCiAgICAgInJvbGwtY2hyb21pdW0t ZGVwcyI6IFJvbGxDaHJvbWl1bURFUFMsCiB9CisKKyMgQWRkIHJldmVydCBhcyBhbiAiZWFzdGVy IGVnZyIgY29tbWFuZC4gV2h5PworIyByZXZlcnQgaXMgdGhlIHNhbWUgYXMgcm9sbG91dCBhbmQg aXQgd291bGQgYmUgY29uZnVzaW5nIHRvIGxpc3QgYm90aCB3aGVuCisjIHRoZXkgZG8gdGhlIHNh bWUgdGhpbmcuIEhvd2V2ZXIsIHRoaXMgY29tbWFuZCBpcyBhIHZlcnkgbmF0dXJhbCB0aGluZyBm b3IKKyMgcGVvcGxlIHRvIHVzZSBhbmQgaXQgc2VlbXMgc2lsbHkgdG8gaGF2ZSB0aGVtIGh1bnQg YXJvdW5kIGZvciAicm9sbG91dCIgaW5zdGVhZC4KK2NvbW1hbmRzID0gdmlzaWJsZV9jb21tYW5k cy5jb3B5KCkKK2NvbW1hbmRzWyJyZXZlcnQiXSA9IFJvbGxvdXQKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmRfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L2lyY19jb21tYW5kX3VuaXR0ZXN0LnB5CmluZGV4 IDU3MzZmNGU5Y2ZlNmRjZWVhZTIwMzc3ZmM0ZGYxODY4NjNjMTA4NmUuLjViZGRjZGYzOWJhMTNl M2NkYzQ0NDAxMThkMjFiZDFiZTExMzUxMDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9ib3QvaXJjX2NvbW1hbmRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL2JvdC9pcmNfY29tbWFuZF91bml0dGVzdC5weQpAQCAtOTgsNiArOTgs MTggQEAgY2xhc3MgSVJDQ29tbWFuZFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBz ZWxmLmFzc2VydEVxdWFscygoWzEyMzRdLCAidGVzdGluZyBmb28iKSwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgcm9sbG91dC5fcGFyc2VfYXJncyhbIjEyMzQiLCAidGVzdGluZyIsICJmb28i XSkpCiAKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoKFs1NTRdLCAidGVzdGluZyBmb28iKSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgcm9sbG91dC5fcGFyc2VfYXJncyhbInI1NTQiLCAi dGVzdGluZyIsICJmb28iXSkpCisKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoKFs1NTYsIDc5 Ml0sICJ0ZXN0aW5nIGZvbyIpLAorICAgICAgICAgICAgICAgICAgICAgICAgICByb2xsb3V0Ll9w YXJzZV9hcmdzKFsicjU1NiIsICI3OTIiLCAidGVzdGluZyIsICJmb28iXSkpCisKKyAgICAgICAg c2VsZi5hc3NlcnRFcXVhbHMoKFsxMjgsIDI1Nl0sICJ0ZXN0aW5nIGZvbyIpLAorICAgICAgICAg ICAgICAgICAgICAgICAgICByb2xsb3V0Ll9wYXJzZV9hcmdzKFsicjEyOCxyMjU2IiwgInRlc3Rp bmciLCAiZm9vIl0pKQorCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKChbNTEyLCAxMDI0LCAy MDQ4XSwgInRlc3RpbmcgZm9vIiksCisgICAgICAgICAgICAgICAgICAgICAgICAgIHJvbGxvdXQu X3BhcnNlX2FyZ3MoWyI1MTIsIDEwMjQsMjA0OCIsICJ0ZXN0aW5nIiwgImZvbyJdKSkKKwogICAg ICAgICAjIFRlc3QgaW52YWxpZCBhcmd1bWVudCBwYXJzaW5nOgogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscygoTm9uZSwgTm9uZSksIHJvbGxvdXQuX3BhcnNlX2FyZ3MoW10pKQogICAgICAgICBz ZWxmLmFzc2VydEVxdWFscygoTm9uZSwgTm9uZSksIHJvbGxvdXQuX3BhcnNlX2FyZ3MoWyItLWJh ciIsICIxMjM0Il0pKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Jv dC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2JvdC9zaGVyaWZmaXJjYm90X3VuaXR0ZXN0LnB5CmluZGV4IGMwYmM5OTI2OTM5NGE1MTFmYjgy ZTFlNWZkOTE3MGMwMTMxNjhiNmMuLmQxZjVmNjYyYWIyNjZmMDU0ZTRiN2RjMDMwODQ2ZDE5MmY3 NmIzZGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qvc2hlcmlm ZmlyY2JvdF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90 L3NoZXJpZmZpcmNib3RfdW5pdHRlc3QucHkKQEAgLTk3LDYgKzk3LDEwIEBAIGNsYXNzIFNoZXJp ZmZJUkNCb3RUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgZXhwZWN0ZWRfc3RkZXJy ID0gIk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2ssIGFiYXJ0aCwgZGFyaW4sIGVzZWlkZWw6IFBy ZXBhcmluZyByb2xsb3V0IGZvciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yMTY1 NC4uLlxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljaywgYWJhcnRoLCBkYXJpbiwgZXNlaWRlbDog Q3JlYXRlZCByb2xsb3V0OiBodHRwOi8vZXhhbXBsZS5jb20vMzY5MzZcbiIKICAgICAgICAgT3V0 cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJvbGxvdXQgMjE2 NTQgVGhpcyBwYXRjaCBicm9rZSB0aGUgd29ybGQiXSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVk X3N0ZGVycikKIAorICAgIGRlZiB0ZXN0X3JldmVydChzZWxmKToKKyAgICAgICAgZXhwZWN0ZWRf c3RkZXJyID0gIk1PQ0s6IGlyYy5wb3N0OiBtb2NrX25pY2ssIGFiYXJ0aCwgZGFyaW4sIGVzZWlk ZWw6IFByZXBhcmluZyByb2xsb3V0IGZvciBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNl dC8yMTY1NC4uLlxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljaywgYWJhcnRoLCBkYXJpbiwgZXNl aWRlbDogQ3JlYXRlZCByb2xsb3V0OiBodHRwOi8vZXhhbXBsZS5jb20vMzY5MzZcbiIKKyAgICAg ICAgT3V0cHV0Q2FwdHVyZSgpLmFzc2VydF9vdXRwdXRzKHNlbGYsIHJ1biwgYXJncz1bInJldmVy dCAyMTY1NCBUaGlzIHBhdGNoIGJyb2tlIHRoZSB3b3JsZCJdLCBleHBlY3RlZF9zdGRlcnI9ZXhw ZWN0ZWRfc3RkZXJyKQorCiAgICAgZGVmIHRlc3Rfcm9sbF9jaHJvbWl1bV9kZXBzKHNlbGYpOgog ICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazogUm9s bGluZyBDaHJvbWl1bSBERVBTIHRvIHIyMTY1NFxuTU9DSzogaXJjLnBvc3Q6IG1vY2tfbmljazog Q3JlYXRlZCBERVBTIHJvbGw6IGh0dHA6Ly9leGFtcGxlLmNvbS8zNjkzNlxuIgogICAgICAgICBP dXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgcnVuLCBhcmdzPVsicm9sbC1jaHJv bWl1bS1kZXBzIDIxNjU0Il0sIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCg==