68399 2011-09-19 15:19:34 -0700 Changelog class should have a method to return all entries 2011-09-20 09:44:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68115 1 leandro leandro eric rniwa webkit.review.bot oldest_to_newest 469724 0 leandro 2011-09-19 15:19:34 -0700 Changelog class should have a method to return all entries 469734 1 107929 leandro 2011-09-19 15:24:41 -0700 Created attachment 107929 Patch 469735 2 leandro 2011-09-19 15:25:20 -0700 CC'ing Ryosuke Niwa. 469915 3 107929 rniwa 2011-09-19 21:55:37 -0700 Comment on attachment 107929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107929&action=review > Tools/ChangeLog:7 > + Implement ChangeLog.parse_entries_from_file(). This method returns a > + generator of ChangeLogEntry objects, ordered from the latest to the Can you put generator on the previous line? It seems odd to end a line with an article. > Tools/ChangeLog:15 > + * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test > + case. Seems like you can hit the entire thing in one line. > Tools/Scripts/webkitpy/common/checkout/changelog.py:171 > + # If we've hit the next entry, return. Nit: We don't return here, right? 470112 4 107929 leandro 2011-09-20 09:30:35 -0700 Comment on attachment 107929 Patch Forgot to submit a new patch taking care of rniwa's comments. 470113 5 108011 leandro 2011-09-20 09:32:33 -0700 Created attachment 108011 Patch 470121 6 108011 webkit.review.bot 2011-09-20 09:44:39 -0700 Comment on attachment 108011 Patch Clearing flags on attachment: 108011 Committed r95549: <http://trac.webkit.org/changeset/95549> 470122 7 webkit.review.bot 2011-09-20 09:44:45 -0700 All reviewed patches have been landed. Closing bug. 107929 2011-09-19 15:24:41 -0700 2011-09-20 09:32:26 -0700 Patch bug-68399-20110919192439.patch text/plain 3751 leandro SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1NDgxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDktMTkgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9u Lm1vYmk+CisKKyAgICAgICAgQ2hhbmdlbG9nIGNsYXNzIHNob3VsZCBoYXZlIGEgbWV0aG9kIHRv IHJldHVybiBhbGwgZW50cmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjgzOTkKKyAgICAgICAgCisgICAgICAgIEltcGxlbWVudCBDaGFuZ2VMb2cu cGFyc2VfZW50cmllc19mcm9tX2ZpbGUoKS4gVGhpcyBtZXRob2QgcmV0dXJucyBhCisgICAgICAg IGdlbmVyYXRvciBvZiBDaGFuZ2VMb2dFbnRyeSBvYmplY3RzLCBvcmRlcmVkIGZyb20gdGhlIGxh dGVzdCB0byB0aGUKKyAgICAgICAgb2xkZXN0IGVudHJ5IGluIHRoZSBmaWxlLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nLnB5OiBDb3B5CisgICAgICAgIHBhcnNlX2xhdGVz dF9lbnRyeV9mcm9tX2ZpbGUoKSBhbmQgYWRhcHQgaXQgdG8gYmVjb21lIGEgZ2VuZXJhdG9yLgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0 dGVzdC5weTogQWRkIHRlc3QKKyAgICAgICAgY2FzZS4KKwogMjAxMS0wOS0xOSAgQWxleGlzIE1l bmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBTdHlsZSBjaGVj a2VyIHNob3VsZCBub3QgY2hlY2sgcHVibGljIFF0IFdLMiBBUEkgZm9yIHBhcmFtZXRlcl9uYW1l LgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9n LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0 L2NoYW5nZWxvZy5weQkocmV2aXNpb24gOTU0MzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2cucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1Miw2ICsx NTIsMjkgQEAgY2xhc3MgQ2hhbmdlTG9nKG9iamVjdCk6CiAgICAgICAgICAgICBlbnRyeV9saW5l cy5hcHBlbmQobGluZSkKICAgICAgICAgcmV0dXJuIE5vbmUgIyBXZSBuZXZlciBmb3VuZCBhIGRh dGUgbGluZSEKIAorICAgIEBzdGF0aWNtZXRob2QKKyAgICBkZWYgcGFyc2VfZW50cmllc19mcm9t X2ZpbGUoY2hhbmdlbG9nX2ZpbGUpOgorICAgICAgICAiIiJjaGFuZ2Vsb2dfZmlsZSBtdXN0IGJl IGEgZmlsZS1saWtlIG9iamVjdCB3aGljaCByZXR1cm5zCisgICAgICAgIHVuaWNvZGUgc3RyaW5n cy4gIFVzZSBjb2RlY3Mub3BlbiBvciBTdHJpbmdJTyh1bmljb2RlKCkpCisgICAgICAgIHRvIHBh c3MgZmlsZSBvYmplY3RzIHRvIHRoaXMgY2xhc3MuIiIiCisgICAgICAgIGRhdGVfbGluZV9yZWdl eHAgPSByZS5jb21waWxlKENoYW5nZUxvZ0VudHJ5LmRhdGVfbGluZV9yZWdleHApCisgICAgICAg IHJvbGxlZF9vdmVyX3JlZ2V4cCA9IHJlLmNvbXBpbGUoQ2hhbmdlTG9nRW50cnkucm9sbGVkX292 ZXJfcmVnZXhwKQorICAgICAgICBlbnRyeV9saW5lcyA9IFtdCisgICAgICAgICMgVGhlIGZpcnN0 IGxpbmUgc2hvdWxkIGJlIGEgZGF0ZSBsaW5lLgorICAgICAgICBmaXJzdF9saW5lID0gY2hhbmdl bG9nX2ZpbGUucmVhZGxpbmUoKQorICAgICAgICBhc3NlcnQoaXNpbnN0YW5jZShmaXJzdF9saW5l LCB1bmljb2RlKSkKKyAgICAgICAgaWYgbm90IGRhdGVfbGluZV9yZWdleHAubWF0Y2goZmlyc3Rf bGluZSk6CisgICAgICAgICAgICByYWlzZSBTdG9wSXRlcmF0aW9uCisgICAgICAgIGVudHJ5X2xp bmVzLmFwcGVuZChmaXJzdF9saW5lKQorCisgICAgICAgIGZvciBsaW5lIGluIGNoYW5nZWxvZ19m aWxlOgorICAgICAgICAgICAgIyBJZiB3ZSd2ZSBoaXQgdGhlIG5leHQgZW50cnksIHJldHVybi4K KyAgICAgICAgICAgIGlmIGRhdGVfbGluZV9yZWdleHAubWF0Y2gobGluZSkgb3Igcm9sbGVkX292 ZXJfcmVnZXhwLm1hdGNoKGxpbmUpOgorICAgICAgICAgICAgICAgICMgUmVtb3ZlIHRoZSBleHRy YSBuZXdsaW5lIGF0IHRoZSBlbmQKKyAgICAgICAgICAgICAgICB5aWVsZCBDaGFuZ2VMb2dFbnRy eSgnJy5qb2luKGVudHJ5X2xpbmVzWzotMV0pKQorICAgICAgICAgICAgICAgIGVudHJ5X2xpbmVz ID0gW10KKyAgICAgICAgICAgIGVudHJ5X2xpbmVzLmFwcGVuZChsaW5lKQorCiAgICAgZGVmIGxh dGVzdF9lbnRyeShzZWxmKToKICAgICAgICAgIyBDaGFuZ2VMb2cgZmlsZXMgYXJlIGFsd2F5cyBV VEYtOCwgd2UgcmVhZCB0aGVtIGluIGFzIHN1Y2ggdG8gc3VwcG9ydCBSZXZpZXdlcnMgd2l0aCB1 bmljb2RlIGluIHRoZWlyIG5hbWVzLgogICAgICAgICBjaGFuZ2Vsb2dfZmlsZSA9IGNvZGVjcy5v cGVuKHNlbGYucGF0aCwgInIiLCAidXRmLTgiKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vY2hlY2tvdXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0dGVzdC5w eQkocmV2aXNpb24gOTU0MzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVj a291dC9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1Myw2ICsxNTMs MTMgQEAgY2xhc3MgQ2hhbmdlTG9nVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbHMoNTczNTQsIHBhcnNlX2J1Z19pZF9mcm9tX2NoYW5nZWxvZyhjb21t aXRfdGV4dCkpCiAKKyAgICBkZWYgdGVzdF9wYXJzZV9sb2dfZW50cmllc19mcm9tX2NoYW5nZWxv ZyhzZWxmKToKKyAgICAgICAgcGFyc2VkX2VudHJpZXMgPSBsaXN0KENoYW5nZUxvZy5wYXJzZV9l bnRyaWVzX2Zyb21fY2hhbmdlbG9nKENoYW5nZUxvZ1Rlc3QuX2V4YW1wbGVfY2hhbmdlbG9nKSkK KyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMobGVuKHBhcnNlZF9lbnRyaWVzKSwgMykKKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbHMocGFyc2VkX2VudHJpZXNbMF0ucmV2aWV3ZXIoKSwgJ0Rhdmlk IExldmluJykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocGFyc2VkX2VudHJpZXNbMV0uYXV0 aG9yX2VtYWlsKCksICdkZGtpbHplckBhcHBsZS5jb20nKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhwYXJzZWRfZW50cmllc1syXS50b3VjaGVkX2ZpbGVzKCksIFsnRHVtcFJlbmRlclRyZWUv bWFjL0R1bXBSZW5kZXJUcmVlV2luZG93Lm1tJ10pCisKICAgICBkZWYgdGVzdF9sYXRlc3RfZW50 cnlfcGFyc2Uoc2VsZik6CiAgICAgICAgIGNoYW5nZWxvZ19jb250ZW50cyA9IHUiJXNcbiVzIiAl IChzZWxmLl9leGFtcGxlX2VudHJ5LCBzZWxmLl9leGFtcGxlX2NoYW5nZWxvZykKICAgICAgICAg Y2hhbmdlbG9nX2ZpbGUgPSBTdHJpbmdJTyhjaGFuZ2Vsb2dfY29udGVudHMpCg== 108011 2011-09-20 09:32:33 -0700 2011-09-20 09:44:39 -0700 Patch bug-68399-20110920133231.patch text/plain 3679 leandro SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1NDgxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDktMTkgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9u Lm1vYmk+CisKKyAgICAgICAgQ2hhbmdlbG9nIGNsYXNzIHNob3VsZCBoYXZlIGEgbWV0aG9kIHRv IHJldHVybiBhbGwgZW50cmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjgzOTkKKyAgICAgICAgCisgICAgICAgIEltcGxlbWVudCBDaGFuZ2VMb2cu cGFyc2VfZW50cmllc19mcm9tX2ZpbGUoKS4gVGhpcyBtZXRob2QgcmV0dXJucyBhIGdlbmVyYXRv cgorICAgICAgICBvZiBDaGFuZ2VMb2dFbnRyeSBvYmplY3RzLCBvcmRlcmVkIGZyb20gdGhlIGxh dGVzdCB0byB0aGUgb2xkZXN0IGVudHJ5IGluIHRoZSBmaWxlLgorCisgICAgICAgIFJldmlld2Vk IGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2No ZWNrb3V0L2NoYW5nZWxvZy5weTogQ29weSBwYXJzZV9sYXRlc3RfZW50cnlfZnJvbV9maWxlKCkK KyAgICAgICAgYW5kIGFkYXB0IGl0IHRvIGJlY29tZSBhIGdlbmVyYXRvci4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2dfdW5pdHRlc3QucHk6IEFk ZCB0ZXN0IGNhc2UuCisKIDIwMTEtMDktMTkgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJk QG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgU3R5bGUgY2hlY2tlciBzaG91bGQgbm90IGNoZWNr IHB1YmxpYyBRdCBXSzIgQVBJIGZvciBwYXJhbWV0ZXJfbmFtZS4KSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZy5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2cucHkJKHJldmlz aW9uIDk1NDMxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvY2hh bmdlbG9nLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNTIsNiArMTUyLDI4IEBAIGNsYXNzIENoYW5n ZUxvZyhvYmplY3QpOgogICAgICAgICAgICAgZW50cnlfbGluZXMuYXBwZW5kKGxpbmUpCiAgICAg ICAgIHJldHVybiBOb25lICMgV2UgbmV2ZXIgZm91bmQgYSBkYXRlIGxpbmUhCiAKKyAgICBAc3Rh dGljbWV0aG9kCisgICAgZGVmIHBhcnNlX2VudHJpZXNfZnJvbV9maWxlKGNoYW5nZWxvZ19maWxl KToKKyAgICAgICAgIiIiY2hhbmdlbG9nX2ZpbGUgbXVzdCBiZSBhIGZpbGUtbGlrZSBvYmplY3Qg d2hpY2ggcmV0dXJucworICAgICAgICB1bmljb2RlIHN0cmluZ3MuICBVc2UgY29kZWNzLm9wZW4g b3IgU3RyaW5nSU8odW5pY29kZSgpKQorICAgICAgICB0byBwYXNzIGZpbGUgb2JqZWN0cyB0byB0 aGlzIGNsYXNzLiIiIgorICAgICAgICBkYXRlX2xpbmVfcmVnZXhwID0gcmUuY29tcGlsZShDaGFu Z2VMb2dFbnRyeS5kYXRlX2xpbmVfcmVnZXhwKQorICAgICAgICByb2xsZWRfb3Zlcl9yZWdleHAg PSByZS5jb21waWxlKENoYW5nZUxvZ0VudHJ5LnJvbGxlZF9vdmVyX3JlZ2V4cCkKKyAgICAgICAg ZW50cnlfbGluZXMgPSBbXQorICAgICAgICAjIFRoZSBmaXJzdCBsaW5lIHNob3VsZCBiZSBhIGRh dGUgbGluZS4KKyAgICAgICAgZmlyc3RfbGluZSA9IGNoYW5nZWxvZ19maWxlLnJlYWRsaW5lKCkK KyAgICAgICAgYXNzZXJ0KGlzaW5zdGFuY2UoZmlyc3RfbGluZSwgdW5pY29kZSkpCisgICAgICAg IGlmIG5vdCBkYXRlX2xpbmVfcmVnZXhwLm1hdGNoKGZpcnN0X2xpbmUpOgorICAgICAgICAgICAg cmFpc2UgU3RvcEl0ZXJhdGlvbgorICAgICAgICBlbnRyeV9saW5lcy5hcHBlbmQoZmlyc3RfbGlu ZSkKKworICAgICAgICBmb3IgbGluZSBpbiBjaGFuZ2Vsb2dfZmlsZToKKyAgICAgICAgICAgIGlm IGRhdGVfbGluZV9yZWdleHAubWF0Y2gobGluZSkgb3Igcm9sbGVkX292ZXJfcmVnZXhwLm1hdGNo KGxpbmUpOgorICAgICAgICAgICAgICAgICMgUmVtb3ZlIHRoZSBleHRyYSBuZXdsaW5lIGF0IHRo ZSBlbmQKKyAgICAgICAgICAgICAgICB5aWVsZCBDaGFuZ2VMb2dFbnRyeSgnJy5qb2luKGVudHJ5 X2xpbmVzWzotMV0pKQorICAgICAgICAgICAgICAgIGVudHJ5X2xpbmVzID0gW10KKyAgICAgICAg ICAgIGVudHJ5X2xpbmVzLmFwcGVuZChsaW5lKQorCiAgICAgZGVmIGxhdGVzdF9lbnRyeShzZWxm KToKICAgICAgICAgIyBDaGFuZ2VMb2cgZmlsZXMgYXJlIGFsd2F5cyBVVEYtOCwgd2UgcmVhZCB0 aGVtIGluIGFzIHN1Y2ggdG8gc3VwcG9ydCBSZXZpZXdlcnMgd2l0aCB1bmljb2RlIGluIHRoZWly IG5hbWVzLgogICAgICAgICBjaGFuZ2Vsb2dfZmlsZSA9IGNvZGVjcy5vcGVuKHNlbGYucGF0aCwg InIiLCAidXRmLTgiKQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NoZWNrb3V0L2NoYW5nZWxvZ191bml0dGVzdC5weQkocmV2aXNpb24gOTU0 MzEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9jaGFuZ2Vsb2df dW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1Myw2ICsxNTMsMTMgQEAgY2xhc3MgQ2hh bmdlTG9nVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bHMoNTczNTQsIHBhcnNlX2J1Z19pZF9mcm9tX2NoYW5nZWxvZyhjb21taXRfdGV4dCkpCiAKKyAg ICBkZWYgdGVzdF9wYXJzZV9sb2dfZW50cmllc19mcm9tX2NoYW5nZWxvZyhzZWxmKToKKyAgICAg ICAgcGFyc2VkX2VudHJpZXMgPSBsaXN0KENoYW5nZUxvZy5wYXJzZV9lbnRyaWVzX2Zyb21fY2hh bmdlbG9nKENoYW5nZUxvZ1Rlc3QuX2V4YW1wbGVfY2hhbmdlbG9nKSkKKyAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMobGVuKHBhcnNlZF9lbnRyaWVzKSwgMykKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbHMocGFyc2VkX2VudHJpZXNbMF0ucmV2aWV3ZXIoKSwgJ0RhdmlkIExldmluJykKKyAgICAg ICAgc2VsZi5hc3NlcnRFcXVhbHMocGFyc2VkX2VudHJpZXNbMV0uYXV0aG9yX2VtYWlsKCksICdk ZGtpbHplckBhcHBsZS5jb20nKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhwYXJzZWRfZW50 cmllc1syXS50b3VjaGVkX2ZpbGVzKCksIFsnRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJU cmVlV2luZG93Lm1tJ10pCisKICAgICBkZWYgdGVzdF9sYXRlc3RfZW50cnlfcGFyc2Uoc2VsZik6 CiAgICAgICAgIGNoYW5nZWxvZ19jb250ZW50cyA9IHUiJXNcbiVzIiAlIChzZWxmLl9leGFtcGxl X2VudHJ5LCBzZWxmLl9leGFtcGxlX2NoYW5nZWxvZykKICAgICAgICAgY2hhbmdlbG9nX2ZpbGUg PSBTdHJpbmdJTyhjaGFuZ2Vsb2dfY29udGVudHMpCg==