68398 2011-09-19 15:17:18 -0700 Need to specify a django version, instead of using default 2011-09-20 17:33:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tomz tomz abarth eric webkit.review.bot oldest_to_newest 469723 0 tomz 2011-09-19 15:17:18 -0700 When running test-webkit-scripts, we get the following warning: WARNING You are using the default Django version (0.96). The default Django version will change in an App Engine release in the near future. Please call use_library() to explicitly select a Django version. For more information see http://code.google.com/appengine/docs/python/tools/libraries.html#Django. I tracked this to QueueStatusServer/handlers/queuestatus.py. We need to explicitly use a library version. 1.2 is suggested on at code.google.com. I re-tested test-webkit-scripts using 1.2 explicitly and all seems well, so I'm specifying it. It seems like there are other scripts not specifying this explicitly, but I'm not seeing the warning anywhere else yet. I'm going to audit the other scripts using django and/or appengine and follow up. 469731 1 107927 tomz 2011-09-19 15:22:51 -0700 Created attachment 107927 Patch 469739 2 abarth 2011-09-19 15:27:47 -0700 Looks reasonably, but Eric should review this patch. 469755 3 107927 eric 2011-09-19 15:45:26 -0700 Comment on attachment 107927 Patch We already specify one, just in main.py The problem is that when we are unittesting things we load the __init__.py instead of main.py like appengine does. We shoul dadd this to __init__.py intead (since it's only really for unittesting), and add a comment that it needs to stay in sync with the one in main.py. 469784 4 107939 tomz 2011-09-19 16:18:08 -0700 Created attachment 107939 Patch 469802 5 107939 eric 2011-09-19 16:43:46 -0700 Comment on attachment 107939 Patch I guess I wasn't aware that 1.2 was even available. :) I assume you ran the server locally and things didn't barf? 469912 6 107939 tomz 2011-09-19 21:48:43 -0700 Comment on attachment 107939 Patch cq- since i want to do some additional testing recommended by Eric. 470500 7 107939 webkit.review.bot 2011-09-20 17:33:46 -0700 Comment on attachment 107939 Patch Clearing flags on attachment: 107939 Committed r95587: <http://trac.webkit.org/changeset/95587> 470501 8 webkit.review.bot 2011-09-20 17:33:51 -0700 All reviewed patches have been landed. Closing bug. 107927 2011-09-19 15:22:51 -0700 2011-09-19 16:18:05 -0700 Patch bug-68398-20110919152247.patch text/plain 1221 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0NTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNzk5YmJkMmVhNGJiOGFhN2JmZDY1YTA1OTE5Y2JlNmRj YzJkNzYwLi45MTIwYWRkZGFhNmZiN2Y3ODhiN2E4YTVhMTQ1YmQyYzExYTEyOTM5IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMTkgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIE5lZWQgdG8gc3BlY2lmeSBhIGRqYW5nbyB2ZXJzaW9uLCBpbnN0ZWFkIG9mIHVzaW5n IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY4Mzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBRdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weToKKwogMjAxMS0wOS0x OSAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAg ICBTdHlsZSBjaGVja2VyIHNob3VsZCBub3QgY2hlY2sgcHVibGljIFF0IFdLMiBBUEkgZm9yIHBh cmFtZXRlcl9uYW1lLgpkaWZmIC0tZ2l0IGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxl cnMvcXVldWVzdGF0dXMucHkgYi9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1 ZXN0YXR1cy5weQppbmRleCA5MDU0ZmNhYjFiNmQxODZkODY5ZDNiY2E1OWU2YmMyZjMzZjdiNzZi Li4wYzNmZWZlMDkzMDJlZWNlMzcxODFmZWQyY2ZhYzJmYzdmOWYxYjEyIDEwMDY0NAotLS0gYS9U b29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weQorKysgYi9Ub29s cy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9xdWV1ZXN0YXR1cy5weQpAQCAtMjksNiArMjks MTAgQEAKIGltcG9ydCBkYXRldGltZQogaW1wb3J0IGl0ZXJ0b29scwogCisjIFJlcXVlc3QgYSBz cGVjaWZpYyBEamFuZ28gdmVyc2lvbgorZnJvbSBnb29nbGUuYXBwZW5naW5lLmRpc3QgaW1wb3J0 IHVzZV9saWJyYXJ5Cit1c2VfbGlicmFyeSgnZGphbmdvJywgJzEuMicpCisKIGZyb20gZ29vZ2xl LmFwcGVuZ2luZS5leHQgaW1wb3J0IHdlYmFwcAogZnJvbSBnb29nbGUuYXBwZW5naW5lLmV4dC53 ZWJhcHAgaW1wb3J0IHRlbXBsYXRlCiAK 107939 2011-09-19 16:18:08 -0700 2011-09-20 17:33:46 -0700 Patch bug-68398-20110919161805.patch text/plain 1777 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0NTEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNzk5YmJkMmVhNGJiOGFhN2JmZDY1YTA1OTE5Y2JlNmRj YzJkNzYwLi5kMjFhYTZhNWE1NDkxZjhiODRkMjNlYzY4NjNlZGQzZDAzOTJjNDQwIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDktMTkgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIE5lZWQgdG8gc3BlY2lmeSBhIGRqYW5nbyB2ZXJzaW9uLCBpbnN0ZWFkIG9mIHVzaW5n IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY4Mzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBRdWV1ZVN0YXR1c1NlcnZlci9fX2luaXRfXy5weToKKyAgICAgICAgKiBRdWV1ZVN0YXR1c1Nl cnZlci9tYWluLnB5OgorCiAyMDExLTA5LTE5ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFy ZEBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFN0eWxlIGNoZWNrZXIgc2hvdWxkIG5vdCBjaGVj ayBwdWJsaWMgUXQgV0syIEFQSSBmb3IgcGFyYW1ldGVyX25hbWUuCmRpZmYgLS1naXQgYS9Ub29s cy9RdWV1ZVN0YXR1c1NlcnZlci9fX2luaXRfXy5weSBiL1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVy L19faW5pdF9fLnB5CmluZGV4IDIzNDZjMjM3OGRjYmM4NDgwZGU4OTViYzM2NjI0NGJkNjZiZTYz OTcuLjU3OTdkMmRkZjBhMDY1MjJiZDY2MWI5NjE1MTJjYTAyNWMwM2FiODkgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL19faW5pdF9fLnB5CisrKyBiL1Rvb2xzL1F1ZXVlU3Rh dHVzU2VydmVyL19faW5pdF9fLnB5CkBAIC02LDYgKzYsOSBAQAogIyBNYWtlIHN1cmUgdGhhdCB0 aGlzIG1vZHVsZSB3aWxsIGxvYWQgaW4gdGhhdCBjYXNlIGJ5IGluY2x1ZGluZyBwYXRocyB0bwog IyB0aGUgZGVmYXVsdCBHb29nbGUgQXBwRW5naW5lIGluc3RhbGwuCiAKKyMgUmVxdWVzdCBhIG1v ZGVybiBEamFuZ28KK2Zyb20gZ29vZ2xlLmFwcGVuZ2luZS5kaXN0IGltcG9ydCB1c2VfbGlicmFy eQordXNlX2xpYnJhcnkoJ2RqYW5nbycsICcxLjInKSAgIyBNdXN0IGFncmVlIHdpdGggbWFpbi5w eSEKIAogZGVmIGZpeF9zeXNfcGF0aCgpOgogICAgIGltcG9ydCBzeXMKZGlmZiAtLWdpdCBhL1Rv b2xzL1F1ZXVlU3RhdHVzU2VydmVyL21haW4ucHkgYi9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9t YWluLnB5CmluZGV4IDQ2NTY0NmUxOWUwOTNhZjJiMmY2YjQ2YzVkOGE3MzVlYjFhMzYwN2YuLmUx MTU1ZmZhNmYwMDhiMjkwMGU3OTFmNDUyMWVlODIyMTQ2ZWVkZWEgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1F1ZXVlU3RhdHVzU2VydmVyL21haW4ucHkKKysrIGIvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIv bWFpbi5weQpAQCAtMjgsNyArMjgsNyBAQAogCiAjIFJlcXVlc3QgYSBtb2Rlcm4gRGphbmdvCiBm cm9tIGdvb2dsZS5hcHBlbmdpbmUuZGlzdCBpbXBvcnQgdXNlX2xpYnJhcnkKLXVzZV9saWJyYXJ5 KCdkamFuZ28nLCAnMS4xJykKK3VzZV9saWJyYXJ5KCdkamFuZ28nLCAnMS4yJykgICMgTXVzdCBh Z3JlZSB3aXRoIF9faW5pdC5weV9fCiAKIGZyb20gZ29vZ2xlLmFwcGVuZ2luZS5leHQgaW1wb3J0 IHdlYmFwcAogZnJvbSBnb29nbGUuYXBwZW5naW5lLmV4dC53ZWJhcHAudXRpbCBpbXBvcnQgcnVu X3dzZ2lfYXBwCg==