68391 2011-09-19 14:37:00 -0700 check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h 2011-09-19 17:41:13 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarrin levin levin webkit.review.bot oldest_to_newest 469693 0 cmarrin 2011-09-19 14:37:00 -0700 Style checking generates: Source/WebCore/platform/win/StructuredExceptionHandlerSupressor.h:52: Extra space before [ [whitespace/braces] [5] for this line: __asm mov [registration], eax Seems like it doesn't understand Windows assembly well enough. 469727 1 levin 2011-09-19 15:21:33 -0700 *** Bug 68400 has been marked as a duplicate of this bug. *** 469732 2 107928 levin 2011-09-19 15:23:28 -0700 Created attachment 107928 Patch 469813 3 107928 webkit.review.bot 2011-09-19 17:06:47 -0700 Comment on attachment 107928 Patch Rejecting attachment 107928 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: 9120b8ae0fc3dfd55045dd4b0a6061b6b9f6c511 r95496 = 6c67a85488c37041218b7b672434107e57743c3b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9772042 469814 4 levin 2011-09-19 17:08:21 -0700 Whoops. I got too used to gardening and deleted the Reviewed by line. :( Will commit by hand. 469824 5 levin 2011-09-19 17:41:13 -0700 Committed as http://trac.webkit.org/changeset/95499 107928 2011-09-19 15:23:28 -0700 2011-09-19 17:06:47 -0700 Patch bug-68391-20110919152327.patch text/plain 2343 levin U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0NzIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNzk5YmJkMmVhNGJiOGFhN2JmZDY1YTA1OTE5Y2JlNmRj YzJkNzYwLi40YjkwYWEwODllMzk3YzI4ZTI1YjU2Mjc1ZGIxOWI5ZTU5YzAyMjVkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEg QEAKKzIwMTEtMDktMTkgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBnZW5lcmF0ZXMgYm9ndXMgd2FybmluZyBmb3IgU3RydWN0 dXJlZEV4Y2VwdGlvbkhhbmRsZXJTdXByZXNzb3IuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgzOTEKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OiBTa2lwIF9fYXNtIGxpbmVzIHdoZW4gZG9pbmcgc3R5 bGUgY2hlY2tzIG9uIGEgbGluZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weTogQWRkZWQgYSB0ZXN0IGZvciB0aGlzLgorCiAyMDExLTA5 LTE5ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCiAgICAg ICAgIFN0eWxlIGNoZWNrZXIgc2hvdWxkIG5vdCBjaGVjayBwdWJsaWMgUXQgV0syIEFQSSBmb3Ig cGFyYW1ldGVyX25hbWUuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CmluZGV4IDdkZWQ1YjE3OWRlOGU2MjIxN2ZjNGQyMzU1ODFiZGQ0Nzk3NTQ2ZjEuLjUy ZmZhZTM2NTkwZTkyMzJiNTcyOGE5ZGU0OTg4OWMyNzU4NzhjM2MgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0zNDAzLDYgKzM0MDMsOCBAQCBk ZWYgcHJvY2Vzc19saW5lKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwKICAgICBjaGVja19mb3Jf ZnVuY3Rpb25fbGVuZ3RocyhjbGVhbl9saW5lcywgbGluZSwgZnVuY3Rpb25fc3RhdGUsIGVycm9y KQogICAgIGlmIHNlYXJjaChyJ1xiTk9MSU5UXGInLCByYXdfbGluZXNbbGluZV0pOiAgIyBpZ25v cmUgbm9saW50IGxpbmVzCiAgICAgICAgIHJldHVybgorICAgIGlmIG1hdGNoKHInXHMqXGJfX2Fz bVxiJywgcmF3X2xpbmVzW2xpbmVdKTogICMgSWdub3JlIGFzbSBsaW5lcyBhcyB0aGV5IGZvcm1h dCBkaWZmZXJlbnRseS4KKyAgICAgICAgcmV0dXJuCiAgICAgY2hlY2tfZnVuY3Rpb25fZGVmaW5p dGlvbihmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lLCBmdW5jdGlv bl9zdGF0ZSwgZXJyb3IpCiAgICAgY2hlY2tfcGFzc19wdHJfdXNhZ2UoY2xlYW5fbGluZXMsIGxp bmUsIGZ1bmN0aW9uX3N0YXRlLCBlcnJvcikKICAgICBjaGVja19mb3JfbXVsdGlsaW5lX2NvbW1l bnRzX2FuZF9zdHJpbmdzKGNsZWFuX2xpbmVzLCBsaW5lLCBlcnJvcikKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXgg NDMyMmI0MDRmMDczZDJiZjM5MDljNTNmMjU0MzE1NDhjNmViYjkzMy4uMzdlYWIzMzYzYWEwMWYx YjUzMjIwYjcyYzJjYjUyOGIzZmIyZGZhNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTYxNSw2ICs2MTUsMTEg QEAgY2xhc3MgRnVuY3Rpb25EZXRlY3Rpb25UZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogCiBjbGFz cyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAKKyAgICBkZWYgdGVzdF9hc21fbGlu ZXNfaWdub3JlZChzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKKyAgICAgICAgICAg ICdfX2FzbSBtb3YgW3JlZ2lzdHJhdGlvbl0sIGVheCcsCisgICAgICAgICAgICAnJykKKwogICAg ICMgVGVzdCBnZXQgbGluZSB3aWR0aC4KICAgICBkZWYgdGVzdF9nZXRfbGluZV93aWR0aChzZWxm KToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoMCwgY3BwX3N0eWxlLmdldF9saW5lX3dpZHRo KCcnKSkK