68385 2011-09-19 13:35:10 -0700 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:] 2011-09-19 13:38:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca aroben oldest_to_newest 469646 0 andersca 2011-09-19 13:35:10 -0700 Remove -[WebView _selectionChanged] and -[WebView _setTooltip:] 469649 1 107911 andersca 2011-09-19 13:36:16 -0700 Created attachment 107911 Patch 469650 2 107911 aroben 2011-09-19 13:37:16 -0700 Comment on attachment 107911 Patch How certain are you that no WebKit clients are overriding these WebView methods? 469651 3 andersca 2011-09-19 13:37:53 -0700 (In reply to comment #2) > (From update of attachment 107911 [details]) > How certain are you that no WebKit clients are overriding these WebView methods? Very certain! 469652 4 andersca 2011-09-19 13:38:11 -0700 Committed r95467: <http://trac.webkit.org/changeset/95467> 107911 2011-09-19 13:36:16 -0700 2011-09-19 13:37:15 -0700 Patch bug-68385-20110919133615.patch text/plain 5042 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NDY2KQorKysgU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDktMTkg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUg LVtXZWJWaWV3IF9zZWxlY3Rpb25DaGFuZ2VkXSBhbmQgLVtXZWJWaWV3IF9zZXRUb29sdGlwOl0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4Mzg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGVz ZSBmdW5jdGlvbnMgYmFjayBpbnRvIHRoZSByZXNwZWN0aXZlIGNsaWVudHMgYW5kIHJlbW92ZSB1 c2VzRG9jdW1lbnRWaWV3cyBjaGVja3MuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJD aHJvbWVDbGllbnQubW06CisgICAgICAgIChXZWJDaHJvbWVDbGllbnQ6OnNldFRvb2xUaXApOgor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbToKKyAgICAgICAgKFdl YkVkaXRvckNsaWVudDo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbik6CisgICAgICAgICogV2Vi Vmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAqIFdlYlZpZXcvV2ViVmlld0V2ZW50SGFuZGxpbmcu bW06CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3SW50ZXJuYWwuaDoKKwogMjAxMS0wOS0xOSAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEJlZ2luIHJl bW92aW5nIC1bV2ViVmlldyBfdXNlc0RvY3VtZW50Q2FsbHNdIGZyb20gV2ViVmlldy5tbQpJbmRl eDogU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50Lm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNs aWVudC5tbQkocmV2aXNpb24gOTU0NTgpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3Vw cG9ydC9XZWJDaHJvbWVDbGllbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTYyMiw3ICs2MjIsOSBA QCB2b2lkIFdlYkNocm9tZUNsaWVudDo6bW91c2VEaWRNb3ZlT3ZlckVsCiAKIHZvaWQgV2ViQ2hy b21lQ2xpZW50OjpzZXRUb29sVGlwKGNvbnN0IFN0cmluZyYgdG9vbFRpcCwgVGV4dERpcmVjdGlv bikKIHsKLSAgICBbbV93ZWJWaWV3IF9zZXRUb29sVGlwOnRvb2xUaXBdOworICAgIE5TVmlldzxX ZWJEb2N1bWVudFZpZXc+ICpkb2N1bWVudFZpZXcgPSBbW1ttX3dlYlZpZXcgX3NlbGVjdGVkT3JN YWluRnJhbWVdIGZyYW1lVmlld10gZG9jdW1lbnRWaWV3XTsKKyAgICBpZiAoW2RvY3VtZW50Vmll dyBpc0tpbmRPZkNsYXNzOltXZWJIVE1MVmlldyBjbGFzc11dKQorICAgICAgICBbKFdlYkhUTUxW aWV3ICopZG9jdW1lbnRWaWV3IF9zZXRUb29sVGlwOnRvb2xUaXBdOwogfQogCiB2b2lkIFdlYkNo cm9tZUNsaWVudDo6cHJpbnQoRnJhbWUqIGZyYW1lKQpJbmRleDogU291cmNlL1dlYktpdC9tYWMv V2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQkocmV2aXNpb24gOTU0 MTkpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQu bW0JKHdvcmtpbmcgY29weSkKQEAgLTI5Miw3ICsyOTIsOSBAQCB2b2lkIFdlYkVkaXRvckNsaWVu dDo6cmVzcG9uZFRvQ2hhbmdlZENvCiAKIHZvaWQgV2ViRWRpdG9yQ2xpZW50OjpyZXNwb25kVG9D aGFuZ2VkU2VsZWN0aW9uKCkKIHsKLSAgICBbbV93ZWJWaWV3IF9zZWxlY3Rpb25DaGFuZ2VkXTsK KyAgICBOU1ZpZXc8V2ViRG9jdW1lbnRWaWV3PiAqZG9jdW1lbnRWaWV3ID0gW1tbbV93ZWJWaWV3 IF9zZWxlY3RlZE9yTWFpbkZyYW1lXSBmcmFtZVZpZXddIGRvY3VtZW50Vmlld107CisgICAgaWYg KFtkb2N1bWVudFZpZXcgaXNLaW5kT2ZDbGFzczpbV2ViSFRNTFZpZXcgY2xhc3NdXSkKKyAgICAg ICAgWyhXZWJIVE1MVmlldyAqKWRvY3VtZW50VmlldyBfc2VsZWN0aW9uQ2hhbmdlZF07CiAKICAg ICAvLyBGSVhNRTogVGhpcyBxdWlyayBpcyBuZWVkZWQgZHVlIHRvIDxyZGFyOi8vcHJvYmxlbS81 MDA5NjI1PiAtIFdlIGNhbiBwaGFzZSBpdCBvdXQgb25jZSBBcGVydHVyZSBjYW4gYWRvcHQgdGhl IG5ldyBiZWhhdmlvciBvbiB0aGVpciBlbmQKICAgICBpZiAoIVdlYktpdExpbmtlZE9uT3JBZnRl cihXRUJLSVRfRklSU1RfVkVSU0lPTl9XSVRIT1VUX0FQRVJUVVJFX1FVSVJLKSAmJiBbW1tOU0J1 bmRsZSBtYWluQnVuZGxlXSBidW5kbGVJZGVudGlmaWVyXSBpc0VxdWFsVG9TdHJpbmc6QCJjb20u YXBwbGUuQXBlcnR1cmUiXSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmll dy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0J KHJldmlzaW9uIDk1NDY1KQorKysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1t CSh3b3JraW5nIGNvcHkpCkBAIC02MDI4LDE4ICs2MDI4LDYgQEAgLSAodm9pZClfc2V0SW5zZXJ0 aW9uUGFzdGVib2FyZDooTlNQYXN0ZQogICAgIF9wcml2YXRlLT5pbnNlcnRpb25QYXN0ZWJvYXJk ID0gcGFzdGVib2FyZDsKIH0KIAotLSAodm9pZClfc2VsZWN0aW9uQ2hhbmdlZAotewotICAgIGlm IChfcHJpdmF0ZS0+dXNlc0RvY3VtZW50Vmlld3MpIHsKLSAgICAgICAgaWQgZG9jdW1lbnRWaWV3 ID0gW1tbc2VsZiBfc2VsZWN0ZWRPck1haW5GcmFtZV0gZnJhbWVWaWV3XSBkb2N1bWVudFZpZXdd OwotICAgICAgICBpZiAoW2RvY3VtZW50VmlldyBpc0tpbmRPZkNsYXNzOltXZWJIVE1MVmlldyBj bGFzc11dKQotICAgICAgICAgICAgW2RvY3VtZW50VmlldyBfc2VsZWN0aW9uQ2hhbmdlZF07Ci0g ICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICAvLyBGSVhNRSAoVmlld2xlc3MpOiBXZSdsbCBu ZWVkIGNvZGUgaGVyZS4KLX0KLQogLSAoRnJhbWUqKV9tYWluQ29yZUZyYW1lCiB7CiAgICAgcmV0 dXJuIChfcHJpdmF0ZSAmJiBfcHJpdmF0ZS0+cGFnZSkgPyBfcHJpdmF0ZS0+cGFnZS0+bWFpbkZy YW1lKCkgOiAwOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3RXZlbnRI YW5kbGluZy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZp ZXdFdmVudEhhbmRsaW5nLm1tCShyZXZpc2lvbiA5NTQxOSkKKysrIFNvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViVmlld0V2ZW50SGFuZGxpbmcubW0JKHdvcmtpbmcgY29weSkKQEAgLTIyNSwx NiArMjI1LDQgQEAgLSAodm9pZClfc3RvcEF1dG9zY3JvbGxUaW1lcgogICAgIFt0aW1lciByZWxl YXNlXTsKIH0KIAotLSAodm9pZClfc2V0VG9vbFRpcDooTlNTdHJpbmcgKil0b29sVGlwCi17Ci0g ICAgaWYgKF9wcml2YXRlLT51c2VzRG9jdW1lbnRWaWV3cykgewotICAgICAgICBpZCBkb2N1bWVu dFZpZXcgPSBbW1tzZWxmIF9zZWxlY3RlZE9yTWFpbkZyYW1lXSBmcmFtZVZpZXddIGRvY3VtZW50 Vmlld107Ci0gICAgICAgIGlmIChbZG9jdW1lbnRWaWV3IGlzS2luZE9mQ2xhc3M6W1dlYkhUTUxW aWV3IGNsYXNzXV0pCi0gICAgICAgICAgICBbZG9jdW1lbnRWaWV3IF9zZXRUb29sVGlwOnRvb2xU aXBdOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgLy8gRklYTUUgKFZpZXdsZXNzKTog Q29kZSB0byBoYW5kbGUgdG9vbHRpcHMgbmVlZHMgdG8gbW92ZSBpbnRvIFdlYlZpZXcuCi19Ci0K IEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlld0ludGVybmFsLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3SW50ZXJuYWwu aAkocmV2aXNpb24gOTU0MTkpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXdJ bnRlcm5hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC04NSw4ICs4NSw2IEBAIEBpbnRlcmZhY2UgV2Vi VmlldyAoV2ViVmlld0ludGVybmFsKQogLSAodm9pZClfZGlzcGF0Y2hEaWRSZWNlaXZlSWNvbkZy b21XZWJGcmFtZTooV2ViRnJhbWUgKil3ZWJGcmFtZTsKICNlbmRpZgogCi0tICh2b2lkKV9zZWxl Y3Rpb25DaGFuZ2VkOwotCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogLSAoQk9P TClfbmVlZHNPbmVTaG90RHJhd2luZ1N5bmNocm9uaXphdGlvbjsKIC0gKHZvaWQpX3NldE5lZWRz T25lU2hvdERyYXdpbmdTeW5jaHJvbml6YXRpb246KEJPT0wpbmVlZHNTeW5jaHJvbml6YXRpb247 CkBAIC0xMDYsNyArMTA0LDYgQEAgQGludGVyZmFjZSBXZWJWaWV3IChXZWJWaWV3RXZlbnRIYW5k bGluZwogLSAodm9pZClfdXBkYXRlTW91c2VvdmVyV2l0aEZha2VFdmVudDsKIC0gKHZvaWQpX2Nh bmNlbFVwZGF0ZU1vdXNlb3ZlclRpbWVyOwogLSAodm9pZClfc3RvcEF1dG9zY3JvbGxUaW1lcjsK LS0gKHZvaWQpX3NldFRvb2xUaXA6KE5TU3RyaW5nICopdG9vbFRpcDsKIEBlbmQKIAogLy8gRklY TUU6IFRlbXBvcmFyeSB3YXkgdG8gZXhwb3NlIG1ldGhvZHMgdGhhdCBhcmUgaW4gdGhlIHdyb25n IGNhdGVnb3J5IGluc2lkZSBXZWJWaWV3Lgo=