68373 2011-09-19 11:05:44 -0700 Remove direct property slot pointers from the instruction stream 2011-09-19 12:29:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver aroben oldest_to_newest 469538 0 oliver 2011-09-19 11:05:44 -0700 Remove direct property slot pointers from the instruction stream 469541 1 107889 oliver 2011-09-19 11:07:35 -0700 Created attachment 107889 Patch 469563 2 oliver 2011-09-19 11:29:30 -0700 Committed r95447: <http://trac.webkit.org/changeset/95447> 469604 3 aroben 2011-09-19 12:28:14 -0700 This broke Windows (at least): http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/21076/steps/compile-webkit/logs/stdio 469605 4 aroben 2011-09-19 12:29:32 -0700 Actually I think it broke 32-bit Mac, too: JavaScriptCore/jit/JITPropertyAccess32_64.cpp: In member function 'void JSC::JIT::compileGetDirectOffset(JSC::JSObject*, JSC::X86Registers::RegisterID, JSC::X86Registers::RegisterID, size_t)': JavaScriptCore/jit/JITPropertyAccess32_64.cpp:462: error: 'result' was not declared in this scope cc1plus: warnings being treated as errors JavaScriptCore/jit/JITPropertyAccess32_64.cpp: At global scope: JavaScriptCore/jit/JITPropertyAccess32_64.cpp:459: warning: unused parameter 'resultPayload' 107889 2011-09-19 11:07:35 -0700 2011-09-19 11:24:50 -0700 Patch bug-68373-20110919110734.patch text/plain 5260 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0MzkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg0 ZjE0NGNkYjk3ODNhN2VkNzBhYTE5MzdlZWY4NDEwZmI2M2IyMDQuLmI4NmVhODUwMjVkZjI5YjVi ZTk2N2IxMTAzYzk2ZDYyYzY2MmM5MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDI1IEBACiAyMDExLTA5LTE5ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAK KyAgICAgICAgUmVtb3ZlIGRpcmVjdCBwcm9wZXJ0eSBzbG90IHBvaW50ZXJzIGZyb20gdGhlIGlu c3RydWN0aW9uIHN0cmVhbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjgzNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgYW4gaW5kaXJlY3QgbG9hZCB0byBhY2Nlc3MgcHJvdG90eXBlIHByb3BlcnRp ZXMgcmF0aGVyIHRoYW4gZGlyZWN0bHkKKyAgICAgICAgc3RvcmluZyB0aGUgcHJvcGVydHkgYWRk cmVzcyBpbiB0aGUgaW5zdHJ1Y3Rpb24gc3RyZWFtLiAgVGhpcyBzaG91bGQgYWxsb3cKKyAgICAg ICAgZnVydGhlciBvcHRpbWlzYXRpb25zIGluIGZ1dHVyZSwgYW5kIGFsc28gcHJvdmlkZXMgYSAw LjUlIHdpbiB0byBzdW5zcGlkZXIuCisKKyAgICAgICAgKiBkZmcvREZHUmVwYXRjaC5jcHA6Cisg ICAgICAgIChKU0M6OkRGRzo6Z2VuZXJhdGVQcm90b0NoYWluQWNjZXNzU3R1Yik6CisgICAgICAg ICogaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpjb21waWxl R2V0RGlyZWN0T2Zmc2V0KToKKyAgICAgICAgKiBqaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5j cHA6CisgICAgICAgIChKU0M6OkpJVDo6Y29tcGlsZUdldERpcmVjdE9mZnNldCk6CisgICAgICAg ICogcnVudGltZS9KU09iamVjdC5oOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6YWRkcmVzc09m UHJvcGVydHlTdG9yYWdlKToKKworMjAxMS0wOS0xOSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBw bGUuY29tPgorCiAgICAgICAgIFJlbW92ZSBidW1wIGFsbG9jYXRvcgogICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgzNzAKIApkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdSZXBhdGNoLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHUmVwYXRjaC5jcHAKaW5kZXggNTBhOGNhMmM2NWQ2OGQwNWEwZjMyZmY5ZWNi MzlkN2Q1OTYzNDQzYi4uM2Y0ZjBmZmNhN2MyMjg1ZDA5ZGViNWVkMTZjZmFkMjAzNzZhZmEyNiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdSZXBhdGNoLmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1JlcGF0Y2guY3BwCkBAIC0xMjQsOCArMTI0 LDkgQEAgc3RhdGljIHZvaWQgZ2VuZXJhdGVQcm90b0NoYWluQWNjZXNzU3R1YihFeGVjU3RhdGUq IGV4ZWMsIFN0cnVjdHVyZVN0dWJJbmZvJiBzdHUKICAgICAgICAgY3VyclN0cnVjdHVyZSA9IGl0 LT5nZXQoKTsKICAgICB9CiAgICAgCi0gICAgc3R1YkppdC5sb2FkUHRyKHByb3RvT2JqZWN0LT5h ZGRyZXNzT2ZQcm9wZXJ0eUF0T2Zmc2V0KG9mZnNldCksIHJlc3VsdEdQUik7Ci0gICAgICAgIAor ICAgIHN0dWJKaXQubG9hZFB0cihwcm90b09iamVjdC0+YWRkcmVzc09mUHJvcGVydHlTdG9yYWdl KCksIHJlc3VsdEdQUik7CisgICAgc3R1YkppdC5sb2FkUHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRy ZXNzKHJlc3VsdEdQUiwgb2Zmc2V0ICogc2l6ZW9mKFdyaXRlQmFycmllcjxVbmtub3duPikpLCBy ZXN1bHRHUFIpOworCiAgICAgTWFjcm9Bc3NlbWJsZXI6Okp1bXAgc3VjY2VzcywgZmFpbDsKICAg ICAKICAgICBlbWl0UmVzdG9yZVNjcmF0Y2goc3R1YkppdCwgbmVlZFRvUmVzdG9yZVNjcmF0Y2gs IHNjcmF0Y2hHUFIsIHN1Y2Nlc3MsIGZhaWwsIGZhaWx1cmVDYXNlcyk7CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCmluZGV4IDZlYTcyOGNkMDUz M2M4NTNlZmMyYzQxYTI5NGY5MTEzYWRkZjljYmUuLjRmYTQ5MTllNGQ4ZWNlM2ExZGVhYzY1MDc0 ODVlMTBjZmFkYjE2ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU UHJvcGVydHlBY2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJv cGVydHlBY2Nlc3MuY3BwCkBAIC00OTksNyArNDk5LDggQEAgdm9pZCBKSVQ6OmNvbXBpbGVHZXRE aXJlY3RPZmZzZXQoUmVnaXN0ZXJJRCBiYXNlLCBSZWdpc3RlcklEIHJlc3VsdCwgc2l6ZV90IGNh Y2gKIAogdm9pZCBKSVQ6OmNvbXBpbGVHZXREaXJlY3RPZmZzZXQoSlNPYmplY3QqIGJhc2UsIFJl Z2lzdGVySUQgcmVzdWx0LCBzaXplX3QgY2FjaGVkT2Zmc2V0KQogewotICAgIGxvYWRQdHIoc3Rh dGljX2Nhc3Q8dm9pZCo+KCZiYXNlLT5tX3Byb3BlcnR5U3RvcmFnZVtjYWNoZWRPZmZzZXRdKSwg cmVzdWx0KTsKKyAgICBsb2FkUHRyKGJhc2UtPmFkZHJlc3NPZlByb3BlcnR5U3RvcmFnZSgpLCBy ZXN1bHQpOworICAgIGxvYWRQdHIoQWRkcmVzcyhyZXN1bHQsIGNhY2hlZE9mZnNldCAqIHNpemVv ZihXcml0ZUJhcnJpZXI8VW5rbm93bj4pKSwgcmVzdWx0KTsKIH0KIAogdm9pZCBKSVQ6OnByaXZh dGVDb21waWxlUHV0QnlJZFRyYW5zaXRpb24oU3RydWN0dXJlU3R1YkluZm8qIHN0dWJJbmZvLCBT dHJ1Y3R1cmUqIG9sZFN0cnVjdHVyZSwgU3RydWN0dXJlKiBuZXdTdHJ1Y3R1cmUsIHNpemVfdCBj YWNoZWRPZmZzZXQsIFN0cnVjdHVyZUNoYWluKiBjaGFpbiwgUmV0dXJuQWRkcmVzc1B0ciByZXR1 cm5BZGRyZXNzLCBib29sIGRpcmVjdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwCmluZGV4IDVjZWMyYjY5MTVlMGVjMWFiODVk NjlkY2M5YmNhY2RiMWY2ZGMyODUuLjk3ZGViN2ExMWMyYTE3YjVlOWJhMDk0NDU1MDJmZWQ0YjUx MGY5YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlB Y2Nlc3MzMl82NC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0 eUFjY2VzczMyXzY0LmNwcApAQCAtNDU4LDggKzQ1OCw5IEBAIHZvaWQgSklUOjpjb21waWxlR2V0 RGlyZWN0T2Zmc2V0KFJlZ2lzdGVySUQgYmFzZSwgUmVnaXN0ZXJJRCByZXN1bHRUYWcsIFJlZ2lz dGVyCiAKIHZvaWQgSklUOjpjb21waWxlR2V0RGlyZWN0T2Zmc2V0KEpTT2JqZWN0KiBiYXNlLCBS ZWdpc3RlcklEIHJlc3VsdFRhZywgUmVnaXN0ZXJJRCByZXN1bHRQYXlsb2FkLCBzaXplX3QgY2Fj aGVkT2Zmc2V0KQogewotICAgIGxvYWQzMihyZWludGVycHJldF9jYXN0PGNoYXIqPigmYmFzZS0+ bV9wcm9wZXJ0eVN0b3JhZ2VbY2FjaGVkT2Zmc2V0XSkgKyBPQkpFQ1RfT0ZGU0VUT0YoSlNWYWx1 ZSwgdS5hc0JpdHMucGF5bG9hZCksIHJlc3VsdFBheWxvYWQpOwotICAgIGxvYWQzMihyZWludGVy cHJldF9jYXN0PGNoYXIqPigmYmFzZS0+bV9wcm9wZXJ0eVN0b3JhZ2VbY2FjaGVkT2Zmc2V0XSkg KyBPQkpFQ1RfT0ZGU0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMudGFnKSwgcmVzdWx0VGFnKTsKKyAg ICBsb2FkUHRyKGJhc2UtPmFkZHJlc3NPZlByb3BlcnR5U3RvcmFnZSgpLCByZXN1bHRUYWcpOwor ICAgIGxvYWQzMihBZGRyZXNzKHJlc3VsdFRhZywgY2FjaGVkT2Zmc2V0ICogc2l6ZW9mKFdyaXRl QmFycmllcjxVbmtub3duPikgKyBPQkpFQ1RfT0ZGU0VUT0YoSlNWYWx1ZSwgdS5hc0JpdHMucGF5 bG9hZCkpLCByZXN1bHQpOworICAgIGxvYWQzMihBZGRyZXNzKHJlc3VsdFRhZywgY2FjaGVkT2Zm c2V0ICogc2l6ZW9mKFdyaXRlQmFycmllcjxVbmtub3duPikgKyBPQkpFQ1RfT0ZGU0VUT0YoSlNW YWx1ZSwgdS5hc0JpdHMudGFnKSksIHJlc3VsdFRhZyk7CiB9CiAKIHZvaWQgSklUOjpwcml2YXRl Q29tcGlsZVB1dEJ5SWRUcmFuc2l0aW9uKFN0cnVjdHVyZVN0dWJJbmZvKiBzdHViSW5mbywgU3Ry dWN0dXJlKiBvbGRTdHJ1Y3R1cmUsIFN0cnVjdHVyZSogbmV3U3RydWN0dXJlLCBzaXplX3QgY2Fj aGVkT2Zmc2V0LCBTdHJ1Y3R1cmVDaGFpbiogY2hhaW4sIFJldHVybkFkZHJlc3NQdHIgcmV0dXJu QWRkcmVzcywgYm9vbCBkaXJlY3QpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU09iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmpl Y3QuaAppbmRleCBhNDczZTgwOGE1NjY0MzBmZjZmYjRhODk2YTZiMmQ4OGUzMDFkOTgzLi5mMWEy MTdiNTUwNjQ1ZWI2YjU4NGZkOTExOGYzMGVlMmZlODBmNDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgKQEAgLTIxMCw5ICsyMTAsOSBAQCBuYW1lc3BhY2UgSlND IHsKICAgICAgICAgdm9pZCBhbGxvY2F0ZVByb3BlcnR5U3RvcmFnZShKU0dsb2JhbERhdGEmLCBz aXplX3Qgb2xkU2l6ZSwgc2l6ZV90IG5ld1NpemUpOwogICAgICAgICBib29sIGlzVXNpbmdJbmxp bmVTdG9yYWdlKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8Y29uc3Qgdm9pZCo+KG1fcHJv cGVydHlTdG9yYWdlLmdldCgpKSA9PSBzdGF0aWNfY2FzdDxjb25zdCB2b2lkKj4odGhpcyArIDEp OyB9CiAKLSAgICAgICAgdm9pZCogYWRkcmVzc09mUHJvcGVydHlBdE9mZnNldChzaXplX3Qgb2Zm c2V0KQorICAgICAgICB2b2lkKiBhZGRyZXNzT2ZQcm9wZXJ0eVN0b3JhZ2UoKQogICAgICAgICB7 Ci0gICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dm9pZCo+KCZtX3Byb3BlcnR5U3RvcmFn ZVtvZmZzZXRdKTsKKyAgICAgICAgICAgIHJldHVybiAmbV9wcm9wZXJ0eVN0b3JhZ2U7CiAgICAg ICAgIH0KIAogICAgICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgYmFzZUV4dGVybmFsU3RvcmFn ZUNhcGFjaXR5ID0gMTY7Cg==