68365 2011-09-19 09:10:38 -0700 HTMLKeygenElement: Don't cache keytype and challenge attributes. 2011-10-17 15:30:08 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling webkit.review.bot oldest_to_newest 469435 0 kling 2011-09-19 09:10:38 -0700 There's no need to cache these attributes. 469436 1 107868 kling 2011-09-19 09:11:17 -0700 Created attachment 107868 Proposed patch 485558 2 107868 webkit.review.bot 2011-10-17 15:30:04 -0700 Comment on attachment 107868 Proposed patch Clearing flags on attachment: 107868 Committed r97658: <http://trac.webkit.org/changeset/97658> 485559 3 webkit.review.bot 2011-10-17 15:30:08 -0700 All reviewed patches have been landed. Closing bug. 107868 2011-09-19 09:11:17 -0700 2011-10-17 15:30:03 -0700 Proposed patch bug-68365.diff text/plain 2577 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyM2YyYzQyLi43Y2RjOGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTEtMDktMTkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIEhUTUxLZXlnZW5FbGVtZW50OiBEb24ndCBjYWNoZSBrZXl0eXBlIGFuZCBjaGFsbGVuZ2Ug YXR0cmlidXRlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY4MzY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBodG1sL0hUTUxLZXlnZW5FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxL ZXlnZW5FbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZSk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MS2V5Z2VuRWxlbWVudDo6YXBwZW5kRm9ybURhdGEpOgorICAgICAgICAqIGh0bWwvSFRNTEtl eWdlbkVsZW1lbnQuaDoKKworMjAxMS0wOS0xOSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtp dC5vcmc+CisKICAgICAgICAgUHJvdGVjdCBhZ2FpbnN0IG1pc3VzZSBvZiBFdmVudExpc3RlbmVy SXRlcmF0b3IuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02ODM2NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxLZXlnZW5FbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVsZW1lbnQuY3BwCmluZGV4 IGQ2MGIxMDUuLmFiZWU3ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtl eWdlbkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVsZW1l bnQuY3BwCkBAIC05OSwyMCArOTksMTYgQEAgdm9pZCBIVE1MS2V5Z2VuRWxlbWVudDo6cGFyc2VN YXBwZWRBdHRyaWJ1dGUoQXR0cmlidXRlKiBhdHRyKQogICAgIGlmIChhdHRyLT5uYW1lKCkgPT0g ZGlzYWJsZWRBdHRyKQogICAgICAgICBzaGFkb3dTZWxlY3QoKS0+c2V0QXR0cmlidXRlKGF0dHIt Pm5hbWUoKSwgYXR0ci0+dmFsdWUoKSk7CiAKLSAgICBpZiAoYXR0ci0+bmFtZSgpID09IGNoYWxs ZW5nZUF0dHIpCi0gICAgICAgIG1fY2hhbGxlbmdlID0gYXR0ci0+dmFsdWUoKTsKLSAgICBlbHNl IGlmIChhdHRyLT5uYW1lKCkgPT0ga2V5dHlwZUF0dHIpCi0gICAgICAgIG1fa2V5VHlwZSA9IGF0 dHItPnZhbHVlKCk7Ci0gICAgZWxzZQotICAgICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojpw YXJzZU1hcHBlZEF0dHJpYnV0ZShhdHRyKTsKKyAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojpw YXJzZU1hcHBlZEF0dHJpYnV0ZShhdHRyKTsKIH0KIAogYm9vbCBIVE1MS2V5Z2VuRWxlbWVudDo6 YXBwZW5kRm9ybURhdGEoRm9ybURhdGFMaXN0JiBlbmNvZGVkX3ZhbHVlcywgYm9vbCkKIHsKICAg ICAvLyBPbmx5IFJTQSBpcyBzdXBwb3J0ZWQgYXQgdGhpcyB0aW1lLgotICAgIGlmICghbV9rZXlU eXBlLmlzTnVsbCgpICYmICFlcXVhbElnbm9yaW5nQ2FzZShtX2tleVR5cGUsICJyc2EiKSkKKyAg ICBjb25zdCBBdG9taWNTdHJpbmcmIGtleVR5cGUgPSBmYXN0R2V0QXR0cmlidXRlKGtleXR5cGVB dHRyKTsKKyAgICBpZiAoIWtleVR5cGUuaXNOdWxsKCkgfHwgIWVxdWFsSWdub3JpbmdDYXNlKGtl eVR5cGUsICJyc2EiKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIFN0cmluZyB2YWx1ZSA9 IHNpZ25lZFB1YmxpY0tleUFuZENoYWxsZW5nZVN0cmluZyhzaGFkb3dTZWxlY3QoKS0+c2VsZWN0 ZWRJbmRleCgpLCBtX2NoYWxsZW5nZSwgZG9jdW1lbnQoKS0+YmFzZVVSTCgpKTsKKyAgICBTdHJp bmcgdmFsdWUgPSBzaWduZWRQdWJsaWNLZXlBbmRDaGFsbGVuZ2VTdHJpbmcoc2hhZG93U2VsZWN0 KCktPnNlbGVjdGVkSW5kZXgoKSwgZmFzdEdldEF0dHJpYnV0ZShjaGFsbGVuZ2VBdHRyKSwgZG9j dW1lbnQoKS0+YmFzZVVSTCgpKTsKICAgICBpZiAodmFsdWUuaXNOdWxsKCkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICBlbmNvZGVkX3ZhbHVlcy5hcHBlbmREYXRhKG5hbWUoKSwgdmFsdWUu dXRmOCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVsZW1l bnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEtleWdlbkVsZW1lbnQuaAppbmRleCA4ODc4 MmM4Li43NzYxOTkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxLZXlnZW5F bGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MS2V5Z2VuRWxlbWVudC5oCkBA IC01Miw5ICs1Miw2IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHJlc2V0KCk7CiAKICAg ICBIVE1MU2VsZWN0RWxlbWVudCogc2hhZG93U2VsZWN0KCkgY29uc3Q7Ci0KLSAgICBBdG9taWNT dHJpbmcgbV9jaGFsbGVuZ2U7Ci0gICAgQXRvbWljU3RyaW5nIG1fa2V5VHlwZTsKIH07CiAKIH0g Ly9uYW1lc3BhY2UK