68359 2011-09-19 07:26:45 -0700 Style checker should not check public Qt WK2 API for parameter_name. 2011-09-19 11:28:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard webkit.review.bot oldest_to_newest 469379 0 menard 2011-09-19 07:26:45 -0700 Style checker should not check public Qt WK2 API for parameter_name. 469380 1 107851 menard 2011-09-19 07:30:05 -0700 Created attachment 107851 Patch 469388 2 107851 kling 2011-09-19 07:58:06 -0700 Comment on attachment 107851 Patch Needs a test in Tools/Scripts/webkitpy/style/checker_unittest.py 469415 3 107862 menard 2011-09-19 08:39:44 -0700 Created attachment 107862 Patch 469417 4 107862 kling 2011-09-19 08:40:37 -0700 Comment on attachment 107862 Patch r=mø 469559 5 107862 webkit.review.bot 2011-09-19 11:28:34 -0700 Comment on attachment 107862 Patch Clearing flags on attachment: 107862 Committed r95446: <http://trac.webkit.org/changeset/95446> 469560 6 webkit.review.bot 2011-09-19 11:28:38 -0700 All reviewed patches have been landed. Closing bug. 107851 2011-09-19 07:30:05 -0700 2011-09-19 08:39:37 -0700 Patch bug-68359-20110919112951.patch text/plain 1519 menard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1NDEzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDktMTkgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5i b3NzYS5vcmc+CisKKyAgICAgICAgU3R5bGUgY2hlY2tlciBzaG91bGQgbm90IGNoZWNrIHB1Ymxp YyBRdCBXSzIgQVBJIGZvciBwYXJhbWV0ZXJfbmFtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHB1YmxpYyBRdCBXSzIgQVBJcyBoYXZlIGRpZmZl cmVudCBydWxlcyB0aGFuIFdlYktpdCBmb3IgcGFyYW1ldGVycyBvZiBtZXRob2RzIGluIGggZmls ZXMuCisgICAgICAgIEFkZCBhbiBleGNlcHRpb24gaW4gdGhlIHN0eWxlIGNoZWNrZXIgdG8gZGlz YWJsZSB0aGUgY2hlY2suCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXIucHk6CisKIDIwMTEtMDktMTYgIEVsbGlvdCBQb2dlciAgPGVwb2dlckBnb29nbGUuY29tPgog CiAgICAgICAgIGFkZCBub24tQ0cgV2Via2l0LU1hYyBidWlsZHMgdG8gZmxha2luZXNzIGRhc2hi b2FyZApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQkocmV2aXNp b24gOTUxOTcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkJKHdv cmtpbmcgY29weSkKQEAgLTE0NCw2ICsxNDQsMTIgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0g WwogICAgICAoWyMgUXQncyBNaW5pQnJvd3NlciBoYXMgbm8gY29uZmlnLmgKICAgICAgICAiVG9v bHMvTWluaUJyb3dzZXIvcXQiXSwKICAgICAgIFsiLWJ1aWxkL2luY2x1ZGUiXSksCisKKyAgICAo WyMgVGhlIFF0IEFQSXMgdXNlIFF0L1FNTCBuYW1pbmcgc3R5bGUsIHdoaWNoIGluY2x1ZGVzCisg ICAgICAjIG5hbWluZyBwYXJhbWV0ZXJzIGluIGggZmlsZXMuCisgICAgICAiU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdCJdLAorICAgICBbIi1yZWFkYWJpbGl0eS9wYXJhbWV0ZXJfbmFt ZSJdKSwKKwogICAgIChbIyBUaGUgR1RLKyBBUElzIHVzZSBHVEsrIG5hbWluZyBzdHlsZSwgd2hp Y2ggaW5jbHVkZXMKICAgICAgICMgbG93ZXItY2FzZWQsIHVuZGVyc2NvcmUtc2VwYXJhdGVkIHZh bHVlcywgd2hpdGVzcGFjZSBiZWZvcmUKICAgICAgICMgcGFyZW5zIGZvciBmdW5jdGlvbiBjYWxs cywgYW5kIGFsd2F5cyBoYXZpbmcgdmFyaWFibGUgbmFtZXMuCg== 107862 2011-09-19 08:39:44 -0700 2011-09-19 11:28:34 -0700 Patch bug-68359-20110919123930.patch text/plain 2263 menard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1NDE1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDktMTkgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5i b3NzYS5vcmc+CisKKyAgICAgICAgU3R5bGUgY2hlY2tlciBzaG91bGQgbm90IGNoZWNrIHB1Ymxp YyBRdCBXSzIgQVBJIGZvciBwYXJhbWV0ZXJfbmFtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHB1YmxpYyBRdCBXSzIgQVBJcyBoYXZlIGRpZmZl cmVudCBydWxlcyB0aGFuIFdlYktpdCBmb3IgcGFyYW1ldGVycyBvZiBtZXRob2RzIGluIGggZmls ZXMuCisgICAgICAgIEFkZCBhbiBleGNlcHRpb24gaW4gdGhlIHN0eWxlIGNoZWNrZXIgdG8gZGlz YWJsZSB0aGUgY2hlY2suIEFsc28gYWRkZWQgdGhlIHRlc3QgZm9yIGl0LgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weToKKwogMjAxMS0wOS0xNiAgRWxsaW90IFBv Z2VyICA8ZXBvZ2VyQGdvb2dsZS5jb20+CiAKICAgICAgICAgYWRkIG5vbi1DRyBXZWJraXQtTWFj IGJ1aWxkcyB0byBmbGFraW5lc3MgZGFzaGJvYXJkCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2VyLnB5CShyZXZpc2lvbiA5NTE5NykKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlci5weQkod29ya2luZyBjb3B5KQpAQCAtMTQ0LDYgKzE0NCwxMiBA QCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgIChbIyBRdCdzIE1pbmlCcm93c2VyIGhh cyBubyBjb25maWcuaAogICAgICAgICJUb29scy9NaW5pQnJvd3Nlci9xdCJdLAogICAgICAgWyIt YnVpbGQvaW5jbHVkZSJdKSwKKworICAgIChbIyBUaGUgUXQgQVBJcyB1c2UgUXQvUU1MIG5hbWlu ZyBzdHlsZSwgd2hpY2ggaW5jbHVkZXMKKyAgICAgICMgbmFtaW5nIHBhcmFtZXRlcnMgaW4gaCBm aWxlcy4KKyAgICAgICJTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0Il0sCisgICAgIFsi LXJlYWRhYmlsaXR5L3BhcmFtZXRlcl9uYW1lIl0pLAorCiAgICAgKFsjIFRoZSBHVEsrIEFQSXMg dXNlIEdUSysgbmFtaW5nIHN0eWxlLCB3aGljaCBpbmNsdWRlcwogICAgICAgIyBsb3dlci1jYXNl ZCwgdW5kZXJzY29yZS1zZXBhcmF0ZWQgdmFsdWVzLCB3aGl0ZXNwYWNlIGJlZm9yZQogICAgICAg IyBwYXJlbnMgZm9yIGZ1bmN0aW9uIGNhbGxzLCBhbmQgYWx3YXlzIGhhdmluZyB2YXJpYWJsZSBu YW1lcy4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVz dC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJf dW5pdHRlc3QucHkJKHJldmlzaW9uIDk1MTk3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2VyX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNTcsNiArMjU3LDkg QEAgY2xhc3MgR2xvYmFsVmFyaWFibGVzVGVzdCh1bml0dGVzdC5UZXN0QwogICAgICAgICBhc3Nl cnROb0NoZWNrKCJUb29scy9NaW5pQnJvd3Nlci9xdC9VcmxMb2FkZXIuY3BwIiwKICAgICAgICAg ICAgICAgICAgICAgImJ1aWxkL2luY2x1ZGUiKQogCisgICAgICAgIGFzc2VydE5vQ2hlY2soIlNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQiLAorICAgICAgICAgICAgICAgICAgICAicmVh ZGFiaWxpdHkvcGFyYW1ldGVyX25hbWUiKQorCiAgICAgICAgIGFzc2VydE5vQ2hlY2soIlNvdXJj ZS9XZWJDb3JlL0ZvcndhcmRpbmdIZWFkZXJzL2RlYnVnZ2VyL0RlYnVnZ2VyLmgiLAogICAgICAg ICAgICAgICAgICAgICAgICJidWlsZC9oZWFkZXJfZ3VhcmQiKQogCg==