68351 2011-09-19 05:41:44 -0700 [chromium]ClearFocusedNode doesn't clear the cursor or selection in editable div element. 2011-09-21 09:39:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 chandra.vallala webkit-unassigned fishd jam webkit.review.bot oldest_to_newest 469341 0 chandra.vallala 2011-09-19 05:41:44 -0700 ClearFocusedNode should clear selection of editable div node. Otherwise div node will still process the keyboard events even though focus has removed for the node. The current implementation works for only text-filed and textarea. 469346 1 107840 chandra.vallala 2011-09-19 05:49:51 -0700 Created attachment 107840 patch for bug 469501 2 107840 fishd 2011-09-19 10:41:07 -0700 Comment on attachment 107840 patch for bug View in context: https://bugs.webkit.org/attachment.cgi?id=107840&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1806 > + || (oldFocusedNode->hasTagName(HTMLNames::divTag) Any block element can be made content editable. Checking only for a DIV tag seems a bit too restrictive. 470673 3 108126 chandra.vallala 2011-09-21 02:21:47 -0700 Created attachment 108126 updated patch updated patch as per comment. 470874 4 108126 webkit.review.bot 2011-09-21 09:38:56 -0700 Comment on attachment 108126 updated patch Clearing flags on attachment: 108126 Committed r95640: <http://trac.webkit.org/changeset/95640> 470875 5 webkit.review.bot 2011-09-21 09:39:00 -0700 All reviewed patches have been landed. Closing bug. 107840 2011-09-19 05:49:51 -0700 2011-09-21 02:21:47 -0700 patch for bug div-focus-clear.patch text/plain 1426 chandra.vallala SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlz aW9uIDk1NDA2KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xODAzLDYgKzE4MDMsOCBAQAogICAgIC8vIHByb2Nlc3Npbmcg a2V5Ym9hcmQgZXZlbnRzIGV2ZW4gdGhvdWdoIGZvY3VzIGhhcyBiZWVuIG1vdmVkIHRvIHRoZSBw YWdlIGFuZAogICAgIC8vIGtleXN0cm9rZXMgZ2V0IGVhdGVuIGFzIGEgcmVzdWx0LgogICAgIGlm IChvbGRGb2N1c2VkTm9kZS0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnRleHRhcmVhVGFnKQorICAg ICAgICB8fCAob2xkRm9jdXNlZE5vZGUtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpkaXZUYWcpCisg ICAgICAgICAgICAmJiBvbGRGb2N1c2VkTm9kZS0+aXNDb250ZW50RWRpdGFibGUoKSkKICAgICAg ICAgfHwgKG9sZEZvY3VzZWROb2RlLT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6aW5wdXRUYWcpCiAg ICAgICAgICAgICAmJiBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4ob2xkRm9jdXNlZE5v ZGUuZ2V0KCkpLT5pc1RleHRGaWVsZCgpKSkgewogICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCkt PmNsZWFyKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gOTU0MDYp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDEzIEBACisyMDExLTA5LTE5ICBjaGFuZHJhIHNoZWthciB2YWxsYWxhICA8Y2hhbmRy YS52YWxsYWxhQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBDbGVhckZvY3VzZWROb2RlIGRvZXNu J3QgY2xlYXIgdGhlIGN1cnNvciBvciBzZWxlY3Rpb24gaW4gZWRpdGFibGUgZGl2IGVsZW1lbnQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODM1MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dl YlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OmNsZWFyRm9jdXNl ZE5vZGUpOgorCiAyMDExLTA5LTE5ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBleHRlbmQgdGltZWxpbmUgY292ZXJhZ2Uu Cg== 108126 2011-09-21 02:21:47 -0700 2011-09-21 09:38:56 -0700 updated patch div-focus-clear.patch text/plain 1598 chandra.vallala SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlz aW9uIDk1NjAwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xODAyLDkgKzE4MDIsOSBAQAogICAgIC8vIGtub3dzIHRvIHJl bW92ZSBzZWxlY3Rpb24gZnJvbSBpdC4gT3RoZXJ3aXNlLCB0aGUgdGV4dCBmaWVsZCBpcyBzdGls bAogICAgIC8vIHByb2Nlc3Npbmcga2V5Ym9hcmQgZXZlbnRzIGV2ZW4gdGhvdWdoIGZvY3VzIGhh cyBiZWVuIG1vdmVkIHRvIHRoZSBwYWdlIGFuZAogICAgIC8vIGtleXN0cm9rZXMgZ2V0IGVhdGVu IGFzIGEgcmVzdWx0LgotICAgIGlmIChvbGRGb2N1c2VkTm9kZS0+aGFzVGFnTmFtZShIVE1MTmFt ZXM6OnRleHRhcmVhVGFnKQotICAgICAgICB8fCAob2xkRm9jdXNlZE5vZGUtPmhhc1RhZ05hbWUo SFRNTE5hbWVzOjppbnB1dFRhZykKLSAgICAgICAgICAgICYmIHN0YXRpY19jYXN0PEhUTUxJbnB1 dEVsZW1lbnQqPihvbGRGb2N1c2VkTm9kZS5nZXQoKSktPmlzVGV4dEZpZWxkKCkpKSB7CisgICAg aWYgKG9sZEZvY3VzZWROb2RlLT5pc0NvbnRlbnRFZGl0YWJsZSgpCisgICAgICAgIHx8IChvbGRG b2N1c2VkTm9kZS0+aXNFbGVtZW50Tm9kZSgpCisgICAgICAgICAgICAmJiBzdGF0aWNfY2FzdDxF bGVtZW50Kj4ob2xkRm9jdXNlZE5vZGUuZ2V0KCkpLT5pc1RleHRGb3JtQ29udHJvbCgpKSkgewog ICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPmNsZWFyKCk7CiAgICAgfQogfQpJbmRleDogU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NjAxKQorKysgU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0w OS0yMSAgY2hhbmRyYSBzaGVrYXIgdmFsbGFsYSAgPGNoYW5kcmEudmFsbGFsYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW2Nocm9taXVtXUNsZWFyRm9jdXNlZE5vZGUgZG9lc24ndCBjbGVhciB0aGUg Y3Vyc29yIG9yIHNlbGVjdGlvbiBpbiBlZGl0YWJsZSBkaXYgZWxlbWVudC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MzUxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6Y2xlYXJGb2N1c2VkTm9kZSk6CisKIDIw MTEtMDktMjAgIEpheSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFRoaXMgQ0wgbWFrZXMgaXQgcG9zc2libGUgdG8gY3JlYXRlIGEgYmxvYiBmcm9tIENocm9taXVt Lgo=