68346 2011-09-19 03:21:23 -0700 [GTK] Fix distcheck build 2011-09-19 23:39:23 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mrobinson pnormand webkit.review.bot oldest_to_newest 469306 0 cgarcia 2011-09-19 03:21:23 -0700 make distcheck doesn't currently work. 469307 1 107826 cgarcia 2011-09-19 03:24:57 -0700 Created attachment 107826 Patch 469323 2 107826 pnormand 2011-09-19 04:14:47 -0700 Comment on attachment 107826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107826&action=review Looks good overall, just a doubt of the mime-type handling test. > Source/WebKit/gtk/tests/testmimehandling.c:-79 > - } else if (g_str_equal(path, "/ogg")) { Hum, why remove this part of the test? If it fails we'd better fix it. 469325 3 cgarcia 2011-09-19 04:22:25 -0700 (In reply to comment #2) > (From update of attachment 107826 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107826&action=review > > Looks good overall, just a doubt of the mime-type handling test. > > > Source/WebKit/gtk/tests/testmimehandling.c:-79 > > - } else if (g_str_equal(path, "/ogg")) { > > Hum, why remove this part of the test? If it fails we'd better fix it. Soup behaviour has changed, the "fix" would depend on soup version, so we should bump the soup requirements to make sure the test won't fail. See: https://bugzilla.gnome.org/show_bug.cgi?id=648846#c8 So, for now we have decided to remove that part of the test. 469327 4 pnormand 2011-09-19 04:34:27 -0700 Oh, OK then :) I've missed that link you also mentionned in the ChangeLog, sorry. 469443 5 107826 webkit.review.bot 2011-09-19 09:21:07 -0700 Comment on attachment 107826 Patch Clearing flags on attachment: 107826 Committed r95417: <http://trac.webkit.org/changeset/95417> 469444 6 webkit.review.bot 2011-09-19 09:21:11 -0700 All reviewed patches have been landed. Closing bug. 469472 7 mrobinson 2011-09-19 10:09:01 -0700 In the future, I think it would be better to update the source lists and fix the tests in two separate patches. That would allow an automatic rollout when the soup version is updated. Source list updates do not need review either, so it isn't much harder. 469930 8 cgarcia 2011-09-19 23:39:23 -0700 (In reply to comment #7) > In the future, I think it would be better to update the source lists and fix the tests in two separate patches. That would allow an automatic rollout when the soup version is updated. Source list updates do not need review either, so it isn't much harder. Ok, sorry, in this case just updating libsoup wound't work, we need to rethink the test itself, but still, you are right. 107826 2011-09-19 03:24:57 -0700 2011-09-19 09:21:07 -0700 Patch fix-distcheck.diff text/plain 5079 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGRiMzY5MDMuLmVjNzQ5ODQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw2ICsxLDE1IEBACiAyMDExLTA5LTE5ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBGaXggZGlzdGNo ZWNrIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02ODM0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogR05VbWFrZWZpbGUubGlzdC5hbToKKworMjAxMS0wOS0xOSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IGRpc3RjaGVjayBi dWlsZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njgy NDEKIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNGFhYmNkZS4uMDQ0MzNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDExLTA5LTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBGaXggZGlzdGNoZWNrIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODM0NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvdGVzdG1pbWVoYW5kbGluZy5jOiBS ZW1vdmUgb2dnIHRlc3RzLCBzaW5jZSB0aGUgYmVoYXZpb3VzCisgICAgICAgIGhhcyBjaGFuZ2Vk IGluIGxpYnNvdXAgKGh0dHBzOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD02 NDg4NDYjYzgpCisgICAgICAgIChzZXJ2ZXJfY2FsbGJhY2spOgorICAgICAgICAobWltZV90eXBl X3BvbGljeV9kZWNpc2lvbl9yZXF1ZXN0ZWRfY2IpOgorICAgICAgICAobWFpbik6CisgICAgICAg ICogd2Via2l0L3dlYmtpdHdlYnBsdWdpbi5jcHA6IEZpeCBpbnRyb3NwZWN0aW9uIGFubm90YXRp b24uCisKIDIwMTEtMDktMTcgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgRnJhbWVMb2FkZXJDbGllbnQgQmFja0ZvcndhcmRMaXN0LXJlbGF0ZWQgbWV0 aG9kcyBhcmUgdW5zdWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFr ZWZpbGUubGlzdC5hbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtlZmlsZS5saXN0LmFt CmluZGV4IGI3OTdkNTIuLjk5NmNhYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9HTlVtYWtlZmlsZS5saXN0LmFtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9HTlVtYWtl ZmlsZS5saXN0LmFtCkBAIC0xMDQsNyArMTA0LDYgQEAgamF2YXNjcmlwdGNvcmVfc291cmNlcyAr PSBcCiAJU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9MYWJlbFNjb3BlLmggXAog CVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcCBcCiAJ U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9SZWdpc3RlcklELmggXAotCVNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWxpYXNUcmFja2VyLmggXAogCVNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwIFwKIAlTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmggXAogCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQ2FwYWJpbGl0aWVzLmNwcCBcCkBAIC0xMTYsNiArMTE1LDcgQEAgamF2YXNjcmlwdGNvcmVf c291cmNlcyArPSBcCiAJU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHUFJJbmZvLmggXAog CVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwIFwKIAlTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0dyYXBoLmggXAorCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH SW50cmluc2ljLmggXAogCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVy YXRvci5jcHAgXAogCVNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29kZUdlbmVyYXRv ci5oIFwKIAlTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcCBcCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmMgYi9T b3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0bWltZWhhbmRsaW5nLmMKaW5kZXggNDFlMTcwYS4u NWI2ZTVhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdG1pbWVoYW5k bGluZy5jCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RtaW1laGFuZGxpbmcuYwpA QCAtNzYsMTUgKzc2LDYgQEAgc2VydmVyX2NhbGxiYWNrKFNvdXBTZXJ2ZXIgKnNlcnZlciwgU291 cE1lc3NhZ2UgKm1zZywKICAgICAgICAgZ19hc3NlcnQoIWVycm9yKTsKIAogICAgICAgICBzb3Vw X21lc3NhZ2VfYm9keV9hcHBlbmQobXNnLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9UQUtF LCBjb250ZW50cywgbGVuZ3RoKTsKLSAgICB9IGVsc2UgaWYgKGdfc3RyX2VxdWFsKHBhdGgsICIv b2dnIikpIHsKLSAgICAgICAgY2hhciogY29udGVudHM7Ci0gICAgICAgIGdzaXplIGxlbmd0aDsK LSAgICAgICAgR0Vycm9yKiBlcnJvciA9IE5VTEw7Ci0KLSAgICAgICAgZ19maWxlX2dldF9jb250 ZW50cygidGVzdC5vZ2ciLCAmY29udGVudHMsICZsZW5ndGgsICZlcnJvcik7Ci0gICAgICAgIGdf YXNzZXJ0KCFlcnJvcik7Ci0KLSAgICAgICAgc291cF9tZXNzYWdlX2JvZHlfYXBwZW5kKG1zZy0+ cmVzcG9uc2VfYm9keSwgU09VUF9NRU1PUllfVEFLRSwgY29udGVudHMsIGxlbmd0aCk7CiAgICAg fQogCiAgICAgc291cF9tZXNzYWdlX2JvZHlfY29tcGxldGUobXNnLT5yZXNwb25zZV9ib2R5KTsK QEAgLTEyNCw5ICsxMTUsNiBAQCBzdGF0aWMgZ2Jvb2xlYW4gbWltZV90eXBlX3BvbGljeV9kZWNp c2lvbl9yZXF1ZXN0ZWRfY2IoV2ViS2l0V2ViVmlldyogdmlldywgV2ViSwogCiAgICAgICAgIGdf YXNzZXJ0X2NtcHN0cihtaW1lX3R5cGUsID09LCAidGV4dC9wbGFpbiIpOwogICAgICAgICBnX2Fz c2VydCh3ZWJraXRfd2ViX3ZpZXdfY2FuX3Nob3dfbWltZV90eXBlKHZpZXcsIG1pbWVfdHlwZSkp OwotICAgIH0gZWxzZSBpZiAoZ19zdHJfZXF1YWwodHlwZSwgIm9nZyIpKSB7Ci0gICAgICAgIGdf YXNzZXJ0X2NtcHN0cihtaW1lX3R5cGUsID09LCAiYXVkaW8veC12b3JiaXMrb2dnIik7Ci0gICAg ICAgIGdfYXNzZXJ0KHdlYmtpdF93ZWJfdmlld19jYW5fc2hvd19taW1lX3R5cGUodmlldywgbWlt ZV90eXBlKSk7CiAgICAgfQogCiAgICAgZ19mcmVlKHR5cGUpOwpAQCAtMjA5LDExICsxOTcsOSBA QCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgZ190ZXN0X2FkZF9kYXRhX2Z1 bmMoIi93ZWJraXQvbWltZS9yZW1vdGUtUERGIiwgInBkZiIsIHRlc3RSZW1vdGVNaW1lVHlwZSk7 CiAgICAgZ190ZXN0X2FkZF9kYXRhX2Z1bmMoIi93ZWJraXQvbWltZS9yZW1vdGUtSFRNTCIsICJo dG1sIiwgdGVzdFJlbW90ZU1pbWVUeXBlKTsKICAgICBnX3Rlc3RfYWRkX2RhdGFfZnVuYygiL3dl YmtpdC9taW1lL3JlbW90ZS1URVhUIiwgInRleHQiLCB0ZXN0UmVtb3RlTWltZVR5cGUpOwotICAg IGdfdGVzdF9hZGRfZGF0YV9mdW5jKCIvd2Via2l0L21pbWUvcmVtb3RlLU9HRyIsICJvZ2ciLCB0 ZXN0UmVtb3RlTWltZVR5cGUpOwogICAgIGdfdGVzdF9hZGRfZGF0YV9mdW5jKCIvd2Via2l0L21p bWUvbG9jYWwtUERGIiwgInBkZiIsIHRlc3RMb2NhbE1pbWVUeXBlKTsKICAgICBnX3Rlc3RfYWRk X2RhdGFfZnVuYygiL3dlYmtpdC9taW1lL2xvY2FsLUhUTUwiLCAiaHRtbCIsIHRlc3RMb2NhbE1p bWVUeXBlKTsKICAgICBnX3Rlc3RfYWRkX2RhdGFfZnVuYygiL3dlYmtpdC9taW1lL2xvY2FsLVRF WFQiLCAidGV4dCIsIHRlc3RMb2NhbE1pbWVUeXBlKTsKLSAgICBnX3Rlc3RfYWRkX2RhdGFfZnVu YygiL3dlYmtpdC9taW1lL2xvY2FsLU9HRyIsICJvZ2ciLCB0ZXN0TG9jYWxNaW1lVHlwZSk7CiAK ICAgICByZXR1cm4gZ190ZXN0X3J1bigpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYnBsdWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2VicGx1Z2luLmNwcAppbmRleCA0MjI4YzUzLi5lMDNiMWVhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2VicGx1Z2luLmNwcApAQCAtMjE5LDcgKzIxOSw3IEBA IGNvbnN0IGNoYXIqIHdlYmtpdF93ZWJfcGx1Z2luX2dldF9wYXRoKFdlYktpdFdlYlBsdWdpbiog cGx1Z2luKQogICogUmV0dXJucyBhbGwgdGhlICNXZWJLaXRXZWJQbHVnaW5NSU1FVHlwZSB0aGF0 IEBwbHVnaW4gaXMgaGFuZGxpbmcKICAqIGF0IHRoZSBtb21lbnQuCiAgKgotICogUmV0dXJuczog KHRyYW5zZmVyIG5vbmUpIChlbGVtZW50LXR5cGUgV2ViS2l0V2ViUGx1Z2luTUlNRVR5cGUpOiBh ICNHU0xpc3Qgb2YgI1dlYktpdFdlYlBsdWdpbk1JTUVUeXBlCisgKiBSZXR1cm5zOiAodHJhbnNm ZXIgbm9uZSkgKGVsZW1lbnQtdHlwZSBXZWJLaXQuV2ViS2l0V2ViUGx1Z2luTUlNRVR5cGUpOiBh ICNHU0xpc3Qgb2YgI1dlYktpdFdlYlBsdWdpbk1JTUVUeXBlCiAgKgogICogU2luY2U6IDEuMy44 CiAgKi8K