68343 2011-09-19 02:11:37 -0700 [chromium] Disable clang when building chromium in WebKit 2011-09-19 12:18:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth thakis webkit.review.bot oldest_to_newest 469290 0 jochen 2011-09-19 02:11:37 -0700 [chromium] Disable clang when building chromium in WebKit 469291 1 107818 jochen 2011-09-19 02:13:18 -0700 Created attachment 107818 Patch 469292 2 jochen 2011-09-19 02:17:39 -0700 an alternative would be to add a dependencies on tools/clang 469364 3 107818 thakis 2011-09-19 06:40:48 -0700 Comment on attachment 107818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107818&action=review LGTM, sorry for the breakage. You can submit this as "Unreviewed, build fix" (then you don't need to wait for a formal r+). > Source/WebKit/chromium/gyp_webkit:107 > + '-Dclang_use_chrome_plugins=0', This line should be enough, you shouldn't need the one above it (but it doesn't hurt either). Maybe add "# http://crbug.com/97043". 469508 4 abarth 2011-09-19 10:48:06 -0700 Adding a dependency on tools/clang seems better. We want the upstream and downstream builds to use the same compiler. 469510 5 thakis 2011-09-19 10:49:20 -0700 (In reply to comment #4) > Adding a dependency on tools/clang seems better. We want the upstream and downstream builds to use the same compiler. Yes, I'll get to that. But since the build uses gcc at the moment anyway, unbreaking this until I do seems better than leaving it broken. 469518 6 107885 jochen 2011-09-19 10:54:03 -0700 Created attachment 107885 Patch 469535 7 107885 abarth 2011-09-19 11:02:26 -0700 Comment on attachment 107885 Patch Okiedokes! 469601 8 107885 webkit.review.bot 2011-09-19 12:18:54 -0700 Comment on attachment 107885 Patch Clearing flags on attachment: 107885 Committed r95454: <http://trac.webkit.org/changeset/95454> 469602 9 webkit.review.bot 2011-09-19 12:18:58 -0700 All reviewed patches have been landed. Closing bug. 107818 2011-09-19 02:13:18 -0700 2011-09-19 10:53:57 -0700 Patch bug-68343-20110919111316.patch text/plain 1687 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OTc2YzBhMjA1ZWJiNTQwMGM3OWEyYWI4M2QxMGVhM2NjOThhZDFhMC4uYmVhYTE0ZTE4NTYyOGMy YTFhMDdiNTNkMjBkMDMxNjYzNTM1NDJhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wOS0xOSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIERpc2FibGUgY2xhbmcgd2hlbiBidWlsZGlu ZyBjaHJvbWl1bSBpbiBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY4MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBERVBTOgorICAgICAgICAqIGd5cF93ZWJraXQ6CisKIDIwMTEtMDktMTkg IElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGV4dGVuZCB0aW1lbGluZSBjb3ZlcmFnZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCBl ZGJjYTEyZDZjZmEyZDRjYTgxOWEzYTAwMTYyYjJjNGQ0Y2Q4ZDIxLi5jODM5ODcyOGU1OGEzNTJm ZjJjYzBlN2ZjZDkzMzBlMDA0M2I1N2FiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3 IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5v cmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYnOiAnMTAwNzQyJworICAnY2hyb21p dW1fcmV2JzogJzEwMTQ5NCcKIH0KIAogZGVwcyA9IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vZ3lwX3dlYmtpdCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtp dAppbmRleCA1MjQ3NzU2ODliOGI5ODU3MTFjMDAwY2I3ZGQ5NWE2OTZlOGU5ZThhLi4zMTMyMGQ1 MjhhMzI3ZmQzZDI1N2E4ZmM0MmMxODE4ZDAyY2M3ODJmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL2d5cF93ZWJraXQKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9neXBf d2Via2l0CkBAIC0xMDMsNiArMTAzLDggQEAgaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAg ICAgICAgICAgICAgICctRGluc2lkZV9jaHJvbWl1bV9idWlsZD0wJywKICAgICAgICAgICAgICAg ICctRHY4X3VzZV9zbmFwc2hvdD1mYWxzZScsCiAgICAgICAgICAgICAgICAnLURtc3ZzX3VzZV9j b21tb25fcmVsZWFzZT0wJywKKyAgICAgICAgICAgICAgICctRGNsYW5nPTAnLAorICAgICAgICAg ICAgICAgJy1EY2xhbmdfdXNlX2Nocm9tZV9wbHVnaW5zPTAnLAogCiAgICAgICAgICAgICAgICAj IGd5cCBoYWNrOiBvdGhlcndpc2UgZ3lwIGFzc3VtZXMgaXRzIGluIGNocm9taXVtJ3Mgc3JjLyBk aXIuCiAgICAgICAgICAgICAgICAnLS1kZXB0aD0uLycsCg== 107885 2011-09-19 10:54:03 -0700 2011-09-19 12:18:54 -0700 Patch bug-68343-20110919195401.patch text/plain 1693 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogOTU0MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg OTc2YzBhMjA1ZWJiNTQwMGM3OWEyYWI4M2QxMGVhM2NjOThhZDFhMC4uYmVhYTE0ZTE4NTYyOGMy YTFhMDdiNTNkMjBkMDMxNjYzNTM1NDJhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wOS0xOSAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIERpc2FibGUgY2xhbmcgd2hlbiBidWlsZGlu ZyBjaHJvbWl1bSBpbiBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY4MzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBERVBTOgorICAgICAgICAqIGd5cF93ZWJraXQ6CisKIDIwMTEtMDktMTkg IElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGV4dGVuZCB0aW1lbGluZSBjb3ZlcmFnZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCBl ZGJjYTEyZDZjZmEyZDRjYTgxOWEzYTAwMTYyYjJjNGQ0Y2Q4ZDIxLi5jODM5ODcyOGU1OGEzNTJm ZjJjYzBlN2ZjZDkzMzBlMDA0M2I1N2FiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0RFUFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3 IEBACiAKIHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5v cmcvc3ZuL3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYnOiAnMTAwNzQyJworICAnY2hyb21p dW1fcmV2JzogJzEwMTQ5NCcKIH0KIAogZGVwcyA9IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vZ3lwX3dlYmtpdCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtp dAppbmRleCA1MjQ3NzU2ODliOGI5ODU3MTFjMDAwY2I3ZGQ5NWE2OTZlOGU5ZThhLi43Njk3YWJj MDExZWJlOWE1M2U4MDNlYzk0MDMwMmZkOGY0YzcxZTJiIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL2d5cF93ZWJraXQKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9neXBf d2Via2l0CkBAIC0xMDQsNiArMTA0LDkgQEAgaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAg ICAgICAgICAgICAgICctRHY4X3VzZV9zbmFwc2hvdD1mYWxzZScsCiAgICAgICAgICAgICAgICAn LURtc3ZzX3VzZV9jb21tb25fcmVsZWFzZT0wJywKIAorICAgICAgICAgICAgICAgIyBUZW1wb3Jh cmlseSBkaXNhYmxlIGNsYW5nIHBsdWdpbnMuIGh0dHA6Ly9jcmJ1Zy5jb20vOTcwNDMKKyAgICAg ICAgICAgICAgICctRGNsYW5nX3VzZV9jaHJvbWVfcGx1Z2lucz0wJywKKwogICAgICAgICAgICAg ICAgIyBneXAgaGFjazogb3RoZXJ3aXNlIGd5cCBhc3N1bWVzIGl0cyBpbiBjaHJvbWl1bSdzIHNy Yy8gZGlyLgogICAgICAgICAgICAgICAgJy0tZGVwdGg9Li8nLAogCg==