68324 2011-09-18 11:35:13 -0700 [Gtk] metaKey modifier is not working with eventSender object 2015-05-07 18:01:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 0 webkit.devdatta webkit-unassigned mrobinson webkit.devdatta xan.lopez oldest_to_newest 469171 0 webkit.devdatta 2011-09-18 11:35:13 -0700 The metaKey modifier is not working as expected with the eventSender object. For e.g. eventSender.mouseDown(["metaKey"]) eventSender.mouseUp(["metaKey"]) eventSender.keyDown(["metaKey"]) should set the event.metaKey to true in the corresponding JavaScript event callback. But event.metaKey always returns false when the event is sent using eventSender object. 469173 1 107789 webkit.devdatta 2011-09-18 11:59:08 -0700 Created attachment 107789 Patch 504109 2 107789 xan.lopez 2011-11-16 11:49:00 -0800 Comment on attachment 107789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107789&action=review Looks good overall, r- for a few small comments. Thanks for the patch! > Tools/DumpRenderTree/gtk/EventSender.cpp:281 > else if (JSStringIsEqualToUTF8CString(string, "metaKey")) The indentation seems to be a bit screwed here? > LayoutTests/ChangeLog:9 > + using evnetSender object. s/evnet/event/ > LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:13 > + return; This seems a bit unnecessary? I'd just have metakey =false; <events with no metakey>; metakey = true; <events with metakey>; and set failed to true if the invariant breaks at any point? > LayoutTests/platform/gtk/fast/events/event-sender-metakey.html:38 > + resultDiv.innerHTML = (true == failed) ? "FAIL" : "PASS"; Simply failed? 1092920 3 mrobinson 2015-05-07 18:01:18 -0700 Closing this since WebKit1 is gone. 107789 2011-09-18 11:59:08 -0700 2011-11-16 11:49:00 -0800 Patch bug-68324-20110919002906.patch text/plain 4344 webkit.devdatta SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDk1Mzk3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDktMTggIERldmRhdHRhIERlc2hwYW5kZSAgPHB3amQ3M0Btb3Rvcm9s YS5jb20+CisKKyAgICAgICAgbWV0YUtleSBtb2RpZmllciBpcyBub3Qgd29ya2luZyB3aXRoIGV2 ZW50U2VuZGVyIG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjgzMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBHREtfTUVUQV9NQVNLIGlzIHVzZWQgdG8gcmVwcmVzZW50IG1ldGFLZXkgZm9yIHBs YXRmb3JtIEdUSyBtb3VzZSBhbmQKKyAgICAgICAga2V5Ym9hcmQgZXZlbnRzLiBTbyBtYWtpbmcg aXQgd2l0aCBzeW5jIHdpdGggV2ViQ29yZSBmaWxlcy4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL2d0ay9FdmVudFNlbmRlci5jcHA6CisgICAgICAgIChnZGtNb2RpZmllckZyb21KU1ZhbHVl KToKKwogMjAxMS0wOS0xNiAgRWxsaW90IFBvZ2VyICA8ZXBvZ2VyQGdvb2dsZS5jb20+CiAKICAg ICAgICAgYWRkIG5vbi1DRyBXZWJraXQtTWFjIGJ1aWxkcyB0byBmbGFraW5lc3MgZGFzaGJvYXJk CkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAJKHJldmlzaW9u IDkzOTQ4KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjc2LDEwICsyNzYsMTAgQEAgc3RhdGljIGd1aW50IGdka01vZGlmaWVy RnJvbUpTVmFsdWUoSlNDbwogICAgIGVsc2UgaWYgKEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJp bmcoc3RyaW5nLCAiYWx0S2V5IikpCiAgICAgICAgIGdka01vZGlmaWVyID0gR0RLX01PRDFfTUFT SzsKICAgICAKLSAgICAvLyBDdXJyZW50bHkgdGhlIG1ldGFLZXkgYXMgZGVmaW5lZCBpbiBXZWJD b3JlL3BsYXRmb3JtL2d0ay9Nb3VzZUV2ZW50R3RrLmNwcAotICAgIC8vIGlzIEdES19NT0QyX01B U0suIFRoaXMgY29kZSBtdXN0IGJlIGtlcHQgaW4gc3luYyB3aXRoIHRoYXQgZmlsZS4KKyAgICAv LyBDdXJyZW50bHkgdGhlIG1ldGFLZXkgYXMgZGVmaW5lZCBpbiBXZWJDb3JlL3BsYXRmb3JtL2d0 ay9QbGF0Zm9ybU1vdXNlRXZlbnRHdGsuY3BwCisgICAgLy8gaXMgR0RLX01FVEFfTUFTSy4gVGhp cyBjb2RlIG11c3QgYmUga2VwdCBpbiBzeW5jIHdpdGggdGhhdCBmaWxlLgogICAgIGVsc2UgaWYg KEpTU3RyaW5nSXNFcXVhbFRvVVRGOENTdHJpbmcoc3RyaW5nLCAibWV0YUtleSIpKQotICAgICAg ICBnZGtNb2RpZmllciA9IEdES19NT0QyX01BU0s7CisgICAgICAgIGdka01vZGlmaWVyID0gR0RL X01FVEFfTUFTSzsKICAgICAKICAgICBKU1N0cmluZ1JlbGVhc2Uoc3RyaW5nKTsKICAgICByZXR1 cm4gZ2RrTW9kaWZpZXI7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NTM5NykKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTA5LTE4ICBE ZXZkYXR0YSBEZXNocGFuZGUgIDxwd2pkNzNAbW90b3JvbGEuY29tPgorCisgICAgICAgIG1ldGFL ZXkgbW9kaWZpZXIgaXMgbm90IHdvcmtpbmcgd2l0aCBldmVudFNlbmRlciBvYmplY3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MzI0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHRlc3Rpbmcgc3Rh dGUgb2YgbWV0YUtleSBmb3IgbW91c2UgYW5kIGtleWJvYXJkIGV2ZW50cyBnZW5lcmF0ZWQKKyAg ICAgICAgdXNpbmcgZXZuZXRTZW5kZXIgb2JqZWN0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L2Zhc3QvZXZlbnRzL2V2ZW50LXNlbmRlci1tZXRha2V5LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL2Zhc3QvZXZlbnRzL2V2ZW50LXNlbmRlci1tZXRha2V5Lmh0 bWw6IEFkZGVkLgorCiAyMDExLTA5LTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+ CiAKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4NjAyODE+IERlY29tcG9zZWQgdGV4dCBpcyBk aXNwbGF5ZWQgaW5jb3JyZWN0bHkgd2hlbiBWZXJkYW5hIGlzIHNwZWNpZmllZApJbmRleDogTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZXZlbnRzL2V2ZW50LXNlbmRlci1tZXRha2V5LWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9l dmVudHMvZXZlbnQtc2VuZGVyLW1ldGFrZXktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZXZlbnRzL2V2ZW50LXNlbmRlci1tZXRha2V5 LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyIEBACitQQVNTCisKSW5kZXg6 IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2V2ZW50cy9ldmVudC1zZW5kZXItbWV0YWtl eS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2V2ZW50 cy9ldmVudC1zZW5kZXItbWV0YWtleS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL2Zhc3QvZXZlbnRzL2V2ZW50LXNlbmRlci1tZXRha2V5Lmh0bWwJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsNDAgQEAKKzxodG1sPgorPGJvZHk+Cis8ZGl2IGlkPSJyZXN1bHQi PjwvZGl2PgorPGlucHV0IGlkPSJ0ZXN0IiB0eXBlPSJidXR0b24iIHZhbHVlPSIiPgorPHNjcmlw dD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICB2YXIgbWV0YUtleSA9IGZhbHNlOwor ICAgIHZhciBmYWlsZWQgPSBmYWxzZTsKKyAgICBmdW5jdGlvbiBoYW5kbGVNZXRha2V5KGUpIHsK KyAgICAgICAgaWYodHJ1ZSA9PSBmYWlsZWQpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAg IGlmKGUubWV0YUtleSAhPSBtZXRhS2V5KQorICAgICAgICAgICAgZmFpbGVkID0gdHJ1ZTsKKyAg ICB9CisgICAgdmFyIHRlc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpOworICAg IHRlc3QuYWRkRXZlbnRMaXN0ZW5lcignbW91c2Vkb3duJywgaGFuZGxlTWV0YWtleSwgZmFsc2Up OworICAgIHRlc3QuYWRkRXZlbnRMaXN0ZW5lcignbW91c2V1cCcsIGhhbmRsZU1ldGFrZXksIGZh bHNlKTsKKyAgICB0ZXN0LmFkZEV2ZW50TGlzdGVuZXIoJ2tleWRvd24nLCBoYW5kbGVNZXRha2V5 LCBmYWxzZSk7CisKKyAgICB0ZXN0LmZvY3VzKCk7CisKKyAgICBldmVudFNlbmRlci5tb3VzZU1v dmVUbyh0ZXN0Lm9mZnNldExlZnQsIHRlc3Qub2Zmc2V0VG9wKTsKKworICAgIC8vIEV2ZW50cyB3 aXRoIG1ldGFrZXkgYXMgZmFsc2UKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBl dmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgZXZlbnRTZW5kZXIua2V5RG93bignYScpOworCisg ICAgLy8gRXZlbnRzIHdpdGggbWV0YWtleSBhcyB0cnVlCisgICAgbWV0YUtleSA9IHRydWU7Cisg ICAgZXZlbnRTZW5kZXIubW91c2VEb3duKDEsIFsibWV0YUtleSJdKTsKKyAgICBldmVudFNlbmRl ci5tb3VzZVVwKDEsIFsibWV0YUtleSJdKTsKKyAgICBldmVudFNlbmRlci5rZXlEb3duKCdhJywg WyJtZXRhS2V5Il0pOworCisgICAgdmFyIHJlc3VsdERpdiA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJyZXN1bHQiKTsKKyAgICByZXN1bHREaXYuaW5uZXJIVE1MID0gKHRydWUgPT0gZmFpbGVk KSA/ICJGQUlMIiA6ICJQQVNTIjsKKzwvc2NyaXB0PgorPC9ib2R5PgpcIE5vIG5ld2xpbmUgYXQg ZW5kIG9mIGZpbGUK