68313 2011-09-17 12:15:01 -0700 Web Inspector: chromium: "Save timeline data" does nothing . 2011-09-18 22:33:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All Windows 7 RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein fam.lam joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 469082 0 loislo 2011-09-17 12:15:01 -0700 windows shell API function GetSaveFileName doesn't accept file names with ':' symbol. 469086 1 107771 loislo 2011-09-17 12:30:51 -0700 Created attachment 107771 [patch] initial version 469156 2 107788 loislo 2011-09-18 01:46:33 -0700 Created attachment 107788 [patch] second iteration 469157 3 107788 pfeldman 2011-09-18 05:29:25 -0700 Comment on attachment 107788 [patch] second iteration View in context: https://bugs.webkit.org/attachment.cgi?id=107788&action=review > Source/WebCore/inspector/front-end/utilities.js:552 > + (!offset ? "Z" : offsetString); No need to include 'Z' and offset. No Z should be treated as local (non UTC time). 469243 4 loislo 2011-09-18 22:33:47 -0700 Committed r95401: <http://trac.webkit.org/changeset/95401> 107771 2011-09-17 12:30:51 -0700 2011-09-18 01:46:33 -0700 [patch] initial version patch text/plain 1445 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiODMyNWUzLi42ZjdiNTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDktMTcgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNocm9taXVtLXdpbjogIlNhdmUgdGltZWxpbmUgZGF0 YSIgZG9lcyBub3RoaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjgzMTMKKworICAgICAgICB3aW5kb3dzIHNoZWxsIEFQSSBmdW5jdGlvbiBHZXRT YXZlRmlsZU5hbWUgZG9lc24ndCBhY2NlcHQgZmlsZSBuYW1lcyB3aXRoICc6JyBzeW1ib2wuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGlt ZWxpbmVNb2RlbC5wcm90b3R5cGUuX3NhdmVUb0ZpbGUpOgorCiAyMDExLTA5LTE3ICBKZWZmIE1p bGxlciAgPGplZmZtQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjk1Mzcy LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGlu ZVBhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBh bmVsLmpzCmluZGV4IGVkM2EwYTcuLjBjOWUzYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTEzNTAsNyArMTM1MCw4 IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg IHJlY29yZHNbcmVjb3Jkcy5sZW5ndGggLSAxXSA9IHJlY29yZHNbcmVjb3Jkcy5sZW5ndGggLSAx XSArICJdIjsKIAogICAgICAgICB2YXIgbm93PSBuZXcgRGF0ZSgpOwotICAgICAgICBJbnNwZWN0 b3JGcm9udGVuZEhvc3Quc2F2ZUFzKCJUaW1lbGluZVJhd0RhdGEtIiArIG5vdy50b1JGQzMzMzko KSArICIuanNvbiIsIHJlY29yZHMuam9pbigiLFxuIikpOworICAgICAgICB2YXIgc3VnZ2VzdGVk RmlsZU5hbWUgPSAiVGltZWxpbmVSYXdEYXRhLSIgKyBub3cudG9SRkMzMzM5KCkucmVwbGFjZSgv Oi9nLCAiLSIpICsgIi5qc29uIjsKKyAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnNhdmVB cyhzdWdnZXN0ZWRGaWxlTmFtZSwgcmVjb3Jkcy5qb2luKCIsXG4iKSk7CiAgICAgfSwKIAogICAg IF9yZXNldDogZnVuY3Rpb24oKQo= 107788 2011-09-18 01:46:33 -0700 2011-09-18 05:29:25 -0700 [patch] second iteration patch text/plain 2848 loislo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxYTc4YjBiLi4xOTg2ZDRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDktMTcgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNocm9taXVtLXdpbjogIlNhdmUgdGltZWxpbmUgZGF0 YSIgZG9lcyBub3RoaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjgzMTMKKworICAgICAgICB3aW5kb3dzIHNoZWxsIEFQSSBmdW5jdGlvbiBHZXRT YXZlRmlsZU5hbWUgZG9lc24ndCBhY2NlcHQgZmlsZSBuYW1lcyB3aXRoICc6JyBzeW1ib2wuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGlt ZWxpbmVNb2RlbC5wcm90b3R5cGUuX3NhdmVUb0ZpbGUpOgorCiAyMDExLTA5LTE3ICBNaWhhaSBQ YXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZyYW1lTG9hZGVyQ2xp ZW50IEJhY2tGb3J3YXJkTGlzdC1yZWxhdGVkIG1ldGhvZHMgYXJlIHVuc3VlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzCmluZGV4 IDgwMTVjMTYuLmQ5YzBkN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKQEAgLTEzNTAsNyArMTM1MCw4IEBAIFdlYkluc3Bl Y3Rvci5UaW1lbGluZU1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJlY29yZHNbcmVj b3Jkcy5sZW5ndGggLSAxXSA9IHJlY29yZHNbcmVjb3Jkcy5sZW5ndGggLSAxXSArICJdIjsKIAog ICAgICAgICB2YXIgbm93PSBuZXcgRGF0ZSgpOwotICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhv c3Quc2F2ZUFzKCJUaW1lbGluZVJhd0RhdGEtIiArIG5vdy50b1JGQzMzMzkoKSArICIuanNvbiIs IHJlY29yZHMuam9pbigiLFxuIikpOworICAgICAgICB2YXIgc3VnZ2VzdGVkRmlsZU5hbWUgPSAi VGltZWxpbmVSYXdEYXRhLSIgKyBub3cudG9JU084NjAxQ29tcGFjdCgpICsgIi5qc29uIjsKKyAg ICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnNhdmVBcyhzdWdnZXN0ZWRGaWxlTmFtZSwgcmVj b3Jkcy5qb2luKCIsXG4iKSk7CiAgICAgfSwKIAogICAgIF9yZXNldDogZnVuY3Rpb24oKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwppbmRleCA0 M2FhZDVmLi5kYWUyMzQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL3V0aWxpdGllcy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL3V0aWxpdGllcy5qcwpAQCAtNTM1LDIxICs1MzUsMjEgQEAgTnVtYmVyLmNvbnN0cmFpbiA9 IGZ1bmN0aW9uKG51bSwgbWluLCBtYXgpCiAgICAgcmV0dXJuIG51bTsKIH0KIAotRGF0ZS5wcm90 b3R5cGUudG9SRkMzMzM5ID0gZnVuY3Rpb24oKQorRGF0ZS5wcm90b3R5cGUudG9JU084NjAxQ29t cGFjdCA9IGZ1bmN0aW9uKCkKIHsKICAgICBmdW5jdGlvbiBsZWFkWmVybyh4KQogICAgIHsKICAg ICAgICAgcmV0dXJuIHggPiA5ID8geCA6ICcwJyArIHgKICAgICB9CiAgICAgdmFyIG9mZnNldCA9 IE1hdGguYWJzKHRoaXMuZ2V0VGltZXpvbmVPZmZzZXQoKSk7Ci0gICAgdmFyIG9mZnNldFN0cmlu ZyA9IE1hdGguZmxvb3Iob2Zmc2V0IC8gNjApICsgJzonICsgbGVhZFplcm8ob2Zmc2V0ICUgNjAp OwotICAgIHJldHVybiB0aGlzLmdldEZ1bGxZZWFyKCkgKyAnLScgKwotICAgICAgICAgICBsZWFk WmVybyh0aGlzLmdldE1vbnRoKCkgKyAxKSArICctJyArCisgICAgdmFyIG9mZnNldFN0cmluZyA9 IChvZmZzZXQgPiAwID8gJy0nIDogJysnKSArIGxlYWRaZXJvKE1hdGguZmxvb3Iob2Zmc2V0IC8g NjApKSArIGxlYWRaZXJvKG9mZnNldCAlIDYwKTsKKyAgICByZXR1cm4gdGhpcy5nZXRGdWxsWWVh cigpICsKKyAgICAgICAgICAgbGVhZFplcm8odGhpcy5nZXRNb250aCgpICsgMSkgKwogICAgICAg ICAgICBsZWFkWmVybyh0aGlzLmdldERhdGUoKSkgKyAnVCcgKwotICAgICAgICAgICBsZWFkWmVy byh0aGlzLmdldEhvdXJzKCkpICsgJzonICsKLSAgICAgICAgICAgbGVhZFplcm8odGhpcy5nZXRN aW51dGVzKCkpICsgJzonICsKKyAgICAgICAgICAgbGVhZFplcm8odGhpcy5nZXRIb3VycygpKSAr CisgICAgICAgICAgIGxlYWRaZXJvKHRoaXMuZ2V0TWludXRlcygpKSArCiAgICAgICAgICAgIGxl YWRaZXJvKHRoaXMuZ2V0U2Vjb25kcygpKSArCi0gICAgICAgICAgICghb2Zmc2V0ID8gIloiIDog KHRoaXMuZ2V0VGltZXpvbmVPZmZzZXQoKSA+IDAgPyAnLScgOiAnKycpICsgb2Zmc2V0U3RyaW5n KTsKKyAgICAgICAgICAgKCFvZmZzZXQgPyAiWiIgOiBvZmZzZXRTdHJpbmcpOwogfQogCiBIVE1M VGV4dEFyZWFFbGVtZW50LnByb3RvdHlwZS5tb3ZlQ3Vyc29yVG9FbmQgPSBmdW5jdGlvbigpCg==