68280 2011-09-16 14:25:15 -0700 [Qt] QDeskWebView missing loadProgress tests 2011-09-20 06:57:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gopal.1.raghavan webkit-unassigned kling webkit.review.bot oldest_to_newest 468805 0 gopal.1.raghavan 2011-09-16 14:25:15 -0700 loadProgres tests are missing for DesktopWebView 468813 1 107724 gopal.1.raghavan 2011-09-16 14:33:02 -0700 Created attachment 107724 DesktopWebView loadProgress test Added test to check loadProgress in DesktopWebView 469356 2 107724 kling 2011-09-19 06:14:14 -0700 Comment on attachment 107724 DesktopWebView loadProgress test View in context: https://bugs.webkit.org/attachment.cgi?id=107724&action=review Test is fine, but let's not break the ChangeLog. > Source/WebKit2/ChangeLog:2 > +2011-09-16 Gopal Raghavan <gopal.1.raghavan@nokia.com> > + [Qt] QDesktopWebView missing loadProgress tests Missing newline between these two lines. 469389 3 107853 gopal.1.raghavan 2011-09-19 07:59:27 -0700 Created attachment 107853 updated patch with reviewer comments Fixed changelog. 469395 4 107853 kling 2011-09-19 08:09:49 -0700 Comment on attachment 107853 updated patch with reviewer comments View in context: https://bugs.webkit.org/attachment.cgi?id=107853&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:24 > + function test_loadProgress() { > + compare(spy.count, 0) > + var testUrl = Qt.resolvedUrl("../common/test1.html") > + webView.load(testUrl) > + compare(webView.loadProgress, 0) > + spy.wait() > + compare(webView.loadProgress, 100) > + } A couple of things: - The 'testUrl' variable is not necessary, just webView.load(Qt.resolvedUrl(...)) - We should check the value of loadProgress before calling load() as well. - This test only exercises the READ function of the loadProgress property. Why not also test that we get notified when it changes? 469437 5 107869 gopal.1.raghavan 2011-09-19 09:11:25 -0700 Created attachment 107869 updated patch with reviewer comments Updated patch with reviewer comments. Cleanup loadProgress test. Added new test to check loadProgress signal. 469440 6 107871 gopal.1.raghavan 2011-09-19 09:16:00 -0700 Created attachment 107871 updated patch with reviewer comments Updated with reviewer comments. - cleanup loadProgress test - added new test for loadProgress signal 469545 7 107871 menard 2011-09-19 11:12:00 -0700 Comment on attachment 107871 updated patch with reviewer comments View in context: https://bugs.webkit.org/attachment.cgi?id=107871&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:27 > + spyProgress.wait() Can't it already be 100 right after this call? So the next line may fail? Also seems like https://gitorious.org/webkit/webkit/blobs/master/Source/WebKit2/UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml has possibly the same problem. In any case look at the touchview and make sure they are in sync. 469552 8 gopal.1.raghavan 2011-09-19 11:17:46 -0700 This is checking loadProgressChanged signal. You are right the progress could hit 100. Typically, I am seeing it give values like 40, 50 etc., I am planning to change that range. Let me upload another patch. Thanks. 469565 9 107894 gopal.1.raghavan 2011-09-19 11:30:25 -0700 Created attachment 107894 updated patch with reviewer comments Modified logic to cover edge cases. This test will catch loadProgressChanged signal between range 0 to 100 and validate it. 469568 10 gopal.1.raghavan 2011-09-19 11:32:09 -0700 Here is the test case results: ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : DesktopWebViewLoadProgress::initTestCase() QWARN : DesktopWebViewLoadProgress::test_loadProgress() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : DesktopWebViewLoadProgress::test_loadProgress() PASS : DesktopWebViewLoadProgress::cleanupTestCase() PASS : DesktopWebViewLoadProgressSignal::initTestCase() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : DesktopWebViewLoadProgressSignal::test_loadProgressSignal() PASS : DesktopWebViewLoadProgressSignal::cleanupTestCase() QWARN : qmltests::UnknownTestFunc() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase() QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase() PASS : DesktopWebViewProperties::initTestCase() QWARN : DesktopWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : DesktopWebViewProperties::test_title() PASS : DesktopWebViewProperties::test_url() PASS : DesktopWebViewProperties::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QWARN : TouchWebViewLoad::test_load() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_load() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_loadNegativeSizeView() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewLoadProgress::initTestCase() QWARN : TouchWebViewLoadProgress::test_loadProgress() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoadProgress::test_loadProgress() PASS : TouchWebViewLoadProgress::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_loadZeroSizeView() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewProperties::initTestCase() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewProperties::test_title() PASS : TouchWebViewProperties::test_url() PASS : TouchWebViewProperties::cleanupTestCase() Totals: 30 passed, 0 failed, 0 skipped ********* Finished testing of qmltests ********* Number of leaked textures: 0 Number of leaked materials: 0 Number of leaked nodes: 0 LEAK: 9 WebContext Number of leaked items: 0 469995 11 107894 menard 2011-09-20 05:37:36 -0700 Comment on attachment 107894 updated patch with reviewer comments View in context: https://bugs.webkit.org/attachment.cgi?id=107894&action=review Informal Review : r- > Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:28 > + compare(true, webView.loadProgress > -1 && webView.loadProgress < 101) OMG This is just wrong. I said it may be that by the time you finish spyProgress.wait() the progress is already 100. Can't you just do compare(loadProgress != 0)? 469997 12 107894 menard 2011-09-20 05:39:24 -0700 Comment on attachment 107894 updated patch with reviewer comments View in context: https://bugs.webkit.org/attachment.cgi?id=107894&action=review >> Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:28 >> + compare(true, webView.loadProgress > -1 && webView.loadProgress < 101) > > OMG This is just wrong. I said it may be that by the time you finish spyProgress.wait() the progress is already 100. Can't you just do compare(loadProgress != 0)? Or is it possible that you get a first call with 0 as a value? 469998 13 kling 2011-09-20 05:42:12 -0700 (In reply to comment #12) > (From update of attachment 107894 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107894&action=review > > >> Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:28 > >> + compare(true, webView.loadProgress > -1 && webView.loadProgress < 101) > > > > OMG This is just wrong. I said it may be that by the time you finish spyProgress.wait() the progress is already 100. Can't you just do compare(loadProgress != 0)? > > Or is it possible that you get a first call with 0 as a value? I rs+ the patch assuming that it works as-is. 470038 14 107894 webkit.review.bot 2011-09-20 06:57:53 -0700 Comment on attachment 107894 updated patch with reviewer comments Clearing flags on attachment: 107894 Committed r95537: <http://trac.webkit.org/changeset/95537> 470039 15 webkit.review.bot 2011-09-20 06:57:57 -0700 All reviewed patches have been landed. Closing bug. 107724 2011-09-16 14:33:02 -0700 2011-09-19 07:59:27 -0700 DesktopWebView loadProgress test 68280.patch text/plain 2399 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MzI1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTYgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisgICAgICAgIFtRdF0gUURlc2t0 b3BXZWJWaWV3IG1pc3NpbmcgbG9hZFByb2dyZXNzIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODI4MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRlc3QgY2FzZSB0byBjaGVjayBsb2Fk IHByb2dyZXNzIGZvciBRRGVza3RvcFdlYlZpZXcKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWw6IEFk ZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMu cHJvOgorCiAyMDExLTA5LTE2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIGJhY2sgdGhlIFdLSGl0VGVzdFJlc3VsdFJlZiBwYXJhbWV0ZXIgdG8g bW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQgaW4gYW4gQUJJIHByZXNlcnZpbmcgd2F5CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBy bwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Ft bHRlc3RzL3FtbHRlc3RzLnBybwkocmV2aXNpb24gOTUyMTApCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBybwkod29ya2luZyBjb3B5 KQpAQCAtMTEsNiArMTEsNyBAQCBERUZJTkVTICs9IFFVSUNLX1RFU1RfU09VUkNFX0RJUj1cIlxc XCIkCiBPVEhFUl9GSUxFUyArPSBcCiAgICAgRGVza3RvcFdlYlZpZXcvdHN0X3Byb3BlcnRpZXMu cW1sIFwKICAgICBEZXNrdG9wV2ViVmlldy90c3RfbmF2aWdhdGlvblBvbGljeUZvclVybC5xbWwg XAorICAgIERlc2t0b3BXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3MucW1sIFwKICAgICBUb3VjaFdl YlZpZXcvdHN0X3Byb3BlcnRpZXMucW1sIFwKICAgICBUb3VjaFdlYlZpZXcvdHN0X2xvYWRaZXJv U2l6ZVZpZXcucW1sIFwKICAgICBUb3VjaFdlYlZpZXcvdHN0X2xvYWROZWdhdGl2ZVNpemVWaWV3 LnFtbApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzLnFtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3 L3RzdF9sb2FkUHJvZ3Jlc3MucW1sCShyZXZpc2lvbiAwKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dy ZXNzLnFtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNiBAQAoraW1wb3J0IFF0UXVpY2sgMi4w CitpbXBvcnQgUXRUZXN0IDEuMAoraW1wb3J0IFF0V2ViS2l0LmV4cGVyaW1lbnRhbCA1LjAKKwor RGVza3RvcFdlYlZpZXcgeworICAgIGlkOiB3ZWJWaWV3CisKKyAgICBTaWduYWxTcHkgeworICAg ICAgICBpZDogc3B5CisgICAgICAgIHRhcmdldDogd2ViVmlldworICAgICAgICBzaWduYWxOYW1l OiAibG9hZFN1Y2NlZWRlZCIKKyAgICB9CisKKyAgICBUZXN0Q2FzZSB7CisgICAgICAgIG5hbWU6 ICJEZXNrdG9wV2ViVmlld0xvYWRQcm9ncmVzcyIKKworICAgICAgICBmdW5jdGlvbiB0ZXN0X2xv YWRQcm9ncmVzcygpIHsKKyAgICAgICAgICAgIGNvbXBhcmUoc3B5LmNvdW50LCAwKQorICAgICAg ICAgICAgdmFyIHRlc3RVcmwgPSBRdC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL3Rlc3QxLmh0bWwi KQorICAgICAgICAgICAgd2ViVmlldy5sb2FkKHRlc3RVcmwpCisgICAgICAgICAgICBjb21wYXJl KHdlYlZpZXcubG9hZFByb2dyZXNzLCAwKQorICAgICAgICAgICAgc3B5LndhaXQoKQorICAgICAg ICAgICAgY29tcGFyZSh3ZWJWaWV3LmxvYWRQcm9ncmVzcywgMTAwKQorICAgICAgICB9CisgICAg fQorfQo= 107853 2011-09-19 07:59:27 -0700 2011-09-19 09:11:25 -0700 updated patch with reviewer comments 68280a.patch text/plain 2340 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NDE0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMTkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBRRGVz a3RvcFdlYlZpZXcgbWlzc2luZyBsb2FkUHJvZ3Jlc3MgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjgwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBjYXNlIHRvIGNoZWNrIGxv YWQgcHJvZ3Jlc3MgZm9yIFFEZXNrdG9wV2ViVmlldworCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzLnFtbDog QWRkZWQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0 cy5wcm86CisKIDIwMTEtMDktMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIEZpeCBkaXN0Y2hlY2sgYnVpbGQKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvcW1sdGVzdHMucHJvCShyZXZpc2lvbiA5NTQxMykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvCSh3b3JraW5nIGNvcHkpCkBA IC0xMSw2ICsxMSw3IEBAIERFRklORVMgKz0gUVVJQ0tfVEVTVF9TT1VSQ0VfRElSPVwiXFxcIiQK IE9USEVSX0ZJTEVTICs9IFwKICAgICBEZXNrdG9wV2ViVmlldy90c3RfcHJvcGVydGllcy5xbWwg XAogICAgIERlc2t0b3BXZWJWaWV3L3RzdF9uYXZpZ2F0aW9uUG9saWN5Rm9yVXJsLnFtbCBcCisg ICAgRGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwgXAogICAgIFRvdWNoV2ViVmll dy90c3RfcHJvcGVydGllcy5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZFplcm9TaXpl Vmlldy5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZE5lZ2F0aXZlU2l6ZVZpZXcucW1s IFwKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMv RGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90 c3RfbG9hZFByb2dyZXNzLnFtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVz cy5xbWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjYgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAor aW1wb3J0IFF0VGVzdCAxLjAKK2ltcG9ydCBRdFdlYktpdC5leHBlcmltZW50YWwgNS4wCisKK0Rl c2t0b3BXZWJWaWV3IHsKKyAgICBpZDogd2ViVmlldworCisgICAgU2lnbmFsU3B5IHsKKyAgICAg ICAgaWQ6IHNweQorICAgICAgICB0YXJnZXQ6IHdlYlZpZXcKKyAgICAgICAgc2lnbmFsTmFtZTog ImxvYWRTdWNjZWVkZWQiCisgICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAi RGVza3RvcFdlYlZpZXdMb2FkUHJvZ3Jlc3MiCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9sb2Fk UHJvZ3Jlc3MoKSB7CisgICAgICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMCkKKyAgICAgICAg ICAgIHZhciB0ZXN0VXJsID0gUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5odG1sIikK KyAgICAgICAgICAgIHdlYlZpZXcubG9hZCh0ZXN0VXJsKQorICAgICAgICAgICAgY29tcGFyZSh3 ZWJWaWV3LmxvYWRQcm9ncmVzcywgMCkKKyAgICAgICAgICAgIHNweS53YWl0KCkKKyAgICAgICAg ICAgIGNvbXBhcmUod2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDEwMCkKKyAgICAgICAgfQorICAgIH0K K30K 107869 2011-09-19 09:11:25 -0700 2011-09-19 09:16:00 -0700 updated patch with reviewer comments 68280b.patch text/plain 3705 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NDE2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMTkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBRRGVz a3RvcFdlYlZpZXcgbWlzc2luZyBsb2FkUHJvZ3Jlc3MgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjgwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBjYXNlIHRvIGNoZWNrIGxv YWQgcHJvZ3Jlc3MgcHJvcGVydHkgYW5kIHNpZ25hbCBmb3IgUURlc2t0b3BXZWJWaWV3CisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3Rz dF9sb2FkUHJvZ3Jlc3MucW1sOiBBZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3NTaWduYWwucW1sOiBB ZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3Rz LnBybzoKKwogMjAxMS0wOS0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gRml4IGRpc3RjaGVjayBidWlsZApJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9xbWx0ZXN0cy5wcm8JKHJldmlzaW9uIDk1NDEzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8JKHdvcmtpbmcgY29weSkKQEAg LTExLDYgKzExLDggQEAgREVGSU5FUyArPSBRVUlDS19URVNUX1NPVVJDRV9ESVI9XCJcXFwiJAog T1RIRVJfRklMRVMgKz0gXAogICAgIERlc2t0b3BXZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbCBc CiAgICAgRGVza3RvcFdlYlZpZXcvdHN0X25hdmlnYXRpb25Qb2xpY3lGb3JVcmwucW1sIFwKKyAg ICBEZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzLnFtbCBcCisgICAgRGVza3RvcFdlYlZp ZXcvdHN0X2xvYWRQcm9ncmVzc1NpZ25hbC5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfcHJv cGVydGllcy5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZFplcm9TaXplVmlldy5xbWwg XAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZE5lZ2F0aXZlU2l6ZVZpZXcucW1sIFwKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdl YlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFBy b2dyZXNzLnFtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMjYgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAoraW1wb3J0IFF0 VGVzdCAxLjAKK2ltcG9ydCBRdFdlYktpdC5leHBlcmltZW50YWwgNS4wCisKK0Rlc2t0b3BXZWJW aWV3IHsKKyAgICBpZDogd2ViVmlldworCisgICAgU2lnbmFsU3B5IHsKKyAgICAgICAgaWQ6IHNw eQorICAgICAgICB0YXJnZXQ6IHdlYlZpZXcKKyAgICAgICAgc2lnbmFsTmFtZTogImxvYWRTdWNj ZWVkZWQiCisgICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAiRGVza3RvcFdl YlZpZXdMb2FkUHJvZ3Jlc3MiCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9sb2FkUHJvZ3Jlc3Mo KSB7CisgICAgICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMCkKKyAgICAgICAgICAgIGNvbXBh cmUod2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDApCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQu cmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5odG1sIikpCisgICAgICAgICAgICBjb21wYXJl KHdlYlZpZXcubG9hZFByb2dyZXNzLCAwKQorICAgICAgICAgICAgc3B5LndhaXQoKQorICAgICAg ICAgICAgY29tcGFyZSh3ZWJWaWV3LmxvYWRQcm9ncmVzcywgMTAwKQorICAgICAgICB9CisgICAg fQorfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BX ZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3NTaWduYWwucW1sCShyZXZpc2lvbiAwKQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90 c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMyBAQAor aW1wb3J0IFF0UXVpY2sgMi4wCitpbXBvcnQgUXRUZXN0IDEuMAoraW1wb3J0IFF0V2ViS2l0LmV4 cGVyaW1lbnRhbCA1LjAKKworRGVza3RvcFdlYlZpZXcgeworICAgIGlkOiB3ZWJWaWV3CisKKyAg ICBTaWduYWxTcHkgeworICAgICAgICBpZDogc3B5CisgICAgICAgIHRhcmdldDogd2ViVmlldwor ICAgICAgICBzaWduYWxOYW1lOiAibG9hZFN1Y2NlZWRlZCIKKyAgICB9CisKKyAgICBTaWduYWxT cHkgeworICAgICAgICBpZDogc3B5UHJvZ3Jlc3MKKyAgICAgICAgdGFyZ2V0OiB3ZWJWaWV3Cisg ICAgICAgIHNpZ25hbE5hbWU6ICJsb2FkUHJvZ3Jlc3NDaGFuZ2VkIgorICAgIH0KKworICAgIFRl c3RDYXNlIHsKKyAgICAgICAgbmFtZTogIkRlc2t0b3BXZWJWaWV3TG9hZFByb2dyZXNzU2lnbmFs IgorCisgICAgICAgIGZ1bmN0aW9uIHRlc3RfbG9hZFByb2dyZXNzU2lnbmFsKCkgeworICAgICAg ICAgICAgY29tcGFyZShzcHlQcm9ncmVzcy5jb3VudCwgMCkKKyAgICAgICAgICAgIHdlYlZpZXcu bG9hZChRdC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL3Rlc3QxLmh0bWwiKSkKKyAgICAgICAgICAg IHNweVByb2dyZXNzLndhaXQoKQorICAgICAgICAgICAgY29tcGFyZSh0cnVlLCB3ZWJWaWV3Lmxv YWRQcm9ncmVzcyA+IDAgJiYgd2ViVmlldy5sb2FkUHJvZ3Jlc3MgPCAxMDApCisgICAgICAgICAg ICBzcHkud2FpdCgpCisgICAgICAgICAgICBzcHlQcm9ncmVzcy53YWl0KCkKKyAgICAgICAgICAg IGNvbXBhcmUod2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDEwMCkKKyAgICAgICAgfQorICAgIH0KK30K 107871 2011-09-19 09:16:00 -0700 2011-09-19 11:30:25 -0700 updated patch with reviewer comments 68280c.patch text/plain 3751 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NDE2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMTkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBRRGVz a3RvcFdlYlZpZXcgbWlzc2luZyBsb2FkUHJvZ3Jlc3MgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjgwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBjYXNlIHRvIGNoZWNrIGxv YWQgcHJvZ3Jlc3MgcHJvcGVydHkgYW5kIHNpZ25hbCBmb3IgUURlc2t0b3BXZWJWaWV3CisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3Rz dF9sb2FkUHJvZ3Jlc3MucW1sOiBBZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3NTaWduYWwucW1sOiBB ZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3Rz LnBybzoKKwogMjAxMS0wOS0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gRml4IGRpc3RjaGVjayBidWlsZApJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9xbWx0ZXN0cy5wcm8JKHJldmlzaW9uIDk1NDEzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8JKHdvcmtpbmcgY29weSkKQEAg LTExLDYgKzExLDggQEAgREVGSU5FUyArPSBRVUlDS19URVNUX1NPVVJDRV9ESVI9XCJcXFwiJAog T1RIRVJfRklMRVMgKz0gXAogICAgIERlc2t0b3BXZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbCBc CiAgICAgRGVza3RvcFdlYlZpZXcvdHN0X25hdmlnYXRpb25Qb2xpY3lGb3JVcmwucW1sIFwKKyAg ICBEZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzLnFtbCBcCisgICAgRGVza3RvcFdlYlZp ZXcvdHN0X2xvYWRQcm9ncmVzc1NpZ25hbC5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfcHJv cGVydGllcy5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZFplcm9TaXplVmlldy5xbWwg XAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZE5lZ2F0aXZlU2l6ZVZpZXcucW1sIFwKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdl YlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFBy b2dyZXNzLnFtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMjYgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAoraW1wb3J0IFF0 VGVzdCAxLjAKK2ltcG9ydCBRdFdlYktpdC5leHBlcmltZW50YWwgNS4wCisKK0Rlc2t0b3BXZWJW aWV3IHsKKyAgICBpZDogd2ViVmlldworCisgICAgU2lnbmFsU3B5IHsKKyAgICAgICAgaWQ6IHNw eQorICAgICAgICB0YXJnZXQ6IHdlYlZpZXcKKyAgICAgICAgc2lnbmFsTmFtZTogImxvYWRTdWNj ZWVkZWQiCisgICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAiRGVza3RvcFdl YlZpZXdMb2FkUHJvZ3Jlc3MiCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9sb2FkUHJvZ3Jlc3Mo KSB7CisgICAgICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMCkKKyAgICAgICAgICAgIGNvbXBh cmUod2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDApCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQu cmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5odG1sIikpCisgICAgICAgICAgICBjb21wYXJl KHdlYlZpZXcubG9hZFByb2dyZXNzLCAwKQorICAgICAgICAgICAgc3B5LndhaXQoKQorICAgICAg ICAgICAgY29tcGFyZSh3ZWJWaWV3LmxvYWRQcm9ncmVzcywgMTAwKQorICAgICAgICB9CisgICAg fQorfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BX ZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3NTaWduYWwucW1sCShyZXZpc2lvbiAwKQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90 c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzNCBAQAor aW1wb3J0IFF0UXVpY2sgMi4wCitpbXBvcnQgUXRUZXN0IDEuMAoraW1wb3J0IFF0V2ViS2l0LmV4 cGVyaW1lbnRhbCA1LjAKKworRGVza3RvcFdlYlZpZXcgeworICAgIGlkOiB3ZWJWaWV3CisKKyAg ICBTaWduYWxTcHkgeworICAgICAgICBpZDogc3B5CisgICAgICAgIHRhcmdldDogd2ViVmlldwor ICAgICAgICBzaWduYWxOYW1lOiAibG9hZFN1Y2NlZWRlZCIKKyAgICB9CisKKyAgICBTaWduYWxT cHkgeworICAgICAgICBpZDogc3B5UHJvZ3Jlc3MKKyAgICAgICAgdGFyZ2V0OiB3ZWJWaWV3Cisg ICAgICAgIHNpZ25hbE5hbWU6ICJsb2FkUHJvZ3Jlc3NDaGFuZ2VkIgorICAgIH0KKworICAgIFRl c3RDYXNlIHsKKyAgICAgICAgbmFtZTogIkRlc2t0b3BXZWJWaWV3TG9hZFByb2dyZXNzU2lnbmFs IgorCisgICAgICAgIGZ1bmN0aW9uIHRlc3RfbG9hZFByb2dyZXNzU2lnbmFsKCkgeworICAgICAg ICAgICAgY29tcGFyZShzcHlQcm9ncmVzcy5jb3VudCwgMCkKKyAgICAgICAgICAgIGNvbXBhcmUo d2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDApCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQucmVz b2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5odG1sIikpCisgICAgICAgICAgICBzcHlQcm9ncmVz cy53YWl0KCkKKyAgICAgICAgICAgIGNvbXBhcmUodHJ1ZSwgd2ViVmlldy5sb2FkUHJvZ3Jlc3Mg PiAwICYmIHdlYlZpZXcubG9hZFByb2dyZXNzIDwgMTAwKQorICAgICAgICAgICAgc3B5LndhaXQo KQorICAgICAgICAgICAgc3B5UHJvZ3Jlc3Mud2FpdCgpCisgICAgICAgICAgICBjb21wYXJlKHdl YlZpZXcubG9hZFByb2dyZXNzLCAxMDApCisgICAgICAgIH0KKyAgICB9Cit9Cg== 107894 2011-09-19 11:30:25 -0700 2011-09-20 06:57:53 -0700 updated patch with reviewer comments 68280d.patch text/plain 3854 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1NDE2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMTkgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBRRGVz a3RvcFdlYlZpZXcgbWlzc2luZyBsb2FkUHJvZ3Jlc3MgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjgwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCBjYXNlIHRvIGNoZWNrIGxv YWQgcHJvZ3Jlc3MgcHJvcGVydHkgYW5kIHNpZ25hbCBmb3IgUURlc2t0b3BXZWJWaWV3CisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3Rz dF9sb2FkUHJvZ3Jlc3MucW1sOiBBZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rl c3RzL3FtbHRlc3RzL0Rlc2t0b3BXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3NTaWduYWwucW1sOiBB ZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3Rz LnBybzoKKwogMjAxMS0wOS0xOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gRml4IGRpc3RjaGVjayBidWlsZApJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9xbWx0ZXN0cy5wcm8JKHJldmlzaW9uIDk1NDEzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8JKHdvcmtpbmcgY29weSkKQEAg LTExLDYgKzExLDggQEAgREVGSU5FUyArPSBRVUlDS19URVNUX1NPVVJDRV9ESVI9XCJcXFwiJAog T1RIRVJfRklMRVMgKz0gXAogICAgIERlc2t0b3BXZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbCBc CiAgICAgRGVza3RvcFdlYlZpZXcvdHN0X25hdmlnYXRpb25Qb2xpY3lGb3JVcmwucW1sIFwKKyAg ICBEZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzLnFtbCBcCisgICAgRGVza3RvcFdlYlZp ZXcvdHN0X2xvYWRQcm9ncmVzc1NpZ25hbC5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfcHJv cGVydGllcy5xbWwgXAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZFplcm9TaXplVmlldy5xbWwg XAogICAgIFRvdWNoV2ViVmlldy90c3RfbG9hZE5lZ2F0aXZlU2l6ZVZpZXcucW1sIFwKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdl YlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFBy b2dyZXNzLnFtbAkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvdGVzdHMvcW1sdGVzdHMvRGVza3RvcFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMjYgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAoraW1wb3J0IFF0 VGVzdCAxLjAKK2ltcG9ydCBRdFdlYktpdC5leHBlcmltZW50YWwgNS4wCisKK0Rlc2t0b3BXZWJW aWV3IHsKKyAgICBpZDogd2ViVmlldworCisgICAgU2lnbmFsU3B5IHsKKyAgICAgICAgaWQ6IHNw eQorICAgICAgICB0YXJnZXQ6IHdlYlZpZXcKKyAgICAgICAgc2lnbmFsTmFtZTogImxvYWRTdWNj ZWVkZWQiCisgICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAiRGVza3RvcFdl YlZpZXdMb2FkUHJvZ3Jlc3MiCisKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9sb2FkUHJvZ3Jlc3Mo KSB7CisgICAgICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMCkKKyAgICAgICAgICAgIGNvbXBh cmUod2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDApCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQu cmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5odG1sIikpCisgICAgICAgICAgICBjb21wYXJl KHdlYlZpZXcubG9hZFByb2dyZXNzLCAwKQorICAgICAgICAgICAgc3B5LndhaXQoKQorICAgICAg ICAgICAgY29tcGFyZSh3ZWJWaWV3LmxvYWRQcm9ncmVzcywgMTAwKQorICAgICAgICB9CisgICAg fQorfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0 cy9EZXNrdG9wV2ViVmlldy90c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BX ZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3NTaWduYWwucW1sCShyZXZpc2lvbiAwKQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wV2ViVmlldy90 c3RfbG9hZFByb2dyZXNzU2lnbmFsLnFtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzNiBAQAor aW1wb3J0IFF0UXVpY2sgMi4wCitpbXBvcnQgUXRUZXN0IDEuMAoraW1wb3J0IFF0V2ViS2l0LmV4 cGVyaW1lbnRhbCA1LjAKKworRGVza3RvcFdlYlZpZXcgeworICAgIGlkOiB3ZWJWaWV3CisKKyAg ICBTaWduYWxTcHkgeworICAgICAgICBpZDogc3B5CisgICAgICAgIHRhcmdldDogd2ViVmlldwor ICAgICAgICBzaWduYWxOYW1lOiAibG9hZFN1Y2NlZWRlZCIKKyAgICB9CisKKyAgICBTaWduYWxT cHkgeworICAgICAgICBpZDogc3B5UHJvZ3Jlc3MKKyAgICAgICAgdGFyZ2V0OiB3ZWJWaWV3Cisg ICAgICAgIHNpZ25hbE5hbWU6ICJsb2FkUHJvZ3Jlc3NDaGFuZ2VkIgorICAgIH0KKworICAgIFRl c3RDYXNlIHsKKyAgICAgICAgbmFtZTogIkRlc2t0b3BXZWJWaWV3TG9hZFByb2dyZXNzU2lnbmFs IgorCisgICAgICAgIGZ1bmN0aW9uIHRlc3RfbG9hZFByb2dyZXNzU2lnbmFsKCkgeworICAgICAg ICAgICAgY29tcGFyZShzcHlQcm9ncmVzcy5jb3VudCwgMCkKKyAgICAgICAgICAgIGNvbXBhcmUo d2ViVmlldy5sb2FkUHJvZ3Jlc3MsIDApCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQucmVz b2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5odG1sIikpCisgICAgICAgICAgICBzcHlQcm9ncmVz cy53YWl0KCkKKyAgICAgICAgICAgIGNvbXBhcmUodHJ1ZSwgd2ViVmlldy5sb2FkUHJvZ3Jlc3Mg PiAtMSAmJiB3ZWJWaWV3LmxvYWRQcm9ncmVzcyA8IDEwMSkKKyAgICAgICAgICAgIGlmICh3ZWJW aWV3LmxvYWRQcm9ncmVzcyA+IDAgJiYgd2ViVmlldy5sb2FkUHJvZ3Jlc3MgPCAxMDApIHsKKyAg ICAgICAgICAgICAgICBzcHkud2FpdCgpCisgICAgICAgICAgICAgICAgc3B5UHJvZ3Jlc3Mud2Fp dCgpCisgICAgICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LmxvYWRQcm9ncmVzcywgMTAwKQor ICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfQorfQo=