68257 2011-09-16 10:40:52 -0700 [CSSRegions] Need test case for 66198 (sliced line box rendering) 2011-09-20 14:58:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P3 Normal --- 66198 63344 1 stearns stearns achicu hyatt webkit.review.bot oldest_to_newest 468595 0 stearns 2011-09-16 10:40:52 -0700 The patch for resolved bug 66198 did not include a test case that directly checked the fix. 468633 1 107688 stearns 2011-09-16 11:18:50 -0700 Created attachment 107688 Testcase for split line boxes 468639 2 stearns 2011-09-16 11:22:43 -0700 This is an updated version of the original testcase for 66198 which did not make it into the submitted patch. The testcases that went in with the patch are testing related areas, but none are checking for a split line box directly. 470205 3 107688 hyatt 2011-09-20 11:27:52 -0700 Comment on attachment 107688 Testcase for split line boxes r=me 470371 4 107688 webkit.review.bot 2011-09-20 14:58:50 -0700 Comment on attachment 107688 Testcase for split line boxes Clearing flags on attachment: 107688 Committed r95571: <http://trac.webkit.org/changeset/95571> 470372 5 webkit.review.bot 2011-09-20 14:58:54 -0700 All reviewed patches have been landed. Closing bug. 107688 2011-09-16 11:18:50 -0700 2011-09-20 14:58:50 -0700 Testcase for split line boxes splitLineBoxTest.patch text/plain 5480 stearns ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MjRkMzVmLi44ODI5ZTViIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDkt MTYgIEFsYW4gU3RlYXJucyAgPHN0ZWFybnNAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1NSZWdp b25zXSBOZWVkIHRlc3QgY2FzZSBmb3IgNjYxOTggKHNsaWNlZCBsaW5lIGJveCByZW5kZXJpbmcp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODI1Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9y ZWdpb25zL3Jlc291cmNlcy9oZWxwZXIuanM6CisgICAgICAgIChhc3NlcnRUb3BMZWZ0TWF0Y2gp OgorICAgICAgICAoc2FtZVRvcExlZnQpOgorICAgICAgICAqIGZhc3QvcmVnaW9ucy9uby1zcGxp dC1saW5lLWJveC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnaW9ucy9u by1zcGxpdC1saW5lLWJveC5odG1sOiBBZGRlZC4KKwogMjAxMS0wOS0xNiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY2hh bmdlIFdlYkluc3BlY3Rvci5jdXJyZW50UGFuZWwgZ2V0dGVyL3NldHRlciB0byBmdW5jdGlvbnMu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvbm8tc3BsaXQtbGluZS1ib3gt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL25vLXNwbGl0LWxpbmUtYm94 LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43ZWYyMmU5 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL25vLXNwbGl0LWxp bmUtYm94LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L3JlZ2lvbnMvbm8tc3BsaXQtbGluZS1ib3guaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvcmVnaW9ucy9uby1zcGxpdC1saW5lLWJveC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjI5ZjE5MzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L3JlZ2lvbnMvbm8tc3BsaXQtbGluZS1ib3guaHRtbApAQCAtMCwwICsxLDU0IEBACis8IS0t CisgIEVhY2ggb2YgdGhlIHR3byByZWdpb25zIHNob3VsZCBvbmx5IGRpc3BsYXkgdHdvIGxpbmUg Ym94ZXMgaW4gdGhpcyB0ZXN0LiAKKyAgVGhlIGJ1Z2d5IGJlaGF2aW9yIHNwbGl0cyB0aGUgdGhp cmQgbGluZSBib3ggYmV0d2VlbiB0aGUgZmlyc3QgYW5kIHNlY29uZCByZWdpb24uCisgIC0tPiAK KzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYtOCIgc3JjPSJyZXNv dXJjZXMvaGVscGVyLmpzIj48L3NjcmlwdD4KKworPHN0eWxlIHR5cGU9InRleHQvY3NzIj4gCisg IC5hcnRpY2xleworICAgIC13ZWJraXQtZmxvdzogInRocmVhZCI7CisgICAgbGluZS1oZWlnaHQ6 MTRweDsKKyAgfQorICAucmVnaW9ueworICAgIGNvbnRlbnQ6LXdlYmtpdC1mcm9tLWZsb3coInRo cmVhZCIpOworICAgIHdpZHRoOjRlbTsKKyAgICBoZWlnaHQ6MzVweDsgIC8qMi41eCBsaW5lIGhl aWdodCovCisgICAgYmFja2dyb3VuZC1jb2xvcjpsaWdodGdyYXk7CisgIH0KKyAgLmRpdmlkZXJ7 CisgICAgd2lkdGg6NGVtOworICAgIGhlaWdodDoxMHB4OworICB9CisgIC5kZXNjcmlwdGlvbnsK KyAgICBjb2xvcjpibHVlOworICB9Cis8L3N0eWxlPiAKKyAKKzxkaXYgaWQ9InRlc3QiPgorICA8 ZGl2IGNsYXNzPSJyZWdpb24iPjwvZGl2PiAKKyAgPGRpdiBjbGFzcz0iZGl2aWRlciI+PC9kaXY+ IAorICA8ZGl2IGlkPSJzZWNvbmRSZWdpb24iIGNsYXNzPSJyZWdpb24iPjwvZGl2PiAKKyAgPGRp diBjbGFzcz0iYXJ0aWNsZSI+IAorICAgIG1ub3BxciBtbm9wcXIgPHNwYW4gaWQ9InRlc3RTcGFu Ij5tPC9zcGFuPm5vcHFyIG1ub3BxciBtbm9wcXIgbW5vcHFyCisgIDwvZGl2PgorICA8cCBjbGFz cz0iZGVzY3JpcHRpb24iPlRoZSB0d28gcmVnaW9ucyBvbiBlaXRoZXIgc2lkZSBvZiB0aGUgZGl2 aWRlciBzaG91bGQgZWFjaCBoYXZlIHR3byB0ZXh0IGxpbmVzLjwvcD4KKyAgPHAgY2xhc3M9ImRl c2NyaXB0aW9uIj5UaGVyZSBzaG91bGQgYmUgbm8gdGV4dCBsaW5lIHNwbGl0IGJldHdlZW4gdGhl IHJlZ2lvbnMuPC9wPgorICA8cCBjbGFzcz0iZGVzY3JpcHRpb24iPlRoZSB0b3AgbGVmdCBjb3Ju ZXIgb2YgdGhlIHRoaXJkIHRleHQgbGluZSBzaG91bGQgYmUgaW4gdGhlIHRvcCBsZWZ0IGNvcm5l ciBvZiB0aGUgc2Vjb25kIHJlZ2lvbi48L3A+Cis8L2Rpdj4KKzxkaXYgaWQ9InJlc3VsdCI+PC9k aXY+CisKKzxzY3JpcHQ+CisgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCh0cnVlKTsKKyAgICAKKyAgdmFyIHRlc3RF bGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RTcGFuIikKKyAgdmFyIHRlc3RS ZWN0ID0gdGVzdEVsZW1lbnQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgIHZhciByZWdpb25F bGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlY29uZFJlZ2lvbiIpCisgIHZhciBy ZWdpb25SZWN0ID0gcmVnaW9uRWxlbWVudC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKKyAgdmFy IHJlc3VsdFN0cmluZyA9IGFzc2VydFRvcExlZnRNYXRjaCAocmVnaW9uUmVjdCwgdGVzdFJlY3Qp OworCisgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgIAlkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidGVzdCIpLmlubmVyVGV4dD0iIjsKKyAgdmFyIHJlc3VsdERpdiA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKKyAgcmVzdWx0RGl2LmlubmVyVGV4dCA9IHJl c3VsdFN0cmluZzsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdp b25zL3Jlc291cmNlcy9oZWxwZXIuanMgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvcmVzb3Vy Y2VzL2hlbHBlci5qcwppbmRleCAwZjE3NGVlLi4wMzQwODA5IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L3JlZ2lvbnMvcmVzb3VyY2VzL2hlbHBlci5qcworKysgYi9MYXlvdXRUZXN0cy9m YXN0L3JlZ2lvbnMvcmVzb3VyY2VzL2hlbHBlci5qcwpAQCAtNCwxNiArNCwxOSBAQCBmdW5jdGlv biBpc0RlYnVnRW5hYmxlZCgpCiAgICAgcmV0dXJuIHdpbmRvdy5sb2NhdGlvbi5oYXNoID09ICIj ZGVidWciOwogfQogCi1mdW5jdGlvbiByZWN0VG9BcnJheShyZWN0KSB7CitmdW5jdGlvbiByZWN0 VG9BcnJheShyZWN0KQorewogICAgIHJldHVybiBbcmVjdC50b3AsIHJlY3QubGVmdCwgcmVjdC5i b3R0b20sIHJlY3QucmlnaHQsIHJlY3Qud2lkdGgsIHJlY3QuaGVpZ2h0XTsKIH0KIAotZnVuY3Rp b24gYXJlRXF1YWxOdW1iZXJzKGFjdHVhbCwgZXhwZWN0ZWQsIHRvbGVyYW5jZSkgeworZnVuY3Rp b24gYXJlRXF1YWxOdW1iZXJzKGFjdHVhbCwgZXhwZWN0ZWQsIHRvbGVyYW5jZSkKK3sKICAgICB2 YXIgZGlmZiA9IE1hdGguYWJzKGFjdHVhbCAtIGV4cGVjdGVkKTsKICAgICByZXR1cm4gZGlmZiA8 PSB0b2xlcmFuY2U7CiB9CiAKLWZ1bmN0aW9uIGFyZUVxdWFsUmVjdHMocjEsIHIyLCB0b2xlcmFu Y2UpIHsKK2Z1bmN0aW9uIGFyZUVxdWFsUmVjdHMocjEsIHIyLCB0b2xlcmFuY2UpCit7CiAgICAg aWYgKHIxLmxlbmd0aCAhPSByMi5sZW5ndGgpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAK QEAgLTI0LDcgKzI3LDI0IEBAIGZ1bmN0aW9uIGFyZUVxdWFsUmVjdHMocjEsIHIyLCB0b2xlcmFu Y2UpIHsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotZnVuY3Rpb24gYXNzZXJ0RXF1YWxSZWN0cyhy ZXN1bHRzLCBuYW1lLCBhY3R1YWxSZWN0LCBleHBlY3RlZFJlY3QsIHRvbGVyYW5jZSkgeworZnVu Y3Rpb24gYXNzZXJ0VG9wTGVmdE1hdGNoIChyMSwgcjIsIHRvbGVyYW5jZSkKK3sKKyAgICBpZiAo c2FtZVRvcExlZnQocjEsIHIyLCB0b2xlcmFuY2UpKQorICAgICAgICByZXR1cm4gIlBBU1MiOwor ICAgIHJldHVybiAiRkFJTC4gRXhwZWN0ZWQgdG9wIGxlZnQgcG9pbnRzIHRvIG1hdGNoLCBidXQg Z290ICgiKyByMS50b3AgKyAiLCIgKyByMS5sZWZ0ICsgIikgYW5kICgiKyByMi50b3AgKyAiLCIg KyByMi5sZWZ0ICsgIikiOworfQorCitmdW5jdGlvbiBzYW1lVG9wTGVmdChyMSwgcjIsIHRvbGVy YW5jZSkKK3sKKyAgICBpZiAodG9sZXJhbmNlID09PSB1bmRlZmluZWQpCisgICAgICAgIHRvbGVy YW5jZSA9IDA7CisgICAgaWYgKCBhcmVFcXVhbE51bWJlcnMocjEudG9wLCByMi50b3AsIHRvbGVy YW5jZSkgJiYgYXJlRXF1YWxOdW1iZXJzKHIxLmxlZnQsIHIyLmxlZnQsIHRvbGVyYW5jZSkgKQor ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK2Z1bmN0aW9uIGFz c2VydEVxdWFsUmVjdHMocmVzdWx0cywgbmFtZSwgYWN0dWFsUmVjdCwgZXhwZWN0ZWRSZWN0LCB0 b2xlcmFuY2UpCit7CiAgICAgaWYgKGFyZUVxdWFsUmVjdHMoYWN0dWFsUmVjdCwgZXhwZWN0ZWRS ZWN0LCB0b2xlcmFuY2UpKQogICAgICAgICByZXR1cm47CiAKQEAgLTUwLDcgKzcwLDggQEAgZnVu Y3Rpb24gdGVzdEJvdW5kaW5nUmVjdHMoZXhwZWN0ZWRCb3VuZGluZ1JlY3RzLCB0b2xlcmFuY2Up CiAgICAgcmV0dXJuICFyZXN1bHRzLmxlbmd0aDsKIH0KIAotZnVuY3Rpb24gYXNzZXJ0UmVjdENv bnRhaW5zKHJlc3VsdHMsIG5hbWUsIGNvbnRhaW5lclJlY3QsIGluc2lkZVJlY3QsIHRvbGVyYW5j ZSkgeworZnVuY3Rpb24gYXNzZXJ0UmVjdENvbnRhaW5zKHJlc3VsdHMsIG5hbWUsIGNvbnRhaW5l clJlY3QsIGluc2lkZVJlY3QsIHRvbGVyYW5jZSkKK3sKICAgICAvLyBtYWtlIHRoZSBjb250YWlu ZXIgcmVjdCBiaWdnZXIgd2l0aCB0b2xlcmFuY2UKICAgICB2YXIgbGVmdCA9IGNvbnRhaW5lclJl Y3QubGVmdCAtIHRvbGVyYW5jZTsKICAgICB2YXIgcmlnaHQgPSBjb250YWluZXJSZWN0LnJpZ2h0 ICsgdG9sZXJhbmNlOwpAQCAtNjMsNyArODQsOCBAQCBmdW5jdGlvbiBhc3NlcnRSZWN0Q29udGFp bnMocmVzdWx0cywgbmFtZSwgY29udGFpbmVyUmVjdCwgaW5zaWRlUmVjdCwgdG9sZXJhbmNlKQog ICAgIHJldHVybiBwYXNzOwogfQogCi1mdW5jdGlvbiBhZGRQYWdlTGV2ZWxEZWJ1Z0JveChyZWN0 LCBjb2xvcikgeworZnVuY3Rpb24gYWRkUGFnZUxldmVsRGVidWdCb3gocmVjdCwgY29sb3IpCit7 CiAgICAgdmFyIGVsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgZWwuc3R5 bGUucG9zaXRpb24gPSAiYWJzb2x1dGUiOwogICAgIGVsLnN0eWxlLmxlZnQgPSByZWN0LmxlZnQg KyAicHgiOwo=