68252 2011-09-16 10:02:43 -0700 update-webkit-chromium should retry the gclient call if it fails once 2011-09-16 21:14:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tomz tomz abarth eric webkit.review.bot oldest_to_newest 468556 0 tomz 2011-09-16 10:02:43 -0700 update-webkit-chromium sometimes fails when run from the bots because gclient can be flaky, as demonstrated in https://bugs.webkit.org/show_bug.cgi?id=67857#c6. We should allow the script to retry the gclient call in case a given failure is transient. 468566 1 107674 tomz 2011-09-16 10:09:04 -0700 Created attachment 107674 Patch 468570 2 107674 abarth 2011-09-16 10:12:15 -0700 Comment on attachment 107674 Patch Do we want to back-off at all? There are also cases where gclient fails because you've screwed up editing the GYP file, and those shouldn't be retried... This is probably a good start though. 468574 3 tomz 2011-09-16 10:21:33 -0700 I'm not sure how to determine which failures should or shouldn't be retried. Maybe based on the specific errorcode? I'll think about ways to identify which ones would make sense to retry or not. I think the worst current case would be that if you break a gyp file, it will retry (with no chance of success) and cost a little extra time. 469009 4 107674 webkit.review.bot 2011-09-16 21:14:18 -0700 Comment on attachment 107674 Patch Clearing flags on attachment: 107674 Committed r95363: <http://trac.webkit.org/changeset/95363> 469010 5 webkit.review.bot 2011-09-16 21:14:23 -0700 All reviewed patches have been landed. Closing bug. 107674 2011-09-16 10:09:04 -0700 2011-09-16 21:14:18 -0700 Patch bug-68252-20110916100901.patch text/plain 1626 tomz U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ5ODYKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0NTE5MzM4YTdiZmIyZDg3MTY3ZThmMGNhNmJiNDE3YzFm OWVlMWIxLi5jNGJiM2EwOWNiNDhlZDJhOGEwNDMyNTlmYjNlMzJhMGEyM2FiY2VhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMDktMTYgIFRvbSBaYWtyYWpzZWsgIDx0b216QGNvZGVhdXJvcmEub3JnPgorCisg ICAgICAgIHVwZGF0ZS13ZWJraXQtY2hyb21pdW0gc2hvdWxkIHJldHJ5IHRoZSBnY2xpZW50IGNh bGwgaWYgaXQgZmFpbHMgb25jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjgyNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bToKKwogMjAxMS0wOS0x MiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjk0OTc2LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy91cGRhdGUtd2Via2l0LWNocm9taXVtIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWNo cm9taXVtCmluZGV4IDU4MTYwMmEwZDVlZjZkZDJkZWNmYTJlM2M3ZjYwNGUxYjA4ZjhkNjAuLjky ZTc2YWNiZmFhYWVjYWE3MTFiZjU2Zjc5MTJmNWU3YzQ5ZDdmM2QgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQorKysgYi9Ub29scy9TY3JpcHRzL3VwZGF0 ZS13ZWJraXQtY2hyb21pdW0KQEAgLTc3LDQgKzc3LDE5IEBAIG15IEBnY2xpZW50QXJncyA9ICgk Z2NsaWVudFBhdGgsICJzeW5jIik7CiBwdXNoIEBnY2xpZW50QXJncywgIi0tZm9yY2UiIGlmICRm b3JjZTsKIHB1c2ggQGdjbGllbnRBcmdzLCAiLS1kZWxldGVfdW52ZXJzaW9uZWRfdHJlZXMiIGlm ICRmb3JjZTsKIHB1c2ggQGdjbGllbnRBcmdzLCAiLS1kZXBzPXVuaXgsYW5kcm9pZCIgaWYgaXND aHJvbWl1bUFuZHJvaWQoKTsKLXN5c3RlbShAZ2NsaWVudEFyZ3MpID09IDAgb3IgZGllICQhOwor CitteSAkY21kID0gam9pbigiICIsQGdjbGllbnRBcmdzKTsKK215ICRtYXhfYXR0ZW1wdHMgPSAz OworbXkgJHJjID0gLTE7CisKKyMgVGhlIGZvbGxvd2luZyB3aWxsIGNhbGwgZ2xpZW50IHVwIHRv ICRtYXhfYXR0ZW1wdHMgdGltZXMgYmVmb3JlCisjIGl0IGdpdmVzIHVwIGFuZCBmYWlscy4gIFdl IG5lZWQgdGhpcyBiZWNhdXNlIGdsY2llbnQgY2FuIGZhaWwKKyMgZm9yIHNldmVyYWwgcmVhc29u cywgc29tZSBvZiB3aGljaCBhcmUgdHJhbnNpZW50IChmbGFraW5lc3MpLgorCitmb3IgKDEgLi4g JG1heF9hdHRlbXB0cykgeworICAgICRyYyA9IHN5c3RlbSgkY21kKTsKKyAgICBwcmludCAiUmUt dHJ5aW5nICciIC4gJGNtZCAuICInXG4iIGlmICRyYyAhPSAwOworICAgIGxhc3QgaWYgJHJjID09 IDA7Cit9CisKK2RpZSAiRXJyb3I6ICckY21kJyBmYWlsZWQgJG1heF9hdHRlbXB0cyB0cmllcyBh bmQgcmV0dXJuZWQgIiAuICRyYyBpZiAoJHJjKTsK