68239 2011-09-16 04:30:41 -0700 Depend on harfbuzz for OS=Android as well 2011-09-16 19:41:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66689 1 peter peter abarth steveblock tonyg webkit.review.bot oldest_to_newest 468418 0 peter 2011-09-16 04:30:41 -0700 Android depends on harfbuzz as well, so reflect that in the project file. Furthermore, fix a compile error in PopupListBox.cpp by explicitly including ctype.h, as isspace otherwise won't be enabled. 468420 1 107634 peter 2011-09-16 04:33:14 -0700 Created attachment 107634 Patch 468425 2 107634 steveblock 2011-09-16 04:46:17 -0700 Comment on attachment 107634 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review > Source/WebCore/ChangeLog:6 > + Android depends on harfbuzz as well, so reflect that in the project 'as well as GTK' > Source/WebCore/ChangeLog:8 > + explicitly including ctype.h, as isspace otherwise won't be enabled. s/enabled/declared ? 468431 3 107637 peter 2011-09-16 04:50:27 -0700 Created attachment 107637 Patch (In reply to comment #2) > (From update of attachment 107634 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review > > > Source/WebCore/ChangeLog:6 > > + Android depends on harfbuzz as well, so reflect that in the project > > 'as well as GTK' That would say that Android depends on GTK too, which is not the case. I've rephrased the sentence. > > > Source/WebCore/ChangeLog:8 > > + explicitly including ctype.h, as isspace otherwise won't be enabled. > > s/enabled/declared ? Done. Thanks! 468433 4 107637 steveblock 2011-09-16 04:53:45 -0700 Comment on attachment 107637 Patch r=me 468992 5 107637 webkit.review.bot 2011-09-16 19:41:21 -0700 Comment on attachment 107637 Patch Clearing flags on attachment: 107637 Committed r95356: <http://trac.webkit.org/changeset/95356> 468993 6 webkit.review.bot 2011-09-16 19:41:25 -0700 All reviewed patches have been landed. Closing bug. 107634 2011-09-16 04:33:14 -0700 2011-09-16 04:50:27 -0700 Patch harfbuzz.patch text/plain 1840 peter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZmM1YWQ2Li45YzU1MDRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDktMTYgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIERlcGVuZCBvbiBoYXJmYnV6eiBmb3IgT1M9QW5kcm9pZCBhcyB3ZWxsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODIzOQorCisgICAgICAg IEFuZHJvaWQgZGVwZW5kcyBvbiBoYXJmYnV6eiBhcyB3ZWxsLCBzbyByZWZsZWN0IHRoYXQgaW4g dGhlIHByb2plY3QKKyAgICAgICAgZmlsZS4gRnVydGhlcm1vcmUsIGZpeCBhIGNvbXBpbGUgZXJy b3IgaW4gUG9wdXBMaXN0Qm94LmNwcCBieQorICAgICAgICBleHBsaWNpdGx5IGluY2x1ZGluZyBj dHlwZS5oLCBhcyBpc3NwYWNlIG90aGVyd2lzZSB3b24ndCBiZSBlbmFibGVkLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5neXAvV2Vi Q29yZS5neXA6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBMaXN0Qm94LmNwcDoK KwogMjAxMS0wOS0xNSAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW0Nocm9taXVtXSBNYWtlIHN1cmUgdGhhdCB0aGUgQVJNIE5FT04gZmlsZXMgYnVpbGQg d2l0aCAtbWFybQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBmZWQ3 OTFiLi4yOTFlYjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAt MTM3Niw2ICsxMzc2LDggQEAKICAgICAgICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRhTGludXhcXC5jcHAkJ10sCiAgICAgICAgICAg ICBbJ2luY2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2ltcGxlRm9udERhdGFM aW51eFxcLmNwcCQnXSwKICAgICAgICAgICBdLAorICAgICAgICB9XSwKKyAgICAgICAgWyd0b29s a2l0X3VzZXNfZ3RrPT0xIG9yIE9TPT0iYW5kcm9pZCInLCB7CiAgICAgICAgICAgJ2RlcGVuZGVu Y2llcyc6IFsKICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2hh cmZidXp6L2hhcmZidXp6Lmd5cDpoYXJmYnV6eicsCiAgICAgICAgICAgXSwKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTGlzdEJveC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cExpc3RCb3guY3BwCmluZGV4IDIwMTUw NjQuLmY3MzU1NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BvcHVwTGlzdEJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v UG9wdXBMaXN0Qm94LmNwcApAQCAtNDcsNiArNDcsNyBAQAogI2luY2x1ZGUgIlNjcm9sbGJhclRo ZW1lLmgiCiAjaW5jbHVkZSAiU3RyaW5nVHJ1bmNhdG9yLmgiCiAjaW5jbHVkZSAiVGV4dFJ1bi5o IgorI2luY2x1ZGUgPGN0eXBlLmg+CiAjaW5jbHVkZSA8bGltaXRzPgogI2luY2x1ZGUgPHd0Zi9D dXJyZW50VGltZS5oPgogCg== 107637 2011-09-16 04:50:27 -0700 2011-09-16 19:41:21 -0700 Patch harfbuzz2.patch text/plain 1851 peter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZmM1YWQ2Li4yODVlODUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDktMTYgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIERlcGVuZCBvbiBoYXJmYnV6eiBmb3IgT1M9QW5kcm9pZCBhcyB3ZWxsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODIzOQorCisgICAgICAg IExpa2UgR1RLLCBBbmRyb2lkIGRlcGVuZHMgb24gaGFyZmJ1enogYXMgd2VsbCwgc28gcmVmbGVj dCB0aGF0IGluCisgICAgICAgIHRoZSBwcm9qZWN0IGZpbGUuIEZ1cnRoZXJtb3JlLCBmaXggYSBj b21waWxlIGVycm9yIGluIFBvcHVwTGlzdEJveC5jcHAKKyAgICAgICAgYnkgZXhwbGljaXRseSBp bmNsdWRpbmcgY3R5cGUuaCwgYXMgaXNzcGFjZSBvdGhlcndpc2Ugd29uJ3QgYmUgZGVjbGFyZWQu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJD b3JlLmd5cC9XZWJDb3JlLmd5cDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cExp c3RCb3guY3BwOgorCiAyMDExLTA5LTE1ICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIE1ha2Ugc3VyZSB0aGF0IHRoZSBBUk0gTkVPTiBm aWxlcyBidWlsZCB3aXRoIC1tYXJtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lw CmluZGV4IGZlZDc5MWIuLjI5MWViNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNv cmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNv cmUuZ3lwCkBAIC0xMzc2LDYgKzEzNzYsOCBAQAogICAgICAgICAgICAgWydpbmNsdWRlJywgJ3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eFxcLmNwcCQnXSwK ICAgICAgICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaW1w bGVGb250RGF0YUxpbnV4XFwuY3BwJCddLAogICAgICAgICAgIF0sCisgICAgICAgIH1dLAorICAg ICAgICBbJ3Rvb2xraXRfdXNlc19ndGs9PTEgb3IgT1M9PSJhbmRyb2lkIicsIHsKICAgICAgICAg ICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhp cmRfcGFydHkvaGFyZmJ1enovaGFyZmJ1enouZ3lwOmhhcmZidXp6JywKICAgICAgICAgICBdLApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBMaXN0Qm94 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTGlzdEJveC5jcHAK aW5kZXggMjAxNTA2NC4uZjczNTU2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vUG9wdXBMaXN0Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9Qb3B1cExpc3RCb3guY3BwCkBAIC00Nyw2ICs0Nyw3IEBACiAjaW5jbHVkZSAi U2Nyb2xsYmFyVGhlbWUuaCIKICNpbmNsdWRlICJTdHJpbmdUcnVuY2F0b3IuaCIKICNpbmNsdWRl ICJUZXh0UnVuLmgiCisjaW5jbHVkZSA8Y3R5cGUuaD4KICNpbmNsdWRlIDxsaW1pdHM+CiAjaW5j bHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAK