68226 2011-09-15 23:54:17 -0700 [EFL] Bump minimum requirement for cairo to 1.10. 2011-09-17 02:27:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim lucas.de.marchi paroga rakuco webkit.review.bot oldest_to_newest 468342 0 ryuan.choi 2011-09-15 23:54:17 -0700 Since r94876, WebKit/Efl require cairo 1.10. But, OptionsEfl.cmake mentioned 1.6 and FindCairo.cmake doesn't check version. 468346 1 ryuan.choi 2011-09-16 00:00:59 -0700 Below are error message. [ 8%] [ 8%] [ 8%] Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/CairoUtilities.cpp.o Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/FontCairo.cpp.o Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/GraphicsContextCairo.cpp.o [ 8%] Building CXX object WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/ImageBufferCairo.cpp.o In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:28: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:84: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:84: error: expected ‘,’ or ‘...’ before ‘*’ token /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp: In function ‘void WebCore::appendRegionToCairoContext(cairo_t*, int)’: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:86: error: ‘region’ was not declared in this scope /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:89: error: ‘region’ was not declared in this scope /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:89: error: ‘cairo_region_num_rectangles’ was not declared in this scope /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:91: error: aggregate ‘cairo_rectangle_int_t rect’ has incomplete type and cannot be defined /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp:92: error: ‘cairo_region_get_rectangle’ was not declared in this scope make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/CairoUtilities.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:38: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/FontCairo.cpp:34: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token In file included from /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:34: /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: ISO C++ forbids declaration of ‘cairo_region_t’ with no type /home/hyuki/webkit/WebKit/Source/WebCore/platform/graphics/cairo/CairoUtilities.h:47: error: expected ‘,’ or ‘...’ before ‘*’ token make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/ImageBufferCairo.cpp.o] Error 1 make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/GraphicsContextCairo.cpp.o] Error 1 make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/cairo/FontCairo.cpp.o] Error 1 468347 2 107612 ryuan.choi 2011-09-16 00:01:15 -0700 Created attachment 107612 Patch 468458 3 rakuco 2011-09-16 06:41:10 -0700 LGTM. 469058 4 107612 webkit.review.bot 2011-09-17 02:27:21 -0700 Comment on attachment 107612 Patch Clearing flags on attachment: 107612 Committed r95379: <http://trac.webkit.org/changeset/95379> 469059 5 webkit.review.bot 2011-09-17 02:27:26 -0700 All reviewed patches have been landed. Closing bug. 107612 2011-09-16 00:01:15 -0700 2011-09-17 02:27:21 -0700 Patch bug-68226-20110916160113.patch text/plain 1903 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTUyNzQKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAyNjBkMzdlNDVkNTM0NDFmNWVjODNhYWZiMmNlYmQzMzAxODM3YzE4Li5kODMx MWE4NmNkYzYzZDQ4NjZiMDE1MGU1ZGNhZDJlOTc2ZmQ5NGRhIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDktMTUgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEJ1bXAgbWluaW11 bSByZXF1aXJlbWVudCBmb3IgY2Fpcm8gdG8gMS4xMC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZENhaXJvLmNtYWtlOiBD aGVjayByZXF1aXJlZCB2ZXJzaW9uLgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlOgorCiAyMDExLTA5LTE1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmVuYW1lIEVOQUJMRShEQVRBQkFTRSkgdG8gRU5BQkxFKFNRTF9EQVRBQkFTRSkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2UgYi9Tb3VyY2UvY21ha2Uv RmluZENhaXJvLmNtYWtlCmluZGV4IGRiODk4MWVmNDIxN2NkMDI1MDAwNmQ5MjYyZDU0ZDRmMGY4 NjM1ZDcuLmQ3YzUzYjk3NGM5MWEwZjhlOTUxZDU4OTU0MmY5Y2ZmNzFkZjQyYjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRD YWlyby5jbWFrZQpAQCAtMTEsNyArMTEsMTIgQEAgaW5jbHVkZShMaWJGaW5kTWFjcm9zKQogbGli ZmluZF9wYWNrYWdlKENhaXJvIEZyZWV0eXBlKQogCiAjIFVzZSBwa2ctY29uZmlnIHRvIGdldCBo aW50cyBhYm91dCBwYXRocwotbGliZmluZF9wa2dfY2hlY2tfbW9kdWxlcyhDYWlyb19QS0dDT05G IGNhaXJvKQorc2V0IChNb2R1bGUgY2Fpcm8pCitpZiAoQ2Fpcm9fRklORF9WRVJTSU9OKQorICBz ZXQgKE1vZHVsZSAiJHtNb2R1bGV9Pj0ke0NhaXJvX0ZJTkRfVkVSU0lPTn0iKQorZW5kaWYgKCkK KworbGliZmluZF9wa2dfY2hlY2tfbW9kdWxlcyhDYWlyb19QS0dDT05GICR7TW9kdWxlfSkKIAog IyBJbmNsdWRlIGRpcgogZmluZF9wYXRoKENhaXJvX0lOQ0xVREVfRElSCmRpZmYgLS1naXQgYS9T b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNt YWtlCmluZGV4IDZlMDRhODljMDBhZTIyMGQyYjg4ZmE0OGRjNjY5YTk1N2Q1M2QyNWUuLjBhZWRk YTM3ZGNiOWQ0OGQyZTRlMzMwZGVlNzY2NmY0NzM0MjFjYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9j bWFrZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl CkBAIC0yNiw3ICsyNiw3IEBAIFNFVChORVRXT1JLX0JBQ0tFTkQgInNvdXAiIENBQ0hFIFNUUklO RyAiY2hvb3NlIHdoaWNoIG5ldHdvcmsgYmFja2VuZCB0byB1c2UgKG9uCiBTRVQoQUxMX0ZPTlRf QkFDS0VORFMgZnJlZXR5cGUgcGFuZ28pCiBTRVQoRk9OVF9CQUNLRU5EICJmcmVldHlwZSIgQ0FD SEUgU1RSSU5HICJjaG9vc2Ugd2hpY2ggbmV0d29yayBiYWNrZW5kIHRvIHVzZSAob25lIG9mICR7 QUxMX0ZPTlRfQkFDS0VORFN9KSIpCiAKLUZJTkRfUEFDS0FHRShDYWlybyAxLjYgUkVRVUlSRUQp CitGSU5EX1BBQ0tBR0UoQ2Fpcm8gMS4xMCBSRVFVSVJFRCkKIEZJTkRfUEFDS0FHRShFRkwgUkVR VUlSRUQpCiBGSU5EX1BBQ0tBR0UoRm9udGNvbmZpZyAyLjguMCBSRVFVSVJFRCkKIEZJTkRfUEFD S0FHRShTcWxpdGUgUkVRVUlSRUQpCg==