68225 2011-09-15 23:30:37 -0700 [Chromium] Expose AXObjectCache methods so WebAccessibilityCache can be deleted. 2011-09-19 16:03:21 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dmazzoni webkit-unassigned dglazkov dtseng webkit.review.bot oldest_to_newest 468329 0 dmazzoni 2011-09-15 23:30:37 -0700 WebAccessibilityCache is duplicating the functionality of AXObjectCache rather than replacing it. In addition, it's resulting in a subtle and confusing bug: because it uses a hash from pointer to ID, occasionally an object will be deleted, but another object will be allocated that coincidentally happens to get the same pointer address. When this happens, WebAccessibilityCache gives it the same ID, which can cause all sorts of anomalous behavior. This bug is to first add the necessary methods to wrap the existing AXObjectCache functionality needed. Then Chromium will be modified to use these methods instead of WebAccessibilityCache. Finally, we'll remove WebAccessibilityCache (https://bugs.webkit.org/show_bug.cgi?id=68224). 468331 1 107611 dmazzoni 2011-09-15 23:37:18 -0700 Created attachment 107611 Patch 469775 2 107611 webkit.review.bot 2011-09-19 16:03:17 -0700 Comment on attachment 107611 Patch Clearing flags on attachment: 107611 Committed r95491: <http://trac.webkit.org/changeset/95491> 469776 3 webkit.review.bot 2011-09-19 16:03:21 -0700 All reviewed patches have been landed. Closing bug. 107611 2011-09-15 23:37:18 -0700 2011-09-19 16:03:17 -0700 Patch bug-68225-20110915233717.patch text/plain 5811 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA5NTI3MykKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTEtMDktMTUgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisK KyAgICAgICAgRXhwb3NlIEFYT2JqZWN0Q2FjaGUgbWV0aG9kcyBzbyB0aGF0IFdlYkFjY2Vzc2li aWxpdHlDYWNoZQorICAgICAgICBjYW4gYmUgZGVsZXRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBleHBvc2VzIHRoZSBmdW5jdGlv bmFsaXR5IG5lZWRlZCBmcm9tIEFYT2JqZWN0Q2FjaGUKKyAgICAgICAgd2l0aCBuZXcgbWV0aG9k cyBpbiBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0IGFuZCBXZWJEb2N1bWVudC4KKyAgICAgICAgTmV4 dCwgQ2hyb21pdW0gd2lsbCBiZSB1cGRhdGVkIHRvIHVzZSBvbmx5IHRoZXNlIG1ldGhvZHMgYW5k CisgICAgICAgIG5vdCBXZWJBY2Nlc3NpYmlsaXR5Q2FjaGUuIFRoZW4sIFdlYkFjY2Vzc2liaWxp dHlDYWNoZSBjYW4gYmUKKyAgICAgICAgZGVsZXRlZCBmcm9tIFdlYktpdC4KKworICAgICAgICAq IHB1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgICogcHVibGljL1dlYkRv Y3VtZW50Lmg6CisgICAgICAgICogc3JjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0OjplbmFibGVBY2Nlc3NpYmlsaXR5 KToKKyAgICAgICAgKFdlYktpdDo6V2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0 eUVuYWJsZWQpOgorICAgICAgICAoV2ViS2l0OjpXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0OjpheElE KToKKyAgICAgICAgKiBzcmMvV2ViRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJE b2N1bWVudDo6YWNjZXNzaWJpbGl0eU9iamVjdCk6CisgICAgICAgIChXZWJLaXQ6OldlYkRvY3Vt ZW50OjphY2Nlc3NpYmlsaXR5T2JqZWN0RnJvbUlEKToKKwogMjAxMS0wOS0xNSAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFNpZ2guICBNaXNzZWQgdGhpcyBvbmUu CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2Jq ZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQWNj ZXNzaWJpbGl0eU9iamVjdC5oCShyZXZpc2lvbiA5NTE3MikKKysrIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAt NzAsNiArNzAsMTIgQEAgcHVibGljOgogCiAgICAgYm9vbCBpc051bGwoKSBjb25zdCB7IHJldHVy biBtX3ByaXZhdGUuaXNOdWxsKCk7IH0KIAorICAgIC8vIFN0YXRpYyBtZXRob2RzIGZvciBlbmFi bGluZyBhY2Nlc3NpYmlsaXR5LgorICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIHZvaWQgZW5hYmxl QWNjZXNzaWJpbGl0eSgpOworICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIGJvb2wgYWNjZXNzaWJp bGl0eUVuYWJsZWQoKTsKKworICAgIFdFQktJVF9FWFBPUlQgaW50IGF4SUQoKSBjb25zdDsKKwog ICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGFjY2Vzc2liaWxpdHlEZXNjcmlwdGlvbigpIGNv bnN0OwogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGFjdGlvblZlcmIoKSBjb25zdDsKICAg ICBXRUJLSVRfRVhQT1JUIGJvb2wgY2FuU2V0Rm9jdXNBdHRyaWJ1dGUoKSBjb25zdDsKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3VtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAkocmV2aXNpb24g OTUxNzIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCSh3 b3JraW5nIGNvcHkpCkBAIC05OCw5ICs5OCwxNyBAQCBwdWJsaWM6CiAgICAgV0VCS0lUX0VYUE9S VCBXZWJFbGVtZW50IGdldEVsZW1lbnRCeUlkKGNvbnN0IFdlYlN0cmluZyYpIGNvbnN0OwogICAg IFdFQktJVF9FWFBPUlQgV2ViTm9kZSBmb2N1c2VkTm9kZSgpIGNvbnN0OwogICAgIFdFQktJVF9F WFBPUlQgV2ViRG9jdW1lbnRUeXBlIGRvY3R5cGUoKSBjb25zdDsKLSAgICBXRUJLSVRfRVhQT1JU IFdlYkFjY2Vzc2liaWxpdHlPYmplY3QgYWNjZXNzaWJpbGl0eU9iamVjdCgpIGNvbnN0OwogICAg IFdFQktJVF9FWFBPUlQgdm9pZCBjYW5jZWxGdWxsU2NyZWVuKCk7CiAKKyAgICAvLyBBY2Nlc3Np YmlsaXR5IHN1cHBvcnQuIFRoZXNlIG1ldGhvZHMgc2hvdWxkIG9ubHkgYmUgY2FsbGVkIG9uIHRo ZQorICAgIC8vIHRvcC1sZXZlbCBkb2N1bWVudCwgYmVjYXVzZSBvbmUgYWNjZXNzaWJpbGl0eSBj YWNoZSBzcGFucyBhbGwgb2YKKyAgICAvLyB0aGUgZG9jdW1lbnRzIG9uIHRoZSBwYWdlLgorCisg ICAgLy8gR2V0cyB0aGUgYWNjZXNzaWJpbGl0eSBvYmplY3QgZm9yIHRoaXMgZG9jdW1lbnQuCisg ICAgV0VCS0lUX0VYUE9SVCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0IGFjY2Vzc2liaWxpdHlPYmpl Y3QoKSBjb25zdDsKKworICAgIC8vIEdldHMgdGhlIGFjY2Vzc2liaWxpdHkgb2JqZWN0IGZvciBh biBvYmplY3Qgb24gdGhpcyBwYWdlIGJ5IElELgorICAgIFdFQktJVF9FWFBPUlQgV2ViQWNjZXNz aWJpbGl0eU9iamVjdCBhY2Nlc3NpYmlsaXR5T2JqZWN0RnJvbUlEKGludCBheElEKSBjb25zdDsK ICAgICAvLyBJbnNlcnRzIHRoZSBnaXZlbiBDU1Mgc291cmNlIGNvZGUgYXMgYSB1c2VyIHN0eWxl c2hlZXQgaW4gdGhlIGRvY3VtZW50LgogICAgIC8vIE1lYW50IGZvciBwcm9ncmFtYXRpYy9vbmUt b2ZmIGluamVjdGlvbiwgYXMgb3Bwb3NlZCB0bwogICAgIC8vIFdlYlZpZXc6OmFkZFVzZXJTdHls ZVNoZWV0IHdoaWNoIGluc2VydHMgc3R5bGVzIGZvciB0aGUgbGlmZXRpbWUgb2YgdGhlCkluZGV4 OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0LmNwcAkocmV2aXNpb24gOTUxNzIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEs NyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYkFjY2Vzc2liaWxpdHlPYmpl Y3QuaCIKIAorI2luY2x1ZGUgIkFYT2JqZWN0Q2FjaGUuaCIKICNpbmNsdWRlICJBY2Nlc3NpYmls aXR5T2JqZWN0LmgiCiAjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eVRhYmxlLmgiCiAjaW5jbHVkZSAi QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5oIgpAQCAtNjksNiArNzAsMjcgQEAgYm9vbCBXZWJBY2Nl c3NpYmlsaXR5T2JqZWN0OjplcXVhbHMoY29ucwogICAgIHJldHVybiAobV9wcml2YXRlLmdldCgp ID09IG4ubV9wcml2YXRlLmdldCgpKTsKIH0KIAorLy8gc3RhdGljCit2b2lkIFdlYkFjY2Vzc2li aWxpdHlPYmplY3Q6OmVuYWJsZUFjY2Vzc2liaWxpdHkoKQoreworICAgIEFYT2JqZWN0Q2FjaGU6 OmVuYWJsZUFjY2Vzc2liaWxpdHkoKTsKK30KKworLy8gc3RhdGljCitib29sIFdlYkFjY2Vzc2li aWxpdHlPYmplY3Q6OmFjY2Vzc2liaWxpdHlFbmFibGVkKCkKK3sKKyAgICByZXR1cm4gQVhPYmpl Y3RDYWNoZTo6YWNjZXNzaWJpbGl0eUVuYWJsZWQoKTsKK30KKworaW50IFdlYkFjY2Vzc2liaWxp dHlPYmplY3Q6OmF4SUQoKSBjb25zdAoreworICAgIGlmIChtX3ByaXZhdGUuaXNOdWxsKCkpCisg ICAgICAgIHJldHVybiAtMTsKKworICAgIG1fcHJpdmF0ZS0+dXBkYXRlQmFja2luZ1N0b3JlKCk7 CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+YXhPYmplY3RJRCgpOworfQorCiBXZWJTdHJpbmcgV2Vi QWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0eURlc2NyaXB0aW9uKCkgY29uc3QKIHsK ICAgICBpZiAobV9wcml2YXRlLmlzTnVsbCgpKQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRvY3VtZW50LmNwcAkocmV2aXNpb24gOTUxNzIpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJEb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3MiwxMyAr MTcyLDYgQEAgV2ViRG9jdW1lbnRUeXBlIFdlYkRvY3VtZW50Ojpkb2N0eXBlKCkgYwogICAgIHJl dHVybiBXZWJEb2N1bWVudFR5cGUoY29uc3RVbndyYXA8RG9jdW1lbnQ+KCktPmRvY3R5cGUoKSk7 CiB9CiAKLVdlYkFjY2Vzc2liaWxpdHlPYmplY3QgV2ViRG9jdW1lbnQ6OmFjY2Vzc2liaWxpdHlP YmplY3QoKSBjb25zdAotewotICAgIGNvbnN0IERvY3VtZW50KiBkb2N1bWVudCA9IGNvbnN0VW53 cmFwPERvY3VtZW50PigpOwotICAgIHJldHVybiBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KAotICAg ICAgICBkb2N1bWVudC0+YXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShkb2N1bWVudC0+cmVu ZGVyZXIoKSkpOwotfQotCiB2b2lkIFdlYkRvY3VtZW50OjppbnNlcnRVc2VyU3R5bGVTaGVldChj b25zdCBXZWJTdHJpbmcmIHNvdXJjZUNvZGUsIFVzZXJTdHlsZUxldmVsIGxldmVsKQogewogICAg IFJlZlB0cjxEb2N1bWVudD4gZG9jdW1lbnQgPSB1bndyYXA8RG9jdW1lbnQ+KCk7CkBAIC0xOTYs NiArMTg5LDIwIEBAIHZvaWQgV2ViRG9jdW1lbnQ6OmNhbmNlbEZ1bGxTY3JlZW4oKQogI2VuZGlm CiB9CiAKK1dlYkFjY2Vzc2liaWxpdHlPYmplY3QgV2ViRG9jdW1lbnQ6OmFjY2Vzc2liaWxpdHlP YmplY3QoKSBjb25zdAoreworICAgIGNvbnN0IERvY3VtZW50KiBkb2N1bWVudCA9IGNvbnN0VW53 cmFwPERvY3VtZW50PigpOworICAgIHJldHVybiBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KAorICAg ICAgICBkb2N1bWVudC0+YXhPYmplY3RDYWNoZSgpLT5nZXRPckNyZWF0ZShkb2N1bWVudC0+cmVu ZGVyZXIoKSkpOworfQorCitXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0IFdlYkRvY3VtZW50OjphY2Nl c3NpYmlsaXR5T2JqZWN0RnJvbUlEKGludCBheElEKSBjb25zdAoreworICAgIGNvbnN0IERvY3Vt ZW50KiBkb2N1bWVudCA9IGNvbnN0VW53cmFwPERvY3VtZW50PigpOworICAgIHJldHVybiBXZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0KAorICAgICAgICBkb2N1bWVudC0+YXhPYmplY3RDYWNoZSgpLT5v YmplY3RGcm9tQVhJRChheElEKSk7Cit9CisKIFdlYkRvY3VtZW50OjpXZWJEb2N1bWVudChjb25z dCBQYXNzUmVmUHRyPERvY3VtZW50PiYgZWxlbSkKICAgICA6IFdlYk5vZGUoZWxlbSkKIHsK