68223 2011-09-15 22:42:23 -0700 [Qt] Crash when dragging google maps. 2011-09-16 04:35:06 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://maps.google.com P2 Normal --- 1 leo.yang leo.yang oldest_to_newest 468303 0 leo.yang 2011-09-15 22:42:23 -0700 Use QtTestBrowser 1. Load http://maps.google.com. 2. Drag the map. It's very likely to crash. 468306 1 107605 leo.yang 2011-09-15 22:57:23 -0700 Created attachment 107605 Patch 468333 2 107605 abarth 2011-09-15 23:43:25 -0700 Comment on attachment 107605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107605&action=review > Source/WebCore/platform/qt/CursorQt.cpp:203 > + m_platformCursor = new QCursor(Qt::ArrowCursor); m_platformCursor isn't any sort of smart pointer? 468357 3 leo.yang 2011-09-16 00:15:18 -0700 Committed r95275: <http://trac.webkit.org/changeset/95275> 468422 4 107605 menard 2011-09-16 04:35:06 -0700 Comment on attachment 107605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107605&action=review >> Source/WebCore/platform/qt/CursorQt.cpp:203 >> + m_platformCursor = new QCursor(Qt::ArrowCursor); > > m_platformCursor isn't any sort of smart pointer? It's deleted in the destructor but yes could be an improvement. Though it is define as mutable PlatformCursor m_platformCursor; for every port except Mac where it is : mutable RetainPtr<NSCursor> m_platformCursor; Definitively some improvements possible here. 107605 2011-09-15 22:57:23 -0700 2011-09-16 04:35:06 -0700 Patch 0001-Qt-Crash-when-dragging-google-maps.patch text/plain 5082 leo.yang RnJvbSBlMzVlMWJlY2Y5MThiNGE0MWZmZDE0Yjg5YjkxNDU0OWM5OWQxZDEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBGcmksIDE2IFNlcCAyMDExIDEzOjUwOjQ2ICswODAwClN1YmplY3Q6IFtQQVRDSF0g W1F0XSBDcmFzaCB3aGVuIGRyYWdnaW5nIGdvb2dsZSBtYXBzLgogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjIzCgpTb3VyY2UvV2ViQ29yZToKClRoZSBjdXN0b20g aW1hZ2UgZm9yIGEgY3Vyc29yIG1pZ2h0IG5vdCBiZSByZWFkeSB3aGVuIFdlYktpdCB0cnlpbmcK dG8gdXNlIGl0IHRvIGNvbnN0cnVjdCB0aGUgY3Vyc29yIGluIFF0IHBvcnRpbmcuIFRoaXMgcGF0 Y2ggaXMgdXNpbmcKYXJyb3cgaW1hZ2UgdG8gc3Vic3RpdHV0ZSB0aGUgdW5yZWFkeSBjdXN0b20g aW1hZ2UuCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KClRlc3Q6IGZhc3QvY3NzL2NyYXNo LW9uLWN1c3RvbS1jdXJzb3Itd2hlbi1sb2FkaW5nLmh0bWwKCiogcGxhdGZvcm0vcXQvQ3Vyc29y UXQuY3BwOgooV2ViQ29yZTo6Y3JlYXRlQ3VzdG9tQ3Vyc29yKToKKFdlYkNvcmU6OkN1cnNvcjo6 ZW5zdXJlUGxhdGZvcm1DdXJzb3IpOgoKTGF5b3V0VGVzdHM6CgpUZXN0IGNhc2UgdG8gdXNlIGFu IHVucmVhZHkgY3VzdG9tIGN1cnNvci4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBm YXN0L2Nzcy9jcmFzaC1vbi1jdXN0b20tY3Vyc29yLXdoZW4tbG9hZGluZy1leHBlY3RlZC50eHQ6 IEFkZGVkLgoqIGZhc3QvY3NzL2NyYXNoLW9uLWN1c3RvbS1jdXJzb3Itd2hlbi1sb2FkaW5nLmh0 bWw6IEFkZGVkLgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMiArKysrKysrKysKIC4uLnJhc2gtb24tY3VzdG9tLWN1cnNvci13aGVu LWxvYWRpbmctZXhwZWN0ZWQudHh0IHwgICAgMSArCiAuLi4vY3NzL2NyYXNoLW9uLWN1c3RvbS1j dXJzb3Itd2hlbi1sb2FkaW5nLmh0bWwgICB8ICAgMjUgKysrKysrKysrKysrKysrKysrKysKIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNyAr KysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DdXJzb3JRdC5jcHAgICAg ICAgICAgICB8ICAgIDQgKysrCiA1IGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyksIDAg ZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3Jh c2gtb24tY3VzdG9tLWN1cnNvci13aGVuLWxvYWRpbmctZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9k ZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3Jhc2gtb24tY3VzdG9tLWN1cnNvci13aGVu LWxvYWRpbmcuaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlNWEzYjkwLi5jZGUyNjUxIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTEtMDktMTUgIExlbyBZYW5nICA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgorCisgICAgICAgIFtRdF0gQ3Jhc2ggd2hlbiBkcmFnZ2luZyBnb29nbGUgbWFwcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjIzCisKKyAgICAg ICAgVGVzdCBjYXNlIHRvIHVzZSBhbiB1bnJlYWR5IGN1c3RvbSBjdXJzb3IuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9jcmFzaC1v bi1jdXN0b20tY3Vyc29yLXdoZW4tbG9hZGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvY3NzL2NyYXNoLW9uLWN1c3RvbS1jdXJzb3Itd2hlbi1sb2FkaW5nLmh0bWw6IEFk ZGVkLgorCiAyMDExLTA5LTE1ICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgog CiAgICAgICAgIFtjaHJvbWl1bV0gc2tpcHBpbmcgdGVzdHMgZHVlIHRvIHI5NTE4OApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3Jhc2gtb24tY3VzdG9tLWN1cnNvci13aGVuLWxv YWRpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3Jhc2gtb24tY3VzdG9t LWN1cnNvci13aGVuLWxvYWRpbmctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAuLmYzODE4MzAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9jcmFzaC1vbi1jdXN0b20tY3Vyc29yLXdoZW4tbG9hZGluZy1leHBlY3RlZC50eHQKQEAg LTAsMCArMSBAQAorUEFTUyB3aXRob3V0IGNyYXNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvY3Jhc2gtb24tY3VzdG9tLWN1cnNvci13aGVuLWxvYWRpbmcuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvY3NzL2NyYXNoLW9uLWN1c3RvbS1jdXJzb3Itd2hlbi1sb2FkaW5nLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYmIxNmU1OAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2NyYXNoLW9uLWN1c3RvbS1jdXJzb3Itd2hlbi1s b2FkaW5nLmh0bWwKQEAgLTAsMCArMSwyNSBAQAorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKyAg ICBkaXYgeworICAgICAgICBjdXJzb3I6IHVybChyZXNvdXJjZXMvcHVycGxlLXNyZ2IucG5nKTsK KyAgICAgICAgd2lkdGg6IDIwMDsKKyAgICAgICAgaGVpZ2h0OiAyMDA7CisgICAgICAgIGJhY2tn cm91bmQ6IGdyZWVuOworICAgIH0KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2 PjwvZGl2PgorICAgIDxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgaWYg KHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgICAgICBldmVudFNlbmRlci5kcmFnTW9kZSA9IGZh bHNlOworICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyg1MCwgNTApCisgICAgfQorICAg IDwvc2NyaXB0PgorICAgIDxwPlBBU1Mgd2l0aG91dCBjcmFzaC48L3A+Cis8L2JvZHk+Cis8L2h0 bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggMjZmYTlhZi4uYmRkZTk0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIwIEBACisyMDExLTA5LTE1ICBMZW8gWWFuZyAgPGxlby55YW5nQHRvcmNobW9iaWxlLmNvbS5j bj4KKworICAgICAgICBbUXRdIENyYXNoIHdoZW4gZHJhZ2dpbmcgZ29vZ2xlIG1hcHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODIyMworCisgICAg ICAgIFRoZSBjdXN0b20gaW1hZ2UgZm9yIGEgY3Vyc29yIG1pZ2h0IG5vdCBiZSByZWFkeSB3aGVu IFdlYktpdCB0cnlpbmcKKyAgICAgICAgdG8gdXNlIGl0IHRvIGNvbnN0cnVjdCB0aGUgY3Vyc29y IGluIFF0IHBvcnRpbmcuIFRoaXMgcGF0Y2ggaXMgdXNpbmcKKyAgICAgICAgYXJyb3cgaW1hZ2Ug dG8gc3Vic3RpdHV0ZSB0aGUgdW5yZWFkeSBjdXN0b20gaW1hZ2UuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvY3Jhc2gtb24t Y3VzdG9tLWN1cnNvci13aGVuLWxvYWRpbmcuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vcXQv Q3Vyc29yUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlQ3VzdG9tQ3Vyc29yKToKKyAg ICAgICAgKFdlYkNvcmU6OkN1cnNvcjo6ZW5zdXJlUGxhdGZvcm1DdXJzb3IpOgorCiAyMDExLTA5 LTE1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAg VW56aXAgaW5pdGlhbGl6YXRpb24gbGlzdHMgYW5kIGNvbnN0cnVjdG9ycyBpbiBKU0NlbGwgaGll cmFyY2h5ICg3LzcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DdXJz b3JRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DdXJzb3JRdC5jcHAKaW5kZXgg NTg4MzYwMC4uZTc4NTRkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQv Q3Vyc29yUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0N1cnNvclF0LmNw cApAQCAtNzUsNiArNzUsOCBAQCBDdXJzb3ImIEN1cnNvcjo6b3BlcmF0b3I9KGNvbnN0IEN1cnNv ciYgb3RoZXIpCiAjaWZuZGVmIFFUX05PX0NVUlNPUgogc3RhdGljIFFDdXJzb3IqIGNyZWF0ZUN1 c3RvbUN1cnNvcihJbWFnZSogaW1hZ2UsIGNvbnN0IEludFBvaW50JiBob3RTcG90KQogeworICAg IGlmICghaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkpCisgICAgICAgIHJldHVy biAwOwogICAgIEludFBvaW50IGVmZmVjdGl2ZUhvdFNwb3QgPSBkZXRlcm1pbmVIb3RTcG90KGlt YWdlLCBob3RTcG90KTsKICAgICByZXR1cm4gbmV3IFFDdXJzb3IoKihpbWFnZS0+bmF0aXZlSW1h Z2VGb3JDdXJyZW50RnJhbWUoKSksIGVmZmVjdGl2ZUhvdFNwb3QueCgpLCBlZmZlY3RpdmVIb3RT cG90LnkoKSk7CiB9CkBAIC0xOTcsNiArMTk5LDggQEAgdm9pZCBDdXJzb3I6OmVuc3VyZVBsYXRm b3JtQ3Vyc29yKCkgY29uc3QKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDdXN0b206CiAgICAg ICAgIG1fcGxhdGZvcm1DdXJzb3IgPSBjcmVhdGVDdXN0b21DdXJzb3IobV9pbWFnZS5nZXQoKSwg bV9ob3RTcG90KTsKKyAgICAgICAgaWYgKCFtX3BsYXRmb3JtQ3Vyc29yKQorICAgICAgICAgICAg bV9wbGF0Zm9ybUN1cnNvciA9IG5ldyBRQ3Vyc29yKFF0OjpBcnJvd0N1cnNvcik7CiAgICAgICAg IGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotLSAK MS43LjQuMQoK