68211 2011-09-15 19:29:59 -0700 remove default NULL argument in LayerChromium::create() 2011-10-11 16:49:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 shawnsingh shawnsingh enne jamesr nduca piman webkit.review.bot oldest_to_newest 468249 0 shawnsingh 2011-09-15 19:29:59 -0700 All existing instances of LayerChromium give an instance of the delegate, and it seems error prone to keep this default arg. 468258 1 107588 shawnsingh 2011-09-15 19:58:02 -0700 Created attachment 107588 Patch 468337 2 107588 jamesr 2011-09-15 23:47:45 -0700 Comment on attachment 107588 Patch Looks good. PluginLayerChromium has one of these too 468939 3 107588 webkit.review.bot 2011-09-16 17:49:33 -0700 Comment on attachment 107588 Patch Clearing flags on attachment: 107588 Committed r95344: <http://trac.webkit.org/changeset/95344> 468940 4 webkit.review.bot 2011-09-16 17:49:37 -0700 All reviewed patches have been landed. Closing bug. 107588 2011-09-15 19:58:02 -0700 2011-09-16 17:49:33 -0700 Patch bug-68211-20110915195801.patch text/plain 1374 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogOTUxODcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkZmM1YWQ2MWIxODg0OThi MzIwZWU3YTkzMjgxZWFiMTRiZmYzYjFkLi5hMDJkYWE5ZGQzZTk5OWY2M2ZiZTMyZTgyNzhlZDVk ZjdiZWJiOTMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTUgIFNoYXdu IFNpbmdoICA8c2hhd25zaW5naEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGRlZmF1 bHQgTlVMTCBhcmd1bWVudCBpbiBMYXllckNocm9taXVtOjpjcmVhdGUoKS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MjExCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29kZSBjbGVhbnVwIHJlbGF0ZWQg dG8gY3JlYXRpbmcgdW5pdCB0ZXN0aW5nLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5oOgorCiAyMDExLTA5LTE1ICBQZXRlciBCZXZlcmxvbyAg PHBldGVyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIE1ha2Ugc3VyZSB0aGF0 IHRoZSBBUk0gTkVPTiBmaWxlcyBidWlsZCB3aXRoIC1tYXJtCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllckNocm9taXVtLmgKaW5k ZXggOTBkZjY4ZDVkYzllYmFjOTI4MmY3MDM5OTVlYmYwNTA4ZWNiZTc5YS4uZjg1MzUxOWY2MWRm ZGQ3MjE0MjZiODc3YzdhZWM3YmY0NDQ0YmEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyQ2hyb21pdW0uaApAQCAtNjks NyArNjksNyBAQCBwdWJsaWM6CiBjbGFzcyBMYXllckNocm9taXVtIDogcHVibGljIFJlZkNvdW50 ZWQ8TGF5ZXJDaHJvbWl1bT4gewogICAgIGZyaWVuZCBjbGFzcyBMYXllclRpbGVyQ2hyb21pdW07 CiBwdWJsaWM6Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8TGF5ZXJDaHJvbWl1bT4gY3JlYXRlKEND TGF5ZXJEZWxlZ2F0ZSogPSAwKTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxMYXllckNocm9taXVt PiBjcmVhdGUoQ0NMYXllckRlbGVnYXRlKik7CiAKICAgICB2aXJ0dWFsIH5MYXllckNocm9taXVt KCk7CiAK