68192 2011-09-15 14:19:13 -0700 Add method to scroll current node to specific position in Chromium WebKit API 2011-09-16 06:17:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 varunjain webkit-unassigned dglazkov fishd fsamuel rjkroege oldest_to_newest 468080 0 varunjain 2011-09-15 14:19:13 -0700 Add method to scroll current node to specific position in Chromium WebKit API 468082 1 107552 varunjain 2011-09-15 14:21:20 -0700 Created attachment 107552 Patch 468096 2 107552 dglazkov 2011-09-15 14:42:03 -0700 Comment on attachment 107552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107552&action=review This logic seems to be in the wrong place. If you had it on Element, you could at least test it with window.internals. > ChangeLog:6 > + Reviewed by NOBODY (OOPS!). No test? > Source/WebKit/chromium/src/WebViewImpl.cpp:1834 > + frame->view()->scrollBy(scrollOffset); Missing indent. 468141 3 107560 varunjain 2011-09-15 16:15:31 -0700 Created attachment 107560 Patch 468149 4 107563 varunjain 2011-09-15 16:20:25 -0700 Created attachment 107563 Patch 468151 5 107563 dglazkov 2011-09-15 16:24:21 -0700 Comment on attachment 107563 Patch please don't forget to file a bug to add a test. 468215 6 107563 fsamuel 2011-09-15 18:24:30 -0700 Comment on attachment 107563 Patch Clearing flags on attachment: 107563 Committed r95252: <http://trac.webkit.org/changeset/95252> 468216 7 fsamuel 2011-09-15 18:24:36 -0700 All reviewed patches have been landed. Closing bug. 468334 8 107563 fishd 2011-09-15 23:44:20 -0700 Comment on attachment 107563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107563&action=review > Source/WebKit/chromium/public/WebView.h:179 > + virtual void scrollFocusedNodeIntoRect(const WebRect& rect) { } nit: we don't name parameters when the name doesn't add any information. here the type name is WebRect, and calling the variable "rect" does not add any information, so the name should be left out. why did you choose to have the rect be in screen coordinates instead of window coordinates? that seems like a fairly unusual choice given that most other APIs use window coordinates (e.g., input events). > Source/WebKit/chromium/src/WebViewImpl.cpp:1828 > + LayoutRect bounds = elementNode->boundsInWindowSpace(); it seems like this requires layout() to have been run before calling this function. should you perhaps assert that layout is not dirty? > Source/WebKit/chromium/src/WebViewImpl.cpp:1832 > + Frame* frame = mainFrameImpl()->frame(); how do you know that the focused node is part of the main frame? what if the focused node is part of a subframe? 468336 9 fishd 2011-09-15 23:46:04 -0700 (In reply to comment #2) > (From update of attachment 107552 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107552&action=review > > This logic seems to be in the wrong place. If you had it on Element, you could at least test it with window.internals. > > > ChangeLog:6 > > + Reviewed by NOBODY (OOPS!). > > No test? I didn't see this question answered. It seems like you could construct a test using the WebFrameTest framework. 468407 10 107563 fsamuel 2011-09-16 03:47:58 -0700 Comment on attachment 107563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107563&action=review >> Source/WebKit/chromium/src/WebViewImpl.cpp:1832 > > how do you know that the focused node is part of the main frame? > what if the focused node is part of a subframe? That's a good point. I think the correct, and most general behavior here is, given a path of frames to the mainframe, we should center each frame on the screen along the way. E.g. MainFrame->subFrame->inputbox. inputbox should be centered in subFrame and subFrame should be centered in MainFrame. 468452 11 varunjain 2011-09-16 06:15:42 -0700 Hi Darin, Dimitri and I agreed to moving this code into FrameView to be able to test it with window.internals in another CL. This is the tracking bug: https://bugs.webkit.org/show_bug.cgi?id=68198 (In reply to comment #8) > (From update of attachment 107563 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107563&action=review > > > Source/WebKit/chromium/public/WebView.h:179 > > + virtual void scrollFocusedNodeIntoRect(const WebRect& rect) { } > > nit: we don't name parameters when the name doesn't add any information. here the type name > is WebRect, and calling the variable "rect" does not add any information, so the name should be left out. > will fix in followup CL > why did you choose to have the rect be in screen coordinates instead of window coordinates? > that seems like a fairly unusual choice given that most other APIs use window coordinates > (e.g., input events). No particular reason for this except that the renderer get the rect in screen coordinates. I can change it to window coordinates in the renderer before passing to webview > > > Source/WebKit/chromium/src/WebViewImpl.cpp:1828 > > + LayoutRect bounds = elementNode->boundsInWindowSpace(); > > it seems like this requires layout() to have been run before calling > this function. should you perhaps assert that layout is not dirty? Yes.. will check for dirty layout and relayout if required. > > > Source/WebKit/chromium/src/WebViewImpl.cpp:1832 > > + Frame* frame = mainFrameImpl()->frame(); > > how do you know that the focused node is part of the main frame? > what if the focused node is part of a subframe? I totally missed that! Thanks for pointing out. I do like Fady's suggestion above. 468453 12 varunjain 2011-09-16 06:17:10 -0700 (In reply to comment #9) > (In reply to comment #2) > > (From update of attachment 107552 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=107552&action=review > > > > This logic seems to be in the wrong place. If you had it on Element, you could at least test it with window.internals. > > > > > ChangeLog:6 > > > + Reviewed by NOBODY (OOPS!). > > > > No test? > > I didn't see this question answered. It seems like you could construct a test using the WebFrameTest framework. as mentioned earlier, I'll move this code into FrameView and test using window.internals 107552 2011-09-15 14:21:20 -0700 2011-09-15 16:15:23 -0700 Patch bug-68192-20110915171806.patch text/plain 3194 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTUxOTgKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAwM2UxYTg0MDVjYWI0MzA1YTJhMDc0NzY2OWY2MTU1YzdhN2NmOWNiLi4wODY4 MWQ4MmVlNTIwMDc4N2U2NjUzM2M2NTI1NGNhMTE1MzhhZWE5IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTUgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGQgbWV0aG9kIHRvIHNjcm9s bCBjdXJyZW50IG5vZGUgdG8gc3BlY2lmaWMgcG9zaXRpb24gaW4gQ2hyb21pdW0gV2ViS2l0IEFQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxOTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqICBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKiAgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMS0wOS0xNCAgQWxleGlzIE1l bmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIFJlcGxh Y2UgUVRfR0NDX1ggYXMgdGhleSBkb24ndCBleGlzdCBpbiBRdDUgYW55bW9yZS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAppbmRleCA2ODY4M2YxYWI0MTc4OTlkZDE5NzRh MzMyM2M2MDFlOTAwNGMzMDcwLi4zMzhjMmFkOTQ1ZjA4MmE0YWZlYTU1YWVjZDBhNzA5NGRiZDFi YTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCkBAIC0xNzQsNiAr MTc0LDEwIEBAIHB1YmxpYzoKICAgICAvLyBTY3JvbGxzIHRoZSBub2RlIGN1cnJlbnRseSBpbiBm b2N1cyBpbnRvIHZpZXcuCiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbEZvY3VzZWROb2RlSW50b1Zp ZXcoKSA9IDA7CiAKKyAgICAvLyBTY3JvbGxzIHRoZSBub2RlIGN1cnJlbnRseSBpbiBmb2N1cyBp bnRvIHxyZWN0fCwgd2hlcmUgfHJlY3R8IGlzIGluCisgICAgLy8gc2NyZWVuIHNwYWNlLgorICAg IHZpcnR1YWwgdm9pZCBzY3JvbGxGb2N1c2VkTm9kZUludG9SZWN0KGNvbnN0IFdlYlJlY3QmIHJl Y3QpIHsgfQorCiAKICAgICAvLyBab29tIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDUxMjlkZjJiMGQxM2E5Y2M4NDdmMGMxYjBlNDEz ZWQwZmEzODYwYmMuLjVkZDNmNjFmMzRjZDFhNjI1MzUxMTU1ZTAwYjcxNzljMWJjYmYwMjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE4MTksNiAr MTgxOSwyMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzY3JvbGxGb2N1c2VkTm9kZUludG9WaWV3KCkK ICAgICB9CiB9CiAKK3ZvaWQgV2ViVmlld0ltcGw6OnNjcm9sbEZvY3VzZWROb2RlSW50b1JlY3Qo Y29uc3QgV2ViUmVjdCYgcmVjdCkKK3sKKyAgICBOb2RlKiBmb2N1c2VkTm9kZSA9IGZvY3VzZWRX ZWJDb3JlTm9kZSgpOworICAgIGlmIChmb2N1c2VkTm9kZSAmJiBmb2N1c2VkTm9kZS0+aXNFbGVt ZW50Tm9kZSgpKSB7CisKKyAgICAgICAgRWxlbWVudCogZWxlbWVudE5vZGUgPSBzdGF0aWNfY2Fz dDxFbGVtZW50Kj4oZm9jdXNlZE5vZGUpOworICAgICAgICBMYXlvdXRSZWN0IGJvdW5kcyA9IGVs ZW1lbnROb2RlLT5ib3VuZHNJbldpbmRvd1NwYWNlKCk7CisgICAgICAgIGludCBjZW50ZXJpbmdP ZmZzZXRYID0gKHJlY3Qud2lkdGggLSBib3VuZHMud2lkdGgoKSkgLyAyOworICAgICAgICBpbnQg Y2VudGVyaW5nT2Zmc2V0WSA9IChyZWN0LmhlaWdodCAtIGJvdW5kcy5oZWlnaHQoKSkgLyAyOwor ICAgICAgICBJbnRTaXplIHNjcm9sbE9mZnNldChib3VuZHMueCgpIC0gY2VudGVyaW5nT2Zmc2V0 WCwgYm91bmRzLnkoKSAtIGNlbnRlcmluZ09mZnNldFkpOworICAgICAgICBGcmFtZSogZnJhbWUg PSBtYWluRnJhbWVJbXBsKCktPmZyYW1lKCk7CisgICAgICAgIGlmIChmcmFtZSAmJiBmcmFtZS0+ dmlldygpKQorICAgICAgICBmcmFtZS0+dmlldygpLT5zY3JvbGxCeShzY3JvbGxPZmZzZXQpOwor ICAgIH0KK30KKwogZG91YmxlIFdlYlZpZXdJbXBsOjp6b29tTGV2ZWwoKQogewogICAgIHJldHVy biBtX3pvb21MZXZlbDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmlu ZGV4IDY5NDFmMzI0Mjk5MmQxMzU3ZjI5MWJlNDVhYzE4MjRlMDZiZGY5OTkuLmM5ODkyY2MxNTkx NTVlMDEwZmMwNTQ5MDBlODJmYTE5M2Y4Y2YxN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaApAQCAtMTUzLDYgKzE1Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs IHZvaWQgc2V0SW5pdGlhbEZvY3VzKGJvb2wgcmV2ZXJzZSk7CiAgICAgdmlydHVhbCB2b2lkIGNs ZWFyRm9jdXNlZE5vZGUoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsRm9jdXNlZE5vZGVJbnRv VmlldygpOworICAgIHZpcnR1YWwgdm9pZCBzY3JvbGxGb2N1c2VkTm9kZUludG9SZWN0KGNvbnN0 IFdlYlJlY3QmKTsKICAgICB2aXJ0dWFsIGRvdWJsZSB6b29tTGV2ZWwoKTsKICAgICB2aXJ0dWFs IGRvdWJsZSBzZXRab29tTGV2ZWwoYm9vbCB0ZXh0T25seSwgZG91YmxlIHpvb21MZXZlbCk7CiAg ICAgdmlydHVhbCB2b2lkIHpvb21MaW1pdHNDaGFuZ2VkKGRvdWJsZSBtaW5pbXVtWm9vbUxldmVs LAo= 107560 2011-09-15 16:15:31 -0700 2011-09-15 16:20:18 -0700 Patch bug-68192-20110915191216.patch text/plain 3198 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTUxOTgKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAwM2UxYTg0MDVjYWI0MzA1YTJhMDc0NzY2OWY2MTU1YzdhN2NmOWNiLi4wODY4 MWQ4MmVlNTIwMDc4N2U2NjUzM2M2NTI1NGNhMTE1MzhhZWE5IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTUgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGQgbWV0aG9kIHRvIHNjcm9s bCBjdXJyZW50IG5vZGUgdG8gc3BlY2lmaWMgcG9zaXRpb24gaW4gQ2hyb21pdW0gV2ViS2l0IEFQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxOTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqICBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKiAgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMS0wOS0xNCAgQWxleGlzIE1l bmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIFJlcGxh Y2UgUVRfR0NDX1ggYXMgdGhleSBkb24ndCBleGlzdCBpbiBRdDUgYW55bW9yZS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAppbmRleCA2ODY4M2YxYWI0MTc4OTlkZDE5NzRh MzMyM2M2MDFlOTAwNGMzMDcwLi4zMzhjMmFkOTQ1ZjA4MmE0YWZlYTU1YWVjZDBhNzA5NGRiZDFi YTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCkBAIC0xNzQsNiAr MTc0LDEwIEBAIHB1YmxpYzoKICAgICAvLyBTY3JvbGxzIHRoZSBub2RlIGN1cnJlbnRseSBpbiBm b2N1cyBpbnRvIHZpZXcuCiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbEZvY3VzZWROb2RlSW50b1Zp ZXcoKSA9IDA7CiAKKyAgICAvLyBTY3JvbGxzIHRoZSBub2RlIGN1cnJlbnRseSBpbiBmb2N1cyBp bnRvIHxyZWN0fCwgd2hlcmUgfHJlY3R8IGlzIGluCisgICAgLy8gc2NyZWVuIHNwYWNlLgorICAg IHZpcnR1YWwgdm9pZCBzY3JvbGxGb2N1c2VkTm9kZUludG9SZWN0KGNvbnN0IFdlYlJlY3QmIHJl Y3QpIHsgfQorCiAKICAgICAvLyBab29tIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDUxMjlkZjJiMGQxM2E5Y2M4NDdmMGMxYjBlNDEz ZWQwZmEzODYwYmMuLjljNDI4YzlkZWY0N2RmNjIwNjU2NDI4MmIwNTUwMzQ1ZjNkNjRmNDkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE4MTksNiAr MTgxOSwyMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzY3JvbGxGb2N1c2VkTm9kZUludG9WaWV3KCkK ICAgICB9CiB9CiAKK3ZvaWQgV2ViVmlld0ltcGw6OnNjcm9sbEZvY3VzZWROb2RlSW50b1JlY3Qo Y29uc3QgV2ViUmVjdCYgcmVjdCkKK3sKKyAgICBOb2RlKiBmb2N1c2VkTm9kZSA9IGZvY3VzZWRX ZWJDb3JlTm9kZSgpOworICAgIGlmIChmb2N1c2VkTm9kZSAmJiBmb2N1c2VkTm9kZS0+aXNFbGVt ZW50Tm9kZSgpKSB7CisKKyAgICAgICAgRWxlbWVudCogZWxlbWVudE5vZGUgPSBzdGF0aWNfY2Fz dDxFbGVtZW50Kj4oZm9jdXNlZE5vZGUpOworICAgICAgICBMYXlvdXRSZWN0IGJvdW5kcyA9IGVs ZW1lbnROb2RlLT5ib3VuZHNJbldpbmRvd1NwYWNlKCk7CisgICAgICAgIGludCBjZW50ZXJpbmdP ZmZzZXRYID0gKHJlY3Qud2lkdGggLSBib3VuZHMud2lkdGgoKSkgLyAyOworICAgICAgICBpbnQg Y2VudGVyaW5nT2Zmc2V0WSA9IChyZWN0LmhlaWdodCAtIGJvdW5kcy5oZWlnaHQoKSkgLyAyOwor ICAgICAgICBJbnRTaXplIHNjcm9sbE9mZnNldChib3VuZHMueCgpIC0gY2VudGVyaW5nT2Zmc2V0 WCwgYm91bmRzLnkoKSAtIGNlbnRlcmluZ09mZnNldFkpOworICAgICAgICBGcmFtZSogZnJhbWUg PSBtYWluRnJhbWVJbXBsKCktPmZyYW1lKCk7CisgICAgICAgIGlmIChmcmFtZSAmJiBmcmFtZS0+ dmlldygpKQorICAgICAgICAgICAgZnJhbWUtPnZpZXcoKS0+c2Nyb2xsQnkoc2Nyb2xsT2Zmc2V0 KTsKKyAgICB9Cit9CisKIGRvdWJsZSBXZWJWaWV3SW1wbDo6em9vbUxldmVsKCkKIHsKICAgICBy ZXR1cm4gbV96b29tTGV2ZWw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu aAppbmRleCA2OTQxZjMyNDI5OTJkMTM1N2YyOTFiZTQ1YWMxODI0ZTA2YmRmOTk5Li5jOTg5MmNj MTU5MTU1ZTAxMGZjMDU0OTAwZTgyZmExOTNmOGNmMTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTE1Myw2ICsxNTMsNyBAQCBwdWJsaWM6CiAgICAgdmly dHVhbCB2b2lkIHNldEluaXRpYWxGb2N1cyhib29sIHJldmVyc2UpOwogICAgIHZpcnR1YWwgdm9p ZCBjbGVhckZvY3VzZWROb2RlKCk7CiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbEZvY3VzZWROb2Rl SW50b1ZpZXcoKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsRm9jdXNlZE5vZGVJbnRvUmVjdChj b25zdCBXZWJSZWN0Jik7CiAgICAgdmlydHVhbCBkb3VibGUgem9vbUxldmVsKCk7CiAgICAgdmly dHVhbCBkb3VibGUgc2V0Wm9vbUxldmVsKGJvb2wgdGV4dE9ubHksIGRvdWJsZSB6b29tTGV2ZWwp OwogICAgIHZpcnR1YWwgdm9pZCB6b29tTGltaXRzQ2hhbmdlZChkb3VibGUgbWluaW11bVpvb21M ZXZlbCwK 107563 2011-09-15 16:20:25 -0700 2011-09-16 03:47:58 -0700 Patch bug-68192-20110915191710.patch text/plain 3174 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTUxOTgKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCAwM2UxYTg0MDVjYWI0MzA1YTJhMDc0NzY2OWY2MTU1YzdhN2NmOWNiLi4wODY4 MWQ4MmVlNTIwMDc4N2U2NjUzM2M2NTI1NGNhMTE1MzhhZWE5IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTUgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGQgbWV0aG9kIHRvIHNjcm9s bCBjdXJyZW50IG5vZGUgdG8gc3BlY2lmaWMgcG9zaXRpb24gaW4gQ2hyb21pdW0gV2ViS2l0IEFQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxOTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqICBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Lmg6CisgICAgICAgICogIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKiAgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaDoKKwogMjAxMS0wOS0xNCAgQWxleGlzIE1l bmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIFJlcGxh Y2UgUVRfR0NDX1ggYXMgdGhleSBkb24ndCBleGlzdCBpbiBRdDUgYW55bW9yZS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAppbmRleCA2ODY4M2YxYWI0MTc4OTlkZDE5NzRh MzMyM2M2MDFlOTAwNGMzMDcwLi4zMzhjMmFkOTQ1ZjA4MmE0YWZlYTU1YWVjZDBhNzA5NGRiZDFi YTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCkBAIC0xNzQsNiAr MTc0LDEwIEBAIHB1YmxpYzoKICAgICAvLyBTY3JvbGxzIHRoZSBub2RlIGN1cnJlbnRseSBpbiBm b2N1cyBpbnRvIHZpZXcuCiAgICAgdmlydHVhbCB2b2lkIHNjcm9sbEZvY3VzZWROb2RlSW50b1Zp ZXcoKSA9IDA7CiAKKyAgICAvLyBTY3JvbGxzIHRoZSBub2RlIGN1cnJlbnRseSBpbiBmb2N1cyBp bnRvIHxyZWN0fCwgd2hlcmUgfHJlY3R8IGlzIGluCisgICAgLy8gc2NyZWVuIHNwYWNlLgorICAg IHZpcnR1YWwgdm9pZCBzY3JvbGxGb2N1c2VkTm9kZUludG9SZWN0KGNvbnN0IFdlYlJlY3QmIHJl Y3QpIHsgfQorCiAKICAgICAvLyBab29tIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IDUxMjlkZjJiMGQxM2E5Y2M4NDdmMGMxYjBlNDEz ZWQwZmEzODYwYmMuLjE4NWQwYjRlYjMxY2JiYTY5Y2I2MWU0ZGM4YjNjMGY1MTBmNTUwZTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE4MTksNiAr MTgxOSwyMSBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzY3JvbGxGb2N1c2VkTm9kZUludG9WaWV3KCkK ICAgICB9CiB9CiAKK3ZvaWQgV2ViVmlld0ltcGw6OnNjcm9sbEZvY3VzZWROb2RlSW50b1JlY3Qo Y29uc3QgV2ViUmVjdCYgcmVjdCkKK3sKKyAgICBOb2RlKiBmb2N1c2VkTm9kZSA9IGZvY3VzZWRX ZWJDb3JlTm9kZSgpOworICAgIGlmICghZm9jdXNlZE5vZGUgfHwgIWZvY3VzZWROb2RlLT5pc0Vs ZW1lbnROb2RlKCkpCisgICAgICAgIHJldHVybjsKKyAgICBFbGVtZW50KiBlbGVtZW50Tm9kZSA9 IHN0YXRpY19jYXN0PEVsZW1lbnQqPihmb2N1c2VkTm9kZSk7CisgICAgTGF5b3V0UmVjdCBib3Vu ZHMgPSBlbGVtZW50Tm9kZS0+Ym91bmRzSW5XaW5kb3dTcGFjZSgpOworICAgIGludCBjZW50ZXJp bmdPZmZzZXRYID0gKHJlY3Qud2lkdGggLSBib3VuZHMud2lkdGgoKSkgLyAyOworICAgIGludCBj ZW50ZXJpbmdPZmZzZXRZID0gKHJlY3QuaGVpZ2h0IC0gYm91bmRzLmhlaWdodCgpKSAvIDI7Cisg ICAgSW50U2l6ZSBzY3JvbGxPZmZzZXQoYm91bmRzLngoKSAtIGNlbnRlcmluZ09mZnNldFgsIGJv dW5kcy55KCkgLSBjZW50ZXJpbmdPZmZzZXRZKTsKKyAgICBGcmFtZSogZnJhbWUgPSBtYWluRnJh bWVJbXBsKCktPmZyYW1lKCk7CisgICAgaWYgKGZyYW1lICYmIGZyYW1lLT52aWV3KCkpCisgICAg ICAgIGZyYW1lLT52aWV3KCktPnNjcm9sbEJ5KHNjcm9sbE9mZnNldCk7Cit9CisKIGRvdWJsZSBX ZWJWaWV3SW1wbDo6em9vbUxldmVsKCkKIHsKICAgICByZXR1cm4gbV96b29tTGV2ZWw7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAppbmRleCA2OTQxZjMyNDI5OTJkMTM1 N2YyOTFiZTQ1YWMxODI0ZTA2YmRmOTk5Li5jOTg5MmNjMTU5MTU1ZTAxMGZjMDU0OTAwZTgyZmEx OTNmOGNmMTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAg LTE1Myw2ICsxNTMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHNldEluaXRpYWxGb2N1 cyhib29sIHJldmVyc2UpOwogICAgIHZpcnR1YWwgdm9pZCBjbGVhckZvY3VzZWROb2RlKCk7CiAg ICAgdmlydHVhbCB2b2lkIHNjcm9sbEZvY3VzZWROb2RlSW50b1ZpZXcoKTsKKyAgICB2aXJ0dWFs IHZvaWQgc2Nyb2xsRm9jdXNlZE5vZGVJbnRvUmVjdChjb25zdCBXZWJSZWN0Jik7CiAgICAgdmly dHVhbCBkb3VibGUgem9vbUxldmVsKCk7CiAgICAgdmlydHVhbCBkb3VibGUgc2V0Wm9vbUxldmVs KGJvb2wgdGV4dE9ubHksIGRvdWJsZSB6b29tTGV2ZWwpOwogICAgIHZpcnR1YWwgdm9pZCB6b29t TGltaXRzQ2hhbmdlZChkb3VibGUgbWluaW11bVpvb21MZXZlbCwK