68183 2011-09-15 12:59:37 -0700 [Qt] QTouchWebView missing loadProgress tests 2011-09-16 22:24:07 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gopal.1.raghavan webkit-unassigned webkit.review.bot oldest_to_newest 468018 0 gopal.1.raghavan 2011-09-15 12:59:37 -0700 There are no tests to check loadProgress property of TouchWebView 468027 1 107535 gopal.1.raghavan 2011-09-15 13:08:43 -0700 Created attachment 107535 TouchWebView loadProgress test Added new tests to check loadProgress property of TouchWebView. Here are the test results: ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase() QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase() PASS : DesktopWebViewProperties::initTestCase() QWARN : DesktopWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : DesktopWebViewProperties::test_title() PASS : DesktopWebViewProperties::test_url() PASS : DesktopWebViewProperties::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QWARN : TouchWebViewLoad::test_load() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_load() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QWARN : TouchWebViewLoad::test_loadNegativeSizeView() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_loadNegativeSizeView() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewLoadProgress::initTestCase() QWARN : TouchWebViewLoadProgress::test_loadProgress() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoadProgress::test_loadProgress() PASS : TouchWebViewLoadProgress::cleanupTestCase() PASS : TouchWebViewLoad::initTestCase() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewLoad::test_loadZeroSizeView() PASS : TouchWebViewLoad::cleanupTestCase() PASS : TouchWebViewProperties::initTestCase() QWARN : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewProperties::test_title() PASS : TouchWebViewProperties::test_url() PASS : TouchWebViewProperties::cleanupTestCase() Totals: 24 passed, 0 failed, 0 skipped ********* Finished testing of qmltests ********* Number of leaked textures: 0 Number of leaked materials: 0 Number of leaked nodes: 0 LEAK: 7 WebContext Number of leaked items: 0 468033 2 107535 menard 2011-09-15 13:22:45 -0700 Comment on attachment 107535 TouchWebView loadProgress test LGTM. 468456 3 107535 cshu 2011-09-16 06:28:12 -0700 Comment on attachment 107535 TouchWebView loadProgress test Looks good. But please cleanup the format of the qml file. I think there are tabs in it. 468671 4 107693 gopal.1.raghavan 2011-09-16 11:43:28 -0700 Created attachment 107693 updated patch with reviewer comments Chang, I have updated patch with format fixes. Thanks. 468674 5 107693 cshu 2011-09-16 11:48:44 -0700 Comment on attachment 107693 updated patch with reviewer comments Thanks! 469026 6 107693 webkit.review.bot 2011-09-16 22:24:03 -0700 Comment on attachment 107693 updated patch with reviewer comments Clearing flags on attachment: 107693 Committed r95367: <http://trac.webkit.org/changeset/95367> 469027 7 webkit.review.bot 2011-09-16 22:24:07 -0700 All reviewed patches have been landed. Closing bug. 107535 2011-09-15 13:08:43 -0700 2011-09-16 11:43:28 -0700 TouchWebView loadProgress test 68183.patch text/plain 2296 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MjE5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTUgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisgICAgICAgIFtRdF0gUVRvdWNo V2ViVmlldyBtaXNzaW5nIGxvYWRQcm9ncmVzcyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0ZXN0IGNhc2UgdG8gY2hlY2sgbG9hZCBw cm9ncmVzcyBmb3IgUVRvdWNoV2ViVmlldworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9Ub3VjaFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWw6IEFkZGVkLgor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvOgor CiAyMDExLTA5LTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgRU5BQkxFX1NWR19BTklNQVRJT04gYXMgYWxsIG1ham9yIHBvcnRzIGhhdmUgaXQgb24g YnkgZGVmYXVsdApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9xbWx0ZXN0cy5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8JKHJldmlzaW9uIDk1MjEwKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0 cy5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTEzLDUgKzEzLDYgQEAgT1RIRVJfRklMRVMgKz0gXAog ICAgIERlc2t0b3BXZWJWaWV3L3RzdF9uYXZpZ2F0aW9uUG9saWN5Rm9yVXJsLnFtbCBcCiAgICAg VG91Y2hXZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbCBcCiAgICAgVG91Y2hXZWJWaWV3L3RzdF9s b2FkWmVyb1NpemVWaWV3LnFtbCBcCi0gICAgVG91Y2hXZWJWaWV3L3RzdF9sb2FkTmVnYXRpdmVT aXplVmlldy5xbWwKKyAgICBUb3VjaFdlYlZpZXcvdHN0X2xvYWROZWdhdGl2ZVNpemVWaWV3LnFt bCBcCisgICAgVG91Y2hXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3MucW1sCiAKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvVG91Y2hXZWJWaWV3L3Rz dF9sb2FkUHJvZ3Jlc3MucW1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvVG91Y2hXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3MucW1s CShyZXZpc2lvbiAwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9Ub3VjaFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMjcgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAoraW1wb3J0IFF0VGVzdCAxLjAKK2lt cG9ydCBRdFdlYktpdC5leHBlcmltZW50YWwgNS4wCisKK1RvdWNoV2ViVmlldyB7CisgICAgaWQ6 IHdlYlZpZXcKKworICAgIFNpZ25hbFNweSB7CisgICAgICAgIGlkOiBzcHkKKyAgICAgICAgdGFy Z2V0OiB3ZWJWaWV3LnBhZ2UKKyAgICAgICAgc2lnbmFsTmFtZTogImxvYWRTdWNjZWVkZWQiCisg ICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAiVG91Y2hXZWJWaWV3TG9hZFBy b2dyZXNzIgorCisJZnVuY3Rpb24gdGVzdF9sb2FkUHJvZ3Jlc3MoKSB7CisJICAgY29tcGFyZShz cHkuY291bnQsIDApCisgICAgICAgICAgIHZhciB0ZXN0VXJsID0gUXQucmVzb2x2ZWRVcmwoIi4u L2NvbW1vbi90ZXN0MS5odG1sIikKKyAgICAgICAgICAgd2ViVmlldy5wYWdlLmxvYWQodGVzdFVy bCkKKwkgICBjb21wYXJlKHdlYlZpZXcucGFnZS5sb2FkUHJvZ3Jlc3MsIDApCisJICAgc3B5Lndh aXQoKQorCSAgIGNvbXBhcmUod2ViVmlldy5wYWdlLmxvYWRQcm9ncmVzcywgMTAwKQorICAgICAg ICB9CisKKyAgICB9Cit9Cg== 107693 2011-09-16 11:43:28 -0700 2011-09-16 22:24:03 -0700 updated patch with reviewer comments 68183a.patch text/plain 2335 gopal.1.raghavan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MjE5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDktMTUgIEdvcGFsIFJh Z2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBub2tpYS5jb20+CisgICAgICAgIFtRdF0gUVRvdWNo V2ViVmlldyBtaXNzaW5nIGxvYWRQcm9ncmVzcyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxODMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0ZXN0IGNhc2UgdG8gY2hlY2sgbG9hZCBw cm9ncmVzcyBmb3IgUVRvdWNoV2ViVmlldworCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9Ub3VjaFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWw6IEFkZGVkLgor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvOgor CiAyMDExLTA5LTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgRU5BQkxFX1NWR19BTklNQVRJT04gYXMgYWxsIG1ham9yIHBvcnRzIGhhdmUgaXQgb24g YnkgZGVmYXVsdApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9xbWx0ZXN0cy5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8JKHJldmlzaW9uIDk1MjEwKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0 cy5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTEzLDUgKzEzLDYgQEAgT1RIRVJfRklMRVMgKz0gXAog ICAgIERlc2t0b3BXZWJWaWV3L3RzdF9uYXZpZ2F0aW9uUG9saWN5Rm9yVXJsLnFtbCBcCiAgICAg VG91Y2hXZWJWaWV3L3RzdF9wcm9wZXJ0aWVzLnFtbCBcCiAgICAgVG91Y2hXZWJWaWV3L3RzdF9s b2FkWmVyb1NpemVWaWV3LnFtbCBcCi0gICAgVG91Y2hXZWJWaWV3L3RzdF9sb2FkTmVnYXRpdmVT aXplVmlldy5xbWwKKyAgICBUb3VjaFdlYlZpZXcvdHN0X2xvYWROZWdhdGl2ZVNpemVWaWV3LnFt bCBcCisgICAgVG91Y2hXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3MucW1sCiAKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvVG91Y2hXZWJWaWV3L3Rz dF9sb2FkUHJvZ3Jlc3MucW1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvVG91Y2hXZWJWaWV3L3RzdF9sb2FkUHJvZ3Jlc3MucW1s CShyZXZpc2lvbiAwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9Ub3VjaFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMjYgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAoraW1wb3J0IFF0VGVzdCAxLjAKK2lt cG9ydCBRdFdlYktpdC5leHBlcmltZW50YWwgNS4wCisKK1RvdWNoV2ViVmlldyB7CisgICAgaWQ6 IHdlYlZpZXcKKworICAgIFNpZ25hbFNweSB7CisgICAgICAgIGlkOiBzcHkKKyAgICAgICAgdGFy Z2V0OiB3ZWJWaWV3LnBhZ2UKKyAgICAgICAgc2lnbmFsTmFtZTogImxvYWRTdWNjZWVkZWQiCisg ICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAiVG91Y2hXZWJWaWV3TG9hZFBy b2dyZXNzIgorCisgICAgICAgIGZ1bmN0aW9uIHRlc3RfbG9hZFByb2dyZXNzKCkgeworICAgICAg ICAgICAgY29tcGFyZShzcHkuY291bnQsIDApCisgICAgICAgICAgICB2YXIgdGVzdFVybCA9IFF0 LnJlc29sdmVkVXJsKCIuLi9jb21tb24vdGVzdDEuaHRtbCIpCisgICAgICAgICAgICB3ZWJWaWV3 LnBhZ2UubG9hZCh0ZXN0VXJsKQorICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LnBhZ2UubG9h ZFByb2dyZXNzLCAwKQorICAgICAgICAgICAgc3B5LndhaXQoKQorICAgICAgICAgICAgY29tcGFy ZSh3ZWJWaWV3LnBhZ2UubG9hZFByb2dyZXNzLCAxMDApCisgICAgICAgIH0KKyAgICB9Cit9Cg==