6818 2006-01-25 20:59:01 -0800 garbage collect a bit later when destroying Frame (fixes node leak false positives) 2006-01-26 12:26:21 -0800 1 1 1 Unclassified WebKit Frames 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 29974 0 mjs 2006-01-25 20:59:01 -0800 Frame clears the properties of the window object and garbage collects every time you change documents. This is good, because you don't want to leak custom properties to the next document, and because much garbage will be created when the properties are cleared. However, it also does this on destruction. That's suboptimal, because the window object itself (and everything it keeps alive) will become collectable after the ScriptInterpreter is destroyed. So the clearing is a waste of time, and the garbage collection would be better done later. On top of all that, this causes false positives from the NodeImpl leak counter. 29975 1 5969 mjs 2006-01-25 21:03:23 -0800 Created attachment 5969 skip the clear, GC after destroying ScriptInterpreter 29977 2 5969 hyatt 2006-01-25 21:07:31 -0800 Comment on attachment 5969 skip the clear, GC after destroying ScriptInterpreter r=me but run the PLT and layout tests. 5969 2006-01-25 21:03:23 -0800 2006-01-25 21:07:31 -0800 skip the clear, GC after destroying ScriptInterpreter gc-after-interpreter-destruction.patch.txt text/plain 2741 mjs SW5kZXg6IGtodG1sL2VjbWEva2pzX3Byb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBraHRtbC9lY21h L2tqc19wcm94eS5jcHAJKHJldmlzaW9uIDEyMzgwKQorKysga2h0bWwvZWNtYS9ranNfcHJveHku Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Niw2ICs0Niw3IEBAIEtKU1Byb3h5SW1wbDo6fktKU1By b3h5SW1wbCgpCiB7CiAgICAgSlNMb2NrIGxvY2s7CiAgICAgZGVsZXRlIG1fc2NyaXB0OworICAg IENvbGxlY3Rvcjo6Y29sbGVjdCgpOwogfQogCiBRVmFyaWFudCBLSlNQcm94eUltcGw6OmV2YWx1 YXRlKGNvbnN0IERPTVN0cmluZyYgZmlsZW5hbWUsIGludCBiYXNlTGluZSwgY29uc3QgRE9NU3Ry aW5nJiBzdHIsIE5vZGVJbXBsICpuKSAKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBD aGFuZ2VMb2cJKHJldmlzaW9uIDEyMzgyKQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMjEgQEAKIDIwMDYtMDEtMjUgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxl LmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIC0gZ2FyYmFnZSBjb2xsZWN0IGEgYml0IGxhdGVyIHdoZW4gZGVzdHJveWluZyBGcmFt ZSAoZml4ZXMgbm9kZSBsZWFrIGZhbHNlIHBvc2l0aXZlcykKKyAgICAgICAgaHR0cDovL2J1Z3pp bGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02ODE4ICAgICAgIAorCisgICAgICAg ICoga2h0bWwvZWNtYS9ranNfcHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S0pTUHJveHlJ bXBsOjp+S0pTUHJveHlJbXBsKTogR2FyYmFnZSBjb2xsZWN0IGFmdGVyIGRlc3Ryb3lpbmcKKyAg ICAgICAgdGhlIHNjcmlwdCBpbnRlcnByZXRlci4KKyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoK KyAgICAgICAgKEZyYW1lOjpjbGVhcik6IEFkZCBhIGJvb2xlYW4gcGFyYW1ldGVyIHRvIGluZGlj YXRlIHdoZXRoZXIgcHJvcGVydGllcworICAgICAgICBvZiB0aGUgd2luZG93IG9iamVjdCBzaG91 bGQgYWxzbyBiZSBjbGVhcmVkIChkZWZhdWx0cyB0byB0cnVlKS4KKyAgICAgICAgKEZyYW1lOjp+ RnJhbWUpOiBDYWxsIGNsZWFyKGZhbHNlKSBpbnN0ZWFkIG9mIGNsZWFyKCkKKyAgICAgICAgKiBw YWdlL0ZyYW1lLmg6CisKKzIwMDYtMDEtMjUgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxl LmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KIAogICAgICAgICAtIFR1cm4gb24g Tm9kZUltcGwgbGVhayBjb3VudGVyIGZvciBkZWJ1ZyBidWlsZHMKSW5kZXg6IHBhZ2UvRnJhbWUu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBwYWdlL0ZyYW1lLmgJKHJldmlzaW9uIDEyMzgwKQorKysgcGFnZS9G cmFtZS5oCSh3b3JraW5nIGNvcHkpCkBAIC05MDQsNyArOTA0LDcgQEAgcHJpdmF0ZSBzbG90czoK IAogICB2b2lkIHNsb3RFbmRMaWZlU3VwcG9ydCgpOwogCi0gIHZpcnR1YWwgdm9pZCBjbGVhcigp OworICB2aXJ0dWFsIHZvaWQgY2xlYXIoYm9vbCBjbGVhcldpbmRvd1Byb3BlcnRpZXMgPSB0cnVl KTsKIAogcHJpdmF0ZToKICAgYm9vbCByZXN0b3JlVVJMKCBjb25zdCBLVVJMICZ1cmwgKTsKSW5k ZXg6IHBhZ2UvRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvRnJhbWUuY3BwCShyZXZpc2lv biAxMjM4MCkKKysrIHBhZ2UvRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsNyArMjE2 LDcgQEAgRnJhbWU6On5GcmFtZSgpCiAgIGRpc2Nvbm5lY3QoIENhY2hlOjpsb2FkZXIoKSwgU0lH TkFMKCByZXF1ZXN0RmFpbGVkKCBraHRtbDo6RG9jTG9hZGVyKiwga2h0bWw6OkNhY2hlZE9iamVj dCAqKSApLAogICAgICAgICAgICB0aGlzLCBTTE9UKCBzbG90TG9hZGVyUmVxdWVzdERvbmUoIGto dG1sOjpEb2NMb2FkZXIqLCBraHRtbDo6Q2FjaGVkT2JqZWN0ICopICkgKTsKIAotICBjbGVhcigp OworICBjbGVhcihmYWxzZSk7CiAKICAgaWYgKGQtPm1fdmlldykgewogICAgIGQtPm1fdmlldy0+ aGlkZSgpOwpAQCAtNTgxLDcgKzU4MSw3IEBAIGJvb2wgRnJhbWU6OmF1dG9sb2FkSW1hZ2VzKCkg Y29uc3QKICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgRnJhbWU6OmNsZWFyKCkKK3ZvaWQgRnJh bWU6OmNsZWFyKGJvb2wgY2xlYXJXaW5kb3dQcm9wZXJ0aWVzKQogewogICBpZiAoIGQtPm1fYkNs ZWFyZWQgKQogICAgIHJldHVybjsKQEAgLTU4OSwxMSArNTg5LDExIEBAIHZvaWQgRnJhbWU6OmNs ZWFyKCkKICAgZC0+bV9iQ2xlYXJpbmcgPSB0cnVlOwogICBkLT5tX21vdXNlUHJlc3NOb2RlID0g MDsKIAotICBpZiAoIGQtPm1fZG9jICkKKyAgaWYgKGQtPm1fZG9jKQogICAgIGQtPm1fZG9jLT5k ZXRhY2goKTsKIAogICAvLyBNb3ZpbmcgcGFzdCBkb2Mgc28gdGhhdCBvblVubG9hZCB3b3Jrcy4K LSAgaWYgKCBkLT5tX2pzY3JpcHQgKQorICBpZiAoY2xlYXJXaW5kb3dQcm9wZXJ0aWVzICYmIGQt Pm1fanNjcmlwdCkKICAgICBkLT5tX2pzY3JpcHQtPmNsZWFyKCk7CiAKICAgaWYgKCBkLT5tX3Zp ZXcgKQo=