68158 2011-09-15 07:06:20 -0700 Don't bother calculating dirty rect for accelerated 2D canvases. 2011-09-15 09:09:09 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling mdelaney7 webkit.review.bot oldest_to_newest 467774 0 kling 2011-09-15 07:06:20 -0700 CanvasRenderingContext2D::didDraw() currently calculates the dirty rect for invalidation, but if the canvas is accelerated and has an AC layer, we don't use the dirty rect, but simply call RenderLayer::contentChanged(). 467775 1 107490 kling 2011-09-15 07:07:05 -0700 Created attachment 107490 Proposed patch 467778 2 107490 kenneth 2011-09-15 07:12:34 -0700 Comment on attachment 107490 Proposed patch Nice 467836 3 107490 webkit.review.bot 2011-09-15 09:09:05 -0700 Comment on attachment 107490 Proposed patch Clearing flags on attachment: 107490 Committed r95193: <http://trac.webkit.org/changeset/95193> 467837 4 webkit.review.bot 2011-09-15 09:09:09 -0700 All reviewed patches have been landed. Closing bug. 107490 2011-09-15 07:07:05 -0700 2011-09-15 09:09:05 -0700 Proposed patch bug-68158.diff text/plain 2684 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNWZhZDhlLi5lZDFkNmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMDktMTUgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIERvbid0IGJvdGhlciBjYWxjdWxhdGluZyBkaXJ0eSByZWN0IGZvciBhY2NlbGVyYXRlZCAy RCBjYW52YXNlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY4MTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRm9yIGFjY2VsZXJhdGVkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCwgZGlkRHJhdygpIHNp bXBseSBjYWxscyBvdXQKKyAgICAgICAgdG8gUmVuZGVyTGF5ZXI6OmNvbnRlbnRDaGFuZ2VkKCku IE1vdmUgdGhpcyB0byB0aGUgdG9wIG9mIGRpZERyYXcoKQorICAgICAgICBzbyB3ZSBkb24ndCB3 YXN0ZSB0aW1lIGNhbGN1bGF0aW5nIGEgcHJlY2lzZSBkaXJ0eSByZWN0LgorCisgICAgICAgICog aHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZGlkRHJhdyk6CisKKzIwMTEtMDktMTUgIEFu ZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAgICAgIENhbnZhc1JlbmRlcmlu Z0NvbnRleHQyRDo6U3RhdGUgY29weSBjdG9yIHNob3VsZCB1c2UgaW5pdGlhbGl6ZXIgbGlzdC4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY4MTUyCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0Nv bnRleHQyRC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdD b250ZXh0MkQuY3BwCmluZGV4IGIxYWZiNTUuLmUxOWM1M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAt MTYyMyw2ICsxNjIzLDE3IEBAIHZvaWQgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpkaWREcmF3 KGNvbnN0IEZsb2F0UmVjdCYgciwgdW5zaWduZWQgb3B0aW9ucykKICAgICBpZiAoIXN0YXRlKCku bV9pbnZlcnRpYmxlQ1RNKQogICAgICAgICByZXR1cm47CiAKKyNpZiBFTkFCTEUoQUNDRUxFUkFU RURfMkRfQ0FOVkFTKSAmJiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgLy8gSWYg d2UgYXJlIGRyYXdpbmcgdG8gaGFyZHdhcmUgYW5kIHdlIGhhdmUgYSBjb21wb3NpdGVkIGxheWVy LCBqdXN0IGNhbGwgY29udGVudENoYW5nZWQoKS4KKyAgICBpZiAoaXNBY2NlbGVyYXRlZCgpKSB7 CisgICAgICAgIFJlbmRlckJveCogcmVuZGVyQm94ID0gY2FudmFzKCktPnJlbmRlckJveCgpOwor ICAgICAgICBpZiAocmVuZGVyQm94ICYmIHJlbmRlckJveC0+aGFzTGF5ZXIoKSAmJiByZW5kZXJC b3gtPmxheWVyKCktPmhhc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSkgeworICAgICAgICAgICAg cmVuZGVyQm94LT5sYXllcigpLT5jb250ZW50Q2hhbmdlZChSZW5kZXJMYXllcjo6Q2FudmFzQ2hh bmdlZCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICB9CisjZW5kaWYKKwog ICAgIEZsb2F0UmVjdCBkaXJ0eVJlY3QgPSByOwogICAgIGlmIChvcHRpb25zICYgQ2FudmFzRGlk RHJhd0FwcGx5VHJhbnNmb3JtKSB7CiAgICAgICAgIEFmZmluZVRyYW5zZm9ybSBjdG0gPSBzdGF0 ZSgpLm1fdHJhbnNmb3JtOwpAQCAtMTY0MywxNCArMTY1NCw3IEBAIHZvaWQgQ2FudmFzUmVuZGVy aW5nQ29udGV4dDJEOjpkaWREcmF3KGNvbnN0IEZsb2F0UmVjdCYgciwgdW5zaWduZWQgb3B0aW9u cykKICAgICAgICAgLy8gd2UnZCBoYXZlIHRvIGtlZXAgdGhlIGNsaXAgcGF0aCBhcm91bmQuCiAg ICAgfQogCi0jaWYgRU5BQkxFKEFDQ0VMRVJBVEVEXzJEX0NBTlZBUykgJiYgVVNFKEFDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HKQotICAgIC8vIElmIHdlIGFyZSBkcmF3aW5nIHRvIGhhcmR3YXJlIGFu ZCB3ZSBoYXZlIGEgY29tcG9zaXRlZCBsYXllciwganVzdCBjYWxsIGNvbnRlbnRDaGFuZ2VkKCku Ci0gICAgUmVuZGVyQm94KiByZW5kZXJCb3ggPSBjYW52YXMoKS0+cmVuZGVyQm94KCk7Ci0gICAg aWYgKGlzQWNjZWxlcmF0ZWQoKSAmJiByZW5kZXJCb3ggJiYgcmVuZGVyQm94LT5oYXNMYXllcigp ICYmIHJlbmRlckJveC0+bGF5ZXIoKS0+aGFzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpKQotICAg ICAgICByZW5kZXJCb3gtPmxheWVyKCktPmNvbnRlbnRDaGFuZ2VkKFJlbmRlckxheWVyOjpDYW52 YXNDaGFuZ2VkKTsKLSAgICBlbHNlCi0jZW5kaWYKLSAgICAgICAgY2FudmFzKCktPmRpZERyYXco ZGlydHlSZWN0KTsKKyAgICBjYW52YXMoKS0+ZGlkRHJhdyhkaXJ0eVJlY3QpOwogfQogCiBHcmFw aGljc0NvbnRleHQqIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd2luZ0NvbnRleHQoKSBj b25zdAo=