68157 2011-09-15 05:54:04 -0700 Set but not used variables cleanup (gcc 4.6) 2011-09-16 16:23:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mperepelitsyn webkit-unassigned darin webkit.review.bot oldest_to_newest 467756 0 mperepelitsyn 2011-09-15 05:54:04 -0700 Set but not used variables cleanup (gcc 4.6) 467761 1 107483 mperepelitsyn 2011-09-15 06:02:06 -0700 Created attachment 107483 Patch 468164 2 107483 darin 2011-09-15 16:54:58 -0700 Comment on attachment 107483 Patch These seem fine. In both cases I am not an expert on the code in question, but I think I can make the call even without that expertise. 468505 3 mperepelitsyn 2011-09-16 08:43:13 -0700 Thanks. Could you land the patch? 468883 4 107483 webkit.review.bot 2011-09-16 16:23:40 -0700 Comment on attachment 107483 Patch Clearing flags on attachment: 107483 Committed r95333: <http://trac.webkit.org/changeset/95333> 468885 5 webkit.review.bot 2011-09-16 16:23:44 -0700 All reviewed patches have been landed. Closing bug. 107483 2011-09-15 06:02:06 -0700 2011-09-16 16:23:40 -0700 Patch bug-68157-20110915190203.patch text/plain 2489 mperepelitsyn SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MTg1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMTUgIE1heCBQZXJl cGVsaXRzeW4gIDxwcGgzNHJAZ21haWwuY29tPgorCisgICAgICAgIFNldCBidXQgbm90IHVzZWQg dmFyaWFibGVzIGNsZWFudXAgKGdjYyA0LjYpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02ODE1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vUmV2ZXJiQ29udm9sdmVyU3RhZ2Uu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmV2ZXJiQ29udm9sdmVyU3RhZ2U6OnByb2Nlc3MpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNZWRpYUNvbnRyb2xzQ2hyb21pdW0uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6cGFpbnRNZWRpYUJ1dHRvbik6CisKIDIwMTEtMDktMTUgIFBldGVyIEJl dmVybG9vICA8cGV0ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gTWFrZSBz dXJlIHRoYXQgdGhlIEFSTSBORU9OIGZpbGVzIGJ1aWxkIHdpdGggLW1hcm0KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1JldmVyYkNvbnZvbHZlclN0YWdlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9SZXZlcmJDb252b2x2ZXJTdGFn ZS5jcHAJKHJldmlzaW9uIDk1MDg3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v UmV2ZXJiQ29udm9sdmVyU3RhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjIsOCArMTIyLDYg QEAgdm9pZCBSZXZlcmJDb252b2x2ZXJTdGFnZTo6cHJvY2VzcyhmbG9hdAogICAgIGlmICghaXNU ZW1wb3JhcnlCdWZmZXJTYWZlKQogICAgICAgICByZXR1cm47CiAKLSAgICBpbnQgd3JpdGVJbmRl eCA9IDA7Ci0KICAgICBpZiAobV9mcmFtZXNQcm9jZXNzZWQgPCBtX3ByZURlbGF5TGVuZ3RoKSB7 CiAgICAgICAgIC8vIEZvciB0aGUgZmlyc3QgbV9wcmVEZWxheUxlbmd0aCBmcmFtZXMgZG9uJ3Qg cHJvY2VzcyB0aGUgY29udm9sdmVyLCBpbnN0ZWFkIHNpbXBseSBidWZmZXIgaW4gdGhlIHByZS1k ZWxheS4KICAgICAgICAgLy8gQnV0IHdoaWxlIGJ1ZmZlcmluZyB0aGUgcHJlLWRlbGF5LCB3ZSBz dGlsbCBuZWVkIHRvIHVwZGF0ZSBvdXIgaW5kZXguCkBAIC0xMzUsNyArMTMzLDcgQEAgdm9pZCBS ZXZlcmJDb252b2x2ZXJTdGFnZTo6cHJvY2VzcyhmbG9hdAogICAgICAgICBtX2NvbnZvbHZlci0+ cHJvY2VzcygmbV9mZnRLZXJuZWwsIHByZURlbGF5ZWRTb3VyY2UsIHRlbXBvcmFyeUJ1ZmZlciwg ZnJhbWVzVG9Qcm9jZXNzKTsKIAogICAgICAgICAvLyBOb3cgYWNjdW11bGF0ZSBpbnRvIHJldmVy YidzIGFjY3VtdWxhdGlvbiBidWZmZXIuCi0gICAgICAgIHdyaXRlSW5kZXggPSBtX2FjY3VtdWxh dGlvbkJ1ZmZlci0+YWNjdW11bGF0ZSh0ZW1wb3JhcnlCdWZmZXIsIGZyYW1lc1RvUHJvY2Vzcywg Jm1fYWNjdW11bGF0aW9uUmVhZEluZGV4LCBtX3Bvc3REZWxheUxlbmd0aCk7CisgICAgICAgIG1f YWNjdW11bGF0aW9uQnVmZmVyLT5hY2N1bXVsYXRlKHRlbXBvcmFyeUJ1ZmZlciwgZnJhbWVzVG9Q cm9jZXNzLCAmbV9hY2N1bXVsYXRpb25SZWFkSW5kZXgsIG1fcG9zdERlbGF5TGVuZ3RoKTsKICAg ICB9CiAKICAgICAvLyBGaW5hbGx5IGNvcHkgaW5wdXQgdG8gcHJlLWRlbGF5LgpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck1lZGlhQ29udHJvbHND aHJvbWl1bS5jcHAJKHJldmlzaW9uIDk1MDg3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck1lZGlhQ29udHJvbHNDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzLDcg KzYzLDYgQEAgc3RhdGljIGJvb2wgaGFzU291cmNlKGNvbnN0IEhUTUxNZWRpYUVsZQogCiBzdGF0 aWMgYm9vbCBwYWludE1lZGlhQnV0dG9uKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3Qg SW50UmVjdCYgcmVjdCwgSW1hZ2UqIGltYWdlKQogewotICAgIEludFJlY3QgaW1hZ2VSZWN0ID0g aW1hZ2UtPnJlY3QoKTsKICAgICBjb250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UsIENvbG9yU3BhY2VE ZXZpY2VSR0IsIHJlY3QpOwogICAgIHJldHVybiB0cnVlOwogfQo=