68127 2011-09-14 15:30:42 -0700 DFG JIT should not speculate integer if the value is always going to be used as a double anyway 2011-09-14 16:06:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 467412 0 fpizlo 2011-09-14 15:30:42 -0700 The DFG JIT will speculate that a value is an integer if the prediction logic tells us so. But this is dangerously unnecessary if the value will always be used as a double. For example, if o.f is predicted integer but is always used as o.f * 1.5, then there is no point to speculating that o.f is an integer because even if we do, we still have to convert it to a double. 467418 1 107408 fpizlo 2011-09-14 15:34:30 -0700 Created attachment 107408 the patch 467450 2 fpizlo 2011-09-14 16:06:35 -0700 Landed in r95136. 107408 2011-09-14 15:34:30 -0700 2011-09-14 15:45:35 -0700 the patch valuetodouble_patch_1.diff text/plain 6578 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTUxMzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAK KzIwMTEtMDktMTQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHNob3VsZCBub3Qgc3BlY3VsYXRlIGludGVnZXIgaWYgdGhlIHZhbHVlIGlzIGFsd2F5 cyBnb2luZyB0byBiZQorICAgICAgICB1c2VkIGFzIGEgZG91YmxlIGFueXdheQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxMjcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEFkZGVkIGEgVmFs dWVUb0RvdWJsZSBub2RlLCB3aGljaCBpcyBhIHZhcmlhbnQgb2YgVmFsdWVUb051bWJlciB0aGF0 CisgICAgICAgIGhpbnRzIHRoYXQgaXQgd2lsbCBvbmx5IGJlIHVzZWQgYXMgYSBkb3VibGUgYW5k IG5ldmVyIGFzIGFuIGludGVnZXIuCisgICAgICAgIFRodXMsIGl0IHR1cm5zIG9mZiBpbnRlZ2Vy IHNwZWN1bGF0aW9uIGV2ZW4gaWYgdGhlIHZhbHVlIHByb2ZpbGVyCisgICAgICAgIHRvbGQgdXMg dGhhdCB0aGUgdmFsdWUgc291cmNlIGlzIGFuIGludC4gVGhlIGxvZ2ljIGZvciBjb252ZXJ0aW5n IGEKKyAgICAgICAgVmFsdWVUb051bWJlciBpbnRvIGEgVmFsdWVUb0RvdWJsZSBpcyBmb3VuZCBp biBQcm9wYWdhdG9yLgorICAgICAgICAKKyAgICAgICAgVGhpcyBhcHBlYXJzIHRvIGJlIGEgMjIl IHNwZWVkLXVwIGluIGltYWdpbmctZGFya3Jvb20uCisKKyAgICAgICAgKiBkZmcvREZHTm9kZS5o OgorICAgICAgICAqIGRmZy9ERkdOb25TcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAgIChKU0M6 OkRGRzo6Tm9uU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAgICAqIGRmZy9ERkdQcm9w YWdhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpQcm9wYWdhdG9yOjpmaXhwb2ludCk6Cisg ICAgICAgIChKU0M6OkRGRzo6UHJvcGFnYXRvcjo6dG9Eb3VibGUpOgorICAgICAgICAoSlNDOjpE Rkc6OlByb3BhZ2F0b3I6OmZpeHVwTm9kZSk6CisgICAgICAgIChKU0M6OkRGRzo6UHJvcGFnYXRv cjo6Zml4dXApOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHA6CisgICAgICAg IChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAgICAoSlNDOjpERkc6 OlNwZWN1bGF0aXZlSklUOjpjb21wdXRlVmFsdWVSZWNvdmVyeUZvcik6CisKIDIwMTEtMDktMTQg IEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBERkcgc2hvdWxkIG5v dCBzcGVjdWxhdGUgdGhhdCB0aGUgY2hpbGQgb2YgTG9naWNhbE5vdCBpcyBhIGJvb2xlYW4gaWYK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCShyZXZpc2lvbiA5NTEyMykKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0x NTgsNiArMTU4LDkgQEAgcHJpdmF0ZToKICAgICAvKiBBcml0aG1ldGljIG9wZXJhdG9ycyBjYWxs IFRvTnVtYmVyIG9uIHRoZWlyIG9wZXJhbmRzLiAqL1wKICAgICBtYWNybyhWYWx1ZVRvTnVtYmVy LCBOb2RlUmVzdWx0TnVtYmVyIHwgTm9kZU11c3RHZW5lcmF0ZSkgXAogICAgIFwKKyAgICAvKiBB IHZhcmlhbnQgb2YgVmFsdWVUb051bWJlciwgd2hpY2ggYSBoaW50IHRoYXQgdGhlIHBhcmVudHMg d2lsbCBhbHdheXMgdXNlIHRoaXMgYXMgYSBkb3VibGUuICovXAorICAgIG1hY3JvKFZhbHVlVG9E b3VibGUsIE5vZGVSZXN1bHROdW1iZXIgfCBOb2RlTXVzdEdlbmVyYXRlKSBcCisgICAgXAogICAg IC8qIEFkZCBvZiB2YWx1ZXMgbWF5IGVpdGhlciBiZSBhcml0aG1ldGljLCBvciByZXN1bHQgaW4g c3RyaW5nIGNvbmNhdGVuYXRpb24uICovXAogICAgIG1hY3JvKFZhbHVlQWRkLCBOb2RlUmVzdWx0 SlMgfCBOb2RlTXVzdEdlbmVyYXRlKSBcCiAgICAgXApJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdOb25TcGVjdWxhdGl2ZUpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdOb25TcGVjdWxhdGl2ZUpJVC5jcHAJKHJldmlzaW9uIDk1MTIz KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb25TcGVjdWxhdGl2ZUpJVC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTU5NSw3ICs1OTUsOCBAQCB2b2lkIE5vblNwZWN1bGF0aXZlSklU Ojpjb21waWxlKFNwZWN1bGF0CiAgICAgICAgIGJyZWFrOwogICAgIH0KIAotICAgIGNhc2UgVmFs dWVUb051bWJlcjogeworICAgIGNhc2UgVmFsdWVUb051bWJlcjoKKyAgICBjYXNlIFZhbHVlVG9E b3VibGU6IHsKICAgICAgICAgQVNTRVJUKCFpc0ludDMyQ29uc3RhbnQobm9kZS5jaGlsZDEoKSkp OwogICAgICAgICBBU1NFUlQoIWlzTnVtYmVyQ29uc3RhbnQobm9kZS5jaGlsZDEoKSkpOwogCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Byb3BhZ2F0b3IuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJvcGFnYXRvci5jcHAJKHJldmlz aW9uIDk1MTIzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcm9wYWdhdG9yLmNw cAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUsOCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBt X2NoYW5nZWQgPSBmYWxzZTsKICAgICAgICAgICAgIHByb3BhZ2F0ZUJhY2t3YXJkKCk7CiAgICAg ICAgIH0gd2hpbGUgKG1fY2hhbmdlZCk7CisgICAgICAgIAorICAgICAgICBmaXh1cCgpOwogICAg IH0KICAgICAKIHByaXZhdGU6CkBAIC0zMjEsNiArMzIzLDgwIEBAIHByaXZhdGU6CiAgICAgICAg ICAgICBwcm9wYWdhdGVOb2RlKG1fZ3JhcGhbbV9jb21waWxlSW5kZXhdKTsKICAgICB9CiAgICAg CisgICAgdm9pZCB0b0RvdWJsZShOb2RlSW5kZXggbm9kZUluZGV4KQorICAgIHsKKyAgICAgICAg aWYgKG1fZ3JhcGhbbm9kZUluZGV4XS5vcCA9PSBWYWx1ZVRvTnVtYmVyKSB7CisjaWYgRU5BQkxF KERGR19ERUJVR19WRVJCT1NFKQorICAgICAgICAgICAgcHJpbnRmKCIgIEAldSAtPiBWYWx1ZVRv RG91YmxlIiwgbm9kZUluZGV4KTsKKyNlbmRpZgorICAgICAgICAgICAgbV9ncmFwaFtub2RlSW5k ZXhdLm9wID0gVmFsdWVUb0RvdWJsZTsKKyAgICAgICAgfQorICAgIH0KKyAgICAKKyAgICB2b2lk IGZpeHVwTm9kZShOb2RlJiBub2RlKQorICAgIHsKKyAgICAgICAgaWYgKCFub2RlLnNob3VsZEdl bmVyYXRlKCkpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIAorICAgICAgICBOb2RlVHlw ZSBvcCA9IG5vZGUub3A7CisKKyNpZiBFTkFCTEUoREZHX0RFQlVHX1ZFUkJPU0UpCisgICAgICAg IHByaW50ZigiICAgJXNbJXVdOiAiLCBHcmFwaDo6b3BOYW1lKG9wKSwgbV9jb21waWxlSW5kZXgp OworI2VuZGlmCisgICAgICAgIAorICAgICAgICBzd2l0Y2ggKG9wKSB7CisgICAgICAgIGNhc2Ug VmFsdWVBZGQ6IHsKKyAgICAgICAgICAgIFByZWRpY3RlZFR5cGUgbGVmdCA9IG1fcHJlZGljdGlv bnNbbm9kZS5jaGlsZDEoKV07CisgICAgICAgICAgICBQcmVkaWN0ZWRUeXBlIHJpZ2h0ID0gbV9w cmVkaWN0aW9uc1tub2RlLmNoaWxkMigpXTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgaWYg KGlzU3Ryb25nUHJlZGljdGlvbihsZWZ0KSAmJiBpc1N0cm9uZ1ByZWRpY3Rpb24ocmlnaHQpICYm IGlzTnVtYmVyUHJlZGljdGlvbihsZWZ0KSAmJiBpc051bWJlclByZWRpY3Rpb24ocmlnaHQpKSB7 CisgICAgICAgICAgICAgICAgaWYgKGxlZnQgJiBQcmVkaWN0RG91YmxlKQorICAgICAgICAgICAg ICAgICAgICB0b0RvdWJsZShub2RlLmNoaWxkMigpKTsKKyAgICAgICAgICAgICAgICBpZiAocmln aHQgJiBQcmVkaWN0RG91YmxlKQorICAgICAgICAgICAgICAgICAgICB0b0RvdWJsZShub2RlLmNo aWxkMSgpKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9Cisg ICAgICAgICAgICAKKyAgICAgICAgY2FzZSBBcml0aEFkZDoKKyAgICAgICAgY2FzZSBBcml0aFN1 YjoKKyAgICAgICAgY2FzZSBBcml0aE11bDogeworICAgICAgICAgICAgUHJlZGljdGVkVHlwZSBs ZWZ0ID0gbV9wcmVkaWN0aW9uc1tub2RlLmNoaWxkMSgpXTsKKyAgICAgICAgICAgIFByZWRpY3Rl ZFR5cGUgcmlnaHQgPSBtX3ByZWRpY3Rpb25zW25vZGUuY2hpbGQyKCldOworICAgICAgICAgICAg CisgICAgICAgICAgICBpZiAoaXNTdHJvbmdQcmVkaWN0aW9uKGxlZnQpICYmIGlzU3Ryb25nUHJl ZGljdGlvbihyaWdodCkpIHsKKyAgICAgICAgICAgICAgICBpZiAobGVmdCAmIFByZWRpY3REb3Vi bGUpCisgICAgICAgICAgICAgICAgICAgIHRvRG91YmxlKG5vZGUuY2hpbGQyKCkpOworICAgICAg ICAgICAgICAgIGlmIChyaWdodCAmIFByZWRpY3REb3VibGUpCisgICAgICAgICAgICAgICAgICAg IHRvRG91YmxlKG5vZGUuY2hpbGQxKCkpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgYnJl YWs7CisgICAgICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICBjYXNlIEFyaXRoRGl2OiB7Cisg ICAgICAgICAgICB0b0RvdWJsZShub2RlLmNoaWxkMSgpKTsKKyAgICAgICAgICAgIHRvRG91Ymxl KG5vZGUuY2hpbGQyKCkpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICAgICAg ICAgIAorICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKwor I2lmIEVOQUJMRShERkdfREVCVUdfVkVSQk9TRSkKKyAgICAgICAgcHJpbnRmKCJcbiIpOworI2Vu ZGlmCisgICAgfQorICAgIAorICAgIHZvaWQgZml4dXAoKQorICAgIHsKKyNpZiBFTkFCTEUoREZH X0RFQlVHX1ZFUkJPU0UpCisgICAgICAgIHByaW50ZigiUGVyZm9ybWluZyBGaXh1cFxuIik7Cisj ZW5kaWYKKyAgICAgICAgZm9yIChtX2NvbXBpbGVJbmRleCA9IDA7IG1fY29tcGlsZUluZGV4IDwg bV9ncmFwaC5zaXplKCk7ICsrbV9jb21waWxlSW5kZXgpCisgICAgICAgICAgICBmaXh1cE5vZGUo bV9ncmFwaFttX2NvbXBpbGVJbmRleF0pOworICAgIH0KKyAgICAKICAgICBHcmFwaCYgbV9ncmFw aDsKICAgICBKU0dsb2JhbERhdGEmIG1fZ2xvYmFsRGF0YTsKICAgICBDb2RlQmxvY2sqIG1fY29k ZUJsb2NrOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxh dGl2ZUpJVC5jcHAJKHJldmlzaW9uIDk1MTIzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg3MCw2ICs4NzAsMTQg QEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAgICAgICBicmVh azsKICAgICB9CiAKKyAgICBjYXNlIFZhbHVlVG9Eb3VibGU6IHsKKyAgICAgICAgU3BlY3VsYXRl RG91YmxlT3BlcmFuZCBvcDEodGhpcywgbm9kZS5jaGlsZDEoKSk7CisgICAgICAgIEZQUlRlbXBv cmFyeSByZXN1bHQodGhpcywgb3AxKTsKKyAgICAgICAgbV9qaXQubW92ZURvdWJsZShvcDEuZnBy KCksIHJlc3VsdC5mcHIoKSk7CisgICAgICAgIGRvdWJsZVJlc3VsdChyZXN1bHQuZnByKCksIG1f Y29tcGlsZUluZGV4KTsKKyAgICAgICAgYnJlYWs7CisgICAgfQorCiAgICAgY2FzZSBWYWx1ZUFk ZDoKICAgICBjYXNlIEFyaXRoQWRkOiB7CiAgICAgICAgIGlmIChzaG91bGRTcGVjdWxhdGVJbnRl Z2VyKG5vZGUuY2hpbGQxKCksIG5vZGUuY2hpbGQyKCkpKSB7CkBAIC0xNjg3LDYgKzE2OTUsNyBA QCBWYWx1ZVJlY292ZXJ5IFNwZWN1bGF0aXZlSklUOjpjb21wdXRlVmFsCiAgICAgICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgIHN3aXRjaCAobm9kZS5vcCkgewogICAg ICAgICAgICAgICAgIGNhc2UgVmFsdWVUb051bWJlcjoKKyAgICAgICAgICAgICAgICBjYXNlIFZh bHVlVG9Eb3VibGU6CiAgICAgICAgICAgICAgICAgICAgIHZhbHVlVG9OdW1iZXJJbmRleCA9IGlu Zm8ubm9kZUluZGV4KCk7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg ICAgIGNhc2UgVmFsdWVUb0ludDMyOgo=