68111 2011-09-14 13:25:37 -0700 Address lifetime issues in OfflineAudioDestinationNode (take 2) 2011-09-14 14:38:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers kbr oldest_to_newest 467284 0 crogers 2011-09-14 13:25:37 -0700 Address Address lifetime issues in OfflineAudioDestinationNode (take 2) 467286 1 107384 crogers 2011-09-14 13:27:32 -0700 Created attachment 107384 Patch 467289 2 crogers 2011-09-14 13:31:42 -0700 my previous patch was incorrect: http://trac.webkit.org/changeset/94984 It's too late to call waitForThreadCompletion() in the destructor, since there's could still be a pending callOnMainThread() using this object. The object must stay alive longer. The approach taken with this new patch is to take a reference just before the worker thread is created, then release the reference once the callOnMainThread() handler has finished. Then we can avoid calling waitForThreadCompletion() 467303 3 107388 crogers 2011-09-14 13:43:59 -0700 Created attachment 107388 Patch 467339 4 107388 kbr 2011-09-14 14:20:30 -0700 Comment on attachment 107388 Patch Looks good to me. 467348 5 crogers 2011-09-14 14:38:37 -0700 Committed r95124: <http://trac.webkit.org/changeset/95124> 107384 2011-09-14 13:27:32 -0700 2011-09-14 13:43:54 -0700 Patch bug-68111-20110914132731.patch text/plain 2159 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogOTUxMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMzkxODdlZmJmNjE1ZWRj N2JmYTBkZmIyMTM5MjkyNDI2MDFhM2Y0Li5kZjkwMjhiNDVkOWNkOGQ5ZmFjMzkwNWU1MTQ3MmI1 MTgyYzI1OGI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMTQgIENocmlz IFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGRyZXNzIEFkZHJlc3Mg bGlmZXRpbWUgaXNzdWVzIGluIE9mZmxpbmVBdWRpb0Rlc3RpbmF0aW9uTm9kZSAodGFrZSAyKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxMTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuICBUaGlzIGZpeGVzIGV4aXN0aW5nIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHdlYmF1 ZGlvL09mZmxpbmVBdWRpb0Rlc3RpbmF0aW9uTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpP ZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6On5PZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUp OgorICAgICAgICAoV2ViQ29yZTo6T2ZmbGluZUF1ZGlvRGVzdGluYXRpb25Ob2RlOjpzdGFydFJl bmRlcmluZyk6CisgICAgICAgIChXZWJDb3JlOjpPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6 OnJlbmRlcik6CisKIDIwMTEtMDktMTQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbc2tpYV0gZmFzdC9jYW52YXMvc2V0V2lkdGhSZXNldEFmdGVyRm9y Y2VkUmVuZGVyIGlzIGZsYWt5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9P ZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v T2ZmbGluZUF1ZGlvRGVzdGluYXRpb25Ob2RlLmNwcAppbmRleCA3YThmOTU4M2UxN2ZiYmJkZDU5 MzIwNzZjNTczNjU5Mzk2NWM1M2MxLi5hZWZlNDNlNGI5NmYyMDYyNzhiOTc2YzJhNjQxNTEyOGE1 OTEyY2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9PZmZsaW5lQXVkaW9E ZXN0aW5hdGlvbk5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL09mZmxpbmVB dWRpb0Rlc3RpbmF0aW9uTm9kZS5jcHAKQEAgLTUyLDkgKzUyLDYgQEAgT2ZmbGluZUF1ZGlvRGVz dGluYXRpb25Ob2RlOjpPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUoQXVkaW9Db250ZXh0KiBj b250ZXh0LAogCiBPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6On5PZmZsaW5lQXVkaW9EZXN0 aW5hdGlvbk5vZGUoKQogewotICAgIGlmIChtX3JlbmRlclRocmVhZCkKLSAgICAgICAgd2FpdEZv clRocmVhZENvbXBsZXRpb24obV9yZW5kZXJUaHJlYWQsIDApOwotICAgIAogICAgIHVuaW5pdGlh bGl6ZSgpOwogfQogCkBAIC04Myw2ICs4MCw3IEBAIHZvaWQgT2ZmbGluZUF1ZGlvRGVzdGluYXRp b25Ob2RlOjpzdGFydFJlbmRlcmluZygpCiAgICAgCiAgICAgaWYgKCFtX3N0YXJ0ZWRSZW5kZXJp bmcpIHsKICAgICAgICAgbV9zdGFydGVkUmVuZGVyaW5nID0gdHJ1ZTsKKyAgICAgICAgcmVmKCk7 IC8vIFNlZSBjb3JyZXNwb25kaW5nIGRlcmVmKCkgY2FsbCBpbiBub3RpZnlDb21wbGV0ZURpc3Bh dGNoKCkuCiAgICAgICAgIG1fcmVuZGVyVGhyZWFkID0gY3JlYXRlVGhyZWFkKE9mZmxpbmVBdWRp b0Rlc3RpbmF0aW9uTm9kZTo6cmVuZGVyRW50cnksIHRoaXMsICJvZmZsaW5lIHJlbmRlcmVyIik7 CiAgICAgfQogfQpAQCAtMTQ2LDggKzE0NCw2IEBAIHZvaWQgT2ZmbGluZUF1ZGlvRGVzdGluYXRp b25Ob2RlOjpyZW5kZXIoKQogICAgIH0KICAgICAKICAgICAvLyBPdXIgd29yayBpcyBkb25lLiBM ZXQgdGhlIEF1ZGlvQ29udGV4dCBrbm93LgotICAgIC8vIFNlZSBjb3JyZXNwb25kaW5nIGRlcmVm KCkgY2FsbCBpbiBub3RpZnlDb21wbGV0ZURpc3BhdGNoKCkuCi0gICAgcmVmKCk7CiAgICAgY2Fs bE9uTWFpblRocmVhZChub3RpZnlDb21wbGV0ZURpc3BhdGNoLCB0aGlzKTsKIH0KIAo= 107388 2011-09-14 13:43:59 -0700 2011-09-14 14:20:30 -0700 Patch bug-68111-20110914134358.patch text/plain 2581 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogOTUxMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMzkxODdlZmJmNjE1ZWRj N2JmYTBkZmIyMTM5MjkyNDI2MDFhM2Y0Li5kZjkwMjhiNDVkOWNkOGQ5ZmFjMzkwNWU1MTQ3MmI1 MTgyYzI1OGI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDktMTQgIENocmlz IFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGRyZXNzIEFkZHJlc3Mg bGlmZXRpbWUgaXNzdWVzIGluIE9mZmxpbmVBdWRpb0Rlc3RpbmF0aW9uTm9kZSAodGFrZSAyKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgxMTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuICBUaGlzIGZpeGVzIGV4aXN0aW5nIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHdlYmF1 ZGlvL09mZmxpbmVBdWRpb0Rlc3RpbmF0aW9uTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpP ZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6On5PZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUp OgorICAgICAgICAoV2ViQ29yZTo6T2ZmbGluZUF1ZGlvRGVzdGluYXRpb25Ob2RlOjpzdGFydFJl bmRlcmluZyk6CisgICAgICAgIChXZWJDb3JlOjpPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6 OnJlbmRlcik6CisKIDIwMTEtMDktMTQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbc2tpYV0gZmFzdC9jYW52YXMvc2V0V2lkdGhSZXNldEFmdGVyRm9y Y2VkUmVuZGVyIGlzIGZsYWt5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9P ZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v T2ZmbGluZUF1ZGlvRGVzdGluYXRpb25Ob2RlLmNwcAppbmRleCA3YThmOTU4M2UxN2ZiYmJkZDU5 MzIwNzZjNTczNjU5Mzk2NWM1M2MxLi4xZmE1NTg4ODM0NzMxZmNiNDdkNWVhOGZkNGExNDAyYjIx ZGUwMzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9PZmZsaW5lQXVkaW9E ZXN0aW5hdGlvbk5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL09mZmxpbmVB dWRpb0Rlc3RpbmF0aW9uTm9kZS5jcHAKQEAgLTQzLDYgKzQzLDcgQEAgY29uc3Qgc2l6ZV90IHJl bmRlclF1YW50dW1TaXplID0gMTI4OwogT2ZmbGluZUF1ZGlvRGVzdGluYXRpb25Ob2RlOjpPZmZs aW5lQXVkaW9EZXN0aW5hdGlvbk5vZGUoQXVkaW9Db250ZXh0KiBjb250ZXh0LCBBdWRpb0J1ZmZl ciogcmVuZGVyVGFyZ2V0KQogICAgIDogQXVkaW9EZXN0aW5hdGlvbk5vZGUoY29udGV4dCwgcmVu ZGVyVGFyZ2V0LT5zYW1wbGVSYXRlKCkpCiAgICAgLCBtX3JlbmRlclRhcmdldChyZW5kZXJUYXJn ZXQpCisgICAgLCBtX3JlbmRlclRocmVhZCgwKQogICAgICwgbV9zdGFydGVkUmVuZGVyaW5nKGZh bHNlKQogewogICAgIG1fcmVuZGVyQnVzID0gYWRvcHRQdHIobmV3IEF1ZGlvQnVzKHJlbmRlclRh cmdldC0+bnVtYmVyT2ZDaGFubmVscygpLCByZW5kZXJRdWFudHVtU2l6ZSkpOwpAQCAtNTIsOSAr NTMsNiBAQCBPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6Ok9mZmxpbmVBdWRpb0Rlc3RpbmF0 aW9uTm9kZShBdWRpb0NvbnRleHQqIGNvbnRleHQsCiAKIE9mZmxpbmVBdWRpb0Rlc3RpbmF0aW9u Tm9kZTo6fk9mZmxpbmVBdWRpb0Rlc3RpbmF0aW9uTm9kZSgpCiB7Ci0gICAgaWYgKG1fcmVuZGVy VGhyZWFkKQotICAgICAgICB3YWl0Rm9yVGhyZWFkQ29tcGxldGlvbihtX3JlbmRlclRocmVhZCwg MCk7Ci0gICAgCiAgICAgdW5pbml0aWFsaXplKCk7CiB9CiAKQEAgLTgzLDYgKzgxLDcgQEAgdm9p ZCBPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6OnN0YXJ0UmVuZGVyaW5nKCkKICAgICAKICAg ICBpZiAoIW1fc3RhcnRlZFJlbmRlcmluZykgewogICAgICAgICBtX3N0YXJ0ZWRSZW5kZXJpbmcg PSB0cnVlOworICAgICAgICByZWYoKTsgLy8gU2VlIGNvcnJlc3BvbmRpbmcgZGVyZWYoKSBjYWxs IGluIG5vdGlmeUNvbXBsZXRlRGlzcGF0Y2goKS4KICAgICAgICAgbV9yZW5kZXJUaHJlYWQgPSBj cmVhdGVUaHJlYWQoT2ZmbGluZUF1ZGlvRGVzdGluYXRpb25Ob2RlOjpyZW5kZXJFbnRyeSwgdGhp cywgIm9mZmxpbmUgcmVuZGVyZXIiKTsKICAgICB9CiB9CkBAIC0xNDYsOCArMTQ1LDYgQEAgdm9p ZCBPZmZsaW5lQXVkaW9EZXN0aW5hdGlvbk5vZGU6OnJlbmRlcigpCiAgICAgfQogICAgIAogICAg IC8vIE91ciB3b3JrIGlzIGRvbmUuIExldCB0aGUgQXVkaW9Db250ZXh0IGtub3cuCi0gICAgLy8g U2VlIGNvcnJlc3BvbmRpbmcgZGVyZWYoKSBjYWxsIGluIG5vdGlmeUNvbXBsZXRlRGlzcGF0Y2go KS4KLSAgICByZWYoKTsKICAgICBjYWxsT25NYWluVGhyZWFkKG5vdGlmeUNvbXBsZXRlRGlzcGF0 Y2gsIHRoaXMpOwogfQogCg==