68107 2011-09-14 12:47:47 -0700 [Chromium] Make WEB_AUDIO conditional and fix the build when disabled 2011-09-14 21:15:01 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66689 1 peter peter crogers kbr steveblock webkit.review.bot oldest_to_newest 467261 0 peter 2011-09-14 12:47:47 -0700 This patch makes the ENABLE_WEB_AUDIO conditional, and fixes the build when it's disabled. Some code in the WebMediaPlayerClientImpl relied on it being enabled. 467263 1 107379 peter 2011-09-14 12:50:24 -0700 Created attachment 107379 Patch 467270 2 crogers 2011-09-14 13:02:54 -0700 Hi Peter, this looks fine to me. Later on we can see what it will take to get this working, but it's normal to disable it at this point. 467340 3 107379 kbr 2011-09-14 14:21:38 -0700 Comment on attachment 107379 Patch Looks fine to me. 467588 4 107379 webkit.review.bot 2011-09-14 21:14:57 -0700 Comment on attachment 107379 Patch Clearing flags on attachment: 107379 Committed r95160: <http://trac.webkit.org/changeset/95160> 467589 5 webkit.review.bot 2011-09-14 21:15:01 -0700 All reviewed patches have been landed. Closing bug. 107379 2011-09-14 12:50:24 -0700 2011-09-14 21:14:57 -0700 Patch web-audio-patch.patch text/plain 3535 peter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMjUwZmJlNS4uMzhlMTBiYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wOS0xNCAgUGV0ZXIgQmV2 ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBNYWtlIFdF Ql9BVURJTyBjb25kaXRpb25hbCBhbmQgZml4IHRoZSBidWlsZCB3aGVuIGRpc2FibGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODEwNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmVhdHVyZXMuZ3lw aToKKyAgICAgICAgKiBzcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjphdWRpb1NvdXJjZVByb3ZpZGVyKToK KyAgICAgICAgKiBzcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmg6CisKIDIwMTEtMDktMDUg IFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9t aXVtXSBXZWIgSW5zcGVjdG9yOiByZXBhaXIgY29uc29sZSBzbmlmZmluZyBmb3IgaW50ZXJhY3Rp dmUgdWkgdGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMu Z3lwaSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCAyNzE3YzUw Li5mZjczNzk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5 cGkKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCkBAIC04Niw3ICs4 Niw2IEBACiAgICAgICAnRU5BQkxFX1RPVUNIX0lDT05fTE9BRElORz08KGVuYWJsZV90b3VjaF9p Y29uX2xvYWRpbmcpJywKICAgICAgICdFTkFCTEVfVjhfU0NSSVBUX0RFQlVHX1NFUlZFUj0xJywK ICAgICAgICdFTkFCTEVfVklERU89MScsCi0gICAgICAnRU5BQkxFX1dFQl9BVURJTz0xJywKICAg ICAgICdFTkFCTEVfV0VCX1NPQ0tFVFM9MScsCiAgICAgICAnRU5BQkxFX1dFQl9USU1JTkc9MScs CiAgICAgICAnRU5BQkxFX1dFQkdMPTEnLApAQCAtMTIxLDYgKzEyMCwxNSBAQAogICAgICdlbmFi bGVfc21vb3RoX3Njcm9sbGluZyUnOiAnPChlbmFibGVfc21vb3RoX3Njcm9sbGluZyknLAogICAg ICd1c2Vfc2tpYSUnOiAnPCh1c2Vfc2tpYSknLAogICAgICdjb25kaXRpb25zJzogWworICAgICAg WydPUz09ImFuZHJvaWQiJywgeworICAgICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWworICAgICAg ICAgICdFTkFCTEVfV0VCX0FVRElPPTAnLAorICAgICAgICBdLAorICAgICAgfSwgeworICAgICAg ICAnZmVhdHVyZV9kZWZpbmVzJzogWworICAgICAgICAgICdFTkFCTEVfV0VCX0FVRElPPTEnLAor ICAgICAgICBdLAorICAgICAgfV0sCiAgICAgICBbJ3VzZV9hY2NlbGVyYXRlZF9jb21wb3NpdGlu Zz09MScsIHsKICAgICAgICAgJ2ZlYXR1cmVfZGVmaW5lcyc6IFsKICAgICAgICAgICAnV1RGX1VT RV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORz0xJywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwCmluZGV4IGNlNTFhZmMu LmEyYTBmOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlh UGxheWVyQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi TWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcApAQCAtNTU2LDExICs1NTYsMTMgQEAgdW5zaWduZWQg V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjp2aWRlb0RlY29kZWRCeXRlQ291bnQoKSBjb25zdAog CiBXZWJDb3JlOjpBdWRpb1NvdXJjZVByb3ZpZGVyKiBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6 OmF1ZGlvU291cmNlUHJvdmlkZXIoKQogeworI2lmIEVOQUJMRShXRUJfQVVESU8pCiAgICAgaWYg KG1fd2ViTWVkaWFQbGF5ZXIuZ2V0KCkpIHsKICAgICAgICAgLy8gV3JhcCB0aGUgV2ViQXVkaW9T b3VyY2VQcm92aWRlciBpbiB0aGUgZm9ybSBvZiBXZWJDb3JlOjpBdWRpb1NvdXJjZVByb3ZpZGVy LgogICAgICAgICBtX2F1ZGlvU291cmNlUHJvdmlkZXIuaW5pdGlhbGl6ZShtX3dlYk1lZGlhUGxh eWVyLT5hdWRpb1NvdXJjZVByb3ZpZGVyKCkpOwogICAgICAgICByZXR1cm4gJm1fYXVkaW9Tb3Vy Y2VQcm92aWRlcjsKICAgICB9CisjZW5kaWYKICAgICByZXR1cm4gMDsKIH0KIApAQCAtNjYzLDYg KzY2NSw3IEBAIFdlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6V2ViTWVkaWFQbGF5ZXJDbGllbnRJ bXBsKCkKIHsKIH0KIAorI2lmIEVOQUJMRShXRUJfQVVESU8pCiB2b2lkIFdlYk1lZGlhUGxheWVy Q2xpZW50SW1wbDo6QXVkaW9Tb3VyY2VQcm92aWRlckltcGw6OnByb3ZpZGVJbnB1dChXZWJDb3Jl OjpBdWRpb0J1cyogYnVzLCBzaXplX3QgZnJhbWVzVG9Qcm9jZXNzKQogewogICAgIEFTU0VSVChi dXMpOwpAQCAtNjgzLDYgKzY4Niw3IEBAIHZvaWQgV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpB dWRpb1NvdXJjZVByb3ZpZGVySW1wbDo6cHJvdmlkZUlucHV0KFdlYkNvcmU6OkF1CiAKICAgICBt X3dlYkF1ZGlvU291cmNlUHJvdmlkZXItPnByb3ZpZGVJbnB1dCh3ZWJBdWRpb0RhdGEsIGZyYW1l c1RvUHJvY2Vzcyk7CiB9CisjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVyQ2xpZW50SW1w bC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBs LmgKaW5kZXggMzVmODU0ZC4uNDQ4NjgwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmgKQEAgLTE2NSw2ICsxNjUsNyBA QCBwcml2YXRlOgogI2VuZGlmCiAgICAgc3RhdGljIGJvb2wgbV9pc0VuYWJsZWQ7CiAKKyNpZiBF TkFCTEUoV0VCX0FVRElPKQogICAgIC8vIEF1ZGlvU291cmNlUHJvdmlkZXJJbXBsIHdyYXBzIGEg V2ViQXVkaW9Tb3VyY2VQcm92aWRlci4KIAogICAgIGNsYXNzIEF1ZGlvU291cmNlUHJvdmlkZXJJ bXBsIDogcHVibGljIFdlYkNvcmU6OkF1ZGlvU291cmNlUHJvdmlkZXIgewpAQCAtMTg0LDYgKzE4 NSw3IEBAIHByaXZhdGU6CiAgICAgfTsKIAogICAgIEF1ZGlvU291cmNlUHJvdmlkZXJJbXBsIG1f YXVkaW9Tb3VyY2VQcm92aWRlcjsKKyNlbmRpZgogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0 Cg==