6809 2006-01-25 17:23:34 -0800 Whole DOM tree can leak if Document is hover/active/focus node on quit 2019-02-06 09:04:09 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs cdumez oldest_to_newest 29943 0 mjs 2006-01-25 17:23:34 -0800 DocumentImpl keeps the hover, active and focus nodes referenced, so the whole DOM tree can leak if the document itself is hover, active or focus when leaving the page. Without this fix, the editing layout tests show 175 NodeImpl leaks with the counter enabled. 29945 1 5966 mjs 2006-01-25 18:04:12 -0800 Created attachment 5966 patch to fix the leak when document is hover/active/focus node I'm not sure if this is the best approach. Maybe it should be FrameView, not Document, that tracks these nodes. 29946 2 5966 hyatt 2006-01-25 18:08:35 -0800 Comment on attachment 5966 patch to fix the leak when document is hover/active/focus node r=me, although the hover/active node should never be the document. 29965 3 mjs 2006-01-25 19:04:31 -0800 The hover/active node becomes the document because detaching a node makes it walk up the parent chain until it finds a node with a renderer, which the document itself still does when first detaching. 1503111 4 lforschler 2019-02-06 09:04:09 -0800 Mass moving XML DOM bugs to the "DOM" Component. 5966 2006-01-25 18:04:12 -0800 2006-01-25 18:08:35 -0800 patch to fix the leak when document is hover/active/focus node hover-focus-active-leak.patch.txt text/plain 1971 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzc1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMDEt MjUgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gZml4ZWQgIldob2xlIERP TSB0cmVlIGNhbiBsZWFrIGlmIERvY3VtZW50IGlzIGhvdmVyL2FjdGl2ZS9mb2N1cyBub2RlIG9u IHF1aXQiCisgICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjgwOQorICAgICAgICAKKyAgICAgICAgVGhpcyBmaXhlcyAxNzUgcmVwcm9kdWNpYmxl IG5vZGUgbGVha3MgaW4gdGhlIGVkaXRpbmcgbGF5b3V0IHRlc3RzLgorICAgICAgICAKKyAgICAg ICAgKiBraHRtbC94bWwvRG9jdW1lbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3Vt ZW50SW1wbDo6ZGV0YWNoKTogQ2xlYXIgaG92ZXIsIGZvY3VzIGFuZCBhY3RpdmUgbm9kZXMuIEl0 IGRvZXNuJ3QKKyAgICAgICAgbWFrZSBzZW5zZSB0byBoYXZlIHRoZXNlIHdpdGhvdXQgYSB2aWV3 IGFueXdheSwgYW5kIGlmIGFueSBvZiB0aGVtIGlzIHRoZSBkb2N1bWVudAorICAgICAgICBpdCBj YW4gY2F1c2UgYSBsZWFrIG9mIHRoZSB3aG9sZSBET00uCisKIDIwMDYtMDEtMjUgIERhdmlkIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBRQnJ1c2ggdG8gQnJ1c2gg YW5kIG1vdmUgaXQgdG8gcGxhdGZvcm0vLiAgUmVtb3ZlIHVudXNlZCBRUG9pbnQvU2l6ZS9SZWN0 RiBmb3J3YXJkaW5nCkluZGV4OiBraHRtbC94bWwvRG9jdW1lbnRJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBraHRtbC94bWwvRG9jdW1lbnRJbXBsLmNwcAkocmV2aXNpb24gMTIzNDcpCisrKyBraHRt bC94bWwvRG9jdW1lbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTc0LDYgKzk3NCwxMCBA QCB2b2lkIERvY3VtZW50SW1wbDo6ZGV0YWNoKCkKICAgICBtX2ltYWdlTG9hZEV2ZW50RGlzcGF0 Y2hTb29uTGlzdC5jbGVhcigpOwogICAgIG1faW1hZ2VMb2FkRXZlbnREaXNwYXRjaGluZ0xpc3Qu Y2xlYXIoKTsKICAgICAKKyAgICBtX2ZvY3VzTm9kZSA9IDA7CisgICAgbV9ob3Zlck5vZGUgPSAw OworICAgIG1fYWN0aXZlTm9kZSA9IDA7CisKICAgICBDb250YWluZXJOb2RlSW1wbDo6ZGV0YWNo KCk7CiAKICAgICBpZiAoIHJlbmRlciApCkluZGV4OiBraHRtbC94bWwvTm9kZUltcGwuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGtodG1sL3htbC9Ob2RlSW1wbC5jcHAJKHJldmlzaW9uIDEyMzQ3KQorKysg a2h0bWwveG1sL05vZGVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA0LDcgKzEwNCw3IEBA IGJvb2wgVGFnTm9kZUxpc3RJbXBsOjpub2RlTWF0Y2hlcyhOb2RlSW0KICNpZm5kZWYgTkRFQlVH CiBzdHJ1Y3QgTm9kZUltcGxDb3VudGVyIHsgCiAgICAgc3RhdGljIGludCBjb3VudDsgCi0gICAg fk5vZGVJbXBsQ291bnRlcigpIHsgLyogaWYgKGNvdW50ICE9IDApIGZwcmludGYoc3RkZXJyLCAi TEVBSzogJWQgTm9kZUltcGxcbiIsIGNvdW50KTsgKi8gfQorICAgIH5Ob2RlSW1wbENvdW50ZXIo KSB7IGlmIChjb3VudCAhPSAwKSBmcHJpbnRmKHN0ZGVyciwgIkxFQUs6ICVkIE5vZGVJbXBsXG4i LCBjb3VudCk7IH0KIH07CiBpbnQgTm9kZUltcGxDb3VudGVyOjpjb3VudCA9IDA7CiBzdGF0aWMg Tm9kZUltcGxDb3VudGVyIG5vZGVJbXBsQ291bnRlcjsK