68082 2011-09-14 08:55:00 -0700 [chromium] Return correct value for getContextAttributes().preserveDrawingBuffer 2011-09-14 20:03:47 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbauman jbauman kbr webkit.review.bot oldest_to_newest 467044 0 jbauman 2011-09-14 08:55:00 -0700 [chromium] Return correct value for getContextAttributes().preserveDrawingBuffer 467048 1 107335 jbauman 2011-09-14 09:00:05 -0700 Created attachment 107335 Patch 467162 2 107335 kbr 2011-09-14 11:21:27 -0700 Comment on attachment 107335 Patch Looks good; thanks for fixing this. 467554 3 107335 webkit.review.bot 2011-09-14 20:03:43 -0700 Comment on attachment 107335 Patch Clearing flags on attachment: 107335 Committed r95156: <http://trac.webkit.org/changeset/95156> 467555 4 webkit.review.bot 2011-09-14 20:03:47 -0700 All reviewed patches have been landed. Closing bug. 107335 2011-09-14 09:00:05 -0700 2011-09-14 20:03:43 -0700 Patch bug-68082-20110914090004.patch text/plain 5767 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogOTUwODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg ZGNhNmU5MTczOWE2NzY1MWQ1MzM2ZDU0MDYyYzExMjVlMmM5Yjg5My4uYTI5ZTAwYmI2MDYxYzdh MjQ4MWYxMjA2NzM4MTM4MTM4YjhiNzE3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxMS0wOS0xNCAgSm9obiBCYXVtYW4gIDxqYmF1bWFuQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFJldHVybiBjb3JyZWN0IHZhbHVlIGZvciBnZXRD b250ZXh0QXR0cmlidXRlcygpLnByZXNlcnZlRHJhd2luZ0J1ZmZlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjgwODIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4 dDNEOjpBdHRyaWJ1dGVzIGRvZXNuJ3Qgc2F2ZQorICAgICAgICBwcmVzZXJ2ZURyYXdpbmdCdWZm ZXIsIHNvIHRoYXQgaGFzIHRvIGJlIHNhdmluZyBpbgorICAgICAgICBHcmFwaGljc0NvbnRleHQz RFByaXZhdGUuCisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OkdyYXBoaWNzQ29u dGV4dDNEUHJpdmF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRFByaXZh dGU6OmNyZWF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6 OmNyZWF0ZUdyYXBoaWNzQ29udGV4dEZyb21XZWJDb250ZXh0KToKKyAgICAgICAgKFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Z2V0Q29udGV4dEF0dHJpYnV0ZXMpOgorICAgICAg ICAqIHNyYy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuaDoKKwogMjAxMS0wOS0xMyAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVGhlIGNoZWNr ZWQgc3RhdGUgb2YgV2ViUG9wdXBNZW51SXRlbSBpc24ndCBpbml0aWFsaXplZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVt LmNwcAppbmRleCAwYTFhYTQyNjczNzFkMjRhMGFhMjZmN2ZkMTUwOTUxYmU2NGRmZDU3Li5lMTQw YjE2NmZhNjZjNmEzMzVmY2JjZWEzNTQ4YmI1NzcxN2Q0ZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRENocm9taXVtLmNwcApA QCAtODQsMTEgKzg0LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog Ly8gR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlCiAKLUdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6 R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKFdlYktpdDo6V2ViVmlld0ltcGwqIHdlYlZpZXdJbXBs LCBQYXNzT3duUHRyPFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0Q+IHdlYkNvbnRleHQpCitH cmFwaGljc0NvbnRleHQzRFByaXZhdGU6OkdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZShXZWJLaXQ6 OldlYlZpZXdJbXBsKiB3ZWJWaWV3SW1wbCwgUGFzc093blB0cjxXZWJLaXQ6OldlYkdyYXBoaWNz Q29udGV4dDNEPiB3ZWJDb250ZXh0LCBHcmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRy cykKICAgICA6IG1faW1wbCh3ZWJDb250ZXh0KQogICAgICwgbV93ZWJWaWV3SW1wbCh3ZWJWaWV3 SW1wbCkKICAgICAsIG1faW5pdGlhbGl6ZWRBdmFpbGFibGVFeHRlbnNpb25zKGZhbHNlKQogICAg ICwgbV9sYXllckNvbXBvc2l0ZWQoZmFsc2UpCisgICAgLCBtX3ByZXNlcnZlRHJhd2luZ0J1ZmZl cihhdHRycy5wcmVzZXJ2ZURyYXdpbmdCdWZmZXIpCiAgICAgLCBtX3Jlc291cmNlU2FmZXR5KFJl c291cmNlU2FmZXR5VW5rbm93bikKICNpZiBVU0UoU0tJQSkKICAgICAsIG1fZ3JDb250ZXh0KDAp CkBAIC0xMTQsOSArMTE1LDkgQEAgR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjp+R3JhcGhpY3ND b250ZXh0M0RQcml2YXRlKCkKIH0KIAogCi1QYXNzT3duUHRyPEdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZT4gR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpjcmVhdGUoV2ViS2l0OjpXZWJWaWV3SW1w bCogd2ViVmlld0ltcGwsIFBhc3NPd25QdHI8V2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRD4g d2ViQ29udGV4dCkKK1Bhc3NPd25QdHI8R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlPiBHcmFwaGlj c0NvbnRleHQzRFByaXZhdGU6OmNyZWF0ZShXZWJLaXQ6OldlYlZpZXdJbXBsKiB3ZWJWaWV3SW1w bCwgUGFzc093blB0cjxXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEPiB3ZWJDb250ZXh0LCBH cmFwaGljc0NvbnRleHQzRDo6QXR0cmlidXRlcyBhdHRycykKIHsKLSAgICByZXR1cm4gYWRvcHRQ dHIobmV3IEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZSh3ZWJWaWV3SW1wbCwgd2ViQ29udGV4dCkp OworICAgIHJldHVybiBhZG9wdFB0cihuZXcgR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKHdlYlZp ZXdJbXBsLCB3ZWJDb250ZXh0LCBhdHRycykpOwogfQogCiBQYXNzUmVmUHRyPEdyYXBoaWNzQ29u dGV4dDNEPiBHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmNyZWF0ZUdyYXBoaWNzQ29udGV4dEZy b21XZWJDb250ZXh0KFBhc3NPd25QdHI8V2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRD4gd2Vi Q29udGV4dCwgR3JhcGhpY3NDb250ZXh0M0Q6OkF0dHJpYnV0ZXMgYXR0cnMsIEhvc3RXaW5kb3cq IGhvc3RXaW5kb3csIEdyYXBoaWNzQ29udGV4dDNEOjpSZW5kZXJTdHlsZSByZW5kZXJTdHlsZSwg VGhyZWFkVXNhZ2UgdGhyZWFkVXNhZ2UpCkBAIC0xMjcsNyArMTI4LDcgQEAgUGFzc1JlZlB0cjxH cmFwaGljc0NvbnRleHQzRD4gR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpjcmVhdGVHcmFwaGlj c0NvbnRleHRGcm8KICAgICBpZiAodGhyZWFkVXNhZ2UgPT0gRm9yVXNlT25UaGlzVGhyZWFkICYm ICF3ZWJDb250ZXh0LT5tYWtlQ29udGV4dEN1cnJlbnQoKSkKICAgICAgICAgcmV0dXJuIDA7CiAK LSAgICBPd25QdHI8R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlPiBwcml2ID0gR3JhcGhpY3NDb250 ZXh0M0RQcml2YXRlOjpjcmVhdGUod2ViVmlld0ltcGwsIHdlYkNvbnRleHQpOworICAgIE93blB0 cjxHcmFwaGljc0NvbnRleHQzRFByaXZhdGU+IHByaXYgPSBHcmFwaGljc0NvbnRleHQzRFByaXZh dGU6OmNyZWF0ZSh3ZWJWaWV3SW1wbCwgd2ViQ29udGV4dCwgYXR0cnMpOwogICAgIGlmICghcHJp dikKICAgICAgICAgcmV0dXJuIDA7CiAKQEAgLTYwMCw2ICs2MDEsNyBAQCBHcmFwaGljc0NvbnRl eHQzRDo6QXR0cmlidXRlcyBHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmdldENvbnRleHRBdHRy aWJ1dGVzKCkKICAgICBhdHRyaWJ1dGVzLnN0ZW5jaWwgPSB3ZWJBdHRyaWJ1dGVzLnN0ZW5jaWw7 CiAgICAgYXR0cmlidXRlcy5hbnRpYWxpYXMgPSB3ZWJBdHRyaWJ1dGVzLmFudGlhbGlhczsKICAg ICBhdHRyaWJ1dGVzLnByZW11bHRpcGxpZWRBbHBoYSA9IHdlYkF0dHJpYnV0ZXMucHJlbXVsdGlw bGllZEFscGhhOworICAgIGF0dHJpYnV0ZXMucHJlc2VydmVEcmF3aW5nQnVmZmVyID0gbV9wcmVz ZXJ2ZURyYXdpbmdCdWZmZXI7CiAgICAgcmV0dXJuIGF0dHJpYnV0ZXM7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5o IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmgK aW5kZXggZjI4ODZlNzI1NjZkYzkzNzBiM2JlNDdhZDRlYzlkNTM4ZWYxYTEyYi4uOWVlNGQwNmYy OWI1MGEwMGQ4MDFhNWIxNDA1NzE5YzRiNDJhOGViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmgKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlLmgKQEAgLTU1LDcgKzU1 LDcgQEAgY2xhc3MgU3dhcEJ1ZmZlcnNDb21wbGV0ZUNhbGxiYWNrQWRhcHRlcjsKIAogY2xhc3Mg R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc093blB0 cjxHcmFwaGljc0NvbnRleHQzRFByaXZhdGU+IGNyZWF0ZShXZWJLaXQ6OldlYlZpZXdJbXBsKiwg UGFzc093blB0cjxXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEPik7CisgICAgc3RhdGljIFBh c3NPd25QdHI8R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlPiBjcmVhdGUoV2ViS2l0OjpXZWJWaWV3 SW1wbCosIFBhc3NPd25QdHI8V2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRD4sIEdyYXBoaWNz Q29udGV4dDNEOjpBdHRyaWJ1dGVzKTsKIAogICAgIGVudW0gVGhyZWFkVXNhZ2UgewogICAgICAg ICBGb3JVc2VPblRoaXNUaHJlYWQsCkBAIC03NCw4ICs3NCw2IEBAIHB1YmxpYzoKIAogICAgIH5H cmFwaGljc0NvbnRleHQzRFByaXZhdGUoKTsKIAotICAgIGJvb2wgaW5pdGlhbGl6ZShHcmFwaGlj c0NvbnRleHQzRDo6QXR0cmlidXRlcywgSG9zdFdpbmRvdyosIGJvb2wgcmVuZGVyRGlyZWN0bHlU b0hvc3RXaW5kb3cpOwotCiAgICAgLy8gSGVscGVyIGZ1bmN0aW9uIHRvIHByb3ZpZGUgYWNjZXNz IHRvIHRoZSBsb3dlci1sZXZlbCBXZWJHcmFwaGljc0NvbnRleHQzRCwKICAgICAvLyB3aGljaCBp cyBuZWVkZWQgZm9yIHN1Ym9yZGluYXRlIGNvbnRleHRzIGxpa2UgV2ViR0wncyB0byBzaGFyZSBy ZXNvdXJjZXMKICAgICAvLyB3aXRoIHRoZSBjb21wb3NpdG9yJ3MgY29udGV4dC4KQEAgLTMwNiw3 ICszMDQsNyBAQCBwdWJsaWM6CiAgICAgR0MzRGVudW0gZ2V0R3JhcGhpY3NSZXNldFN0YXR1c0FS QigpOwogCiBwcml2YXRlOgotICAgIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZShXZWJLaXQ6Oldl YlZpZXdJbXBsKiwgUGFzc093blB0cjxXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEPik7Cisg ICAgR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKFdlYktpdDo6V2ViVmlld0ltcGwqLCBQYXNzT3du UHRyPFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0Q+LCBHcmFwaGljc0NvbnRleHQzRDo6QXR0 cmlidXRlcyk7CiAKICAgICBPd25QdHI8V2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRD4gbV9p bXBsOwogICAgIE93blB0cjxFeHRlbnNpb25zM0RDaHJvbWl1bT4gbV9leHRlbnNpb25zOwpAQCAt MzE3LDYgKzMxNSw3IEBAIHByaXZhdGU6CiAgICAgSGFzaFNldDxTdHJpbmc+IG1fZW5hYmxlZEV4 dGVuc2lvbnM7CiAgICAgSGFzaFNldDxTdHJpbmc+IG1fcmVxdWVzdGFibGVFeHRlbnNpb25zOwog ICAgIGJvb2wgbV9sYXllckNvbXBvc2l0ZWQ7CisgICAgYm9vbCBtX3ByZXNlcnZlRHJhd2luZ0J1 ZmZlcjsKIAogICAgIGVudW0gUmVzb3VyY2VTYWZldHkgewogICAgICAgICBSZXNvdXJjZVNhZmV0 eVVua25vd24sCg==