68080 2011-09-14 08:13:43 -0700 query SystemParametersInfo for GDI font smoothing settings 2011-09-14 10:03:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed jamesr kbr senorblanco webkit.review.bot oldest_to_newest 467030 0 reed 2011-09-14 08:13:43 -0700 query SystemParametersInfo for GDI font smoothing settings 467031 1 107332 reed 2011-09-14 08:16:07 -0700 Created attachment 107332 Patch 467047 2 107332 senorblanco 2011-09-14 08:58:17 -0700 Comment on attachment 107332 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107332&action=review Looks good. r=me > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:108 > + static bool gInited; > + static uint32_t gFlags; Nit: since gFlags is a function-level static anyway, if you wanted, you could save the gInited bool by refactoring the initialization into another function and doing: static uint32_t gFlags = getTextFlagsFromGDI(); return gFlags; Of course, a new function to save a bool, maybe not worth it. :) 467095 3 107332 webkit.review.bot 2011-09-14 10:03:19 -0700 Comment on attachment 107332 Patch Clearing flags on attachment: 107332 Committed r95097: <http://trac.webkit.org/changeset/95097> 467096 4 webkit.review.bot 2011-09-14 10:03:23 -0700 All reviewed patches have been landed. Closing bug. 107332 2011-09-14 08:16:07 -0700 2011-09-14 10:03:19 -0700 Patch bug-68080-20110914111605.patch text/plain 3308 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MDkzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDktMTQgIE1pa2UgUmVl ZCAgPHJlZWRAZ29vZ2xlLmNvbT4KKworICAgICAgICBxdWVyeSBTeXN0ZW1QYXJhbWV0ZXJzSW5m byBmb3IgR0RJIGZvbnQgc21vb3RoaW5nIHNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02ODA4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gZml4ZXMgYW50aWFsaWFzaW5n IGlzc3VlcyBiYXNlZCBvbiBVc2VyIHNldHRpbmdzCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL1NraWFGb250V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldERlZmF1bHRH RElUZXh0RmxhZ3MpOgorICAgICAgICAoV2ViQ29yZTo6c2V0dXBQYWludEZvckZvbnQpOgorCiAy MDExLTA5LTEzICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmZyYW1lRGVzdHJveWVk IGlzIGNhbGxlZCBhZnRlciBtX3BhZ2UgaGFzIGJlZW4gcmVzZXQuCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1NraWFGb250V2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1NraWFGb250V2luLmNwcAko cmV2aXNpb24gOTUwMjUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1NraWFGb250V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTksNiArOTksMjkgQEAgc3RhdGlj IGJvb2wgZGlzYWJsZVRleHRMQ0QoUGxhdGZvcm1Db250ZQogICAgICAgICAgICB8fCBza2lhQ29u dGV4dC0+aXNEcmF3aW5nVG9JbWFnZUJ1ZmZlcigpOwogfQogCisvLyBMb29rdXAgdGhlIGN1cnJl bnQgc3lzdGVtIHNldHRpbmdzIGZvciBmb250IHNtb290aGluZy4KKy8vIFdlIGNhY2hlIHRoZXNl IHZhbHVlcyBmb3IgcGVyZm9ybWFuY2UsIGJ1dCBpZiB0aGUgYnJvd3NlciBoYXMgYXdheSB0byBi ZQorLy8gbm90aWZpZWQgd2hlbiB0aGVzZSBjaGFuZ2UsIHdlIGNvdWxkIHJlLXF1ZXJ5IHRoZW0g YXQgdGhhdCB0aW1lLgorc3RhdGljIHVpbnQzMl90IGdldERlZmF1bHRHRElUZXh0RmxhZ3MoKQor eworICAgIHN0YXRpYyBib29sIGdJbml0ZWQ7CisgICAgc3RhdGljIHVpbnQzMl90IGdGbGFnczsK KyAgICBpZiAoIWdJbml0ZWQpIHsKKyAgICAgICAgQk9PTCBlbmFibGVkOworICAgICAgICBpZiAo U3lzdGVtUGFyYW1ldGVyc0luZm8oU1BJX0dFVEZPTlRTTU9PVEhJTkcsIDAsICZlbmFibGVkLCAw KSAmJiBlbmFibGVkKSB7CisgICAgICAgICAgICBnRmxhZ3MgfD0gU2tQYWludDo6a0FudGlBbGlh c19GbGFnOworCisgICAgICAgICAgICBVSU5UIHNtb290aFR5cGU7CisgICAgICAgICAgICBpZiAo U3lzdGVtUGFyYW1ldGVyc0luZm8oU1BJX0dFVEZPTlRTTU9PVEhJTkdUWVBFLCAwLCAmc21vb3Ro VHlwZSwgMCkpIHsKKyAgICAgICAgICAgICAgICBpZiAoRkVfRk9OVFNNT09USElOR0NMRUFSVFlQ RSA9PSBzbW9vdGhUeXBlKQorICAgICAgICAgICAgICAgICAgICBnRmxhZ3MgfD0gU2tQYWludDo6 a0xDRFJlbmRlclRleHRfRmxhZzsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgICAgICBn SW5pdGVkID0gdHJ1ZTsKKyAgICB9CisgICAgcmV0dXJuIGdGbGFnczsKK30KKwogc3RhdGljIHZv aWQgc2V0dXBQYWludEZvckZvbnQoSEZPTlQgaGZvbnQsIFNrUGFpbnQqIHBhaW50LCBQbGF0Zm9y bUNvbnRleHRTa2lhKiBwY3MpCiB7CiAgICAgLy8gIEZJWE1FOgpAQCAtMTE4LDI0ICsxNDEsMzAg QEAgc3RhdGljIHZvaWQgc2V0dXBQYWludEZvckZvbnQoSEZPTlQgaGZvbgogICAgIFNrU2FmZVVu cmVmKGZhY2UpOwogCiAgICAgdWludDMyX3QgZmxhZ3MgPSBwYWludC0+Z2V0RmxhZ3MoKTsKLSAg ICAvLyBvdXIgZGVmYXVsdHMKLSAgICBmbGFncyB8PSBTa1BhaW50OjprQW50aUFsaWFzX0ZsYWc7 Ci0gICAgaWYgKGRpc2FibGVUZXh0TENEKHBjcykpCi0gICAgICAgIGZsYWdzICY9IH5Ta1BhaW50 OjprTENEUmVuZGVyVGV4dF9GbGFnOwotICAgIGVsc2UKLSAgICAgICAgZmxhZ3MgfD0gU2tQYWlu dDo6a0xDRFJlbmRlclRleHRfRmxhZzsKKyAgICAvLyBjbGVhciBvdXIgZmxhZ3MgaW5pdGlhbGx5 LCBhbmQgdGhlbiBzZWxlY3RpdmVseSBzZXQgdGhlbQorICAgIC8vIGJhc2VkIG9uIHRoZSBMT0dG T05UIHF1YWxpdHkKKyAgICBmbGFncyAmPSBTa1BhaW50OjprQW50aUFsaWFzX0ZsYWc7CisgICAg ZmxhZ3MgJj0gU2tQYWludDo6a0xDRFJlbmRlclRleHRfRmxhZzsKIAogICAgIHN3aXRjaCAoaW5m by5sZlF1YWxpdHkpIHsKICAgICBjYXNlIE5PTkFOVElBTElBU0VEX1FVQUxJVFk6Ci0gICAgICAg IGZsYWdzICY9IH5Ta1BhaW50OjprQW50aUFsaWFzX0ZsYWc7Ci0gICAgICAgIGZsYWdzICY9IH5T a1BhaW50OjprTENEUmVuZGVyVGV4dF9GbGFnOwogICAgICAgICBicmVhazsKICAgICBjYXNlIEFO VElBTElBU0VEX1FVQUxJVFk6Ci0gICAgICAgIGZsYWdzICY9IH5Ta1BhaW50OjprTENEUmVuZGVy VGV4dF9GbGFnOworICAgICAgICBmbGFncyB8PSBTa1BhaW50OjprQW50aUFsaWFzX0ZsYWc7Cisg ICAgICAgIGJyZWFrOworICAgIGNhc2UgQ0xFQVJUWVBFX1FVQUxJVFk6CisgICAgICAgIGZsYWdz IHw9IFNrUGFpbnQ6OmtBbnRpQWxpYXNfRmxhZzsKKyAgICAgICAgZmxhZ3MgfD0gU2tQYWludDo6 a0xDRFJlbmRlclRleHRfRmxhZzsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKKyAgICAg ICAgZmxhZ3MgfD0gZ2V0RGVmYXVsdEdESVRleHRGbGFncygpOwogICAgICAgICBicmVhazsKICAg ICB9CisKKyAgICAvLyBkbyB0aGlzIGNoZWNrIGFmdGVyIG91ciBzd2l0Y2ggb24gbGZRdWFsaXR5 CisgICAgaWYgKGRpc2FibGVUZXh0TENEKHBjcykpCisgICAgICAgIGZsYWdzICY9IH5Ta1BhaW50 OjprTENEUmVuZGVyVGV4dF9GbGFnOworCiAgICAgcGFpbnQtPnNldEZsYWdzKGZsYWdzKTsKIH0K IAo=