68078 2011-09-14 06:51:04 -0700 [chromium] compilation failed in target 'webkit_unit_tests' 2011-09-16 15:26:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 chandra.vallala webkit-unassigned abarth jam webkit.review.bot oldest_to_newest 466996 0 chandra.vallala 2011-09-14 06:51:04 -0700 c1plus: warnings being treated as errors third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.cpp: In member function ‘virtual WebKit::WebNavigationPolicy<unnamed>::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationType, const WebKit::WebNode&, WebKit::WebNavigationPolicy, bool)’: third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.cpp:226:9: error: converting ‘false’ to pointer type for argument 1 of ‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ make: * [out/Debug/obj.target/webkit_unit_tests/third_party/WebKit/Source/WebKit/chromium/tests/WebFrameTest.o] Error 1 467008 1 107328 chandra.vallala 2011-09-14 07:02:36 -0700 Created attachment 107328 fix for the bug. 467189 2 107328 abarth 2011-09-14 11:48:29 -0700 Comment on attachment 107328 fix for the bug. View in context: https://bugs.webkit.org/attachment.cgi?id=107328&action=review > Source/WebKit/chromium/tests/WebFrameTest.cpp:226 > - EXPECT_EQ(false, isRedirect); > + EXPECT_EQ(0, isRedirect); This should be EXPECT_FALSE 467669 3 107467 chandra.vallala 2011-09-14 23:52:50 -0700 Created attachment 107467 updated the patch Updated the patch as per comments. 468839 4 107467 webkit.review.bot 2011-09-16 15:26:35 -0700 Comment on attachment 107467 updated the patch Clearing flags on attachment: 107467 Committed r95328: <http://trac.webkit.org/changeset/95328> 468840 5 webkit.review.bot 2011-09-16 15:26:39 -0700 All reviewed patches have been landed. Closing bug. 107328 2011-09-14 07:02:36 -0700 2011-09-15 23:16:27 -0700 fix for the bug. bug-68078.patch text/plain 1225 chandra.vallala SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJ KHJldmlzaW9uIDk1MDg2KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFt ZVRlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMsNyArMjIzLDcgQEAKICAgICAgICAgY29u c3QgV2ViTm9kZSYgb3JpZ2luYXRpbmdOb2RlLAogICAgICAgICBXZWJOYXZpZ2F0aW9uUG9saWN5 IGRlZmF1bHRQb2xpY3ksIGJvb2wgaXNSZWRpcmVjdCkKICAgICB7Ci0gICAgICAgIEVYUEVDVF9F UShmYWxzZSwgaXNSZWRpcmVjdCk7CisgICAgICAgIEVYUEVDVF9FUSgwLCBpc1JlZGlyZWN0KTsK ICAgICAgICAgcmV0dXJuIFdlYk5hdmlnYXRpb25Qb2xpY3lDdXJyZW50VGFiOwogICAgIH0KIApJ bmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MDg2KQorKysgU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAxMS0wOS0xNCAgY2hhbmRyYSBzaGVrYXIgdmFsbGFsYSAgIDxjaGFuZHJhLnZhbGxhbGFA bW90b3JvbGEuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gY29tcGlsYXRpb24gZmFpbGVkIGlu IHRhcmdldCAnd2Via2l0X3VuaXRfdGVzdHMnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02ODA3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogdGVzdHMvV2ViRnJhbWVUZXN0LmNwcDoKKyAgICAgICAgKFdl YktpdDo6VGVzdFJlbG9hZERvZXNudFJlZGlyZWN0V2ViRnJhbWVDbGllbnQ6OmRlY2lkZVBvbGlj eUZvck5hdmlnYXRpb24pOgorCiAyMDExLTA5LTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBUaGUgY2hlY2tlZCBzdGF0ZSBvZiBXZWJQb3B1 cE1lbnVJdGVtIGlzbid0IGluaXRpYWxpemVkCg== 107467 2011-09-14 23:52:50 -0700 2011-09-16 15:26:35 -0700 updated the patch bug-68078.patch text/plain 1200 chandra.vallala SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViRnJhbWVUZXN0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkZyYW1lVGVzdC5jcHAJ KHJldmlzaW9uIDk1MTczKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJGcmFt ZVRlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMsNyArMjIzLDcgQEAKICAgICAgICAgY29u c3QgV2ViTm9kZSYgb3JpZ2luYXRpbmdOb2RlLAogICAgICAgICBXZWJOYXZpZ2F0aW9uUG9saWN5 IGRlZmF1bHRQb2xpY3ksIGJvb2wgaXNSZWRpcmVjdCkKICAgICB7Ci0gICAgICAgIEVYUEVDVF9F UShmYWxzZSwgaXNSZWRpcmVjdCk7CisgICAgICAgIEVYUEVDVF9GQUxTRShpc1JlZGlyZWN0KTsK ICAgICAgICAgcmV0dXJuIFdlYk5hdmlnYXRpb25Qb2xpY3lDdXJyZW50VGFiOwogICAgIH0KIApJ bmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MTczKQorKysgU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAxMS0wOS0xNCAgY2hhbmRyYSBzaGVrYXIgdiAgPGNoYW5kcmEudmFsbGFsYUBtb3Rvcm9s YS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBjb21waWxhdGlvbiBmYWlsZWQgaW4gdGFyZ2V0 ICd3ZWJraXRfdW5pdF90ZXN0cycuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02ODA3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogdGVzdHMvV2ViRnJhbWVUZXN0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 VGVzdFJlbG9hZERvZXNudFJlZGlyZWN0V2ViRnJhbWVDbGllbnQ6OmRlY2lkZVBvbGljeUZvck5h dmlnYXRpb24pOgorCiAyMDExLTA5LTE0ICBIYW8gWmhlbmcgIDx6aGVuZ2hhb0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgZGVwZW5kZW5jaWVzIG9mIERSVCBmb3IgQW5kcm9p ZC4K