68056 2011-09-13 21:42:45 -0700 MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary 2011-09-14 11:59:36 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 466824 0 eric.carlson 2011-09-13 21:42:45 -0700 MediaPlayerPrivateAVFoundationObjC::createAVPlayer creates a periodic time observer that fires once in a very long while just so it can also be called whenever the time is changed. This was originally necessary early on, but AVPlayerItem's -seekToTime:toleranceBefore:toleranceAfter:completionHandler makes it completely unnecessary. 466826 1 webkit-bug-importer 2011-09-13 21:43:37 -0700 <rdar://problem/10121225> 466834 2 107286 eric.carlson 2011-09-13 22:07:12 -0700 Created attachment 107286 Proposed patch. 466841 3 107286 darin 2011-09-13 22:14:46 -0700 Comment on attachment 107286 Proposed patch. Patch would be better if it explained why we thought it was needed, what changed, and so why it’s not needed now. 467199 4 eric.carlson 2011-09-14 11:59:36 -0700 http://trac.webkit.org/changeset/95104 107286 2011-09-13 22:07:12 -0700 2011-09-13 22:14:45 -0700 Proposed patch. patch_2.txt text/plain 2890 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk1MDc1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMTMgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uT2JqQydzICJwZXJpb2RpYyB0aW1lIG9ic2VydmVyIiBpcyB1bm5lY2Vz c2FyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Njgw NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIGNvZGUgcmVtb3ZlZCBpcyB0ZXN0ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6Y3JlYXRlQVZQbGF5ZXIpOgorCiAyMDExLTA5LTEzICBB Ymhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ3Jhc2ggaW4g UmVuZGVyU2Nyb2xsYmFyUGFydDo6aW1hZ2VDaGFuZ2VkLgpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uT2JqQy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDLm1tCShyZXZpc2lvbiA5NDc2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMu bW0JKHdvcmtpbmcgY29weSkKQEAgLTEwNSw3ICsxMDUsNiBAQCAtKGlkKWluaXRXaXRoQ2FsbGJh Y2s6KE1lZGlhUGxheWVyUHJpdmF0CiAtKHZvaWQpZGlzY29ubmVjdDsKIC0odm9pZClwbGF5YWJs ZUtub3duOwogLSh2b2lkKW1ldGFkYXRhTG9hZGVkOwotLSh2b2lkKXRpbWVDaGFuZ2VkOihkb3Vi bGUpdGltZTsKIC0odm9pZClzZWVrQ29tcGxldGVkOihCT09MKWZpbmlzaGVkOwogLSh2b2lkKWRp ZEVuZDooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRpb247CiAtKHZvaWQpb2JzZXJ2ZVZhbHVl Rm9yS2V5UGF0aDprZXlQYXRoIG9mT2JqZWN0OihpZClvYmplY3QgY2hhbmdlOihOU0RpY3Rpb25h cnkgKiljaGFuZ2UgY29udGV4dDooTWVkaWFQbGF5ZXJBVkZvdW5kYXRpb25PYnNlcnZhdGlvbkNv bnRleHQpY29udGV4dDsKQEAgLTI4MCwxNCArMjc5LDYgQEAgdm9pZCBNZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDOgogICAgIG1fYXZQbGF5ZXIuYWRvcHROUyhbW0FWUGxheWVyIGFs bG9jXSBpbml0XSk7CiAgICAgW21fYXZQbGF5ZXIuZ2V0KCkgYWRkT2JzZXJ2ZXI6bV9vYmpjT2Jz ZXJ2ZXIuZ2V0KCkgZm9yS2V5UGF0aDpAInJhdGUiIG9wdGlvbnM6bmlsIGNvbnRleHQ6KHZvaWQg KilNZWRpYVBsYXllckFWRm91bmRhdGlvbk9ic2VydmF0aW9uQ29udGV4dFBsYXllcl07CiAgICAg Ci0gICAgLy8gQWRkIGEgdGltZSBvYnNlcnZlciwgYXNrIHRvIGJlIGNhbGxlZCBpbmZyZXF1ZW50 bHkgYmVjYXVzZSB3ZSBkb24ndCByZWFsbHkgd2FudCBwZXJpb2RpYyBjYWxsYmFja3MgYnV0Ci0g ICAgLy8gb3VyIG9ic2VydmVyIHdpbGwgYWxzbyBiZSBjYWxsZWQgd2hlbmV2ZXIgYSBzZWVrIGhh cHBlbnMuCi0gICAgY29uc3QgZG91YmxlIHZlcnlMb25nSW50ZXJ2YWwgPSA2MCAqIDYwICogMjQg KiAzMDsKLSAgICBXZWJDb3JlQVZGTW92aWVPYnNlcnZlciAqb2JzZXJ2ZXIgPSBtX29iamNPYnNl cnZlci5nZXQoKTsKLSAgICBtX3RpbWVPYnNlcnZlciA9IFttX2F2UGxheWVyLmdldCgpIGFkZFBl cmlvZGljVGltZU9ic2VydmVyRm9ySW50ZXJ2YWw6Q01UaW1lTWFrZVdpdGhTZWNvbmRzKHZlcnlM b25nSW50ZXJ2YWwsIDEwKSBxdWV1ZTpuaWwgdXNpbmdCbG9jazpeKENNVGltZSB0aW1lKXsKLSAg ICAgICAgW29ic2VydmVyIHRpbWVDaGFuZ2VkOkNNVGltZUdldFNlY29uZHModGltZSldOwotICAg IH1dOwotICAgIAogICAgIGlmIChtX2F2UGxheWVySXRlbSkKICAgICAgICAgW21fYXZQbGF5ZXIu Z2V0KCkgcmVwbGFjZUN1cnJlbnRJdGVtV2l0aFBsYXllckl0ZW06bV9hdlBsYXllckl0ZW0uZ2V0 KCldOwogCkBAIC04NDIsMTQgKzgzMyw2IEBAIC0gKHZvaWQpcGxheWFibGVLbm93bgogICAgIG1f Y2FsbGJhY2stPnNjaGVkdWxlTWFpblRocmVhZE5vdGlmaWNhdGlvbihNZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb246Ok5vdGlmaWNhdGlvbjo6QXNzZXRQbGF5YWJpbGl0eUtub3duKTsKIH0K IAotLSAodm9pZCl0aW1lQ2hhbmdlZDooZG91YmxlKXRpbWUKLXsKLSAgICBpZiAoIW1fY2FsbGJh Y2spCi0gICAgICAgIHJldHVybjsKLQotICAgIG1fY2FsbGJhY2stPnNjaGVkdWxlTWFpblRocmVh ZE5vdGlmaWNhdGlvbihNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246Ok5vdGlmaWNhdGlv bjo6UGxheWVyVGltZUNoYW5nZWQsIHRpbWUpOwotfQotCiAtICh2b2lkKXNlZWtDb21wbGV0ZWQ6 KEJPT0wpZmluaXNoZWQKIHsKICAgICBpZiAoIW1fY2FsbGJhY2spCg==